213601 2020-06-25 07:41:46 -0700 App-bound domain service worker registrations should be limited 2020-06-25 11:16:27 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney beidson bfulgham youennf oldest_to_newest 1666035 0 katherine_cheney 2020-06-25 07:41:46 -0700 We should limit the number of service worker registrations available to app-bound domains 1666036 1 katherine_cheney 2020-06-25 07:42:05 -0700 <rdar://problem/64717589> 1666041 2 402733 katherine_cheney 2020-06-25 07:49:03 -0700 Created attachment 402733 Patch 1666089 3 402733 bfulgham 2020-06-25 10:47:33 -0700 Comment on attachment 402733 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402733&action=review > Source/WebCore/workers/service/server/SWServer.cpp:338 > + completionHandler(m_appBoundDomains.contains(domain) && m_scopeToRegistrationMap.keys().size() < maxRegistrationCount); It seems like this code change also limits full web browsers to three registrations. Is that desired? 1666092 4 402733 katherine_cheney 2020-06-25 10:58:17 -0700 Comment on attachment 402733 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402733&action=review >> Source/WebCore/workers/service/server/SWServer.cpp:338 >> + completionHandler(m_appBoundDomains.contains(domain) && m_scopeToRegistrationMap.keys().size() < maxRegistrationCount); > > It seems like this code change also limits full web browsers to three registrations. Is that desired? It won't because the completion handler result will only be checked if the entitlement is not present (see SWServer::scheduleJob and SWServer::addRegistrationFromStore). It's a little confusing but we added the check here to prevent the app-bound domains from being read unnecessarily. 1666096 5 402733 bfulgham 2020-06-25 11:09:34 -0700 Comment on attachment 402733 Patch r=me 1666097 6 402733 katherine_cheney 2020-06-25 11:13:37 -0700 Comment on attachment 402733 Patch Thanks! 1666098 7 ews-feeder 2020-06-25 11:16:26 -0700 Committed r263521: <https://trac.webkit.org/changeset/263521> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402733. 402733 2020-06-25 07:49:03 -0700 2020-06-25 11:16:26 -0700 Patch bug-213601-20200625074902.patch text/plain 2614 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGU5MDg3ZDdkZDg1MDgw MzAzZmZhMjFjZjg5M2Y4ZjYyZjdlOTQ1My4uYmMyYjM0OTdmMGQ1ZjA5NDZkOGIyY2NlOGMzZDZj MDM4MmFlOTY3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA2LTI1ICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIEFwcC1ib3Vu ZCBkb21haW4gc2VydmljZSB3b3JrZXIgcmVnaXN0cmF0aW9ucyBzaG91bGQgYmUgbGltaXRlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzNjAxCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NDcxNzU4OT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaW1pdCBudW1iZXIgb2Ygc2VydmljZSB3b3JrZXIg cmVnaXN0cmF0aW9ucyBmb3IgYXBwLWJvdW5kIGRvbWFpbnMuCisgICAgICAgIFRoZSBjdXJyZW50 IHByb3Bvc2FsIGlzIDMsIGJ1dCB0aGlzIGNvdWxkIGJlIGNoYW5nZWQgaW4gdGhlIGZ1dHVyZS4K KworICAgICAgICBObyBuZXcgdGVzdHMsIGN1cnJlbnRseSBUZXN0V2ViS2l0QVBJIGlzIHVuYWJs ZSB0byB0ZXN0IGZhaWxlZAorICAgICAgICBzZXJ2aWNlIHdvcmtlciByZWdpc3RyYXRpb24gKHRl c3Qgd2lsbCB0aW1lb3V0KS4gQ29uZmlybWVkIGJlaGF2aW9yCisgICAgICAgIG1hbnVhbGx5Lgor CisgICAgICAgICogd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTV1NlcnZlcjo6dmFsaWRhdGVSZWdpc3RyYXRpb25Eb21haW4pOgorCiAyMDIw LTA2LTI0ICBVbWFyIElxYmFsICA8dWlxYmFsQGFwcGxlLmNvbT4KIAogICAgICAgICBXZSBzaG91 bGQgcmVzdXJyZWN0IHRoZSBvbGRlciBwYXRjaCB0aGF0IGNvbGxlY3RzIHNvbWUgc3RhdGlzdGlj cyBvZiB3ZWIgQVBJIGNhbGxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3Nl cnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vydmlj ZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCmluZGV4IDg0ZDI0N2MxZTA3ZGM2N2NiN2IzZDFlYmI2ODFl YTI3MWMwZmE4NjEuLjEzM2Y2MDdkNjNmODQ4YTIxM2M2NDkwNTIxZDQ1MGRiZDEzYTM3YWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIu Y3BwCkBAIC00OSw2ICs0OSw4IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorc3RhdGljIGNv bnN0IHVuc2lnbmVkIG1heFJlZ2lzdHJhdGlvbkNvdW50ID0gMzsKKwogU1dTZXJ2ZXI6OkNvbm5l Y3Rpb246OkNvbm5lY3Rpb24oU1dTZXJ2ZXImIHNlcnZlciwgSWRlbnRpZmllciBpZGVudGlmaWVy KQogICAgIDogbV9zZXJ2ZXIoc2VydmVyKQogICAgICwgbV9pZGVudGlmaWVyKGlkZW50aWZpZXIp CkBAIC0zMzMsNyArMzM1LDcgQEAgU1dTZXJ2ZXI6OlNXU2VydmVyKFVuaXF1ZVJlZjxTV09yaWdp blN0b3JlPiYmIG9yaWdpblN0b3JlLCBib29sIHByb2Nlc3NUZXJtaW5hdGkKIHZvaWQgU1dTZXJ2 ZXI6OnZhbGlkYXRlUmVnaXN0cmF0aW9uRG9tYWluKFdlYkNvcmU6OlJlZ2lzdHJhYmxlRG9tYWlu IGRvbWFpbiwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChib29sKT4mJiBjb21wbGV0aW9uSGFuZGxl cikKIHsKICAgICBpZiAobV9oYXNTZXJ2aWNlV29ya2VyRW50aXRsZW1lbnQgfHwgbV9oYXNSZWNl aXZlZEFwcEJvdW5kRG9tYWlucykgewotICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihtX2FwcEJv dW5kRG9tYWlucy5jb250YWlucyhkb21haW4pKTsKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIo bV9hcHBCb3VuZERvbWFpbnMuY29udGFpbnMoZG9tYWluKSAmJiBtX3Njb3BlVG9SZWdpc3RyYXRp b25NYXAua2V5cygpLnNpemUoKSA8IG1heFJlZ2lzdHJhdGlvbkNvdW50KTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KICAgICAKQEAgLTM0Miw3ICszNDQsNyBAQCB2b2lkIFNXU2VydmVyOjp2YWxp ZGF0ZVJlZ2lzdHJhdGlvbkRvbWFpbihXZWJDb3JlOjpSZWdpc3RyYWJsZURvbWFpbiBkb21haW4s IENvbQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBtX2hhc1JlY2VpdmVkQXBwQm91bmRE b21haW5zID0gdHJ1ZTsKICAgICAgICAgbV9hcHBCb3VuZERvbWFpbnMgPSBXVEZNb3ZlKGFwcEJv dW5kRG9tYWlucyk7Ci0gICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKG1fYXBwQm91bmREb21haW5z LmNvbnRhaW5zKGRvbWFpbikpOworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihtX2FwcEJvdW5k RG9tYWlucy5jb250YWlucyhkb21haW4pICYmIG1fc2NvcGVUb1JlZ2lzdHJhdGlvbk1hcC5rZXlz KCkuc2l6ZSgpIDwgbWF4UmVnaXN0cmF0aW9uQ291bnQpOwogICAgIH0pOwogfQogCg==