213575 2020-06-24 14:19:18 -0700 Access to AXIsolatedTree:m_readerThreadNodeMap should happen only on the secondary AX thread. 2020-06-26 12:43:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1665869 0 andresg_22 2020-06-24 14:19:18 -0700 Access to AXIsolatedTree:m_readerThreadNodeMap should happen only on the secondary AX thread. 1665872 1 402687 andresg_22 2020-06-24 14:33:13 -0700 Created attachment 402687 Patch 1666538 2 ews-feeder 2020-06-26 12:20:10 -0700 Committed r263572: <https://trac.webkit.org/changeset/263572> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402687. 1666541 3 webkit-bug-importer 2020-06-26 12:21:24 -0700 <rdar://problem/64817078> 1666554 4 402687 darin 2020-06-26 12:43:16 -0700 Comment on attachment 402687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402687&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:109 > + void updateChildrenIDs(AXID axID, Vector<AXID>&& childrenIDs); WebKit coding style discourages including names like "axID" that just repeat the name of the type, when declaring a function. This was a pre-existing thing that we just moved, but something to avoid in future. Seems like a minor bug in the style checking script that it didn’t detect this — I know it has code that attempts to do it, but maybe the upper/lowercase confuses it. 402687 2020-06-24 14:33:13 -0700 2020-06-26 12:20:11 -0700 Patch bug-213575-20200624173312.patch text/plain 4732 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTI4NDRiZjY2YWQ1MDI0 YWJjMWZlOWZhMzdhM2Y5MDU1NWQ4YzU2Zi4uZDgzMDY3YjRkYzlhOGZlODdlODQxNTdmZWQ3Zjk2 ODc0ZjE4Y2U2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA2LTI0ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBY2Nlc3MgdG8g QVhJc29sYXRlZFRyZWU6bV9yZWFkZXJUaHJlYWROb2RlTWFwIHNob3VsZCBoYXBwZW4gb25seSBv biB0aGUgc2Vjb25kYXJ5IEFYIHRocmVhZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMzU3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFmdGVyIGNhbGxpbmcgQVhPYmplY3RDYWNoZTo6aW5pdGlhbGl6 ZVNlY29uZGFyeUFYVGhyZWFkLCB0aGVyZSBtYXkKKyAgICAgICAgc3RpbGwgYmUgc29tZSBjbGll bnQgcmVxdWVzdHMgY29taW5nIGluIG9uIHRoZSBtYWluIHRocmVhZC4gVGh1cworICAgICAgICBB WElzb2xhdGVkVHJlZTo6YXBwbHlQZW5kaW5nY2hhbmdlcyBhbmQgbm9kZUZvcklEIGNhbiBiZSBj YWxsZWQgb24gdGhlCisgICAgICAgIG1haW4gdGhyZWFkLiBTaW5jZSB0aGVzZSB0d28gbWV0aG9k cyBhY2Nlc3MgdGhlIG1lbWJlciB2YXJpYWJsZQorICAgICAgICBtX3JlYWRlclRocmVhZE5vZGVN YXAgd2hpY2ggc2hvdWxkIGJlIGFjY2Vzc2VkIG9ubHkgb24gdGhlIHNlY29uZGFyeSBBWAorICAg ICAgICB0aHJlYWQsIHdlIG5vdyBjaGVjayBmb3IgdGhpcyBjb25kaXRpb24gYW5kIGJhaWwgb3V0 IGlmIG5lZWRlZC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNv bGF0ZWRUcmVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFYSXNvbGF0ZWRUcmVlOjpub2RlRm9y SUQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZFRyZWU6OmFwcGx5UGVuZGlu Z0NoYW5nZXMpOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0 ZWRUcmVlLmg6IFJlb3JkZXJlZCBwcml2YXRlIG1ldGhvZHMKKyAgICAgICAgYWJvdmUgbWVtYmVy IHZhcmlhYmxlcyB0byBjb21wbHkgd2l0aCBXZWJLaXQgY29kaW5nIGNvbnZlbnRpb25zLAorICAg ICAgICBwb2ludGVkIG91dCBieSBEYXJpbiBBZGxlciBpbiByZXZpZXcgZm9yIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM0MzUuCisKIDIwMjAtMDYtMjMgIFNlcmdp byBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1mbGV4 XSBBbGxvdyBpbmRlZmluaXRlIHNpemUgZmxleCBpdGVtcyB0byBiZSBkZWZpbml0ZSB3cnQgcmVz b2x2aW5nIHBlcmNlbnRhZ2VzIGluc2lkZSB0aGVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5jcHAKaW5k ZXggMGEwOWIwMzRhN2VlMWM0ZmI5MzY2MTNjMWJiZmU1NjRiMDk1NjU4YS4uYTRiYmY5OWIyZTZl ODA5ZWRlYzA0MmJlNDc1OTQxZmJjMzI1NTQwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRUcmVlLmNwcApA QCAtMTQwLDEwICsxNDAsMTAgQEAgUmVmUHRyPEFYSXNvbGF0ZWRUcmVlPiBBWElzb2xhdGVkVHJl ZTo6dHJlZUZvclBhZ2VJRChQYWdlSWRlbnRpZmllciBwYWdlSUQpCiAKIFJlZlB0cjxBWElzb2xh dGVkT2JqZWN0PiBBWElzb2xhdGVkVHJlZTo6bm9kZUZvcklEKEFYSUQgYXhJRCkgY29uc3QKIHsK LSAgICAvLyBGSVhNRTogVGhlIGZvbGxvd2luZyBBU1NFUlQgc2hvdWxkIGJlIG1ldCBidXQgaXQg aXMgY29tbWVudGVkIG91dCBhdCB0aGUKLSAgICAvLyBtb21lbnQgYmVjYXVzZSBvZiA8cmRhcjov L3Byb2JsZW0vNjM5ODU2NDY+IEFmdGVyIGNhbGxpbmcgX0FYVUlFbGVtZW50VXNlU2Vjb25kYXJ5 QVhUaHJlYWQodHJ1ZSksCi0gICAgLy8gc3RpbGwgcmVjZWl2ZXMgY2xpZW50IHJlcXVlc3Qgb24g bWFpbiB0aHJlYWQuCi0gICAgLy8gQVNTRVJUKGF4T2JqZWN0Q2FjaGUoKS0+Y2FuVXNlU2Vjb25k YXJ5QVhUaHJlYWQoKSA/ICFpc01haW5UaHJlYWQoKSA6IGlzTWFpblRocmVhZCgpKTsKKyAgICAv LyBJbiBpc29sYXRlZCB0cmVlIG1vZGUgMiwgb25seSBhY2Nlc3MgbV9yZWFkZXJUaHJlYWROb2Rl TWFwIG9uIHRoZSBBWCB0aHJlYWQuCisgICAgaWYgKGF4T2JqZWN0Q2FjaGUoKS0+Y2FuVXNlU2Vj b25kYXJ5QVhUaHJlYWQoKSAmJiBpc01haW5UaHJlYWQoKSkKKyAgICAgICAgcmV0dXJuIG51bGxw dHI7CisKICAgICByZXR1cm4gYXhJRCAhPSBJbnZhbGlkQVhJRCA/IG1fcmVhZGVyVGhyZWFkTm9k ZU1hcC5nZXQoYXhJRCkgOiBudWxscHRyOwogfQogCkBAIC0zOTAsNiArMzkwLDExIEBAIHZvaWQg QVhJc29sYXRlZFRyZWU6OmFwcGVuZE5vZGVDaGFuZ2VzKFZlY3RvcjxOb2RlQ2hhbmdlPiYmIGNo YW5nZXMpCiB2b2lkIEFYSXNvbGF0ZWRUcmVlOjphcHBseVBlbmRpbmdDaGFuZ2VzKCkKIHsKICAg ICBBWFRSQUNFKCJBWElzb2xhdGVkVHJlZTo6YXBwbHlQZW5kaW5nQ2hhbmdlcyIpOworCisgICAg Ly8gSW4gaXNvbGF0ZWQgdHJlZSBtb2RlIDIsIG9ubHkgYXBwbHkgcGVuZGluZyBjaGFuZ2VzIG9u IHRoZSBBWCB0aHJlYWQuCisgICAgaWYgKGF4T2JqZWN0Q2FjaGUoKS0+Y2FuVXNlU2Vjb25kYXJ5 QVhUaHJlYWQoKSAmJiBpc01haW5UaHJlYWQoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgTG9j a0hvbGRlciBsb2NrZXIgeyBtX2NoYW5nZUxvZ0xvY2sgfTsKIAogICAgIEFYTE9HKG1ha2VTdHJp bmcoImZvY3VzZWROb2RlSUQgIiwgbV9mb2N1c2VkTm9kZUlELCAiIHBlbmRpbmdGb2N1c2VkTm9k ZUlEICIsIG1fcGVuZGluZ0ZvY3VzZWROb2RlSUQpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRUcmVlLmggYi9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5oCmluZGV4 IDk3MzViZjZmODhkZjE1NzYxNTNjYWQzNWU3YjkyOWUzMzE1ZjMzMGYuLjE2YTRiYTkzMzI4Nzkz YTZiZTgyMjAwYTk3N2JhZTNhYjM0M2YzMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRUcmVlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuaApAQCAtOTgs NyArOTgsNiBAQCBwcml2YXRlOgogICAgIEFYSXNvbGF0ZWRUcmVlKCk7CiAgICAgdm9pZCBjbGVh cigpOwogCi0gICAgQVhJc29sYXRlZFRyZWVJRCBtX3RyZWVJRDsKICAgICBzdGF0aWMgSGFzaE1h cDxBWElzb2xhdGVkVHJlZUlELCBSZWY8QVhJc29sYXRlZFRyZWU+PiYgdHJlZUlEQ2FjaGUoKTsK ICAgICBzdGF0aWMgSGFzaE1hcDxQYWdlSWRlbnRpZmllciwgUmVmPEFYSXNvbGF0ZWRUcmVlPj4m IHRyZWVQYWdlQ2FjaGUoKTsKIApAQCAtMTA2LDcgKzEwNSwxMCBAQCBwcml2YXRlOgogICAgIFJl ZjxBWElzb2xhdGVkT2JqZWN0PiBjcmVhdGVTdWJ0cmVlKEFYQ29yZU9iamVjdCYsIEFYSUQgcGFy ZW50SUQsIGJvb2wgYXR0YWNoV3JhcHBlciwgVmVjdG9yPE5vZGVDaGFuZ2U+Jik7CiAgICAgLy8g UXVldWVzIGFsbCBwZW5kaW5nIGFkZGl0aW9ucyB0byB0aGUgdHJlZSBhcyB0aGUgcmVzdWx0IG9m IGEgc3VidHJlZSBnZW5lcmF0aW9uLgogICAgIHZvaWQgYXBwZW5kTm9kZUNoYW5nZXMoVmVjdG9y PE5vZGVDaGFuZ2U+JiYpOworICAgIC8vIENhbGxlZCBvbiBtYWluIHRocmVhZCB0byB1cGRhdGUg Ym90aCBtX25vZGVNYXAgYW5kIG1fcGVuZGluZ0NoaWxkcmVuVXBkYXRlcy4KKyAgICB2b2lkIHVw ZGF0ZUNoaWxkcmVuSURzKEFYSUQgYXhJRCwgVmVjdG9yPEFYSUQ+JiYgY2hpbGRyZW5JRHMpOwog CisgICAgQVhJc29sYXRlZFRyZWVJRCBtX3RyZWVJRDsKICAgICBBWE9iamVjdENhY2hlKiBtX2F4 T2JqZWN0Q2FjaGUgeyBudWxscHRyIH07CiAKICAgICAvLyBPbmx5IGFjY2Vzc2VkIG9uIG1haW4g dGhyZWFkLgpAQCAtMTIzLDkgKzEyNSw2IEBAIHByaXZhdGU6CiAgICAgQVhJRCBtX3BlbmRpbmdG b2N1c2VkTm9kZUlEIHsgSW52YWxpZEFYSUQgfTsKICAgICBBWElEIG1fZm9jdXNlZE5vZGVJRCB7 IEludmFsaWRBWElEIH07CiAgICAgTG9jayBtX2NoYW5nZUxvZ0xvY2s7Ci0KLSAgICAvLyBDYWxs ZWQgb24gbWFpbiB0aHJlYWQgdG8gdXBkYXRlcyBib3RoIG1fbm9kZU1hcCBhbmQgbV9wZW5kaW5n Q2hpbGRyZW5VcGRhdGVzLgotICAgIHZvaWQgdXBkYXRlQ2hpbGRyZW5JRHMoQVhJRCBheElELCBW ZWN0b3I8QVhJRD4mJiBjaGlsZHJlbklEcyk7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl Cg==