213570 2020-06-24 12:06:08 -0700 Black rectangle appears when closing PIP on iPhone 2020-06-24 19:12:00 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1665815 0 peng.liu6 2020-06-24 12:06:08 -0700 Black rectangle appears when closing PIP on iPhone 1665816 1 peng.liu6 2020-06-24 12:06:51 -0700 <rdar://problem/62963556> 1665845 2 402678 peng.liu6 2020-06-24 13:23:29 -0700 Created attachment 402678 Patch 1665854 3 402678 eric.carlson 2020-06-24 13:49:03 -0700 Comment on attachment 402678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402678&action=review > Source/WebCore/ChangeLog:10 > + Don't unhide the window and view of WebAVPlayerViewController before exiting Picture-in-Picture. I think it is worth saying where m_window will be made visible, e.g. "... before exiting Picture-in-Picture because m_window will be shown ..." 1665884 4 402678 peng.liu6 2020-06-24 15:28:00 -0700 Comment on attachment 402678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402678&action=review >> Source/WebCore/ChangeLog:10 >> + Don't unhide the window and view of WebAVPlayerViewController before exiting Picture-in-Picture. > > I think it is worth saying where m_window will be made visible, e.g. "... before exiting Picture-in-Picture because m_window will be shown ..." Thanks for the review! Actually both m_window and m_playerViewController will be destroyed after exiting picture-in-picture. So I think we don't need to show them before destroying them unless there is some animation issue (I haven't found any issue in tests yet). 1665956 5 ews-feeder 2020-06-24 19:11:59 -0700 Committed r263492: <https://trac.webkit.org/changeset/263492> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402678. 402678 2020-06-24 13:23:29 -0700 2020-06-24 19:11:59 -0700 Patch bug-213570-20200624132328.patch text/plain 1606 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRkY2Q0OTNiNGM3NGZj ZTc5MmEyYjNmYThmYzc0NDhiZWI5M2IxZi4uMTU4NjliZmIzNDM4YzE0MDFlZjYxN2E4ODg1ZTBj ZGEyNzcwYjU1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA2LTI0ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgQmxhY2sgcmVjdGFuZ2xlIGFw cGVhcnMgd2hlbiBjbG9zaW5nIFBJUCBvbiBpUGhvbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzU3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL1ZpZGVvRnVsbHNjcmVlbklu dGVyZmFjZUFWS2l0Lm1tOgorICAgICAgICAoVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6 OndpbGxTdG9wUGljdHVyZUluUGljdHVyZSk6CisgICAgICAgIERvbid0IHVuaGlkZSB0aGUgd2lu ZG93IGFuZCB2aWV3IG9mIFdlYkFWUGxheWVyVmlld0NvbnRyb2xsZXIgYmVmb3JlIGV4aXRpbmcg UGljdHVyZS1pbi1QaWN0dXJlLgorCiAyMDIwLTA2LTIzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBh cHBsZS5jb20+CiAKICAgICAgICAgW011bHRpY29sXSBSZXNldCB0aGUgY2hpbGRyZW5JbmxpbmUg c3RhdGUgb24gdGhlIFJlbmRlckJsb2NrRmxvdyB3aGVuIGRlc3Ryb3lpbmcgdGhlIG11bHRpY29s dW1uIGNvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9WaWRl b0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lv cy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQppbmRleCA2MDk0YzhmMDRkNGYxOTlk M2QxZTE3YTZjOTUzNzZkNWVjMTMxMjdmLi5iNTM3MjhiNmE0ZDZlOGVhZjNlZDVlYTZkMTFmMzY5 MmJlZWI3MGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVmlkZW9G dWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCkBAIC0xMTE4LDkgKzExMTgsNiBA QCB2b2lkIFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Ojp3aWxsU3RvcFBpY3R1cmVJblBp Y3R1cmUoKQogICAgIGlmIChtX2N1cnJlbnRNb2RlLmhhc0Z1bGxzY3JlZW4oKSB8fCBtX3Jlc3Rv cmluZ0Z1bGxzY3JlZW5Gb3JQaWN0dXJlSW5QaWN0dXJlU3RvcCkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgW21fd2luZG93IHNldEhpZGRlbjpOT107Ci0gICAgW1ttX3BsYXllclZpZXdDb250cm9s bGVyIHZpZXddIHNldEhpZGRlbjpOT107Ci0KICAgICBpZiAobV92aWRlb0Z1bGxzY3JlZW5Nb2Rl bCkKICAgICAgICAgbV92aWRlb0Z1bGxzY3JlZW5Nb2RlbC0+d2lsbEV4aXRQaWN0dXJlSW5QaWN0 dXJlKCk7CiB9Cg==