213543 2020-06-23 18:51:51 -0700 REGRESSION(r260800): Null Ptr Deref READ @ WTF::Optional<WTF::Seconds>::clear 2020-06-25 15:12:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207153 InRadar P2 Normal --- 1 pgyanchandani sabouhallawa achristensen bfulgham darin ggaren sabouhallawa simon.fraser zalan oldest_to_newest 1665616 0 pgyanchandani 2020-06-23 18:51:51 -0700 Null Ptr Deref READ @ WTF::Optional<WTF::Seconds>::clear 1665617 1 pgyanchandani 2020-06-23 18:53:05 -0700 rdar://problem/64494037 1665654 2 402625 pgyanchandani 2020-06-23 23:43:51 -0700 Created attachment 402625 Patch 1665798 3 402625 achristensen 2020-06-24 11:12:51 -0700 Comment on attachment 402625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402625&action=review Null check looks fine. > LayoutTests/fast/rendering/iframe-window-animation-modifies-iframe-srcdoc-crash.html:22 > +<video onloadstart="runTest()"> This is running after DumpRenderTree has already finished the test. If you move the testRunner.dumpAsText call to outside the function it should make the results the same for DumpRenderTree and WebKitTestRunner. 1665808 4 402666 pgyanchandani 2020-06-24 11:42:12 -0700 Created attachment 402666 Patch 1665824 5 402666 ggaren 2020-06-24 12:26:56 -0700 Comment on attachment 402666 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402666&action=review > LayoutTests/fast/rendering/iframe-window-animation-modifies-iframe-srcdoc-crash.html:21 > +<video onloadstart="runTest()"> Alex's suggestion helped, but I think we can do even better here. From the test harness's perspective by default, the test is over when you hit the closing </html> tag. So, the video loadstart and requestAnimation frame callbacks, which happen asynchronously on a delay, happen after the test harness thinks the test is over. That seems to work, but it's a bit fragile, since the test harness would be well within its rights to just terminate the test before any of that code ran. testRunner.waitUntilDone() is how we tell the test harness that we want it to wait until some point after the closing </html> tag. And testRunner.notifyDone() is how we tell the test harness we have reached that point. So, I think you should call testRunner.waitUntilDone() at the top, right after testRunner.dumpAsText(), and then call testRunner.notifyDone() as the last line in srcDocModify(). 1665851 6 402666 ggaren 2020-06-24 13:45:07 -0700 Comment on attachment 402666 Patch r=me since the test does work for now, and we're having a heck of a time getting waitUntilDone() to work 1665863 7 ews-feeder 2020-06-24 14:07:41 -0700 Committed r263473: <https://trac.webkit.org/changeset/263473> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402666. 1665892 8 pgyanchandani 2020-06-24 15:41:00 -0700 (In reply to Geoffrey Garen from comment #5) > Comment on attachment 402666 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402666&action=review > > > LayoutTests/fast/rendering/iframe-window-animation-modifies-iframe-srcdoc-crash.html:21 > > +<video onloadstart="runTest()"> > > Alex's suggestion helped, but I think we can do even better here. > > From the test harness's perspective by default, the test is over when you > hit the closing </html> tag. So, the video loadstart and requestAnimation > frame callbacks, which happen asynchronously on a delay, happen after the > test harness thinks the test is over. That seems to work, but it's a bit > fragile, since the test harness would be well within its rights to just > terminate the test before any of that code ran. > > testRunner.waitUntilDone() is how we tell the test harness that we want it > to wait until some point after the closing </html> tag. And > testRunner.notifyDone() is how we tell the test harness we have reached that > point. > > So, I think you should call testRunner.waitUntilDone() at the top, right > after testRunner.dumpAsText(), and then call testRunner.notifyDone() as the > last line in srcDocModify(). Making a note for future reference - waitUntilDone() and notifyDone() was not working for this test. notifyDone was never getting called. 1665906 9 402666 sabouhallawa 2020-06-24 16:32:24 -0700 Comment on attachment 402666 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402666&action=review >>> LayoutTests/fast/rendering/iframe-window-animation-modifies-iframe-srcdoc-crash.html:21 >>> +<video onloadstart="runTest()"> >> >> Alex's suggestion helped, but I think we can do even better here. >> >> From the test harness's perspective by default, the test is over when you hit the closing </html> tag. So, the video loadstart and requestAnimation frame callbacks, which happen asynchronously on a delay, happen after the test harness thinks the test is over. That seems to work, but it's a bit fragile, since the test harness would be well within its rights to just terminate the test before any of that code ran. >> >> testRunner.waitUntilDone() is how we tell the test harness that we want it to wait until some point after the closing </html> tag. And testRunner.notifyDone() is how we tell the test harness we have reached that point. >> >> So, I think you should call testRunner.waitUntilDone() at the top, right after testRunner.dumpAsText(), and then call testRunner.notifyDone() as the last line in srcDocModify(). > > Making a note for future reference - waitUntilDone() and notifyDone() was not working for this test. notifyDone was never getting called. I do not think this is correct. Just follow what Geoffrey said in his comment and the test will not timeout. For quicker verification, you can just add alert messages in runTest() and srcDocModify() and open the test in mini browser and you will see the alert messages pop up as expected. 1665913 10 simon.fraser 2020-06-24 17:14:01 -0700 We should not leave this broken test in the tree. 1665938 11 pgyanchandani 2020-06-24 17:54:39 -0700 (In reply to Simon Fraser (smfr) from comment #10) > We should not leave this broken test in the tree. Hi Simon, Said, Tried making modification to the test as suggested by Geoff and for some reason the test times out for notifyDone with WebKitTestRunner. Even Geoff tried the same and both of us were facing the same issue. I am trying to check on the same. Thanks, Pinki 1666184 12 sabouhallawa 2020-06-25 13:08:58 -0700 Reopening to attach new patch. 1666185 13 402800 sabouhallawa 2020-06-25 13:08:59 -0700 Created attachment 402800 Patch 1666244 14 ews-feeder 2020-06-25 15:12:20 -0700 Committed r263533: <https://trac.webkit.org/changeset/263533> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402800. 402625 2020-06-23 23:43:51 -0700 2020-06-24 11:42:10 -0700 Patch bug-213543-20200623234350.patch text/plain 3783 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMwNGYxM2JkY2E2MDI0 ZTFhNGY0NzUzNjcxOWY0MDNhMTJjYmI3ZS4uY2Q3YWRkM2RlOWJhYWY0NjNhZjI4NGIzOGYzNDY5 NDNiNzUxZGM1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA2LTIzICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs IFB0ciBEZXJlZiBSRUFEIEAgV1RGOjpPcHRpb25hbDxXVEY6OlNlY29uZHM+OjpjbGVhcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzNTQzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hpbGUgcGVyZm9y bWluZyBhbiBhbmltYXRpb24gcmVxdWVzdCwgdGhlIGNhbGxiYWNrIGZ1bmN0aW9ucyBtb2RpZmll cyB0aGUgaWZyYW1lJ3Mgc3JjZG9jIGF0dHJpYnV0ZSwgbGVhZGluZyB0byBkb21XaW5kb3cgYmVp bmcgbnVsbCBkdXJpbmcKKyAgICAgICAgcmVuZGVyaW5nLCBhbmQgcmVzdWx0aW5nIGludG8gY3Jh c2guCisKKyAgICAgICAgVGVzdDogZmFzdC9yZW5kZXJpbmcvaWZyYW1lLXdpbmRvdy1hbmltYXRp b24tbW9kaWZpZXMtaWZyYW1lLXNyY2RvYy1jcmFzaC5odG1sCisKKyAgICAgICAgKiBwYWdlL1Bh Z2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6dXBkYXRlUmVuZGVyaW5nKToKKwogMjAy MC0wNi0xOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2Nv YV0gRGVsYXkgaXNzdWluZyBNYW5hZ2VkU2Vzc2lvbiAmIE5ldHdvcmsgRXh0ZW5zaW9uIHNhbmRi b3ggZXh0ZW5zaW9ucyB1bnRpbCBhIGxvYWQgaXMgYWN0dWFsbHkgaXNzdWVkCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl LmNwcAppbmRleCBkZGFiMDZkOGMxMzU4ZTE2MGQ3YjI1Y2YzZDk2Y2FiOTBkYzI5MWE2Li40MjY1 MjBhZmM2N2IyNzliNTBmZDVmMjBmMWRkZDQ0MzBmYmU1ZjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAK QEAgLTE0MjQsNyArMTQyNCw3IEBAIHZvaWQgUGFnZTo6dXBkYXRlUmVuZGVyaW5nKCkKICAgICB9 KTsKIAogICAgIGZvciAoYXV0byYgZG9jdW1lbnQgOiBpbml0aWFsRG9jdW1lbnRzKSB7Ci0gICAg ICAgIGlmIChkb2N1bWVudCkKKyAgICAgICAgaWYgKGRvY3VtZW50ICYmIGRvY3VtZW50LT5kb21X aW5kb3coKSkKICAgICAgICAgICAgIGRvY3VtZW50LT5kb21XaW5kb3coKS0+dW5mcmVlemVOb3dU aW1lc3RhbXAoKTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmZThhOTI3OWQ0ODI5ZDkzMGJmOTVmNjUyYmIw MDEwMWM5OTZkOTYzLi5hODlkMDExNmNmOWY2ZDBlMWU2MDQ5NWRiM2I3ODA3NjkwNGRkMThhIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDYtMjMgIFBpbmtpIEd5YW5jaGFuZGFuaSAgPHBn eWFuY2hhbmRhbmlAYXBwbGUuY29tPgorCisgICAgICAgIE51bGwgUHRyIERlcmVmIFJFQUQgQCBX VEY6Ok9wdGlvbmFsPFdURjo6U2Vjb25kcz46OmNsZWFyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM1NDMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIHJlZ3Jlc3Npb24gdGVzdC4KKworICAg ICAgICAqIGZhc3QvcmVuZGVyaW5nL2lmcmFtZS13aW5kb3ctYW5pbWF0aW9uLW1vZGlmaWVzLWlm cmFtZS1zcmNkb2MtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3Jl bmRlcmluZy9pZnJhbWUtd2luZG93LWFuaW1hdGlvbi1tb2RpZmllcy1pZnJhbWUtc3JjZG9jLWNy YXNoLmh0bWw6IEFkZGVkLgorCiAyMDIwLTA2LTE5ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhm aWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvc3lzdGVt LWxhbmd1YWdlL25hdmlnYXRvci1sYW5ndWFnZS9uYXZpZ2F0b3ItbGFuZ3VhZ2UgdGVzdHMgYXJl IGZhaWxpbmcgb24gQ2F0YWxpbmEgYW5kIGlPUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9yZW5kZXJpbmcvaWZyYW1lLXdpbmRvdy1hbmltYXRpb24tbW9kaWZpZXMtaWZyYW1lLXNyY2Rv Yy1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3JlbmRlcmluZy9pZnJhbWUt d2luZG93LWFuaW1hdGlvbi1tb2RpZmllcy1pZnJhbWUtc3JjZG9jLWNyYXNoLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi41ZTRmMjIxZjQ2NWIxMjBhZjIwMWQwZjkxNWU2MGRlNGY2MjA0ZGVhCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZW5kZXJpbmcvaWZyYW1lLXdpbmRv dy1hbmltYXRpb24tbW9kaWZpZXMtaWZyYW1lLXNyY2RvYy1jcmFzaC1leHBlY3RlZC50eHQKQEAg LTAsMCArMSwzIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNyYXNoLgorCisg CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlbmRlcmluZy9pZnJhbWUtd2luZG93LWFu aW1hdGlvbi1tb2RpZmllcy1pZnJhbWUtc3JjZG9jLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L3JlbmRlcmluZy9pZnJhbWUtd2luZG93LWFuaW1hdGlvbi1tb2RpZmllcy1pZnJhbWUtc3Jj ZG9jLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNGI5ZDg4MGIyODE2MjM3MGEyZjM2MjJjMmExMDcw MWNmZDE5NjNhMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVuZGVyaW5n L2lmcmFtZS13aW5kb3ctYW5pbWF0aW9uLW1vZGlmaWVzLWlmcmFtZS1zcmNkb2MtY3Jhc2guaHRt bApAQCAtMCwwICsxLDI1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorCis8c2NyaXB0Pgor ZnVuY3Rpb24gc3JjRG9jTW9kaWZ5KCkgeworICAgIGlmcmFtZS5zcmNkb2MgPSAiIjsKK30KK2Z1 bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHsKKyAg ICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgfQorICAgIGRvY3VtZW50ID0gaWZy YW1lLmNvbnRlbnREb2N1bWVudDsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgic2VsZWN0QWxs IiwgZmFsc2UpOworICAgIHdpbmRvdy5yZXF1ZXN0QW5pbWF0aW9uRnJhbWUoc3JjRG9jTW9kaWZ5 KTsKK30KKzwvc2NyaXB0PgorCis8Ym9keT4KKzxwPlRoaXMgdGVzdCBwYXNzZXMgaWYgdGhlcmUg aXMgbm8gY3Jhc2guPC9wPgorPGlmcmFtZSBpZD0iaWZyYW1lIiBzcmM9ImRhdGE6dGV4dC9odG1s LGZvbyI+PC9pZnJhbWU+Cis8dmlkZW8gIG9ubG9hZHN0YXJ0PSJydW5UZXN0KCkiPgorPHNvdXJj ZT4KKzwvYm9keT4KKzwvaHRtbD4K 402666 2020-06-24 11:42:12 -0700 2020-06-24 14:07:42 -0700 Patch bug-213543-20200624114211.patch text/plain 3709 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDkyNTMxOGE0OTk2MDhm OGY0NWQ1ZDg2ZTAxNDFjZDFjNDQ0NTE0My4uMjJhMjkxYmUzZmU1YmNiODc5ZDdiN2IzZGI0M2Zk MmZhZTc3Mzk1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA2LTI0ICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs IFB0ciBEZXJlZiBSRUFEIEAgV1RGOjpPcHRpb25hbDxXVEY6OlNlY29uZHM+OjpjbGVhcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzNTQzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hpbGUgcGVyZm9y bWluZyBhbiBhbmltYXRpb24gcmVxdWVzdCwgdGhlIGNhbGxiYWNrIGZ1bmN0aW9ucyBtb2RpZmll cyB0aGUgaWZyYW1lJ3Mgc3JjZG9jIGF0dHJpYnV0ZSwgbGVhZGluZyB0byBkb21XaW5kb3cgYmVp bmcgbnVsbCBkdXJpbmcKKyAgICAgICAgcmVuZGVyaW5nLCBhbmQgcmVzdWx0aW5nIGludG8gY3Jh c2guCisKKyAgICAgICAgVGVzdDogZmFzdC9yZW5kZXJpbmcvaWZyYW1lLXdpbmRvdy1hbmltYXRp b24tbW9kaWZpZXMtaWZyYW1lLXNyY2RvYy1jcmFzaC5odG1sCisKKyAgICAgICAgKiBwYWdlL1Bh Z2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6dXBkYXRlUmVuZGVyaW5nKToKKwogMjAy MC0wNi0yNCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBEb24ndCBjbGFpbSB0byBzdXBwb3J0IGZ1bGxzY3JlZW4gbW9kZSB1bmxlc3MgZnVsbFNjcmVl bkVuYWJsZWQgc2V0dGluZyBpcyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL1BhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCBkZGFiMDZk OGMxMzU4ZTE2MGQ3YjI1Y2YzZDk2Y2FiOTBkYzI5MWE2Li40MjY1MjBhZmM2N2IyNzliNTBmZDVm MjBmMWRkZDQ0MzBmYmU1ZjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2Uu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTE0MjQsNyArMTQyNCw3 IEBAIHZvaWQgUGFnZTo6dXBkYXRlUmVuZGVyaW5nKCkKICAgICB9KTsKIAogICAgIGZvciAoYXV0 byYgZG9jdW1lbnQgOiBpbml0aWFsRG9jdW1lbnRzKSB7Ci0gICAgICAgIGlmIChkb2N1bWVudCkK KyAgICAgICAgaWYgKGRvY3VtZW50ICYmIGRvY3VtZW50LT5kb21XaW5kb3coKSkKICAgICAgICAg ICAgIGRvY3VtZW50LT5kb21XaW5kb3coKS0+dW5mcmVlemVOb3dUaW1lc3RhbXAoKTsKICAgICB9 CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA4MzM2MWYyZDU1MTA5ZTdhNDM4ZTViOGFhNzExZTg2NWQyMGRhNzc1Li5hNjIw ZWFlMTkyNmY2MWQwZGNiOWY2NzA3NDExZDg2NzI3OWQwYjRhIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMjAtMDYtMjQgIFBpbmtpIEd5YW5jaGFuZGFuaSAgPHBneWFuY2hhbmRhbmlAYXBwbGUu Y29tPgorCisgICAgICAgIE51bGwgUHRyIERlcmVmIFJFQUQgQCBXVEY6Ok9wdGlvbmFsPFdURjo6 U2Vjb25kcz46OmNsZWFyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTM1NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAK KyAgICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QuCisKKyAgICAgICAgKiBmYXN0L3JlbmRl cmluZy9pZnJhbWUtd2luZG93LWFuaW1hdGlvbi1tb2RpZmllcy1pZnJhbWUtc3JjZG9jLWNyYXNo LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZW5kZXJpbmcvaWZyYW1lLXdp bmRvdy1hbmltYXRpb24tbW9kaWZpZXMtaWZyYW1lLXNyY2RvYy1jcmFzaC5odG1sOiBBZGRlZC4K KwogMjAyMC0wNi0yNCAgS2FybCBSYWNrbGVyICA8cmFja2xlckBhcHBsZS5jb20+CiAKICAgICAg ICAgQ2FudmFzL3BoaWxpcC90ZXN0cy8yZC5saW5lLmNhcC5yb3VuZC5odG1sIGlzIG5vIGxvbmdl ciBmYWlsaW5nIC0gcmVtb3ZlIGV4cGVjdGF0aW9ucwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9yZW5kZXJpbmcvaWZyYW1lLXdpbmRvdy1hbmltYXRpb24tbW9kaWZpZXMtaWZyYW1lLXNy Y2RvYy1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3JlbmRlcmluZy9pZnJh bWUtd2luZG93LWFuaW1hdGlvbi1tb2RpZmllcy1pZnJhbWUtc3JjZG9jLWNyYXNoLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi41ZTRmMjIxZjQ2NWIxMjBhZjIwMWQwZjkxNWU2MGRlNGY2MjA0ZGVh Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZW5kZXJpbmcvaWZyYW1lLXdp bmRvdy1hbmltYXRpb24tbW9kaWZpZXMtaWZyYW1lLXNyY2RvYy1jcmFzaC1leHBlY3RlZC50eHQK QEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNyYXNoLgor CisgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlbmRlcmluZy9pZnJhbWUtd2luZG93 LWFuaW1hdGlvbi1tb2RpZmllcy1pZnJhbWUtc3JjZG9jLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L3JlbmRlcmluZy9pZnJhbWUtd2luZG93LWFuaW1hdGlvbi1tb2RpZmllcy1pZnJhbWUt c3JjZG9jLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjBhOTA2NGIxN2Y0ZDg3OTEyZjI0MDIzN2Q5 NTI1OTZkYTAyZjIzNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVuZGVy aW5nL2lmcmFtZS13aW5kb3ctYW5pbWF0aW9uLW1vZGlmaWVzLWlmcmFtZS1zcmNkb2MtY3Jhc2gu aHRtbApAQCAtMCwwICsxLDI0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorCis8c2NyaXB0 PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwor CitmdW5jdGlvbiBzcmNEb2NNb2RpZnkoKSB7CisgICAgaWZyYW1lLnNyY2RvYyA9ICIiOworfQor ZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICBkb2N1bWVudCA9IGlmcmFtZS5jb250ZW50RG9jdW1l bnQ7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoInNlbGVjdEFsbCIsIGZhbHNlKTsKKyAgICB3 aW5kb3cucmVxdWVzdEFuaW1hdGlvbkZyYW1lKHNyY0RvY01vZGlmeSk7Cit9Cis8L3NjcmlwdD4K KworPGJvZHk+Cis8cD5UaGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNyYXNoLjwvcD4K KzxpZnJhbWUgaWQ9ImlmcmFtZSIgc3JjPSJkYXRhOnRleHQvaHRtbCxmb28iPjwvaWZyYW1lPgor PHZpZGVvICBvbmxvYWRzdGFydD0icnVuVGVzdCgpIj4KKzxzb3VyY2U+Cis8L2JvZHk+Cis8L2h0 bWw+Cg== 402800 2020-06-25 13:08:59 -0700 2020-06-25 15:12:20 -0700 Patch bug-213543-20200625130858.patch text/plain 1703 sabouhallawa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI2MzUyNCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA2LTI1ICBTYWlkIEFib3UtSGFsbGF3 YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjYwODAw KTogTnVsbCBQdHIgRGVyZWYgUkVBRCBAIFdURjo6T3B0aW9uYWw8V1RGOjpTZWNvbmRzPjo6Y2xl YXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzU0 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug dGhlIHRlc3QgYXN5bmNocm9ub3VzIHNpbmNlIGl0IGludm9sdmVzIGEgckFGIGNhbGxiYWNrLgor CisgICAgICAgICogZmFzdC9yZW5kZXJpbmcvaWZyYW1lLXdpbmRvdy1hbmltYXRpb24tbW9kaWZp ZXMtaWZyYW1lLXNyY2RvYy1jcmFzaC5odG1sOgorCiAyMDIwLTA2LTI1ICBLYXJsIFJhY2tsZXIg IDxyYWNrbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgZXhwZWN0YXRpb24gZm9yIGZh c3QvZHluYW1pYy93aW5kb3ctcmVzaXplLXNjcm9sbGJhcnMtdGVzdC5odG1sIGFzIHRoZXkgYXJl IHBhc3NpbmcuIApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9yZW5kZXJpbmcvaWZyYW1lLXdpbmRv dy1hbmltYXRpb24tbW9kaWZpZXMtaWZyYW1lLXNyY2RvYy1jcmFzaC5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvcmVuZGVyaW5nL2lmcmFtZS13aW5kb3ctYW5pbWF0aW9uLW1v ZGlmaWVzLWlmcmFtZS1zcmNkb2MtY3Jhc2guaHRtbAkocmV2aXNpb24gMjYzNTIyKQorKysgTGF5 b3V0VGVzdHMvZmFzdC9yZW5kZXJpbmcvaWZyYW1lLXdpbmRvdy1hbmltYXRpb24tbW9kaWZpZXMt aWZyYW1lLXNyY2RvYy1jcmFzaC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yLDExICsyLDE1IEBA CiA8aHRtbD4KIAogPHNjcmlwdD4KLWlmICh3aW5kb3cudGVzdFJ1bm5lcikKK2lmICh3aW5kb3cu dGVzdFJ1bm5lcikgeworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOwogICAgIHRlc3RS dW5uZXIuZHVtcEFzVGV4dCgpOworfQogCiBmdW5jdGlvbiBzcmNEb2NNb2RpZnkoKSB7CiAgICAg aWZyYW1lLnNyY2RvYyA9ICIiOworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAg dGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CiB9CiBmdW5jdGlvbiBydW5UZXN0KCkgewogICAgIGRv Y3VtZW50ID0gaWZyYW1lLmNvbnRlbnREb2N1bWVudDsKQEAgLTE4LDcgKzIyLDcgQEAgZnVuY3Rp b24gcnVuVGVzdCgpIHsKIDxib2R5PgogPHA+VGhpcyB0ZXN0IHBhc3NlcyBpZiB0aGVyZSBpcyBu byBjcmFzaC48L3A+CiA8aWZyYW1lIGlkPSJpZnJhbWUiIHNyYz0iZGF0YTp0ZXh0L2h0bWwsZm9v Ij48L2lmcmFtZT4KLTx2aWRlbyAgb25sb2Fkc3RhcnQ9InJ1blRlc3QoKSI+Cis8dmlkZW8gb25s b2Fkc3RhcnQ9InJ1blRlc3QoKSI+CiA8c291cmNlPgogPC9ib2R5PgogPC9odG1sPgo=