213538 2020-06-23 16:12:32 -0700 Remove [CallbackNeedsOperatorEqual] extended attribute 2020-06-24 04:12:21 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203288 InRadar P2 Enhancement --- 1 ashvayka ashvayka cdumez darin ews-watchlist joepeck sam webkit-bug-importer oldest_to_newest 1665581 0 ashvayka 2020-06-23 16:12:32 -0700 Remove [CallbackNeedsOperatorEqual] extended attribute 1665582 1 402603 ashvayka 2020-06-23 16:16:11 -0700 Created attachment 402603 Patch 1665585 2 402603 cdumez 2020-06-23 16:19:15 -0700 Comment on attachment 402603 Patch Was there no bindings tests for this? I guess we'll see if the bindings bubble is green. 1665693 3 ashvayka 2020-06-24 04:02:50 -0700 (In reply to Chris Dumez from comment #2) > Comment on attachment 402603 [details] > Patch Thank you for review, Chris. > Was there no bindings tests for this? I guess we'll see if the bindings > bubble is green. No, they weren't (according to grep). EWS is all green, so I'm gonna go ahead and land this. 1665694 4 ews-feeder 2020-06-24 04:11:51 -0700 Committed r263450: <https://trac.webkit.org/changeset/263450> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402603. 1665695 5 webkit-bug-importer 2020-06-24 04:12:21 -0700 <rdar://problem/64694906> 402603 2020-06-23 16:16:11 -0700 2020-06-24 04:11:52 -0700 Patch bug-213538-20200624021609.patch text/plain 5606 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MzQyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDIwLTA2LTIzICBBbGV4ZXkg U2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KKworICAgICAgICBSZW1vdmUgW0NhbGxi YWNrTmVlZHNPcGVyYXRvckVxdWFsXSBleHRlbmRlZCBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzUzOAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIHJlbW92ZXMgbm93 IHVudXNlZCBbQ2FsbGJhY2tOZWVkc09wZXJhdG9yRXF1YWxdIGV4dGVuZGVkIGF0dHJpYnV0ZS4K KyAgICAgICAgSXQgd2FzIGFkZGVkIHRvIGFjY29tbW9kYXRlIE1lZGlhUXVlcnlMaXN0TGlzdGVu ZXIsIHdoaWNoIHdhcyByZW1vdmVkIGluIHIyNjAyNDMuCisKKyAgICAgICAgV2UgYXJlIHNhZmUg dG8gcmVtb3ZlIFtDYWxsYmFja05lZWRzT3BlcmF0b3JFcXVhbF0gc2luY2UgaXRzIGltcGxlbWVu dGF0aW9uCisgICAgICAgIGV4cGVjdHMgY2VydGFpbiBjb25zdHJ1Y3RvciBzaWduYXR1cmUsIGFu ZCBjYWxsYmFjayBpbnRlcmZhY2VzIGFyZSBjb25zaWRlcmVkCisgICAgICAgIGxlZ2FjeSBieSBz cGVjIGF1dGhvcnMgYW55d2F5LgorCisgICAgICAgIEFsc28sIHRoaXMgcGF0Y2ggcmVtb3ZlcyAy IHJlc29sdmVkIEZJWE1FczoKKyAgICAgICAgMS4gT3JkaW5hcnlEZWZpbmVPd25Qcm9wZXJ0eSgp IGlzIHBlcmZvcm1lZCBjb3JyZWN0bHksIG5vIGR5bmFtaWMgZGlzcGF0Y2ggdGhlcmUuCisgICAg ICAgIDIuIFNldCgpIGlzIHBlcmZvcm1lZCBjb3JyZWN0bHksIHdpdGggYGZhbHNlYCBhcyBsYXN0 IGFyZ3VtZW50LgorICAgICAgICAgICAoY2hhbmdlZCBpbiBodHRwczovL2dpdGh1Yi5jb20vaGV5 Y2FtL3dlYmlkbC9wdWxsLzgzMiwgY292ZXJlZCBieSBXUFQpCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JKUy5wbToKKyAgICAgICAgKEdlbmVyYXRlRGVmaW5lT3duUHJvcGVydHkpOgor ICAgICAgICAoR2VuZXJhdGVBdHRyaWJ1dGVTZXR0ZXJCb2R5RGVmaW5pdGlvbik6CisgICAgICAg IChHZW5lcmF0ZUNhbGxiYWNrSGVhZGVyQ29udGVudCk6CisgICAgICAgIChHZW5lcmF0ZUNhbGxi YWNrSW1wbGVtZW50YXRpb25Db250ZW50KToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0lE TEF0dHJpYnV0ZXMuanNvbjoKKwogMjAyMC0wNi0yMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0ZSB4Y2ZpbGVsaXN0IGZpbGVzIGFm dGVyIHNvbWUgcmVjZW50IFdlYlhSIGNoYW5nZXMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkocmV2aXNpb24gMjYzNDA3 KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0J KHdvcmtpbmcgY29weSkKQEAgLTEyMjIsNyArMTIyMiw2IEBAIHN1YiBHZW5lcmF0ZURlZmluZU93 blByb3BlcnR5CiAgICAgfQogICAgIAogICAgICMgNC4gUmV0dXJuIE9yZGluYXJ5RGVmaW5lT3du UHJvcGVydHkoTywgUCwgRGVzYykuCi0gICAgIyBGSVhNRTogRG9lcyB0aGlzIGRvIHRoZSBzYW1l IHRoaW5nPwogICAgIHB1c2goQCRvdXRwdXRBcnJheSwgIiAgICByZXR1cm4gSlNPYmplY3Q6OmRl ZmluZU93blByb3BlcnR5KG9iamVjdCwgbGV4aWNhbEdsb2JhbE9iamVjdCwgcHJvcGVydHlOYW1l LCBuZXdQcm9wZXJ0eURlc2NyaXB0b3IsIHNob3VsZFRocm93KTtcbiIpOwogICAgIAogICAgIHB1 c2goQCRvdXRwdXRBcnJheSwgIn1cblxuIik7CkBAIC01MTc2LDkgKzUxNzUsNyBAQCBzdWIgR2Vu ZXJhdGVBdHRyaWJ1dGVTZXR0ZXJCb2R5RGVmaW5pdGlvCiAgICAgICAgIG15ICRmb3J3YXJkSWQg PSAkYXR0cmlidXRlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPntQdXRGb3J3YXJkc307CiAgICAgICAg IHB1c2goQCRvdXRwdXRBcnJheSwgIiAgICBhdXRvIGZvcndhcmRJZCA9IElkZW50aWZpZXI6OmZy b21TdHJpbmcodm0sIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTENoYXIqPihcIiR7Zm9yd2FyZElk fVwiKSwgc3RybGVuKFwiJHtmb3J3YXJkSWR9XCIpKTtcbiIpOwogICAgICAgICAKLSAgICAgICAg IyAzLjUuOS40LiBQZXJmb3JtID8gU2V0KFEsIGZvcndhcmRJZCwgVikuCi0gICAgICAgICMgRklY TUU6IFdoYXQgc2hvdWxkIHRoZSBzZWNvbmQgdmFsdWUgdG8gdGhlIFB1dFByb3BlcnR5U2xvdCBi ZT8KLSAgICAgICAgIyAoaHR0cHM6Ly9naXRodWIuY29tL2hleWNhbS93ZWJpZGwvaXNzdWVzLzM2 OCkKKyAgICAgICAgIyAzLjUuOS40LiBQZXJmb3JtID8gU2V0KFEsIGZvcndhcmRJZCwgViwgZmFs c2UpLgogICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIgICAgUHV0UHJvcGVydHlTbG90IHNs b3QodmFsdWVUb0ZvcndhcmRUbywgZmFsc2UpO1xuIik7CiAgICAgICAgIHB1c2goQCRvdXRwdXRB cnJheSwgIiAgICBhc09iamVjdCh2YWx1ZVRvRm9yd2FyZFRvKS0+bWV0aG9kVGFibGUodm0pLT5w dXQoYXNPYmplY3QodmFsdWVUb0ZvcndhcmRUbyksICZsZXhpY2FsR2xvYmFsT2JqZWN0LCBmb3J3 YXJkSWQsIHZhbHVlLCBzbG90KTtcbiIpOwogICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIg ICAgUkVUVVJOX0lGX0VYQ0VQVElPTih0aHJvd1Njb3BlLCBmYWxzZSk7XG4iKTsKQEAgLTYxNjgs OCArNjE2NSw2IEBAIHN1YiBHZW5lcmF0ZUNhbGxiYWNrSGVhZGVyQ29udGVudAogCiAgICAgcHVz aChAJGNvbnRlbnRSZWYsICIgICAgc3RhdGljIEpTQzo6SlNWYWx1ZSBnZXRDb25zdHJ1Y3RvcihK U0M6OlZNJiwgY29uc3QgSlNDOjpKU0dsb2JhbE9iamVjdCopO1xuIikgaWYgQHskY29uc3RhbnRz fTsKIAotICAgIHB1c2goQCRjb250ZW50UmVmLCAiICAgIHZpcnR1YWwgYm9vbCBvcGVyYXRvcj09 KGNvbnN0ICR7bmFtZX0mKSBjb25zdCBvdmVycmlkZTtcblxuIikgaWYgJGludGVyZmFjZU9yQ2Fs bGJhY2stPmV4dGVuZGVkQXR0cmlidXRlcy0+e0NhbGxiYWNrTmVlZHNPcGVyYXRvckVxdWFsfTsK LQogICAgICMgT3BlcmF0aW9ucwogICAgIG15ICRudW1PcGVyYXRpb25zID0gQHskb3BlcmF0aW9u c307CiAgICAgaWYgKCRudW1PcGVyYXRpb25zID4gMCkgewpAQCAtNjIyOSwxMSArNjIyNCw3IEBA IHN1YiBHZW5lcmF0ZUNhbGxiYWNrSW1wbGVtZW50YXRpb25Db250ZW4KIAogICAgICMgQ29uc3Ry dWN0b3IKICAgICBwdXNoKEAkY29udGVudFJlZiwgIiR7Y2xhc3NOYW1lfTo6JHtjbGFzc05hbWV9 KEpTT2JqZWN0KiBjYWxsYmFjaywgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdClcbiIp OwotICAgIGlmICgkaW50ZXJmYWNlT3JDYWxsYmFjay0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57Q2Fs bGJhY2tOZWVkc09wZXJhdG9yRXF1YWx9KSB7Ci0gICAgICAgIHB1c2goQCRjb250ZW50UmVmLCAi ICAgIDogJHtuYW1lfShnbG9iYWxPYmplY3QtPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSwgJHtj bGFzc05hbWV9VHlwZSlcbiIpOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIHB1c2goQCRjb250ZW50 UmVmLCAiICAgIDogJHtuYW1lfShnbG9iYWxPYmplY3QtPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQo KSlcbiIpOwotICAgIH0KKyAgICBwdXNoKEAkY29udGVudFJlZiwgIiAgICA6ICR7bmFtZX0oZ2xv YmFsT2JqZWN0LT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpXG4iKTsKICAgICBwdXNoKEAkY29u dGVudFJlZiwgIiAgICAsIG1fZGF0YShuZXcgJHtjYWxsYmFja0RhdGFUeXBlfShjYWxsYmFjaywg Z2xvYmFsT2JqZWN0LCB0aGlzKSlcbiIpOwogICAgIHB1c2goQCRjb250ZW50UmVmLCAie1xuIik7 CiAgICAgcHVzaChAJGNvbnRlbnRSZWYsICJ9XG5cbiIpOwpAQCAtNjI1MywxNSArNjI0NCw2IEBA IHN1YiBHZW5lcmF0ZUNhbGxiYWNrSW1wbGVtZW50YXRpb25Db250ZW4KICAgICBwdXNoKEAkY29u dGVudFJlZiwgIiNlbmRpZlxuIik7CiAgICAgcHVzaChAJGNvbnRlbnRSZWYsICJ9XG5cbiIpOwog Ci0gICAgaWYgKCRpbnRlcmZhY2VPckNhbGxiYWNrLT5leHRlbmRlZEF0dHJpYnV0ZXMtPntDYWxs YmFja05lZWRzT3BlcmF0b3JFcXVhbH0pIHsKLSAgICAgICAgcHVzaChAJGNvbnRlbnRSZWYsICJi b29sICR7Y2xhc3NOYW1lfTo6b3BlcmF0b3I9PShjb25zdCAke25hbWV9JiBvdGhlcikgY29uc3Rc biIpOwotICAgICAgICBwdXNoKEAkY29udGVudFJlZiwgIntcbiIpOwotICAgICAgICBwdXNoKEAk Y29udGVudFJlZiwgIiAgICBpZiAob3RoZXIudHlwZSgpICE9IHR5cGUoKSlcbiIpOwotICAgICAg ICBwdXNoKEAkY29udGVudFJlZiwgIiAgICAgICAgcmV0dXJuIGZhbHNlO1xuIik7Ci0gICAgICAg IHB1c2goQCRjb250ZW50UmVmLCAiICAgIHJldHVybiBzdGF0aWNfY2FzdDxjb25zdCAke2NsYXNz TmFtZX0qPigmb3RoZXIpLT5tX2RhdGEtPmNhbGxiYWNrKCkgPT0gbV9kYXRhLT5jYWxsYmFjaygp O1xuIik7Ci0gICAgICAgIHB1c2goQCRjb250ZW50UmVmLCAifVxuXG4iKTsKLSAgICB9Ci0KICAg ICAjIENvbnN0YW50cy4KICAgICBteSAkbnVtQ29uc3RhbnRzID0gQHskY29uc3RhbnRzfTsKICAg ICBpZiAoJG51bUNvbnN0YW50cyA+IDApIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvSURMQXR0cmlidXRlcy5qc29uCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvSURMQXR0cmlidXRlcy5qc29uCShyZXZpc2lvbiAyNjM0MDcpCisr KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0lETEF0dHJpYnV0ZXMuanNvbgkod29y a2luZyBjb3B5KQpAQCAtMzUsOSArMzUsNiBAQAogICAgICAgICAgICAgImNvbnRleHRzQWxsb3dl ZCI6IFsiaW50ZXJmYWNlIiwgImF0dHJpYnV0ZSIsICJvcGVyYXRpb24iXSwKICAgICAgICAgICAg ICJ2YWx1ZXMiOiBbIioiXQogICAgICAgICB9LAotICAgICAgICAiQ2FsbGJhY2tOZWVkc09wZXJh dG9yRXF1YWwiOiB7Ci0gICAgICAgICAgICAiY29udGV4dHNBbGxvd2VkIjogWyJjYWxsYmFjay1m dW5jdGlvbiJdCi0gICAgICAgIH0sCiAgICAgICAgICJDYWxsYmFja1RoaXNPYmplY3QiOiB7CiAg ICAgICAgICAgICAiY29udGV4dHNBbGxvd2VkIjogWyJjYWxsYmFjay1mdW5jdGlvbiIsICJvcGVy YXRpb24iXQogICAgICAgICB9LAo=