213518 2020-06-23 08:03:05 -0700 [ews] Allow archiving 'jsc' product 2020-06-23 12:52:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino aakash_jain ap clopez ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1665384 0 dpino 2020-06-23 08:03:05 -0700 [ews] Allow archiving 'jsc-only' product 1665385 1 402559 dpino 2020-06-23 08:03:37 -0700 Created attachment 402559 Patch 1665386 2 dpino 2020-06-23 08:04:59 -0700 It seems at this moment archiving 'jsc-only' products is not possible. See: https://ews-build.webkit.org/#/builders/38/builds/10 This patch attempts to allow archiving 'jsc-only' products. 1665388 3 402559 aakash_jain 2020-06-23 08:20:44 -0700 Comment on attachment 402559 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402559&action=review > Tools/BuildSlaveSupport/built-product-archive:235 > + elif platform == 'gtk' or platform == 'wpe' or platform == 'jsc-only': You can also simplify it to: elif platform in ('gtk', 'jsc-only', 'wpe'): 1665413 4 aakash_jain 2020-06-23 09:06:38 -0700 Please add jsc-only to extractBuiltProduct as well. 1665415 5 aakash_jain 2020-06-23 09:09:00 -0700 Maybe we should add support for 'jsc' as well, in case we decide to split up jsc ews queue (in builder and tester) as well. 1665463 6 402574 dpino 2020-06-23 11:40:34 -0700 Created attachment 402574 Patch 1665475 7 402574 aakash_jain 2020-06-23 11:49:08 -0700 Comment on attachment 402574 Patch I am not sure if both 'jsc' and 'jsc-only' should follow same code-path (as wpe/gtk), but that doesn't need to block this patch. 1665507 8 ews-feeder 2020-06-23 12:51:58 -0700 Committed r263414: <https://trac.webkit.org/changeset/263414> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402574. 1665508 9 webkit-bug-importer 2020-06-23 12:52:18 -0700 <rdar://problem/64658577> 402559 2020-06-23 08:03:37 -0700 2020-06-23 11:40:30 -0700 Patch bug-213518-20200623150336.patch text/plain 2003 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzQwMDJmZWJmNjMwZWEzYzQ2NmYzMWU5NGM0MGI2ZDlk MzRkMTRhOS4uYmE3YjVkODBlOTMwOGE4ZTM0MTE4MTA1YzQzN2ZiYzBhMjhhOWI0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTA2LTIzICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW2V3c10gQWxsb3cgYXJjaGl2aW5nICdqc2Mtb25seScgcHJvZHVjdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzNTE4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmU6CisgICAgICAgIChhcmNoaXZlQnVpbHRQcm9kdWN0 KToKKwogMjAyMC0wNi0yMyAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFtld3NdIFJlbmFtZSAnSlNDVGVzdHNGYWN0b3J5JyB0byAnSlNDQnVpbGRBbmRU ZXN0c0ZhY3RvcnknCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1w cm9kdWN0LWFyY2hpdmUgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFy Y2hpdmUKaW5kZXggN2I4ZmUyZTZjYTczMWY0ZTliMTgyODA0OTZkNGI4OGE4ODUwNzIzYS4uNTk2 NjQyMjAzYmJlMjMyZjY5NjUyMDNjMjhmN2E3MWZiMjFhZTEwMiAxMDA2NDQKLS0tIGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZlCisrKyBiL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZQpAQCAtMTkzLDcgKzE5Myw3IEBAIGRl ZiBtaW5pZnlEaXJlY3RvcnkocGxhdGZvcm0sIGRpcmVjdG9yeSk6CiAKIAogZGVmIGFyY2hpdmVC dWlsdFByb2R1Y3QoY29uZmlndXJhdGlvbiwgcGxhdGZvcm0sIGZ1bGxQbGF0Zm9ybSwgbWluaWZ5 PUZhbHNlKToKLSAgICBhc3NlcnQgcGxhdGZvcm0gaW4gKCdtYWMnLCAnd2luJywgJ2d0aycsICdp b3MnLCAnd3BlJywgJ3dpbmNhaXJvJykKKyAgICBhc3NlcnQgcGxhdGZvcm0gaW4gKCdndGsnLCAn aW9zJywgJ2pzYy1vbmx5JywgJ21hYycsICd3aW4nLCAnd2luY2Fpcm8nLCAnd3BlJykKIAogICAg IGlmIHBsYXRmb3JtID09ICdpb3MnOgogICAgICAgICBjb21iaW5lZERpcmVjdG9yeSA9IG9zLnBh dGguam9pbihfdG9wTGV2ZWxCdWlsZERpcmVjdG9yeSwgJ2NvbWJpbmVkLW1hYy1hbmQtaW9zJykK QEAgLTIzMiw4ICsyMzIsOCBAQCBkZWYgYXJjaGl2ZUJ1aWx0UHJvZHVjdChjb25maWd1cmF0aW9u LCBwbGF0Zm9ybSwgZnVsbFBsYXRmb3JtLCBtaW5pZnk9RmFsc2UpOgogCiAgICAgICAgIHNodXRp bC5ybXRyZWUodGhpbkRpcmVjdG9yeSkKIAotICAgIGVsaWYgcGxhdGZvcm0gPT0gJ2d0aycgb3Ig cGxhdGZvcm0gPT0gJ3dwZSc6Ci0gICAgICAgICMgT24gR1RLKy9XUEUgd2UgZG9uJ3QgbmVlZCB0 aGUgaW50ZXJtZWRpYXRlIHN0ZXAgb2YgY3JlYXRpbmcgYSB0aGluRGlyZWN0b3J5CisgICAgZWxp ZiBwbGF0Zm9ybSA9PSAnZ3RrJyBvciBwbGF0Zm9ybSA9PSAnd3BlJyBvciBwbGF0Zm9ybSA9PSAn anNjLW9ubHknOgorICAgICAgICAjIE9uIEdUSysvV1BFL0pTQ09ubHkgd2UgZG9uJ3QgbmVlZCB0 aGUgaW50ZXJtZWRpYXRlIHN0ZXAgb2YgY3JlYXRpbmcgYSB0aGluRGlyZWN0b3J5CiAgICAgICAg ICMgdG8gYmUgY29tcHJlc3NlZCBpbiBhIFpJUCBmaWxlLCBiZWNhdXNlIHdlIGNhbiBjcmVhdGUg dGhlIFpJUCBkaXJlY3RseS4KICAgICAgICAgIyBUaGlzIGlzIGZhc3RlciBhbmQgcmVxdWlyZXMg bGVzcyBkaXNrIHJlc291cmNlcy4KICAgICAgICAgbmVlZGVkRGlyZWN0b3JpZXMgPSBbJ2Jpbics ICdsaWInXQo= 402574 2020-06-23 11:40:34 -0700 2020-06-23 12:51:59 -0700 Patch bug-213518-20200623184033.patch text/plain 2773 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzQwMDJmZWJmNjMwZWEzYzQ2NmYzMWU5NGM0MGI2ZDlk MzRkMTRhOS4uZmZkOTYxMTI0ZDRiNjVkYWRlMzY5ZGQwNTkwNjJiY2ZkMzE1OTk1NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTA2LTIzICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW2V3c10gQWxsb3cgYXJjaGl2aW5nICdqc2MnIHByb2R1Y3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzUxOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbHQtcHJvZHVjdC1hcmNoaXZlOgorICAgICAgICAoYXJjaGl2ZUJ1aWx0UHJvZHVjdCk6CisK IDIwMjAtMDYtMjMgIERpZWdvIFBpbm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KIAogICAg ICAgICBbZXdzXSBSZW5hbWUgJ0pTQ1Rlc3RzRmFjdG9yeScgdG8gJ0pTQ0J1aWxkQW5kVGVzdHNG YWN0b3J5JwpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVj dC1hcmNoaXZlIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbHQtcHJvZHVjdC1hcmNoaXZl CmluZGV4IDdiOGZlMmU2Y2E3MzFmNGU5YjE4MjgwNDk2ZDRiODhhODg1MDcyM2EuLjBhYTM2NjQ0 NTRlOTJhOTJlZjdmYjEwNTc1NDIxYjBhMTQ4ZjcxOTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZQorKysgYi9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUKQEAgLTE5Myw3ICsxOTMsNyBAQCBkZWYgbWlu aWZ5RGlyZWN0b3J5KHBsYXRmb3JtLCBkaXJlY3RvcnkpOgogCiAKIGRlZiBhcmNoaXZlQnVpbHRQ cm9kdWN0KGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtLCBmdWxsUGxhdGZvcm0sIG1pbmlmeT1GYWxz ZSk6Ci0gICAgYXNzZXJ0IHBsYXRmb3JtIGluICgnbWFjJywgJ3dpbicsICdndGsnLCAnaW9zJywg J3dwZScsICd3aW5jYWlybycpCisgICAgYXNzZXJ0IHBsYXRmb3JtIGluICgnZ3RrJywgJ2lvcycs ICdqc2MnLCAnbWFjJywgJ3dpbicsICd3aW5jYWlybycsICd3cGUnKQogCiAgICAgaWYgcGxhdGZv cm0gPT0gJ2lvcyc6CiAgICAgICAgIGNvbWJpbmVkRGlyZWN0b3J5ID0gb3MucGF0aC5qb2luKF90 b3BMZXZlbEJ1aWxkRGlyZWN0b3J5LCAnY29tYmluZWQtbWFjLWFuZC1pb3MnKQpAQCAtMjMyLDgg KzIzMiw4IEBAIGRlZiBhcmNoaXZlQnVpbHRQcm9kdWN0KGNvbmZpZ3VyYXRpb24sIHBsYXRmb3Jt LCBmdWxsUGxhdGZvcm0sIG1pbmlmeT1GYWxzZSk6CiAKICAgICAgICAgc2h1dGlsLnJtdHJlZSh0 aGluRGlyZWN0b3J5KQogCi0gICAgZWxpZiBwbGF0Zm9ybSA9PSAnZ3RrJyBvciBwbGF0Zm9ybSA9 PSAnd3BlJzoKLSAgICAgICAgIyBPbiBHVEsrL1dQRSB3ZSBkb24ndCBuZWVkIHRoZSBpbnRlcm1l ZGlhdGUgc3RlcCBvZiBjcmVhdGluZyBhIHRoaW5EaXJlY3RvcnkKKyAgICBlbGlmIHBsYXRmb3Jt IGluICgnZ3RrJywgJ2pzYycsICd3cGUnKToKKyAgICAgICAgIyBPbiBHVEsrL1dQRS9KU0Mgd2Ug ZG9uJ3QgbmVlZCB0aGUgaW50ZXJtZWRpYXRlIHN0ZXAgb2YgY3JlYXRpbmcgYSB0aGluRGlyZWN0 b3J5CiAgICAgICAgICMgdG8gYmUgY29tcHJlc3NlZCBpbiBhIFpJUCBmaWxlLCBiZWNhdXNlIHdl IGNhbiBjcmVhdGUgdGhlIFpJUCBkaXJlY3RseS4KICAgICAgICAgIyBUaGlzIGlzIGZhc3RlciBh bmQgcmVxdWlyZXMgbGVzcyBkaXNrIHJlc291cmNlcy4KICAgICAgICAgbmVlZGVkRGlyZWN0b3Jp ZXMgPSBbJ2JpbicsICdsaWInXQpAQCAtMjY2LDcgKzI2Niw3IEBAIGRlZiB1bnppcEFyY2hpdmUo ZGlyZWN0b3J5VG9FeHRyYWN0VG8sIGNvbmZpZ3VyYXRpb24pOgogCiAKIGRlZiBleHRyYWN0QnVp bHRQcm9kdWN0KGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtKToKLSAgICBhc3NlcnQgcGxhdGZvcm0g aW4gKCdtYWMnLCAnd2luJywgJ2d0aycsICdpb3MnLCAnd3BlJywgJ3dpbmNhaXJvJykKKyAgICBh c3NlcnQgcGxhdGZvcm0gaW4gKCdndGsnLCAnaW9zJywgJ2pzYycsICdtYWMnLCAnd2luJywgJ3dp bmNhaXJvJywgJ3dwZScpCiAKICAgICBhcmNoaXZlRmlsZSA9IG9zLnBhdGguam9pbihfdG9wTGV2 ZWxCdWlsZERpcmVjdG9yeSwgY29uZmlndXJhdGlvbiArICcuemlwJykKIApAQCAtMjc1LDcgKzI3 NSw3IEBAIGRlZiBleHRyYWN0QnVpbHRQcm9kdWN0KGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtKToK IAogICAgIGlmIHBsYXRmb3JtIGluICgnbWFjJywgJ2lvcycpOgogICAgICAgICByZXR1cm4gdW56 aXBBcmNoaXZlKF90b3BMZXZlbEJ1aWxkRGlyZWN0b3J5LCBjb25maWd1cmF0aW9uKQotICAgIGVs aWYgcGxhdGZvcm0gaW4gKCd3aW4nLCAnZ3RrJywgJ3dwZScsICd3aW5jYWlybycpOgorICAgIGVs aWYgcGxhdGZvcm0gaW4gKCdndGsnLCAnanNjJywgJ3dpbicsICd3aW5jYWlybycsICd3cGUnKToK ICAgICAgICAgcHJpbnQgJ0V4dHJhY3RpbmcnLCBfY29uZmlndXJhdGlvbkJ1aWxkRGlyZWN0b3J5 CiAgICAgICAgIGlmIHVuemlwQXJjaGl2ZShfY29uZmlndXJhdGlvbkJ1aWxkRGlyZWN0b3J5LCBj b25maWd1cmF0aW9uKToKICAgICAgICAgICAgIHJldHVybiAxCg==