213517 2020-06-23 07:37:02 -0700 [ macOS ] fullscreen/video-inside-flex-item.html is a flaky failure 2020-06-25 03:18:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Mac macOS 10.15 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=213110 InRadar P2 Normal --- 213549 1 rackler svillar eric.carlson ews-watchlist glenn jer.noble peng.liu6 philipj rackler sergio simon.fraser svillar tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1665378 0 rackler 2020-06-23 07:37:02 -0700 fullscreen/video-inside-flex-item.html Description: This test is flaky failing on macOS. It does seem to be passing on wk2 release. It has been flaky failing since introduced. Introduced here: https://trac.webkit.org/changeset/263389/webkit History: https://results.webkit.org/?suite=layout-tests&test=fullscreen%2Fvideo-inside-flex-item.html&platform=ios&platform=mac Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/fullscreen/video-inside-flex-item-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/fullscreen/video-inside-flex-item-actual.txt @@ -2,7 +2,7 @@ EVENT(webkitfullscreenchange) EXPECTED (800 == '800') OK EVENT(webkitfullscreenchange) -EXPECTED (300 == '300') OK -EXPECTED (150 == '150') OK +EXPECTED (320 == '300'), OBSERVED '320' FAIL +EXPECTED (240 == '150'), OBSERVED '240' FAIL END OF TEST 1665380 1 webkit-bug-importer 2020-06-23 07:38:48 -0700 <rdar://problem/64643289> 1665401 2 402564 rackler 2020-06-23 08:46:19 -0700 Created attachment 402564 Patch 1665406 3 svillar 2020-06-23 08:49:59 -0700 I think in this case you should create specific expectations for the macos/ios failing configurations. 1665412 4 tsavell 2020-06-23 08:56:53 -0700 (In reply to Sergio Villar Senin from comment #3) > I think in this case you should create specific expectations for the > macos/ios failing configurations. In this case the test would be marked to pass on Mac WK2 Release only. This doesn't seem like an effective test right now if it only functions for one specific configuration. 1665421 5 simon.fraser 2020-06-23 09:21:59 -0700 Full results: https://results.webkit.org/?suite=layout-tests&test=fullscreen%2Fvideo-inside-flex-item.html So the test flakes on macOS WK1 Release, always fails on WK1 Debug, always passes on W2 Release, always fails on WK2 Debug. Sergio, there's a timing issue with this test, please investigate. 1665425 6 svillar 2020-06-23 09:38:12 -0700 (In reply to Simon Fraser (smfr) from comment #5) > Full results: > > https://results.webkit.org/?suite=layout-tests&test=fullscreen%2Fvideo- > inside-flex-item.html > > So the test flakes on macOS WK1 Release, always fails on WK1 Debug, always > passes on W2 Release, always fails on WK2 Debug. > > Sergio, there's a timing issue with this test, please investigate. Sure, I'll take a look. 1665492 7 402581 svillar 2020-06-23 12:19:44 -0700 Created attachment 402581 Patch 1665625 8 ews-feeder 2020-06-23 19:20:54 -0700 Committed r263436: <https://trac.webkit.org/changeset/263436> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402581. 1665641 9 ryanhaddad 2020-06-23 21:06:12 -0700 The test is still failing: --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/fullscreen/video-inside-flex-item-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/fullscreen/video-inside-flex-item-actual.txt @@ -2,7 +2,7 @@ EVENT(webkitfullscreenchange) TEST(video.clientWidth == document.body.clientWidth) OK EVENT(webkitfullscreenchange) -TEST(video.clientWidth == oldVideoWidth) OK -TEST(video.clientHeight == oldVideoHeight) OK +TEST(video.clientWidth == oldVideoWidth) FAIL +TEST(video.clientHeight == oldVideoHeight) FAIL END OF TEST 1665642 10 ryanhaddad 2020-06-23 21:11:29 -0700 Reopening since this isn't fixed. 1665676 11 svillar 2020-06-24 02:15:19 -0700 (In reply to Ryan Haddad from comment #10) > Reopening since this isn't fixed. It's indeed failing on Debug, I'll come up with something soon. 1665692 12 svillar 2020-06-24 03:50:49 -0700 (In reply to Ryan Haddad from comment #10) > Reopening since this isn't fixed. I've submitted a patch to bug 213549 to fix this issue. It's working fine in Mac debug for me locally. 1666012 13 svillar 2020-06-25 03:18:16 -0700 Fixed in bug 213549 402564 2020-06-23 08:46:19 -0700 2020-06-23 09:27:29 -0700 Patch bug-213517-20200623104614.patch text/plain 1321 rackler U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzk2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzYwMTFhOTliMTNlYWNkNzdkNGI3 NGYxZWZkYTUzZDA1ZGFmYmU3NS4uZGIwNGJjN2ExNTMyZmE1ZDZjMzJjOWViNGQzMzZlNmJkNjUw OTU3MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTA2LTIzICBLYXJsIFJhY2tsZXIgIDxy YWNrbGVyQGFwcGxlLmNvbT4KKworICAgICAgICBbIG1hY09TIF0gZnVsbHNjcmVlbi92aWRlby1p bnNpZGUtZmxleC1pdGVtLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM1MTcKKworICAgICAgICBVbnJldmll d2VkIHRlc3QgZ2FyZGVuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3Rh dGlvbnM6CisKIDIwMjAtMDYtMjMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgWyBDYXRhbGluYSBEZWJ1ZyBXSzIgXSBmYXN0L2V2ZW50cy9wbGF0Zm9y bS13aGVlbGV2ZW50LWluLXNjcm9sbGluZy1kaXYuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMmQ4NDkwMTAwODI2 MzAyOTY5NGRkMDMxYWQ0ZTdhNDE0ZmE3Y2NkYS4uM2RiNzEzMzY5ODExODM2ODhlYjgyY2M1MmM3 OTU2M2Y2NjU0NWYyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RF eHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnMKQEAgLTE5NDMsMyArMTk0Myw1IEBAIHdlYmtpdC5vcmcvYi8yMTI0ODggWyBDYXRhbGluYSBd IG1lZGlhL3ZpZGVvLXBsYXktYXVkaW8tcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtCiB3ZWJraXQu b3JnL2IvMjEyNTY1IFsgQ2F0YWxpbmEgTW9qYXZlIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9lbmNvZGluZy9zaW5nbGUtYnl0ZS1kZWNvZGVyLmh0bWwgWyBGYWlsdXJlIF0KIAog ZmFzdC90ZXh0L3RleHQtc3R5bGVzLy1hcHBsZS1zeXN0ZW0gWyBQYXNzIF0KKword2Via2l0Lm9y Zy9iLzIxMzUxNyBmdWxsc2NyZWVuL3ZpZGVvLWluc2lkZS1mbGV4LWl0ZW0uaHRtbCBbIFBhc3Mg RmFpbHVyZSBdCg== 402581 2020-06-23 12:19:44 -0700 2020-06-23 19:20:54 -0700 Patch bug-213517-20200623211942.patch text/plain 2982 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNDAzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2I1ZGFlYTJlZWQ1MWU5MWY4MWNm MWU4NjU5MjM1OWIyMmVjOWI4ZS4uYTU5OWI2MWUwN2ZkOTc0ZGE1ODczYzU2N2Q1ZDQxYTBiYjNk YTdkMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA2LTIzICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFsgbWFjT1MgXSBmdWxsc2NyZWVu L3ZpZGVvLWluc2lkZS1mbGV4LWl0ZW0uaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzUxNworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFZpZGVvIGlzIHJlbmRlcmVk IGRpZmZlcmVudGx5IGRlcGVuZGluZyBvbiB0aGUgY29uZmlndXJhdGlvbi9wbGF0Zm9ybS4gSW5z dGVhZCBvZiBjaGVja2luZyB0aGUgYWN0dWFsCisgICAgICAgIHNpemUgaW4gcGl4ZWxzIGl0J3Mg YmV0dGVyIHRvIHZlcmlmeSB0aGF0IHRoZSBzaXplIGFmdGVyIGNhbmNlbGxpbmcgZnVsbHNjcmVl biBpcyB0aGUgc2FtZSBhcyBiZWZvcmUKKyAgICAgICAgZ29pbmcgdG8gZnVsbHNjcmVlbi4KKwor ICAgICAgICAqIGZ1bGxzY3JlZW4vdmlkZW8taW5zaWRlLWZsZXgtaXRlbS1leHBlY3RlZC50eHQ6 CisgICAgICAgICogZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVtLmh0bWw6CisKIDIw MjAtMDYtMjMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIEtl eWZyYW1lIGFuaW1hdGlvbiBkb2Vzbid0ICd0IHNob3cgdXAgaW4gdGhlIEFuaW1hdGlvbnMgdGlt ZWxpbmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8taW5zaWRlLWZs ZXgtaXRlbS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWluc2lk ZS1mbGV4LWl0ZW0tZXhwZWN0ZWQudHh0CmluZGV4IDMzYTViODQ5YTNmZTMyODE4YWQ1NjI5MWMy NmJlNWRmYzZkMWEyZWEuLjkzNzllZDNkMWEzMGY5NjBlMjRhODc4NDZiZDA4OTE5NjU1NmI2YzEg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8taW5zaWRlLWZsZXgtaXRl bS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1pbnNpZGUt ZmxleC1pdGVtLWV4cGVjdGVkLnR4dApAQCAtMSw4ICsxLDggQEAKIAogRVZFTlQod2Via2l0ZnVs bHNjcmVlbmNoYW5nZSkKLUVYUEVDVEVEICg4MDAgPT0gJzgwMCcpIE9LCitURVNUKHZpZGVvLmNs aWVudFdpZHRoID09IGRvY3VtZW50LmJvZHkuY2xpZW50V2lkdGgpIE9LCiBFVkVOVCh3ZWJraXRm dWxsc2NyZWVuY2hhbmdlKQotRVhQRUNURUQgKDMwMCA9PSAnMzAwJykgT0sKLUVYUEVDVEVEICgx NTAgPT0gJzE1MCcpIE9LCitURVNUKHZpZGVvLmNsaWVudFdpZHRoID09IG9sZFZpZGVvV2lkdGgp IE9LCitURVNUKHZpZGVvLmNsaWVudEhlaWdodCA9PSBvbGRWaWRlb0hlaWdodCkgT0sKIEVORCBP RiBURVNUCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8taW5zaWRl LWZsZXgtaXRlbS5odG1sIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxl eC1pdGVtLmh0bWwKaW5kZXggZDkxMTRiMTE1NmJmYzdkMjkyZGNjZjAyNWFhOTliYjM4M2JjYTU1 MC4uOTQwMTU0MGE3YjM1ZDk5Mjc4N2JmYzU1M2MzZDU0ODA2Y2Y4OWYzYiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVtLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVtLmh0bWwKQEAgLTI1 LDEzICsyNSwxNSBAQCBpZiAoRWxlbWVudC5wcm90b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxTY3Jl ZW4gPT0gdW5kZWZpbmVkKSB7CiAgICAgbG9nUmVzdWx0KGZhbHNlLCAiRWxlbWVudC5wcm90b3R5 cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5kZWZpbmVkIik7CiAgICAgZW5kVGVzdCgp OwogfSBlbHNlIHsKKyAgICB2YXIgb2xkVmlkZW9XaWR0aCA9IHZpZGVvLmNsaWVudFdpZHRoOwor ICAgIHZhciBvbGRWaWRlb0hlaWdodCA9IHZpZGVvLmNsaWVudEhlaWdodDsKICAgICB3YWl0Rm9y RXZlbnRPbmNlKGRvY3VtZW50LCAnd2Via2l0ZnVsbHNjcmVlbmNoYW5nZScsIGZ1bmN0aW9uKCkg ewogICAgICAgICAvLyBGaXJzdCBjaGVjayB0aGF0IHRoZSB2aWRlbyB3ZW50IGZ1bGxzY3JlZW4u Ci0gICAgICAgIHRlc3RFeHBlY3RlZCh2aWRlby5jbGllbnRXaWR0aCwgZG9jdW1lbnQuYm9keS5j bGllbnRXaWR0aCk7CisgICAgICAgIHRlc3QoInZpZGVvLmNsaWVudFdpZHRoID09IGRvY3VtZW50 LmJvZHkuY2xpZW50V2lkdGgiKTsKICAgICAgICAgd2FpdEZvckV2ZW50T25jZShkb2N1bWVudCwg J3dlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UnLCBmdW5jdGlvbigpIHsKICAgICAgICAgICAgIC8vIFRo ZW4gY2hlY2sgdGhhdCB0aGUgb3JpZ2luYWwgdmlkZW8gc2l6ZSBpcyBwcm9wZXJseSByZXN0b3Jl ZC4KLSAgICAgICAgICAgIHRlc3RFeHBlY3RlZCh2aWRlby5jbGllbnRXaWR0aCwgMzAwKTsKLSAg ICAgICAgICAgIHRlc3RFeHBlY3RlZCh2aWRlby5jbGllbnRIZWlnaHQsIDE1MCk7CisgICAgICAg ICAgICB0ZXN0KCJ2aWRlby5jbGllbnRXaWR0aCA9PSBvbGRWaWRlb1dpZHRoIik7CisgICAgICAg ICAgICB0ZXN0KCJ2aWRlby5jbGllbnRIZWlnaHQgPT0gb2xkVmlkZW9IZWlnaHQiKTsKICAgICAg ICAgICAgIGVuZFRlc3QoKTsKICAgICAgICAgfSk7CiAgICAgICAgIGRvY3VtZW50LndlYmtpdENh bmNlbEZ1bGxTY3JlZW4oKTsK