213500 2020-06-22 20:20:29 -0700 [WebDriver][WPE] Allow running Selenium tests with the WPE WebDriver 2020-07-04 09:04:55 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 213916 1 lmoura lmoura bugs-noreply cgarcia ews-watchlist glenn jbedard oldest_to_newest 1665273 0 lmoura 2020-06-22 20:20:29 -0700 The WPE WebDriver is available in the imported selenium from bug213263, but test infra needs to actually make them runnable with WPE. 1665276 1 402530 lmoura 2020-06-22 20:33:21 -0700 Created attachment 402530 Patch 1665298 2 402530 cgarcia 2020-06-22 22:43:49 -0700 Comment on attachment 402530 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402530&action=review > WebDriverTests/imported/selenium/py/conftest.py:48 > + 'WPEWebKit', I guess I forgot this on the selenium patch. Changes to this file should be done upstream, and then reimport. > WebDriverTests/imported/selenium/py/conftest.py:125 > + if driver_class == 'WPEWebKit': This is not correctly indented, no? 1668473 3 lmoura 2020-07-02 20:48:26 -0700 (In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 402530 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402530&action=review > > > WebDriverTests/imported/selenium/py/conftest.py:48 > > + 'WPEWebKit', > > I guess I forgot this on the selenium patch. Changes to this file should be > done upstream, and then reimport. Right. I've added a patch to bug213916 with the upstream version with this fix already merged. > > > WebDriverTests/imported/selenium/py/conftest.py:125 > > + if driver_class == 'WPEWebKit': > > This is not correctly indented, no? Indeed. Strange that the local version is correct. I'll update the patch. 1668602 4 403469 lmoura 2020-07-03 11:12:25 -0700 Created attachment 403469 Patch 1668794 5 ews-feeder 2020-07-04 09:04:54 -0700 Committed r263933: <https://trac.webkit.org/changeset/263933> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403469. 402530 2020-06-22 20:33:21 -0700 2020-07-02 20:48:38 -0700 Patch bug-213500-20200623003319.patch text/plain 3313 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQxMGQ5OTI0OTFiZGJkOWQ4YWExYjNlODdiODQ1MDAz MjRjOTk0MC4uNGYzZWI4Y2IyOTg4MTA3MWU3NTcxMjEwZWE5ZTgyNTdiZDFjNDM0NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTA2LTIyICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtXZWJEcml2ZXJdW1dQRV0gQWxsb3cgcnVubmluZyBTZWxlbml1bSB0ZXN0cyB3aXRoIHRo ZSBXUEUgV2ViRHJpdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTM1MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgbWlzc2luZyBtZXRob2QgdXNlZCB0byBkaXNjb3ZlciB0aGUgc2VsZW5pdW0g bmFtZSBvZgorICAgICAgICB0aGUgV1BFIHdlYmRyaXZlci4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvd2ViZHJpdmVyX3Rlc3RzL3dlYmRyaXZlcl9kcml2ZXJfd3BlLnB5OgorICAgICAg ICAoV2ViRHJpdmVyV1BFLnNlbGVuaXVtX25hbWUpOgorCiAyMDIwLTA2LTIxICBQaGlsaXBwZSBO b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbRmxhdHBha10gTmlnaHRs eSBydW5uZXIgZmFpbHMgdG8gZXh0cmFjdCB6aXAgZmlsZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvd2ViZHJpdmVyX3Rlc3RzL3dlYmRyaXZlcl9kcml2ZXJfd3BlLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX2RyaXZlcl93 cGUucHkKaW5kZXggM2NlNDhiMGI3YTVlYWZjZDUyMmQ5NmNjYjhlM2EzNWNmMDEwM2FiMy4uMThm NWNjM2UyNmNjY2E1OTMxOTdjNWI2ZDg2NThkNzNlOWU5YThiZCAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX2RyaXZlcl93cGUucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX2Ry aXZlcl93cGUucHkKQEAgLTIwLDcgKzIwLDYgQEAKICMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9S IE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMKICMg U09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuCiAKLWltcG9ydCBvcwogZnJvbSB3ZWJraXRweS53ZWJkcml2ZXJfdGVzdHMud2ViZHJpdmVy X2RyaXZlciBpbXBvcnQgV2ViRHJpdmVyLCByZWdpc3Rlcl9kcml2ZXIKIAogCkBAIC00OSw1ICs0 OCw4IEBAIGNsYXNzIFdlYkRyaXZlcldQRShXZWJEcml2ZXIpOgogICAgICAgICAgICAgJ2JpbmFy eSc6IHNlbGYuYnJvd3Nlcl9wYXRoKCksCiAgICAgICAgICAgICAnYXJncyc6IHNlbGYuYnJvd3Nl cl9hcmdzKCl9fQogCisgICAgZGVmIHNlbGVuaXVtX25hbWUoc2VsZik6CisgICAgICAgIHJldHVy biAnV1BFV2ViS2l0JworCiAKIHJlZ2lzdGVyX2RyaXZlcignd3BlJywgV2ViRHJpdmVyV1BFKQpk aWZmIC0tZ2l0IGEvV2ViRHJpdmVyVGVzdHMvQ2hhbmdlTG9nIGIvV2ViRHJpdmVyVGVzdHMvQ2hh bmdlTG9nCmluZGV4IDdkNDQxOWY0Y2IyZGVhNzg3ODk4ZGFmNTFhZDFjM2E0NWM2NmExZTcuLmFj MjI5MDUwYzIyZTg1ZDQ3M2M1ZTVkYjM5MjQyZTgzMDI4NGZhODMgMTAwNjQ0Ci0tLSBhL1dlYkRy aXZlclRlc3RzL0NoYW5nZUxvZworKysgYi9XZWJEcml2ZXJUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNi0yMiAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4K KworICAgICAgICBbV2ViRHJpdmVyXVtXUEVdIEFsbG93IHJ1bm5pbmcgU2VsZW5pdW0gdGVzdHMg d2l0aCB0aGUgV1BFIFdlYkRyaXZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEzNTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIFdQRSB0byB0aGUgbGlzdCBvZiBXZWJEcml2ZXJzIGFsbG93ZWQg dG8gcnVuIHRoZSB0ZXN0IHN1aXRlLiBUaGlzCisgICAgICAgIHNob3VsZCBhbHNvIGJlIHN1Ym1p dHRlZCB1cHN0cmVhbSBsYXRlci4KKworICAgICAgICAqIGltcG9ydGVkL3NlbGVuaXVtL3B5L2Nv bmZ0ZXN0LnB5OgorICAgICAgICAoZHJpdmVyKToKKwogMjAyMC0wNi0yMSAgTGF1cm8gTW91cmEg IDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV2ViRHJpdmVyXVtHVEtdIFNvbWUgZXhl Y3V0aW5nX2FzeW5jX2phdmFzY3JpcHRfdGVzdHMucHkgdGVzdHMgYXJlIGZhaWxpbmcgd2l0aCBU aW1lb3V0RXhjZXB0aW9ucwpkaWZmIC0tZ2l0IGEvV2ViRHJpdmVyVGVzdHMvaW1wb3J0ZWQvc2Vs ZW5pdW0vcHkvY29uZnRlc3QucHkgYi9XZWJEcml2ZXJUZXN0cy9pbXBvcnRlZC9zZWxlbml1bS9w eS9jb25mdGVzdC5weQppbmRleCA1MDkwMzEwNGQwOTdkZWVlODBhYzA1MTk0OGM1Mzc4NzMzMmZk MDk5Li5jNTk2MjYyMTEzNTU4NGVkNDllMmQwZWZlOWE5NzEzYTliMTBjYTU3IDEwMDY0NAotLS0g YS9XZWJEcml2ZXJUZXN0cy9pbXBvcnRlZC9zZWxlbml1bS9weS9jb25mdGVzdC5weQorKysgYi9X ZWJEcml2ZXJUZXN0cy9pbXBvcnRlZC9zZWxlbml1bS9weS9jb25mdGVzdC5weQpAQCAtNDUsNiAr NDUsNyBAQCBkcml2ZXJzID0gKAogICAgICdTYWZhcmknLAogICAgICdXZWJLaXRHVEsnLAogICAg ICdDaHJvbWl1bUVkZ2UnLAorICAgICdXUEVXZWJLaXQnLAogKQogCiAKQEAgLTEyMSw2ICsxMjIs OCBAQCBkZWYgZHJpdmVyKHJlcXVlc3QpOgogICAgICAgICBpZiBkcml2ZXJfY2xhc3MgPT0gJ0No cm9taXVtRWRnZSc6CiAgICAgICAgICAgICBvcHRpb25zID0gZ2V0X29wdGlvbnMoZHJpdmVyX2Ns YXNzLCByZXF1ZXN0LmNvbmZpZykKICAgICAgICAgICAgIGt3YXJncy51cGRhdGUoeydpc19sZWdh Y3knOiBGYWxzZX0pCisJaWYgZHJpdmVyX2NsYXNzID09ICdXUEVXZWJLaXQnOgorICAgICAgICAg ICAgb3B0aW9ucyA9IGdldF9vcHRpb25zKGRyaXZlcl9jbGFzcywgcmVxdWVzdC5jb25maWcpCiAg ICAgICAgIGlmIGRyaXZlcl9wYXRoIGlzIG5vdCBOb25lOgogICAgICAgICAgICAga3dhcmdzWydl eGVjdXRhYmxlX3BhdGgnXSA9IGRyaXZlcl9wYXRoCiAgICAgICAgIGlmIG9wdGlvbnMgaXMgbm90 IE5vbmU6Cg== 403469 2020-07-03 11:12:25 -0700 2020-07-04 09:04:55 -0700 Patch bug-213500-20200703151223.patch text/plain 1751 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzODk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDhhNThhYmI3YmU1YmMyY2U2MTcyNWQ2NGZhYmI4MmU0 OGYyMTI3OC4uZjJmNjZiYzVhMDNhYzlmMGI1NDhmNGUwNTY4MGVhZTAyNzk1OWYzMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIwLTA3LTAzICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtXZWJEcml2ZXJdW1dQRV0gQWxsb3cgcnVubmluZyBTZWxlbml1bSB0ZXN0cyB3aXRoIHRo ZSBXUEUgV2ViRHJpdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTM1MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgbWlzc2luZyBtZXRob2QgdXNlZCB0byBkaXNjb3ZlciB0aGUgc2VsZW5pdW0g bmFtZSBvZgorICAgICAgICB0aGUgV1BFIHdlYmRyaXZlci4KKworICAgICAgICBQcm9wZXIgZ2Fy ZGVuaW5nL3RyaWFnaW5nIG9mIGZhaWx1cmVzIHdpbGwgY29tZSBpbiBmb2xsb3dpbmcgY29tbWl0 cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvd2ViZHJpdmVyX3Rlc3RzL3dlYmRyaXZl cl9kcml2ZXJfd3BlLnB5OgorICAgICAgICAoV2ViRHJpdmVyV1BFLnNlbGVuaXVtX25hbWUpOgor CiAyMDIwLTA3LTAzICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtXUEVdW3dlYmtpdHB5XSBVc2UgaGVhZGxlc3MgZHJpdmVyIGluc3Rl YWQgb2Ygd2F5bGFuZCBkcml2ZXIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv d2ViZHJpdmVyX3Rlc3RzL3dlYmRyaXZlcl9kcml2ZXJfd3BlLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX2RyaXZlcl93cGUucHkKaW5kZXggM2Nl NDhiMGI3YTVlYWZjZDUyMmQ5NmNjYjhlM2EzNWNmMDEwM2FiMy4uMThmNWNjM2UyNmNjY2E1OTMx OTdjNWI2ZDg2NThkNzNlOWU5YThiZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX2RyaXZlcl93cGUucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS93ZWJkcml2ZXJfdGVzdHMvd2ViZHJpdmVyX2RyaXZlcl93cGUucHkKQEAg LTIwLDcgKzIwLDYgQEAKICMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJ U0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMKICMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKLWltcG9ydCBv cwogZnJvbSB3ZWJraXRweS53ZWJkcml2ZXJfdGVzdHMud2ViZHJpdmVyX2RyaXZlciBpbXBvcnQg V2ViRHJpdmVyLCByZWdpc3Rlcl9kcml2ZXIKIAogCkBAIC00OSw1ICs0OCw4IEBAIGNsYXNzIFdl YkRyaXZlcldQRShXZWJEcml2ZXIpOgogICAgICAgICAgICAgJ2JpbmFyeSc6IHNlbGYuYnJvd3Nl cl9wYXRoKCksCiAgICAgICAgICAgICAnYXJncyc6IHNlbGYuYnJvd3Nlcl9hcmdzKCl9fQogCisg ICAgZGVmIHNlbGVuaXVtX25hbWUoc2VsZik6CisgICAgICAgIHJldHVybiAnV1BFV2ViS2l0Jwor CiAKIHJlZ2lzdGVyX2RyaXZlcignd3BlJywgV2ViRHJpdmVyV1BFKQo=