213492 2020-06-22 15:56:21 -0700 Web Inspector: Elements: Node: use a `WI.ContextMenu` instead of a `<select>` for listener filtering 2020-06-22 17:34:55 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi hi inspector-bugzilla-changes nvasilyev timothy webkit-bug-importer oldest_to_newest 1665205 0 hi 2020-06-22 15:56:21 -0700 Using a `<select>` means that the context menu will appear in the same place no matter where the icon is clicked, but that is not needed, so just use a `WI.ContextMenu` instead (it's also simpler). 1665208 1 402518 hi 2020-06-22 15:57:42 -0700 Created attachment 402518 Patch 1665226 2 ews-feeder 2020-06-22 16:43:51 -0700 Committed r263376: <https://trac.webkit.org/changeset/263376> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402518. 1665227 3 webkit-bug-importer 2020-06-22 16:44:16 -0700 <rdar://problem/64614336> 1665241 4 nvasilyev 2020-06-22 17:34:55 -0700 From the accessibility point, I think we should go the exact opposite way - use <select> elements instead of WI.ContextMenu on <div> elements whenever possible. In VoiceOver, when simulating a click by pressing Cmd-Shift-Ctrl-Option-Space, the context menu is shown as expected, but it isn't immediately focused. Also, with this patch, the filter icon is no longer tab-focusable. 402518 2020-06-22 15:57:42 -0700 2020-06-22 16:43:52 -0700 Patch bug-213492-20200622155741.patch text/plain 6692 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNhYzZjYjNlY2M0MmQyNWM1YzFmODBmMjUzOTk4 MDQxZjY4ODA0MzYuLjQ5MGVjNmRlYjRkNjI2OGJkMDRkODQ1ODljNjQzMGY0MGJkMmY5MWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA2LTIyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBF bGVtZW50czogTm9kZTogdXNlIGEgYFdJLkNvbnRleHRNZW51YCBpbnN0ZWFkIG9mIGEgYDxzZWxl Y3Q+YCBmb3IgbGlzdGVuZXIgZmlsdGVyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM0OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNT aWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXSS5ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5w cm90b3R5cGUuaW5pdGlhbExheW91dCk6CisgICAgICAgIChXSS5ET01Ob2RlRGV0YWlsc1NpZGVi YXJQYW5lbC5wcm90b3R5cGUuX3BvcHVsYXRlRXZlbnRMaXN0ZW5lcnNGaWx0ZXJDb250ZXh0TWVu dSk6IEFkZGVkLgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNT aWRlYmFyUGFuZWwuY3NzOgorICAgICAgICAoLnNpZGViYXIgPiAucGFuZWwuZG9tLW5vZGUtZGV0 YWlscyAuZGV0YWlscy1zZWN0aW9uLmRvbS1ub2RlLWV2ZW50LWxpc3RlbmVycyA+IC5oZWFkZXIg PiAuZmlsdGVyID4gc2VsZWN0KTogRGVsZXRlZC4KKworICAgICAgICAqIExvY2FsaXphdGlvbnMv ZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKwogMjAyMC0wNi0xOCAgRGV2aW4gUm91c3Nv ICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ29uc29sZTog YWRkIGNvbW1lbnRzIGZvciBsb2NhbGl6ZWQgc3RyaW5ncyBpbiBleGVjdXRpb24gY29udGV4dCBw aWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2Vu Lmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxp emF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDhmMDgyNTFiYTFlNjJm ZDQyMGY4Y2QwYzI2MzdhZTM3YzJiMDY3ZjUuLmI4OGRlNGRiNmE2ZTAyZTkzN2FkOGMwM2VlMjYy ZTYwODFlOWI3MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRp b25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpAQCAtNjI5LDgg KzYyOSwxMCBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJHcmFwaGljcyBUYWIgTmFtZSJdID0gIkdyYXBo aWNzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkdyb3VwIl0gPSAiR3JvdXAiOwogbG9jYWxpemVkU3Ry aW5nc1siR3JvdXAgQnkgUmVzb3VyY2UiXSA9ICJHcm91cCBCeSBSZXNvdXJjZSI7CiBsb2NhbGl6 ZWRTdHJpbmdzWyJHcm91cCBNZWRpYSBSZXF1ZXN0cyJdID0gIkdyb3VwIE1lZGlhIFJlcXVlc3Rz IjsKLWxvY2FsaXplZFN0cmluZ3NbIkdyb3VwIGJ5IEV2ZW50Il0gPSAiR3JvdXAgYnkgRXZlbnQi OwotbG9jYWxpemVkU3RyaW5nc1siR3JvdXAgYnkgVGFyZ2V0Il0gPSAiR3JvdXAgYnkgVGFyZ2V0 IjsKKy8qIEdyb3VwIERPTSBldmVudCBsaXN0ZW5lcnMgYnkgRE9NIGV2ZW50ICovCitsb2NhbGl6 ZWRTdHJpbmdzWyJHcm91cCBieSBFdmVudCBAIE5vZGUgRXZlbnQgTGlzdGVuZXJzIl0gPSAiR3Jv dXAgYnkgRXZlbnQiOworLyogR3JvdXAgRE9NIGV2ZW50IGxpc3RlbmVycyBieSBET00gbm9kZSAq LworbG9jYWxpemVkU3RyaW5nc1siR3JvdXAgYnkgVGFyZ2V0IEAgTm9kZSBFdmVudCBMaXN0ZW5l cnMiXSA9ICJHcm91cCBieSBUYXJnZXQiOwogbG9jYWxpemVkU3RyaW5nc1siR3JvdXBpbmcgTWV0 aG9kIl0gPSAiR3JvdXBpbmcgTWV0aG9kIjsKIGxvY2FsaXplZFN0cmluZ3NbIkhBUiBFeHBvcnQg KCVzKSJdID0gIkhBUiBFeHBvcnQgKCVzKSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJIQVIgSW1wb3J0 Il0gPSAiSEFSIEltcG9ydCI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5jc3MgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWlsc1NpZGViYXJQ YW5lbC5jc3MKaW5kZXggZmRkYWJhZjcwNGFjOTljZjA5MTc3ODMzOWM1ZGYzNTA2NmJkNDliOS4u MzUwZDI2ZDdlYjFkZDZkNWQ1YTIwNWM3MzFiZTU2ZGFhMTJiZmQyMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRl YmFyUGFuZWwuY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0RPTU5vZGVEZXRhaWxzU2lkZWJhclBhbmVsLmNzcwpAQCAtNDUsMjIgKzQ1LDYgQEAgYm9k eVtkaXI9cnRsXSAuc2lkZWJhciA+IC5wYW5lbC5kb20tbm9kZS1kZXRhaWxzIC5kZXRhaWxzLXNl Y3Rpb24uZG9tLW5vZGUtZXZlbnQKICAgICBmaWx0ZXI6IGJyaWdodG5lc3MoMC41KTsKIH0KIAot LnNpZGViYXIgPiAucGFuZWwuZG9tLW5vZGUtZGV0YWlscyAuZGV0YWlscy1zZWN0aW9uLmRvbS1u b2RlLWV2ZW50LWxpc3RlbmVycyA+IC5oZWFkZXIgPiAuZmlsdGVyID4gc2VsZWN0IHsKLSAgICBw b3NpdGlvbjogYWJzb2x1dGU7Ci0gICAgdG9wOiAwOwotICAgIHJpZ2h0OiAwOwotICAgIGJvdHRv bTogMDsKLSAgICBsZWZ0OiAwOwotICAgIG1hcmdpbjogMDsKLSAgICBwYWRkaW5nOiAwOwotICAg IGNvbG9yOiB0cmFuc3BhcmVudDsKLSAgICBiYWNrZ3JvdW5kLWNvbG9yOiB0cmFuc3BhcmVudDsK LSAgICBib3JkZXI6IG5vbmU7Ci0gICAgYm9yZGVyLXJhZGl1czogNTAlOwotICAgIG9wYWNpdHk6 IDA7Ci0gICAgLXdlYmtpdC1hcHBlYXJhbmNlOiBub25lOwotfQotCiAuc2lkZWJhciA+IC5wYW5l bC5kb20tbm9kZS1kZXRhaWxzIC5kZXRhaWxzLXNlY3Rpb24uZG9tLW5vZGUtZXZlbnQtbGlzdGVu ZXJzIC5kZXRhaWxzLXNlY3Rpb24uZXZlbnQtbGlzdGVuZXItc2VjdGlvbiA+IC5oZWFkZXIgPiAu ZXZlbnQtbGlzdGVuZXItb3B0aW9ucyB7CiAgICAgZGlzcGxheTogbm9uZTsKICAgICB3aWR0aDog MTVweDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0RPTU5vZGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMKaW5kZXgg NjI4MGI1NjhiYTE5ZGRmYjEwMTg4NzFiYjNkMjY5NmMzNjljMjRlMi4uZmU4NzE5ZDI2MzQ5MDIx Mjg5YTJiODJhYjZiZTM0N2M3YzI1MjJhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFp bHNTaWRlYmFyUGFuZWwuanMKQEAgLTc5LDI0ICs3OSw3IEBAIFdJLkRPTU5vZGVEZXRhaWxzU2lk ZWJhclBhbmVsID0gY2xhc3MgRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXSS5E T01ECiAgICAgICAgIH0KIAogICAgICAgICBsZXQgZXZlbnRMaXN0ZW5lcnNGaWx0ZXJFbGVtZW50 ID0gV0kuSW1hZ2VVdGlsaXRpZXMudXNlU1ZHU3ltYm9sKCJJbWFnZXMvRmlsdGVyRmllbGRHbHlw aC5zdmciLCAiZmlsdGVyIiwgV0kuVUlTdHJpbmcoIkdyb3VwaW5nIE1ldGhvZCIpKTsKLQotICAg ICAgICBsZXQgZXZlbnRMaXN0ZW5lcnNHcm91cE1ldGhvZFNlbGVjdEVsZW1lbnQgPSBldmVudExp c3RlbmVyc0ZpbHRlckVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgi c2VsZWN0IikpOwotICAgICAgICBldmVudExpc3RlbmVyc0dyb3VwTWV0aG9kU2VsZWN0RWxlbWVu dC5hZGRFdmVudExpc3RlbmVyKCJjaGFuZ2UiLCAoZXZlbnQpID0+IHsKLSAgICAgICAgICAgIHRo aXMuX2V2ZW50TGlzdGVuZXJHcm91cGluZ01ldGhvZFNldHRpbmcudmFsdWUgPSBldmVudExpc3Rl bmVyc0dyb3VwTWV0aG9kU2VsZWN0RWxlbWVudC52YWx1ZTsKLQotICAgICAgICAgICAgdGhpcy5f cmVmcmVzaEV2ZW50TGlzdGVuZXJzKCk7Ci0gICAgICAgIH0pOwotCi0gICAgICAgIGZ1bmN0aW9u IGNyZWF0ZU9wdGlvbih0ZXh0LCB2YWx1ZSkgewotICAgICAgICAgICAgbGV0IG9wdGlvbkVsZW1l bnQgPSBldmVudExpc3RlbmVyc0dyb3VwTWV0aG9kU2VsZWN0RWxlbWVudC5hcHBlbmRDaGlsZChk b2N1bWVudC5jcmVhdGVFbGVtZW50KCJvcHRpb24iKSk7Ci0gICAgICAgICAgICBvcHRpb25FbGVt ZW50LnZhbHVlID0gdmFsdWU7Ci0gICAgICAgICAgICBvcHRpb25FbGVtZW50LnRleHRDb250ZW50 ID0gdGV4dDsKLSAgICAgICAgfQotCi0gICAgICAgIGNyZWF0ZU9wdGlvbihXSS5VSVN0cmluZygi R3JvdXAgYnkgRXZlbnQiKSwgV0kuRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuRXZlbnRMaXN0 ZW5lckdyb3VwaW5nTWV0aG9kLkV2ZW50KTsKLSAgICAgICAgY3JlYXRlT3B0aW9uKFdJLlVJU3Ry aW5nKCJHcm91cCBieSBUYXJnZXQiKSwgV0kuRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuRXZl bnRMaXN0ZW5lckdyb3VwaW5nTWV0aG9kLlRhcmdldCk7Ci0KLSAgICAgICAgZXZlbnRMaXN0ZW5l cnNHcm91cE1ldGhvZFNlbGVjdEVsZW1lbnQudmFsdWUgPSB0aGlzLl9ldmVudExpc3RlbmVyR3Jv dXBpbmdNZXRob2RTZXR0aW5nLnZhbHVlOworICAgICAgICBXSS5hZGRNb3VzZURvd25Db250ZXh0 TWVudUhhbmRsZXJzKGV2ZW50TGlzdGVuZXJzRmlsdGVyRWxlbWVudCwgdGhpcy5fcG9wdWxhdGVF dmVudExpc3RlbmVyc0ZpbHRlckNvbnRleHRNZW51LmJpbmQodGhpcykpOwogCiAgICAgICAgIHRo aXMuX2V2ZW50TGlzdGVuZXJzU2VjdGlvbkdyb3VwID0gbmV3IFdJLkRldGFpbHNTZWN0aW9uR3Jv dXA7CiAgICAgICAgIGxldCBldmVudExpc3RlbmVyc1NlY3Rpb24gPSBuZXcgV0kuRGV0YWlsc1Nl Y3Rpb24oImRvbS1ub2RlLWV2ZW50LWxpc3RlbmVycyIsIFdJLlVJU3RyaW5nKCJFdmVudCBMaXN0 ZW5lcnMiKSwgW3RoaXMuX2V2ZW50TGlzdGVuZXJzU2VjdGlvbkdyb3VwXSwgZXZlbnRMaXN0ZW5l cnNGaWx0ZXJFbGVtZW50KTsKQEAgLTkwMCw2ICs4ODMsMjAgQEAgV0kuRE9NTm9kZURldGFpbHNT aWRlYmFyUGFuZWwgPSBjbGFzcyBET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbCBleHRlbmRzIFdJ LkRPTUQKICAgICAgICAgZG9tTm9kZS5hY2Nlc3NpYmlsaXR5UHJvcGVydGllcyhhY2Nlc3NpYmls aXR5UHJvcGVydGllc0NhbGxiYWNrLmJpbmQodGhpcykpOwogICAgIH0KIAorICAgIF9wb3B1bGF0 ZUV2ZW50TGlzdGVuZXJzRmlsdGVyQ29udGV4dE1lbnUoY29udGV4dE1lbnUpCisgICAgeworICAg ICAgICBsZXQgYWRkR3JvdXBpbmdNZXRob2RDaGVja2JveEl0ZW0gPSAobGFiZWwsIGdyb3VwaW5n TWV0aG9kKSA9PiB7CisgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRDaGVja2JveEl0ZW0o bGFiZWwsICgpID0+IHsKKyAgICAgICAgICAgICAgICB0aGlzLl9ldmVudExpc3RlbmVyR3JvdXBp bmdNZXRob2RTZXR0aW5nLnZhbHVlID0gZ3JvdXBpbmdNZXRob2Q7CisKKyAgICAgICAgICAgICAg ICB0aGlzLl9yZWZyZXNoRXZlbnRMaXN0ZW5lcnMoKTsKKyAgICAgICAgICAgIH0sIHRoaXMuX2V2 ZW50TGlzdGVuZXJHcm91cGluZ01ldGhvZFNldHRpbmcudmFsdWUgPT09IGdyb3VwaW5nTWV0aG9k KTsKKyAgICAgICAgfTsKKworICAgICAgICBhZGRHcm91cGluZ01ldGhvZENoZWNrYm94SXRlbShX SS5VSVN0cmluZygiR3JvdXAgYnkgRXZlbnQiLCAiR3JvdXAgYnkgRXZlbnQgQCBOb2RlIEV2ZW50 IExpc3RlbmVycyIsICJHcm91cCBET00gZXZlbnQgbGlzdGVuZXJzIGJ5IERPTSBldmVudCIpLCBX SS5ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5FdmVudExpc3RlbmVyR3JvdXBpbmdNZXRob2Qu RXZlbnQpOworICAgICAgICBhZGRHcm91cGluZ01ldGhvZENoZWNrYm94SXRlbShXSS5VSVN0cmlu ZygiR3JvdXAgYnkgVGFyZ2V0IiwgIkdyb3VwIGJ5IFRhcmdldCBAIE5vZGUgRXZlbnQgTGlzdGVu ZXJzIiwgIkdyb3VwIERPTSBldmVudCBsaXN0ZW5lcnMgYnkgRE9NIG5vZGUiKSwgV0kuRE9NTm9k ZURldGFpbHNTaWRlYmFyUGFuZWwuRXZlbnRMaXN0ZW5lckdyb3VwaW5nTWV0aG9kLlRhcmdldCk7 CisgICAgfQorCiAgICAgX2V2ZW50TGlzdGVuZXJzQ2hhbmdlZChldmVudCkKICAgICB7CiAgICAg ICAgIGlmIChldmVudC50YXJnZXQgPT09IHRoaXMuZG9tTm9kZSB8fCBldmVudC50YXJnZXQuaXNB bmNlc3Rvcih0aGlzLmRvbU5vZGUpKQo=