213488 2020-06-22 13:59:32 -0700 [Cocoa] Avoid copying the default AppleLanguage preference to the WebContent process 2020-06-22 16:04:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=213214 P2 Normal --- 1 pvollan pvollan bfulgham cdumez ggaren oldest_to_newest 1665172 0 pvollan 2020-06-22 13:59:32 -0700 There is no need to copy the default AppleLanguage preference from the UI process to the WebContent process. The value of this key is available in the WebContent process using the preferences API. 1665178 1 402512 pvollan 2020-06-22 14:06:26 -0700 Created attachment 402512 Patch 1665201 2 402512 ggaren 2020-06-22 15:52:10 -0700 Comment on attachment 402512 Patch r=me 1665206 3 pvollan 2020-06-22 15:56:24 -0700 (In reply to Geoffrey Garen from comment #2) > Comment on attachment 402512 [details] > Patch > > r=me Thanks for reviewing! 1665207 4 402512 cdumez 2020-06-22 15:56:43 -0700 Comment on attachment 402512 Patch It looks like you are reverting my fix from a few days ago. 1665213 5 402512 cdumez 2020-06-22 16:02:39 -0700 Comment on attachment 402512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402512&action=review > Source/WebKit/UIProcess/WebProcessProxy.cpp:-321 > - overrideLanguages = platformOverrideLanguages(); With this change, if a user did: dvdo defaults write com.apple.Safari AppleLanguages '("en-US", "fr-FR")' navigator.languages would not be impacted by the Safari user default anymore. We need to read the UIProcess UserDefault for AppleLanguages here, send it over XPC and then set AppleLanguages to this value in the WebProcess. 1665214 6 pvollan 2020-06-22 16:03:50 -0700 (In reply to Chris Dumez from comment #5) > Comment on attachment 402512 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402512&action=review > > > Source/WebKit/UIProcess/WebProcessProxy.cpp:-321 > > - overrideLanguages = platformOverrideLanguages(); > > With this change, if a user did: > dvdo defaults write com.apple.Safari AppleLanguages '("en-US", "fr-FR")' > > navigator.languages would not be impacted by the Safari user default > anymore. We need to read the UIProcess UserDefault for AppleLanguages here, > send it over XPC and then set AppleLanguages to this value in the WebProcess. Right, I see how this change would break that. Thanks for reviewing! 402512 2020-06-22 14:06:26 -0700 2020-06-22 15:56:43 -0700 Patch bug-213488-20200622140625.patch text/plain 1784 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjMzNjQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA2LTIyICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIEF2b2lkIGNvcHlp bmcgdGhlIGRlZmF1bHQgQXBwbGVMYW5ndWFnZSBwcmVmZXJlbmNlIHRvIHRoZSBXZWJDb250ZW50 IHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMzQ4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoZXJlIGlzIG5vIG5lZWQgdG8gY29weSB0aGUgZGVmYXVsdCBBcHBsZUxhbmd1YWdlIHByZWZl cmVuY2UgZnJvbSB0aGUgVUkgcHJvY2VzcyB0byB0aGUgV2ViQ29udGVudCBwcm9jZXNzLiBUaGUg dmFsdWUgb2YgdGhpcyBrZXkgaXMgYXZhaWxhYmxlCisgICAgICAgIGluIHRoZSBXZWJDb250ZW50 IHByb2Nlc3MgdXNpbmcgdGhlIHByZWZlcmVuY2VzIEFQSS4gU3RvcCBjYWxsaW5nIHRoZSBmdW5j dGlvbiBwbGF0Zm9ybU92ZXJyaWRlTGFuZ3VhZ2VzLCBzaW5jZSBpdCByZXR1cm5zIHRoZSBkZWZh dWx0IHZhbHVlIG9mCisgICAgICAgIHRoZSBBcHBsZUxhbmd1YWdlIHByZWZlcmVuY2UuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBzaW5jZSB0aGlzIHBhdGNoIHNob3VsZCBub3QgaW50cm9kdWNl IGFueSBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1By b3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5OjpnZXRMYXVuY2hPcHRp b25zKToKKwogMjAyMC0wNi0yMiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBVcGRhdGUgbWFjT1MgdmVyc2lvbiBtYWNyb3MKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcAkocmV2aXNpb24gMjYzMzUxKQor KysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzE3LDggKzMxNyw2IEBAIHZvaWQgV2ViUHJvY2Vzc1Byb3h5OjpnZXRMYXVuY2hP cHRpb25zKFAKICAgICAgICAgbGF1bmNoT3B0aW9ucy5leHRyYUluaXRpYWxpemF0aW9uRGF0YS5h ZGQoImluc3BlY3Rvci1wcm9jZXNzIl9zLCAiMSJfcyk7CiAKICAgICBhdXRvIG92ZXJyaWRlTGFu Z3VhZ2VzID0gbV9wcm9jZXNzUG9vbC0+Y29uZmlndXJhdGlvbigpLm92ZXJyaWRlTGFuZ3VhZ2Vz KCk7Ci0gICAgaWYgKG92ZXJyaWRlTGFuZ3VhZ2VzLmlzRW1wdHkoKSkKLSAgICAgICAgb3ZlcnJp ZGVMYW5ndWFnZXMgPSBwbGF0Zm9ybU92ZXJyaWRlTGFuZ3VhZ2VzKCk7CiAgICAgaWYgKCFvdmVy cmlkZUxhbmd1YWdlcy5pc0VtcHR5KCkpIHsKICAgICAgICAgU3RyaW5nQnVpbGRlciBsYW5ndWFn ZVN0cmluZzsKICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBvdmVycmlkZUxhbmd1YWdl cy5zaXplKCk7ICsraSkgewo=