213473 2020-06-22 11:54:47 -0700 resultsdbpy: Make architecture differences explicit 2020-06-22 14:53:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain webkit-bug-importer oldest_to_newest 1665098 0 jbedard 2020-06-22 11:54:47 -0700 Architecture used to be implied by platform, so we didn't display it in the UI. This is no longer the case. 1665099 1 webkit-bug-importer 2020-06-22 11:55:06 -0700 <rdar://problem/64602736> 1665103 2 402489 jbedard 2020-06-22 12:08:09 -0700 Created attachment 402489 Patch 1665104 3 402489 aakash_jain 2020-06-22 12:12:45 -0700 Comment on attachment 402489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402489&action=review > Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:183 > + result += ' with ' + this.architecture; Can you please provide an example of the use-case? 1665147 4 jbedard 2020-06-22 13:14:28 -0700 (In reply to Aakash Jain from comment #3) > Comment on attachment 402489 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402489&action=review > > > Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:183 > > + result += ' with ' + this.architecture; > > Can you please provide an example of the use-case? Mojave E Release on Macmini8,1 with x86_64 This is super important for Rosetta testing because a single model can actually run with multiple architectures. 1665152 5 402489 aakash_jain 2020-06-22 13:32:34 -0700 Comment on attachment 402489 Patch rs=me 1665155 6 402505 jbedard 2020-06-22 13:37:34 -0700 Created attachment 402505 Patch for landing 1665186 7 ews-feeder 2020-06-22 14:53:44 -0700 Committed r263367: <https://trac.webkit.org/changeset/263367> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402505. 402489 2020-06-22 12:08:09 -0700 2020-06-22 13:37:32 -0700 Patch bug-213473-20200622120808.patch text/plain 1376 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MzM1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA2LTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzZGJweTogTWFrZSBhcmNoaXRlY3R1cmUgZGlmZmVyZW5jZXMg ZXhwbGljaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMzQ3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQ2MDI3MzY+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRz ZGJweS92aWV3L3N0YXRpYy9qcy9jb25maWd1cmF0aW9uLmpzOgorICAgICAgICAoQ29uZmlndXJh dGlvbi5wcm90b3R5cGUudG9TdHJpbmcpOgorCiAyMDIwLTA2LTIyICBBYWthc2ggSmFpbiAgPGFh a2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzXSBTd2l0Y2ggY29udHJpYnV0b3Jz Lmpzb24gdXJsIGZyb20gdHJhYyB0byBzdm4gc2VydmVyCkluZGV4OiBUb29scy9yZXN1bHRzZGJw eS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy9jb25maWd1cmF0aW9uLmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbmZpZ3Vy YXRpb24uanMJKHJldmlzaW9uIDI2MzM1NykKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNk YnB5L3ZpZXcvc3RhdGljL2pzL2NvbmZpZ3VyYXRpb24uanMJKHdvcmtpbmcgY29weSkKQEAgLTE3 OSw2ICsxNzksOCBAQCBjbGFzcyBDb25maWd1cmF0aW9uIHsKICAgICAgICAgICAgIHJlc3VsdCAr PSAnICcgKyB0aGlzLnN0eWxlLnNwbGl0KCctJykubWFwKHdvcmQgPT4gd29yZC5jaGFyQXQoMCku dG9VcHBlckNhc2UoKSArIHdvcmQuc2xpY2UoMSkpLmpvaW4oJy0nKTsKICAgICAgICAgfSBpZiAo dGhpcy5tb2RlbCAhPSBudWxsKQogICAgICAgICAgICAgcmVzdWx0ICs9ICcgb24gJyArIHRoaXMu bW9kZWw7CisgICAgICAgIGlmICh0aGlzLmFyY2hpdGVjdHVyZSAhPSBudWxsKQorICAgICAgICAg ICAgcmVzdWx0ICs9ICcgd2l0aCAnICsgdGhpcy5hcmNoaXRlY3R1cmU7CiAKICAgICAgICAgaWYg KHRoaXMuc2RrICE9IG51bGwpCiAgICAgICAgICAgICByZXN1bHQgKz0gJyAoJyArIHRoaXMuc2Rr ICsgJyknOwo= 402505 2020-06-22 13:37:34 -0700 2020-06-22 14:53:45 -0700 Patch for landing bug-213473-20200622133733.patch text/plain 1369 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MzM2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA2LTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzZGJweTogTWFrZSBhcmNoaXRlY3R1cmUgZGlmZmVyZW5jZXMg ZXhwbGljaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMzQ3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQ2MDI3MzY+CisKKyAgICAgICAgUnVi YmVyLXN0YW1wZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1 bHRzZGJweS92aWV3L3N0YXRpYy9qcy9jb25maWd1cmF0aW9uLmpzOgorICAgICAgICAoQ29uZmln dXJhdGlvbi5wcm90b3R5cGUudG9TdHJpbmcpOgorCiAyMDIwLTA2LTIyICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFQSSBUZXN0IFdlYWtMaW5raW5n LldlYWtJbXBvcnQgZmFpbHMgb24gYXJtNjQKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3Vs dHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbmZpZ3VyYXRpb24uanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29uZmlndXJhdGlvbi5q cwkocmV2aXNpb24gMjYzMzYyKQorKysgVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmll dy9zdGF0aWMvanMvY29uZmlndXJhdGlvbi5qcwkod29ya2luZyBjb3B5KQpAQCAtMTc5LDYgKzE3 OSw4IEBAIGNsYXNzIENvbmZpZ3VyYXRpb24gewogICAgICAgICAgICAgcmVzdWx0ICs9ICcgJyAr IHRoaXMuc3R5bGUuc3BsaXQoJy0nKS5tYXAod29yZCA9PiB3b3JkLmNoYXJBdCgwKS50b1VwcGVy Q2FzZSgpICsgd29yZC5zbGljZSgxKSkuam9pbignLScpOwogICAgICAgICB9IGlmICh0aGlzLm1v ZGVsICE9IG51bGwpCiAgICAgICAgICAgICByZXN1bHQgKz0gJyBvbiAnICsgdGhpcy5tb2RlbDsK KyAgICAgICAgaWYgKHRoaXMuYXJjaGl0ZWN0dXJlICE9IG51bGwpCisgICAgICAgICAgICByZXN1 bHQgKz0gJyB3aXRoICcgKyB0aGlzLmFyY2hpdGVjdHVyZTsKIAogICAgICAgICBpZiAodGhpcy5z ZGsgIT0gbnVsbCkKICAgICAgICAgICAgIHJlc3VsdCArPSAnICgnICsgdGhpcy5zZGsgKyAnKSc7 Cg==