21346 2008-10-03 13:48:52 -0700 attribute value selector not being reevaluated upon attribute change 2012-05-22 04:56:48 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 pelaiata kling asutherland bdakin ddkilzer divya pknight simon.fraser oldest_to_newest 93969 0 pelaiata 2008-10-03 13:48:52 -0700 I have encountered a bug in which I have an attribute value selector which is not being reevaluated when my JavaScript code changes the value of the attribute. I have included the source code below and have verified that it works fine in Mozilla browsers but fails in the latest nightly build of WebKit r37126. The key features to observe the bug are that there must be an attribute value selector on a class selector followed by another class selector whose style we would like to define. In the example below, we have a container whose class is "entry" with an attribute which is either "good" or "bad". Inside the container we have a node whose class is "toggle" and we would like to define the style on this node based on the status of its container. The toggle node has a JavaScript click handler which toggles the status of its container between "good" and "bad". Example source code: <html> <head> <title>Selector Test</title> <style> .toggle {cursor: pointer;} .entry[status="good"] .toggle { color: green; } .entry[status="bad"] .toggle { color: red; } </style> </head> <body> <div class="entry" status="good"> <span class="toggle" onclick="var status=this.parentNode.getAttribute('status'); var newStatus=(status=='good'?'bad':'good'); this.parentNode.setAttribute('status', newStatus);">Click to toggle between good (green) and bad (red).</span> </div> </body> </html> 151017 1 ddkilzer 2009-09-29 13:15:36 -0700 <rdar://problem/7261995> 151021 2 pknight 2009-09-29 13:25:45 -0700 Interestingly, if you add this empty rule in Tom's example: .entry[status] {} then the color of the .toggle element changes correctly. 630216 3 143269 kling 2012-05-22 04:18:24 -0700 Created attachment 143269 Patch This was fixed recently, but probably without a test. Turning the provided test case into a layout test so we don't break this again. 630225 4 143269 koivisto 2012-05-22 04:26:32 -0700 Comment on attachment 143269 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143269&action=review r=me > LayoutTests/fast/css/attribute-selector-recursive-update-on-setAttribute.html:4 > +<meta charset="utf-8"> Why is this here? 630253 5 143269 kling 2012-05-22 04:56:39 -0700 Comment on attachment 143269 Patch Clearing flags on attachment: 143269 Committed r117954: <http://trac.webkit.org/changeset/117954> 630254 6 kling 2012-05-22 04:56:48 -0700 All reviewed patches have been landed. Closing bug. 143269 2012-05-22 04:18:24 -0700 2012-05-22 04:56:39 -0700 Patch bug-21346.diff text/plain 2793 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmZDZiOWRiLi41ZTBmODgxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUt MjIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhIGxh eW91dCB0ZXN0IGZvciBhdHRyaWJ1dGUgc2VsZWN0b3IgaW52YWxpZGF0aW9uIHRyaWdnZXJpbmcg cmVjdXJzaXZlIHN0eWxlIHJlY2FsYy4KKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMjEz NDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVn IDIxMzQ2IHdhcyBhbHJlYWR5IGZpeGVkIHNvbWV3aGVyZSBpbiB0aGUgc2VtaXJlY2VudCBwYXN0 LCBzbyBoZXJlJ3MgdGhlIHByb3ZpZGVkCisgICAgICAgIHRlc3QgY2FzZSBhcyBmb3JtIG9mIGEg bGF5b3V0IHRlc3QgdG8gbWFrZSBzdXJlIHdlIGRvbid0IHJlZ3Jlc3MgdGhpcyBhZ2Fpbi4KKwor ICAgICAgICAqIGZhc3QvY3NzL2F0dHJpYnV0ZS1zZWxlY3Rvci1yZWN1cnNpdmUtdXBkYXRlLW9u LXNldEF0dHJpYnV0ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL2F0 dHJpYnV0ZS1zZWxlY3Rvci1yZWN1cnNpdmUtdXBkYXRlLW9uLXNldEF0dHJpYnV0ZS5odG1sOiBB ZGRlZC4KKwogMjAxMi0wNS0yMiAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgTWFyayB0d28gdGVzdHMgYXMgc2tpcHBlZCB3aGlsZSB3ZSBmaWd1cmUgb3V0IHdo eSB0aGV5IGFyZSBmYWlsaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvYXR0 cmlidXRlLXNlbGVjdG9yLXJlY3Vyc2l2ZS11cGRhdGUtb24tc2V0QXR0cmlidXRlLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2F0dHJpYnV0ZS1zZWxlY3Rvci1yZWN1cnNpdmUt dXBkYXRlLW9uLXNldEF0dHJpYnV0ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uMDY2ZmY3MQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvY3NzL2F0dHJpYnV0ZS1zZWxlY3Rvci1yZWN1cnNpdmUtdXBkYXRlLW9uLXNldEF0dHJpYnV0 ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGF0 dHJpYnV0ZSBzZWxlY3RvcnMgYXJlIHJlY3Vyc2l2ZWx5IHJlLWV2YWx1YXRlZCB3aGVuIHRoZSBh dHRyaWJ1dGUgY2hhbmdlcy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1Mg Z2V0Q29tcHV0ZWRTdHlsZSh0b2dnbGUpLmNvbG9yIGlzICdyZ2IoMCwgMTI4LCAwKScKK1BBU1Mg Z2V0Q29tcHV0ZWRTdHlsZSh0b2dnbGUpLmNvbG9yIGlzICdyZ2IoMjU1LCAwLCAwKScKK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9hdHRyaWJ1dGUtc2VsZWN0b3ItcmVjdXJzaXZlLXVwZGF0 ZS1vbi1zZXRBdHRyaWJ1dGUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2F0dHJpYnV0ZS1z ZWxlY3Rvci1yZWN1cnNpdmUtdXBkYXRlLW9uLXNldEF0dHJpYnV0ZS5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmZmZDU4MTUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2Nzcy9hdHRyaWJ1dGUtc2VsZWN0b3ItcmVjdXJzaXZlLXVwZGF0ZS1vbi1z ZXRBdHRyaWJ1dGUuaHRtbApAQCAtMCwwICsxLDM1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVz b3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzdHlsZT4KKy5lbnRyeVtzdGF0dXM9 ImZvbyJdIC50b2dnbGUgeworICAgIGNvbG9yOiBncmVlbjsKK30KKy5lbnRyeVtzdGF0dXM9ImJh ciJdIC50b2dnbGUgeworICAgIGNvbG9yOiByZWQ7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJv ZHk+Cis8ZGl2IGNsYXNzPSJlbnRyeSIgc3RhdHVzPSJmb28iPgorICAgIDxzcGFuIGNsYXNzPSJ0 b2dnbGUiPlRleHQuPC9zcGFuPgorPC9kaXY+Cis8c2NyaXB0PgorCitkZXNjcmlwdGlvbigiVGhp cyB0ZXN0IGNoZWNrcyB0aGF0IGF0dHJpYnV0ZSBzZWxlY3RvcnMgYXJlIHJlY3Vyc2l2ZWx5IHJl LWV2YWx1YXRlZCB3aGVuIHRoZSBhdHRyaWJ1dGUgY2hhbmdlcy4iKTsKKwordmFyIGVudHJ5PSBk b2N1bWVudC5nZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCJlbnRyeSIpWzBdOwordmFyIHRvZ2dsZSA9 IGRvY3VtZW50LmdldEVsZW1lbnRzQnlDbGFzc05hbWUoInRvZ2dsZSIpWzBdOworCitzaG91bGRC ZSgiZ2V0Q29tcHV0ZWRTdHlsZSh0b2dnbGUpLmNvbG9yIiwgIidyZ2IoMCwgMTI4LCAwKSciKTsK K2VudHJ5LnNldEF0dHJpYnV0ZSgic3RhdHVzIiwgImJhciIpOworc2hvdWxkQmUoImdldENvbXB1 dGVkU3R5bGUodG9nZ2xlKS5jb2xvciIsICIncmdiKDI1NSwgMCwgMCknIik7CisKK2RvY3VtZW50 LmJvZHkucmVtb3ZlQ2hpbGQoZW50cnkpOworCis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9q cy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K