213449 2020-06-21 19:07:33 -0700 [WTF] Ensure ASCIILiteral is ASCII characters at compile time 2020-06-22 08:17:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki aperez benjamin cdumez cmarcelo darin ews-watchlist mark.lam ross.kirsling webkit-bug-importer oldest_to_newest 1664909 0 ysuzuki 2020-06-21 19:07:33 -0700 [WTF] Ensure ASCIILiteral is ASCII characters at compile time 1664910 1 402438 ysuzuki 2020-06-21 19:09:16 -0700 Created attachment 402438 Patch 1664912 2 402438 ross.kirsling 2020-06-21 19:25:38 -0700 Comment on attachment 402438 Patch r=me. ラーメン食べたい。 1664915 3 402438 mark.lam 2020-06-21 19:33:36 -0700 Comment on attachment 402438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402438&action=review > Source/WTF/wtf/text/ASCIILiteral.h:64 > + ASSERT_UNDER_CONSTEXPR_CONTEXT(isASCII(characters[i])); Since this is constexpr, is there a reason why we only want this for ASSERT_ENABLED? Why not have RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT this? 1664920 4 402438 ysuzuki 2020-06-21 19:58:17 -0700 Comment on attachment 402438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402438&action=review >> Source/WTF/wtf/text/ASCIILiteral.h:64 >> + ASSERT_UNDER_CONSTEXPR_CONTEXT(isASCII(characters[i])); > > Since this is constexpr, is there a reason why we only want this for ASSERT_ENABLED? Why not have RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT this? Discussed with Mark on Slack, this function can be called in non-constexpr context, like, auto string = "Hey"_s; // instead of constexpr string = "Hey"_s; in non global code. So, this is safer for accidental runtime checks. 1664943 5 ews-feeder 2020-06-21 23:51:32 -0700 Committed r263341: <https://trac.webkit.org/changeset/263341> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402438. 1664944 6 webkit-bug-importer 2020-06-21 23:52:17 -0700 <rdar://problem/64585669> 1664948 7 402438 aperez 2020-06-22 00:23:32 -0700 Comment on attachment 402438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402438&action=review > Source/WTF/ChangeLog:12 > + auto globalVariable = "ラーメン (Ramen in Japanese)"_s; As a ramen enthusiast, I like this example in the commit log ^_^ 🍜️♥️ 1665025 8 darin 2020-06-22 07:50:48 -0700 Very very happy to see this change go in. 1665033 9 darin 2020-06-22 08:10:43 -0700 Is there some way to make this even more strongly guaranteed to be done at compile time? I assume the answer is no, but obviously we want to compile errors with a poorly formed literal, not a runtime check if it happens to be used in a non-constexpr context. 1665038 10 ysuzuki 2020-06-22 08:17:19 -0700 (In reply to Darin Adler from comment #9) > Is there some way to make this even more strongly guaranteed to be done at > compile time? I assume the answer is no, but obviously we want to compile > errors with a poorly formed literal, not a runtime check if it happens to be > used in a non-constexpr context. This is the purpose of consteval in C++20! https://en.cppreference.com/w/cpp/language/consteval I can't wait to use C++20 :D 402438 2020-06-21 19:09:16 -0700 2020-06-21 23:51:33 -0700 Patch bug-213449-20200621190915.patch text/plain 2942 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNkZDkxNGQwMjNjODc1MjlmMzE2NWUw YTJjZmVjMDZkYTRmODIyZmYuLjcyYzE2Njg1MWY3Y2E4ZGMxMjcyNmNhNWQ1NGZlYzRjOTU3MTc0 NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjAtMDYtMjEgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbV1RGXSBFbnN1cmUgQVNDSUlMaXRlcmFsIGlzIEFT Q0lJIGNoYXJhY3RlcnMgYXQgY29tcGlsZSB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM0NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHVycG9zZSBvZiBBU0NJSUxpdGVyYWwgaXMgZW5z dXJlIHRoYXQgdGhpcyBpcyBjb21waWxlLXRpbWUgKGRvIG5vdCBuZWVkIHRvIGNvbnNpZGVyIGFi b3V0IG93bmVyc2hpcCkgQVNDSUkgY2hhcmFjdGVycy4KKyAgICAgICAgQnkgdXNpbmcgYGlzQVND SUlgIGFuZCBgQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhUYCwgd2UgY2FuIG1ha2Ugc3Vy ZSB0aGF0IHRoaXMgQyBzdHJpbmcgZG9lcyBub3QgaW5jbHVkZSBub24gQVNDSUkgY2hhcmFjdGVy cy4KKyAgICAgICAgRm9yIGV4YW1wbGUsCisKKyAgICAgICAgICAgIGF1dG8gZ2xvYmFsVmFyaWFi bGUgPSAi44Op44O844Oh44OzIChSYW1lbiBpbiBKYXBhbmVzZSkiX3M7CisKKyAgICAgICAgYmVj b21lcyBjb21waWxlIGVycm9yLgorCisgICAgICAgICogd3RmL0FTQ0lJQ1R5cGUuaDoKKyAgICAg ICAgKFdURjo6aXNBU0NJSSk6CisgICAgICAgICogd3RmL3RleHQvQVNDSUlMaXRlcmFsLmg6Cisg ICAgICAgIChXVEY6OlN0cmluZ0xpdGVyYWxzOjpvcGVyYXRvciBfcyk6CisKIDIwMjAtMDYtMTkg IFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBDaGVj ayBHaWdhY2FnZSB1c2FnZSBiZWZvcmUgbGF1bmNoaW5nIFZNCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi9BU0NJSUNUeXBlLmggYi9Tb3VyY2UvV1RGL3d0Zi9BU0NJSUNUeXBlLmgKaW5kZXgg ODU4M2Y0NmZhMzI5YTE3NDk5Y2Y0MzgyY2ZkMWY1MzNjNGZhZTE3YS4uOTQ1ZTc4Mjg0NzU2M2Ji NmIwOGJiNWFkY2Q1MjE1NGQ2NjkzMTM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQVND SUlDVHlwZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0FTQ0lJQ1R5cGUuaApAQCAtMzksNyArMzks NyBAQAogCiBuYW1lc3BhY2UgV1RGIHsKIAotdGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFjdGVyVHlw ZT4gYm9vbCBpc0FTQ0lJKENoYXJhY3RlclR5cGUpOwordGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFj dGVyVHlwZT4gY29uc3RleHByIGJvb2wgaXNBU0NJSShDaGFyYWN0ZXJUeXBlKTsKIHRlbXBsYXRl PHR5cGVuYW1lIENoYXJhY3RlclR5cGU+IGJvb2wgaXNBU0NJSUFscGhhKENoYXJhY3RlclR5cGUp OwogdGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4gYm9vbCBpc0FTQ0lJQWxwaGFudW1l cmljKENoYXJhY3RlclR5cGUpOwogdGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4gYm9v bCBpc0FTQ0lJQmluYXJ5RGlnaXQoQ2hhcmFjdGVyVHlwZSk7CkBAIC03Miw3ICs3Miw3IEBAIHRl bXBsYXRlPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+IENoYXJhY3RlclR5cGUgdG9BU0NJSUxvd2Vy VW5jaGVja2VkKENoYXJhY3RlclR5CiAKIGV4dGVybiBXVEZfRVhQT1JUX1BSSVZBVEUgY29uc3Qg dW5zaWduZWQgY2hhciBhc2NpaUNhc2VGb2xkVGFibGVbMjU2XTsKIAotdGVtcGxhdGU8dHlwZW5h bWUgQ2hhcmFjdGVyVHlwZT4gaW5saW5lIGJvb2wgaXNBU0NJSShDaGFyYWN0ZXJUeXBlIGNoYXJh Y3RlcikKK3RlbXBsYXRlPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+IGNvbnN0ZXhwciBib29sIGlz QVNDSUkoQ2hhcmFjdGVyVHlwZSBjaGFyYWN0ZXIpCiB7CiAgICAgcmV0dXJuICEoY2hhcmFjdGVy ICYgfjB4N0YpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9BU0NJSUxpdGVy YWwuaCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvQVNDSUlMaXRlcmFsLmgKaW5kZXggNzEyMjg4NWY4 MmRiZDcwMTY3Y2FlNjk1NDY0NDA2ZTQ0NjVlZGI3Ni4uYTkwOGRmM2JlYTYxZmZjMjNlYmRkYjM0 NGM3NTZmYzJjOGU4ODI3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9BU0NJSUxp dGVyYWwuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0FTQ0lJTGl0ZXJhbC5oCkBAIC0yNSw2 ICsyNSw4IEBACiAKICNwcmFnbWEgb25jZQogCisjaW5jbHVkZSA8d3RmL0FTQ0lJQ1R5cGUuaD4K KwogbmFtZXNwYWNlIFdURiB7CiAKIGNsYXNzIFByaW50U3RyZWFtOwpAQCAtNTUsOCArNTcsMTQg QEAgY2xhc3MgQVNDSUlMaXRlcmFsIGZpbmFsIHsKIAogaW5saW5lIG5hbWVzcGFjZSBTdHJpbmdM aXRlcmFscyB7CiAKLWNvbnN0ZXhwciBBU0NJSUxpdGVyYWwgb3BlcmF0b3IiIiBfcyhjb25zdCBj aGFyKiBjaGFyYWN0ZXJzLCBzaXplX3QpCitjb25zdGV4cHIgQVNDSUlMaXRlcmFsIG9wZXJhdG9y IiIgX3MoY29uc3QgY2hhciogY2hhcmFjdGVycywgc2l6ZV90IG4pCiB7CisjaWYgQVNTRVJUX0VO QUJMRUQKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG47ICsraSkKKyAgICAgICAgQVNTRVJU X1VOREVSX0NPTlNURVhQUl9DT05URVhUKGlzQVNDSUkoY2hhcmFjdGVyc1tpXSkpOworI2Vsc2UK KyAgICBVTlVTRURfUEFSQU0obik7CisjZW5kaWYKICAgICByZXR1cm4gQVNDSUlMaXRlcmFsOjpm cm9tTGl0ZXJhbFVuc2FmZShjaGFyYWN0ZXJzKTsKIH0KIAo=