213438 2020-06-20 14:16:22 -0700 Code cleanup in WebAccessibilityObjectWrapper updateObjectBackingStore and position. 2020-06-22 09:32:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1664780 0 andresg_22 2020-06-20 14:16:22 -0700 Code cleanup in WebAccessibilityObjectWrapper updateObjectBackingStore and position. 1664782 1 402403 andresg_22 2020-06-20 14:21:54 -0700 Created attachment 402403 Patch 1664886 2 402403 darin 2020-06-21 13:35:27 -0700 Comment on attachment 402403 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402403&action=review > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). > + > + > + > + * accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Some extra blank lines here. > Source/WebCore/ChangeLog:16 > + Check for isIsolatedTreeEnabled, not just for the request thread. This comment makes it sound like we want to check both, but the code seems to no longer check the thread. > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:346 > + auto* backingObject = self.axBackingObject; I would have just used "auto" rather than "auto*", but many others prefer it this way. > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1976 > return [NSValue valueWithPoint:(NSPoint)self.axBackingObject->relativeFrame().location()]; Surprised we need the cast to NSPoint here. 1665004 3 402467 andresg_22 2020-06-22 06:56:44 -0700 Created attachment 402467 Patch 1665006 4 andresg_22 2020-06-22 07:01:44 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 402403 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402403&action=review > > > Source/WebCore/ChangeLog:10 > > + Reviewed by NOBODY (OOPS!). > > + > > + > > + > > + * accessibility/mac/WebAccessibilityObjectWrapperBase.mm: > > Some extra blank lines here. Fixed. > > > Source/WebCore/ChangeLog:16 > > + Check for isIsolatedTreeEnabled, not just for the request thread. > > This comment makes it sound like we want to check both, but the code seems > to no longer check the thread. Fixed the comment, since indeed we don't want to check the thread because isolated tree mode 1 is on the main thread, isolated tree mode 2 is on the secondary thread. > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:346 > > + auto* backingObject = self.axBackingObject; > > I would have just used "auto" rather than "auto*", but many others prefer it > this way. > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1976 > > return [NSValue valueWithPoint:(NSPoint)self.axBackingObject->relativeFrame().location()]; > > Surprised we need the cast to NSPoint here. Removed it since indeed we don't need it, FloatPoint has an NSPoint cast operator. 1665068 5 ews-feeder 2020-06-22 09:31:59 -0700 Committed r263352: <https://trac.webkit.org/changeset/263352> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402467. 1665069 6 webkit-bug-importer 2020-06-22 09:32:15 -0700 <rdar://problem/64598798> 402403 2020-06-20 14:21:54 -0700 2020-06-22 06:56:42 -0700 Patch bug-213438-20200620172153.patch text/plain 2661 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTg5NjQxNmZhNTYyYWNm OWJmNDQ0Njk0YjNiNjNhYjNhYjBkYTE0Yi4uYTRhZjNmYjZlMTk2NzYxZDNjODFhYWNlZTFmMzhh YTk0YWI0ZTUxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA2LTIwICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBDb2RlIGNsZWFu dXAgaW4gV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgdXBkYXRlT2JqZWN0QmFja2luZ1N0 b3JlIGFuZCBwb3NpdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMzQzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyQmFzZS5tbToKKyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJC YXNlIHVwZGF0ZU9iamVjdEJhY2tpbmdTdG9yZV0pOgorICAgICAgICBSZW1vdmVkIHVubmVjZXNz YXJ5IGNhbGwgdG8gYXhCYWNraW5nT2JqZWN0LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9t YWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW06CisgICAgICAgICgtW1dlYkFj Y2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIHBvc2l0aW9uXSk6CisgICAgICAgIENoZWNrIGZvciBp c0lzb2xhdGVkVHJlZUVuYWJsZWQsIG5vdCBqdXN0IGZvciB0aGUgcmVxdWVzdCB0aHJlYWQuCisK IDIwMjAtMDYtMjAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb TEZDXVtURkNdW1F1aXJrXSBUYWJsZSBoZWlnaHQgbmVlZHMgcXVpcmsgaGFuZGxpbmcKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyQmFzZS5tbSBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dl YkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQmFzZS5tbQppbmRleCBlNGMxYmFkOTQ5Mjk5OGEx ZjMwNzk5ZDZhMmVmZDExNTgxYTQ1NTY0Li44ZmQzYmRmOTI1M2JkMDQxZWMxZmJkNmFkYjYxNTVm ZTlhNzRhMDgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckJhc2UubW0KKysrIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJCYXNlLm1tCkBA IC0zNDMsMTAgKzM0MywxMSBAQCBOU0FycmF5ICpjb252ZXJ0VG9OU0FycmF5KGNvbnN0IFdlYkNv cmU6OkFYQ29yZU9iamVjdDo6QWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdAogICAgIENGUmV0YWlu KChfX2JyaWRnZSBDRlR5cGVSZWYpc2VsZik7CiAgICAgQ0ZBdXRvcmVsZWFzZSgoX19icmlkZ2Ug Q0ZUeXBlUmVmKXNlbGYpOwogCi0gICAgaWYgKCFzZWxmLmF4QmFja2luZ09iamVjdCkKKyAgICBh dXRvKiBiYWNraW5nT2JqZWN0ID0gc2VsZi5heEJhY2tpbmdPYmplY3Q7CisgICAgaWYgKCFiYWNr aW5nT2JqZWN0KQogICAgICAgICByZXR1cm4gbmlsOwogCi0gICAgc2VsZi5heEJhY2tpbmdPYmpl Y3QtPnVwZGF0ZUJhY2tpbmdTdG9yZSgpOworICAgIGJhY2tpbmdPYmplY3QtPnVwZGF0ZUJhY2tp bmdTdG9yZSgpOwogCiAgICAgcmV0dXJuIHNlbGYuYXhCYWNraW5nT2JqZWN0OwogfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXJNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQppbmRleCAyMWIwMWM3ZDVhMTMzY2Y0Y2Ex ODk4OTAwNzYzYzNiMmU0NmM3YWYwLi5kNzhhNWE1Zjc3YWRiMDRhZjY0MzQwYmZhZTFlN2QzZGI4 MjU3YmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQpAQCAtMTk3 Miw3ICsxOTcyLDcgQEAgc3RhdGljIHZvaWQgV2ViVHJhbnNmb3JtQ0dQYXRoVG9OU0JlemllclBh dGgodm9pZCogaW5mbywgY29uc3QgQ0dQYXRoRWxlbWVudCAqZWwKIC0gKE5TVmFsdWUgKilwb3Np dGlvbgogewogI2lmIEVOQUJMRShBQ0NFU1NJQklMSVRZX0lTT0xBVEVEX1RSRUUpCi0gICAgaWYg KF9BWFVJRWxlbWVudFJlcXVlc3RTZXJ2aWNlZEJ5U2Vjb25kYXJ5QVhUaHJlYWQoKSkKKyAgICBp ZiAoQVhPYmplY3RDYWNoZTo6aXNJc29sYXRlZFRyZWVFbmFibGVkKCkpCiAgICAgICAgIHJldHVy biBbTlNWYWx1ZSB2YWx1ZVdpdGhQb2ludDooTlNQb2ludClzZWxmLmF4QmFja2luZ09iamVjdC0+ cmVsYXRpdmVGcmFtZSgpLmxvY2F0aW9uKCldOwogI2VuZGlmCiAK 402467 2020-06-22 06:56:44 -0700 2020-06-22 09:32:00 -0700 Patch bug-213438-20200622095641.patch text/plain 2879 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTg5NjQxNmZhNTYyYWNm OWJmNDQ0Njk0YjNiNjNhYjNhYjBkYTE0Yi4uNTQyNTEyZDJlNTVmNWRiYzFhZWY1ZTU4YWUzMzg2 NzEyZWRjNWY5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA2LTIwICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBDb2RlIGNsZWFu dXAgaW4gV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgdXBkYXRlT2JqZWN0QmFja2luZ1N0 b3JlIGFuZCBwb3NpdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMzQzOAorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisg ICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJC YXNlLm1tOgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckJhc2UgdXBk YXRlT2JqZWN0QmFja2luZ1N0b3JlXSk6CisgICAgICAgIFJlbW92ZWQgdW5uZWNlc3NhcnkgY2Fs bCB0byBheEJhY2tpbmdPYmplY3QuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbToKKyAgICAgICAgKC1bV2ViQWNjZXNzaWJp bGl0eU9iamVjdFdyYXBwZXIgcG9zaXRpb25dKToKKyAgICAgICAgQ2hlY2sgZm9yIGlzSXNvbGF0 ZWRUcmVlRW5hYmxlZCBpbnN0ZWFkIG9mIGZvciB0aGUgcmVxdWVzdCB0aHJlYWQsCisgICAgICAg IHNpbmNlIGlzb2xhdGVkIHRyZWUgbW9kZSA9IDEgcnVucyBvbiB0aGUgbWFpbiB0aHJlYWQuCisK IDIwMjAtMDYtMjAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb TEZDXVtURkNdW1F1aXJrXSBUYWJsZSBoZWlnaHQgbmVlZHMgcXVpcmsgaGFuZGxpbmcKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyQmFzZS5tbSBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dl YkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQmFzZS5tbQppbmRleCBlNGMxYmFkOTQ5Mjk5OGEx ZjMwNzk5ZDZhMmVmZDExNTgxYTQ1NTY0Li44ZmQzYmRmOTI1M2JkMDQxZWMxZmJkNmFkYjYxNTVm ZTlhNzRhMDgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckJhc2UubW0KKysrIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJCYXNlLm1tCkBA IC0zNDMsMTAgKzM0MywxMSBAQCBOU0FycmF5ICpjb252ZXJ0VG9OU0FycmF5KGNvbnN0IFdlYkNv cmU6OkFYQ29yZU9iamVjdDo6QWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdAogICAgIENGUmV0YWlu KChfX2JyaWRnZSBDRlR5cGVSZWYpc2VsZik7CiAgICAgQ0ZBdXRvcmVsZWFzZSgoX19icmlkZ2Ug Q0ZUeXBlUmVmKXNlbGYpOwogCi0gICAgaWYgKCFzZWxmLmF4QmFja2luZ09iamVjdCkKKyAgICBh dXRvKiBiYWNraW5nT2JqZWN0ID0gc2VsZi5heEJhY2tpbmdPYmplY3Q7CisgICAgaWYgKCFiYWNr aW5nT2JqZWN0KQogICAgICAgICByZXR1cm4gbmlsOwogCi0gICAgc2VsZi5heEJhY2tpbmdPYmpl Y3QtPnVwZGF0ZUJhY2tpbmdTdG9yZSgpOworICAgIGJhY2tpbmdPYmplY3QtPnVwZGF0ZUJhY2tp bmdTdG9yZSgpOwogCiAgICAgcmV0dXJuIHNlbGYuYXhCYWNraW5nT2JqZWN0OwogfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXJNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQppbmRleCAyMWIwMWM3ZDVhMTMzY2Y0Y2Ex ODk4OTAwNzYzYzNiMmU0NmM3YWYwLi45Njg2ZDQzNTU2NGJiZjAzOTczMzNiMGVmMGM0YzdlZjJh ZjI5MmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQpAQCAtMTk3 Miw4ICsxOTcyLDggQEAgc3RhdGljIHZvaWQgV2ViVHJhbnNmb3JtQ0dQYXRoVG9OU0JlemllclBh dGgodm9pZCogaW5mbywgY29uc3QgQ0dQYXRoRWxlbWVudCAqZWwKIC0gKE5TVmFsdWUgKilwb3Np dGlvbgogewogI2lmIEVOQUJMRShBQ0NFU1NJQklMSVRZX0lTT0xBVEVEX1RSRUUpCi0gICAgaWYg KF9BWFVJRWxlbWVudFJlcXVlc3RTZXJ2aWNlZEJ5U2Vjb25kYXJ5QVhUaHJlYWQoKSkKLSAgICAg ICAgcmV0dXJuIFtOU1ZhbHVlIHZhbHVlV2l0aFBvaW50OihOU1BvaW50KXNlbGYuYXhCYWNraW5n T2JqZWN0LT5yZWxhdGl2ZUZyYW1lKCkubG9jYXRpb24oKV07CisgICAgaWYgKEFYT2JqZWN0Q2Fj aGU6OmlzSXNvbGF0ZWRUcmVlRW5hYmxlZCgpKQorICAgICAgICByZXR1cm4gW05TVmFsdWUgdmFs dWVXaXRoUG9pbnQ6c2VsZi5heEJhY2tpbmdPYmplY3QtPnJlbGF0aXZlRnJhbWUoKS5sb2NhdGlv bigpXTsKICNlbmRpZgogCiAgICAgYXV0byByZWN0ID0gc25hcHBlZEludFJlY3Qoc2VsZi5heEJh Y2tpbmdPYmplY3QtPmVsZW1lbnRSZWN0KCkpOwo=