213422 2020-06-19 17:49:55 -0700 [Windows] fast/forms/search-field-buttons-do-not-have-focus-rings.html is failing 2020-06-20 00:08:44 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes cdumez megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1664656 0 wenson_hsieh 2020-06-19 17:49:55 -0700 SSIA 1664676 1 402367 wenson_hsieh 2020-06-19 19:00:07 -0700 Created attachment 402367 Patch 1664706 2 402367 thorton 2020-06-19 23:44:22 -0700 Comment on attachment 402367 Patch This ... was pretty rough before, and it's still pretty rough. But ok. 1664707 3 402367 wenson_hsieh 2020-06-19 23:48:55 -0700 Comment on attachment 402367 Patch Thanks for the review! Yeah...this ended up being a pretty annoying bug to test :/ 1664709 4 ews-feeder 2020-06-20 00:08:43 -0700 Committed r263317: <https://trac.webkit.org/changeset/263317> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402367. 402367 2020-06-19 19:00:07 -0700 2020-06-20 00:08:43 -0700 Patch bug-213422-20200619190007.patch text/plain 7203 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMzA1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOWNmNzY1ZWNiODQwODdmZGJlOGIy NjA5Y2IwMWE4OGJlYjY5ZDc0NS4uZmMxOWY0ZWUwNGU0MTllOTg2NTliOGFkMzJlZmNlMDNjMzA4 NWQ4NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA2LTE5ICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5kb3dzXSBmYXN0L2Zvcm1zL3Nl YXJjaC1maWVsZC1idXR0b25zLWRvLW5vdC1oYXZlLWZvY3VzLXJpbmdzLmh0bWwgaXMgZmFpbGlu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzNDIy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVmYWN0 b3IgdGhpcyB0ZXN0IHNvIHRoYXQgaXQgZG9lc24ndCBhdHRlbXB0IHRvIGhhcmQtY29kZSB0aGUg cG9zaXRpb24gYW5kIHNpemVzIG9mIHRoZSBzZWFyY2ggZmllbGQgYnV0dG9ucy4KKyAgICAgICAg VG8gZG8gdGhpcywgd2UgdXNlIGFuIGludGVybmFsIGhlbHBlciB0byBncmFiIHRoZSBgZGl2YCBl bGVtZW50cyB0aGF0IGNvcnJlc3BvbmQgdG8gdGhlIHJlc3VsdHMgYW5kIGNhbmNlbAorICAgICAg ICBidXR0b25zLCBhbmQgdGhlbiB1c2UgdGhlaXIgYm91bmRpbmcgcmVjdHMgdG8gcGxhY2UgdGhl IG9wYXF1ZSBgZGl2YHMgdG8gY292ZXIgdGhlc2UgYnV0dG9ucy4KKworICAgICAgICAqIGZhc3Qv Zm9ybXMvc2VhcmNoLWZpZWxkLWJ1dHRvbnMtZG8tbm90LWhhdmUtZm9jdXMtcmluZ3MtZXhwZWN0 ZWQuaHRtbDoKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlYXJjaC1maWVsZC1idXR0b25zLWRvLW5v dC1oYXZlLWZvY3VzLXJpbmdzLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vd2luL1Rlc3RFeHBl Y3RhdGlvbnM6CisKIDIwMjAtMDYtMTkgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZyBvbiBXaW5kb3dzCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC1maWVsZC1idXR0b25zLWRv LW5vdC1oYXZlLWZvY3VzLXJpbmdzLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL3NlYXJjaC1maWVsZC1idXR0b25zLWRvLW5vdC1oYXZlLWZvY3VzLXJpbmdzLWV4cGVjdGVk Lmh0bWwKaW5kZXggMGRlZWNlNzQ2ZmFiZWNjMzc0NTNiMzJjNGZlNzc4ZDIyZDhkNDBkYi4uZTBh MjYxNmExZWNmYzlhODhkNzk3MDI2YzhhNjA5M2M1MTdkNDBmZSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtZmllbGQtYnV0dG9ucy1kby1ub3QtaGF2ZS1mb2N1cy1y aW5ncy1leHBlY3RlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoLWZp ZWxkLWJ1dHRvbnMtZG8tbm90LWhhdmUtZm9jdXMtcmluZ3MtZXhwZWN0ZWQuaHRtbApAQCAtMTEs NyArMTEsNiBAQAogICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgICAgICAg dG9wOiAwOwogICAgICAgICAgICAgbGVmdDogMDsKLSAgICAgICAgICAgIHpvb206IDEuNDsKICAg ICAgICAgICAgIC13ZWJraXQtYXBwZWFyYW5jZTogbm9uZTsKICAgICAgICAgfQogCkBAIC0yMCwx OCArMTksOCBAQAogICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogd2hpdGU7CiAgICAgICAg IH0KIAotICAgICAgICAjY292ZXItcmVzdWx0cyB7Ci0gICAgICAgICAgICB0b3A6IDEwcHg7Ci0g ICAgICAgICAgICBsZWZ0OiA0cHg7Ci0gICAgICAgICAgICB3aWR0aDogMjhweDsKLSAgICAgICAg ICAgIGhlaWdodDogMjJweDsKLSAgICAgICAgfQotCi0gICAgICAgICNjb3Zlci1jYW5jZWwgewot ICAgICAgICAgICAgdG9wOiAxMHB4OwotICAgICAgICAgICAgbGVmdDogMzE2cHg7Ci0gICAgICAg ICAgICB3aWR0aDogMjhweDsKLSAgICAgICAgICAgIGhlaWdodDogMjRweDsKKyAgICAgICAgcCB7 CisgICAgICAgICAgICBtYXJnaW4tdG9wOiAxMDBweDsKICAgICAgICAgfQogICAgIDwvc3R5bGU+ CiA8L2hlYWQ+CkBAIC0zOSw1ICsyOCwyNSBAQAogICAgIDxpbnB1dCB0eXBlPSJzZWFyY2giIHJl c3VsdHM9IjUiIHZhbHVlPSJmb28iIGF1dG9mb2N1cz48L2lucHV0PgogICAgIDxkaXYgaWQ9ImNv dmVyLXJlc3VsdHMiPjwvZGl2PgogICAgIDxkaXYgaWQ9ImNvdmVyLWNhbmNlbCI+PC9kaXY+Cisg ICAgPHA+VGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgdGhlIHNlYXJjaCBhbmQgcmVzdWx0cyBidXR0 b25zIGluIGEgc2VhcmNoIGZpZWxkIGRvIG5vdCBlYWNoIGRyYXcgdGhlaXIgb3duIGZvY3VzIHJp bmdzLiBUaGlzIHRlc3QgbXVzdCBiZSBydW4gdW5kZXIgV2ViS2l0VGVzdFJ1bm5lciBvciBEdW1w UmVuZGVyVHJlZS48L3A+CisgICAgPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmludGVybmFscykg eworICAgICAgICBjb25zdCBzZWFyY2ggPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJpbnB1dFt0 eXBlPXNlYXJjaF0iKTsKKworICAgICAgICBjb25zdCBjb3ZlckNhbmNlbCA9IGRvY3VtZW50LnF1 ZXJ5U2VsZWN0b3IoIiNjb3Zlci1jYW5jZWwiKTsKKyAgICAgICAgY29uc3QgY2FuY2VsQnV0dG9u Qm91bmRzID0gaW50ZXJuYWxzLnNoYWRvd1Jvb3Qoc2VhcmNoKS5xdWVyeVNlbGVjdG9yKCJkaXZb cHNldWRvPSctd2Via2l0LXNlYXJjaC1jYW5jZWwtYnV0dG9uJ10iKS5nZXRCb3VuZGluZ0NsaWVu dFJlY3QoKTsKKyAgICAgICAgY292ZXJDYW5jZWwuc3R5bGUubGVmdCA9IGAke01hdGgucm91bmQo Y2FuY2VsQnV0dG9uQm91bmRzLmxlZnQpIC0gMX1weGA7CisgICAgICAgIGNvdmVyQ2FuY2VsLnN0 eWxlLnRvcCA9IGAke01hdGgucm91bmQoY2FuY2VsQnV0dG9uQm91bmRzLnRvcCkgLSAxfXB4YDsK KyAgICAgICAgY292ZXJDYW5jZWwuc3R5bGUud2lkdGggPSBgJHtNYXRoLnJvdW5kKGNhbmNlbEJ1 dHRvbkJvdW5kcy53aWR0aCkgKyAyfXB4YDsKKyAgICAgICAgY292ZXJDYW5jZWwuc3R5bGUuaGVp Z2h0ID0gYCR7TWF0aC5yb3VuZChjYW5jZWxCdXR0b25Cb3VuZHMuaGVpZ2h0KSArIDJ9cHhgOwor CisgICAgICAgIGNvbnN0IGNvdmVyUmVzdWx0cyA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoIiNj b3Zlci1yZXN1bHRzIik7CisgICAgICAgIGNvbnN0IHJlc3VsdHNCdXR0b25Cb3VuZHMgPSBpbnRl cm5hbHMuc2hhZG93Um9vdChzZWFyY2gpLnF1ZXJ5U2VsZWN0b3IoImRpdltwc2V1ZG89Jy13ZWJr aXQtc2VhcmNoLXJlc3VsdHMtYnV0dG9uJ10iKS5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKTsKKyAg ICAgICAgY292ZXJSZXN1bHRzLnN0eWxlLmxlZnQgPSBgJHtNYXRoLnJvdW5kKHJlc3VsdHNCdXR0 b25Cb3VuZHMubGVmdCkgLSAxfXB4YDsKKyAgICAgICAgY292ZXJSZXN1bHRzLnN0eWxlLnRvcCA9 IGAke01hdGgucm91bmQocmVzdWx0c0J1dHRvbkJvdW5kcy50b3ApIC0gMX1weGA7CisgICAgICAg IGNvdmVyUmVzdWx0cy5zdHlsZS53aWR0aCA9IGAke01hdGgucm91bmQocmVzdWx0c0J1dHRvbkJv dW5kcy53aWR0aCkgKyAyfXB4YDsKKyAgICAgICAgY292ZXJSZXN1bHRzLnN0eWxlLmhlaWdodCA9 IGAke01hdGgucm91bmQocmVzdWx0c0J1dHRvbkJvdW5kcy5oZWlnaHQpICsgMn1weGA7CisgICAg fQorICAgIDwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoLWZpZWxkLWJ1 dHRvbnMtZG8tbm90LWhhdmUtZm9jdXMtcmluZ3MuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvc2VhcmNoLWZpZWxkLWJ1dHRvbnMtZG8tbm90LWhhdmUtZm9jdXMtcmluZ3MuaHRtbAppbmRl eCA0ODU5OWVkZDRhZDJiZDEzZDQ1ZmQ4ZDliMmIyNDA3MTRlOGM4ZmNlLi5mZGFlODhhOTM4ZDNh YmFjNzRlMGQ1ZDk2OTExY2Q0YzBhYjcxY2MyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL3NlYXJjaC1maWVsZC1idXR0b25zLWRvLW5vdC1oYXZlLWZvY3VzLXJpbmdzLmh0bWwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtZmllbGQtYnV0dG9ucy1kby1ub3Qt aGF2ZS1mb2N1cy1yaW5ncy5odG1sCkBAIC03LDcgKzcsNiBAQAogICAgICAgICAgICAgcG9zaXRp b246IGFic29sdXRlOwogICAgICAgICAgICAgdG9wOiAwOwogICAgICAgICAgICAgbGVmdDogMDsK LSAgICAgICAgICAgIHpvb206IDEuNDsKICAgICAgICAgICAgIC13ZWJraXQtYXBwZWFyYW5jZTog bm9uZTsKICAgICAgICAgfQogCkBAIC0xNiwxOCArMTUsOCBAQAogICAgICAgICAgICAgYmFja2dy b3VuZC1jb2xvcjogd2hpdGU7CiAgICAgICAgIH0KIAotICAgICAgICAjY292ZXItcmVzdWx0cyB7 Ci0gICAgICAgICAgICB0b3A6IDEwcHg7Ci0gICAgICAgICAgICBsZWZ0OiA0cHg7Ci0gICAgICAg ICAgICB3aWR0aDogMjhweDsKLSAgICAgICAgICAgIGhlaWdodDogMjJweDsKLSAgICAgICAgfQot Ci0gICAgICAgICNjb3Zlci1jYW5jZWwgewotICAgICAgICAgICAgdG9wOiAxMHB4OwotICAgICAg ICAgICAgbGVmdDogMzE2cHg7Ci0gICAgICAgICAgICB3aWR0aDogMjhweDsKLSAgICAgICAgICAg IGhlaWdodDogMjRweDsKKyAgICAgICAgcCB7CisgICAgICAgICAgICBtYXJnaW4tdG9wOiAxMDBw eDsKICAgICAgICAgfQogICAgIDwvc3R5bGU+CiA8L2hlYWQ+CkBAIC0zNSw1ICsyNCwyNSBAQAog ICAgIDxpbnB1dCB0eXBlPSJzZWFyY2giIHJlc3VsdHM9IjUiIHZhbHVlPSJmb28iIGF1dG9mb2N1 cz48L2lucHV0PgogICAgIDxkaXYgaWQ9ImNvdmVyLXJlc3VsdHMiPjwvZGl2PgogICAgIDxkaXYg aWQ9ImNvdmVyLWNhbmNlbCI+PC9kaXY+CisgICAgPHA+VGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQg dGhlIHNlYXJjaCBhbmQgcmVzdWx0cyBidXR0b25zIGluIGEgc2VhcmNoIGZpZWxkIGRvIG5vdCBl YWNoIGRyYXcgdGhlaXIgb3duIGZvY3VzIHJpbmdzLiBUaGlzIHRlc3QgbXVzdCBiZSBydW4gdW5k ZXIgV2ViS2l0VGVzdFJ1bm5lciBvciBEdW1wUmVuZGVyVHJlZS48L3A+CisgICAgPHNjcmlwdD4K KyAgICBpZiAod2luZG93LmludGVybmFscykgeworICAgICAgICBjb25zdCBzZWFyY2ggPSBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yKCJpbnB1dFt0eXBlPXNlYXJjaF0iKTsKKworICAgICAgICBjb25z dCBjb3ZlckNhbmNlbCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoIiNjb3Zlci1jYW5jZWwiKTsK KyAgICAgICAgY29uc3QgY2FuY2VsQnV0dG9uQm91bmRzID0gaW50ZXJuYWxzLnNoYWRvd1Jvb3Qo c2VhcmNoKS5xdWVyeVNlbGVjdG9yKCJkaXZbcHNldWRvPSctd2Via2l0LXNlYXJjaC1jYW5jZWwt YnV0dG9uJ10iKS5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKTsKKyAgICAgICAgY292ZXJDYW5jZWwu c3R5bGUubGVmdCA9IGAke01hdGgucm91bmQoY2FuY2VsQnV0dG9uQm91bmRzLmxlZnQpIC0gMX1w eGA7CisgICAgICAgIGNvdmVyQ2FuY2VsLnN0eWxlLnRvcCA9IGAke01hdGgucm91bmQoY2FuY2Vs QnV0dG9uQm91bmRzLnRvcCkgLSAxfXB4YDsKKyAgICAgICAgY292ZXJDYW5jZWwuc3R5bGUud2lk dGggPSBgJHtNYXRoLnJvdW5kKGNhbmNlbEJ1dHRvbkJvdW5kcy53aWR0aCkgKyAyfXB4YDsKKyAg ICAgICAgY292ZXJDYW5jZWwuc3R5bGUuaGVpZ2h0ID0gYCR7TWF0aC5yb3VuZChjYW5jZWxCdXR0 b25Cb3VuZHMuaGVpZ2h0KSArIDJ9cHhgOworCisgICAgICAgIGNvbnN0IGNvdmVyUmVzdWx0cyA9 IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoIiNjb3Zlci1yZXN1bHRzIik7CisgICAgICAgIGNvbnN0 IHJlc3VsdHNCdXR0b25Cb3VuZHMgPSBpbnRlcm5hbHMuc2hhZG93Um9vdChzZWFyY2gpLnF1ZXJ5 U2VsZWN0b3IoImRpdltwc2V1ZG89Jy13ZWJraXQtc2VhcmNoLXJlc3VsdHMtYnV0dG9uJ10iKS5n ZXRCb3VuZGluZ0NsaWVudFJlY3QoKTsKKyAgICAgICAgY292ZXJSZXN1bHRzLnN0eWxlLmxlZnQg PSBgJHtNYXRoLnJvdW5kKHJlc3VsdHNCdXR0b25Cb3VuZHMubGVmdCkgLSAxfXB4YDsKKyAgICAg ICAgY292ZXJSZXN1bHRzLnN0eWxlLnRvcCA9IGAke01hdGgucm91bmQocmVzdWx0c0J1dHRvbkJv dW5kcy50b3ApIC0gMX1weGA7CisgICAgICAgIGNvdmVyUmVzdWx0cy5zdHlsZS53aWR0aCA9IGAk e01hdGgucm91bmQocmVzdWx0c0J1dHRvbkJvdW5kcy53aWR0aCkgKyAyfXB4YDsKKyAgICAgICAg Y292ZXJSZXN1bHRzLnN0eWxlLmhlaWdodCA9IGAke01hdGgucm91bmQocmVzdWx0c0J1dHRvbkJv dW5kcy5oZWlnaHQpICsgMn1weGA7CisgICAgfQorICAgIDwvc2NyaXB0PgogPC9ib2R5PgogPC9o dG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2lu L1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNjNjMGZiMjM2OWY2MzBmMjdiMzBkOTlhZTBiMmVhOGM4 NTUwNzljZS4uZjhiYmI3YjM1ZDQ1OTZkMDIxOThiODU2MWFmYmIyZGRlZmM0MWYyZCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTIxNjUsOCArMjE2NSw2 IEBAIHdlYmtpdC5vcmcvYi8xNDA4NjUgZmFzdC9mb3Jtcy90ZXh0YXJlYS1wbGFjZWhvbGRlci1z ZXQtYXR0cmlidXRlLmh0bWwgWyBQYXNzIEltCiAjIFRpbnkgaW1hZ2Utb25seSBkaWZmZXJlbmNl CiBmYXN0L3RleHQvYmFzZWxpbmUtaW5saW5lLWJsb2NrLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJl IF0KIAotd2Via2l0Lm9yZy9iLzIxMzQyMiBmYXN0L2Zvcm1zL3NlYXJjaC1maWVsZC1idXR0b25z LWRvLW5vdC1oYXZlLWZvY3VzLXJpbmdzLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLQogIyBu ZXcgdGltZW91dHMsIG5lZWQgYnVnIHJlcG9ydHMKIGZhc3QvZm9ybXMvYnV0dG9uLXN0YXRlLXJl c3RvcmUuaHRtbCBbIFNraXAgXQogZmFzdC9mb3Jtcy9yYWRpby9zdGF0ZS1yZXN0b3JlLXJhZGlv LWdyb3VwLmh0bWwgWyBTa2lwIF0K