213413 2020-06-19 16:11:24 -0700 REGRESSION (r263253): Search field results and cancel buttons have their own focus rings 2020-06-19 17:50:48 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh cdumez changseok dougk esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1664588 0 wenson_hsieh 2020-06-19 16:11:24 -0700 SSIA 1664589 1 webkit-bug-importer 2020-06-19 16:11:51 -0700 <rdar://problem/64548419> 1664613 2 402348 wenson_hsieh 2020-06-19 16:50:20 -0700 Created attachment 402348 Patch 1664654 3 wenson_hsieh 2020-06-19 17:43:45 -0700 Committed r263303: <https://trac.webkit.org/changeset/263303> 1664657 4 wenson_hsieh 2020-06-19 17:50:48 -0700 I fixed the macOS failures in the new version of the patch, but it looks like the test might need to be further adjusted to make it work on windows too, where it's not covering the search and cancel buttons as intended :( I'll track this in <https://bugs.webkit.org/show_bug.cgi?id=213422>... 402348 2020-06-19 16:50:20 -0700 2020-06-19 17:01:15 -0700 Patch bug-213413-20200619165019.patch text/plain 6642 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjBjZTZhOGM2OWM0NDRj MWQ0YzQ0ZWMwNWVhZGVmZDlhMDkwMWUxNy4uYzAyODI1MmFmMzBlMDk0OWY0MTJlMzkzMjQ2ZmMx NzM0OWRkNTFjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA2LTE5ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyNjMyNTMpOiBTZWFyY2ggZmllbGQgcmVzdWx0cyBhbmQgY2FuY2VsIGJ1dHRvbnMgaGF2ZSB0 aGVpciBvd24gZm9jdXMgcmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMzQxMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQ1NDg0MTk+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWZ0ZXIgcjI2 MzI1MywgYHBhaW50Q2VsbEFuZFNldEZvY3VzZWRFbGVtZW50TmVlZHNSZXBhaW50SWZOZWNlc3Nh cnlgIGlzIHVzZWQgd2hlbiBwYWludGluZyB0aGUgYnV0dG9ucyBpbiBhCisgICAgICAgIHNlYXJj aCBmaWVsZCdzIHNoYWRvdyByb290LiBIb3dldmVyLCB0aGUgcmVuZGVyZXIgdGhhdCBpcyBwYXNz ZWQgaW4gKHdoaWNoIGlzIHVzZWQgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgd2UKKyAgICAgICAgc2hv dWxkIGFkZGl0aW9uYWxseSBkcmF3IGZvY3VzIHJpbmdzKSBpcyB0aGUgaW5wdXQgZWxlbWVudCdz IHJlbmRlcmVyIHJhdGhlciB0aGFuIHRoZSByZW5kZXJlcnMgb2YgdGhlIHJlc3VsdHMKKyAgICAg ICAgYW5kIGNhbmNlbCBidXR0b25zIHRoZW1zZWx2ZXMuIFRoaXMgbWVhbnMgdGhhdCB3aGVuIHRo ZSBzZWFyY2ggZmllbGQgaXMgZm9jdXNlZCwgd2Ugd2lsbCBkcmF3IGZvY3VzIHJpbmdzIGFyb3Vu ZAorICAgICAgICBlYWNoIG9mIHRoZSBidXR0b25zIGluIHRoZSBzaGFkb3cgcm9vdCBhcyB3ZWxs LgorCisgICAgICAgIEFkZHJlc3MgdGhpcyBieSB1c2luZyBgYm94YCAodGhlIGJ1dHRvbnMnIFJl bmRlckJveGVzKSBpbnN0ZWFkLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvc2VhcmNoLWZp ZWxkLWJ1dHRvbnMtZG8tbm90LWhhdmUtZm9jdXMtcmluZ3MuaHRtbAorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVN YWM6OnBhaW50U2VhcmNoRmllbGRDYW5jZWxCdXR0b24pOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyVGhlbWVNYWM6OnBhaW50U2VhcmNoRmllbGRSZXN1bHRzQnV0dG9uKToKKwogMjAyMC0wNi0x OSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFj T1NdIE1vdmUgcHJvZ3Jlc3MgYmFyIHBhaW50aW5nIGNvZGUgb2ZmIG9mIENhcmJvbiBBUEkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbSBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQppbmRleCAyZjRiZmEzMmJj ODBmY2ZhYWFhZjQ0N2UzMzA2YWNlZDQ1Mzc0MWFlLi45ZDg5MWViZWRjYjM2YzUzZTdhZWQ3YjQ5 YjZlMDRiOTZhNWQyYTQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l TWFjLm1tCkBAIC0yMDM3LDcgKzIwMzcsNyBAQCBib29sIFJlbmRlclRoZW1lTWFjOjpwYWludFNl YXJjaEZpZWxkQ2FuY2VsQnV0dG9uKGNvbnN0IFJlbmRlckJveCYgYm94LCBjb25zdCBQYQogICAg ICAgICBwYWludEluZm8uY29udGV4dCgpLnNjYWxlKHpvb21MZXZlbCk7CiAgICAgICAgIHBhaW50 SW5mby5jb250ZXh0KCkudHJhbnNsYXRlKC11bnpvb21lZFJlY3QubG9jYXRpb24oKSk7CiAgICAg fQotICAgIHBhaW50Q2VsbEFuZFNldEZvY3VzZWRFbGVtZW50TmVlZHNSZXBhaW50SWZOZWNlc3Nh cnkoW3NlYXJjaCBjYW5jZWxCdXR0b25DZWxsXSwgaW5wdXRCb3gsIHBhaW50SW5mbywgdW56b29t ZWRSZWN0KTsKKyAgICBwYWludENlbGxBbmRTZXRGb2N1c2VkRWxlbWVudE5lZWRzUmVwYWludElm TmVjZXNzYXJ5KFtzZWFyY2ggY2FuY2VsQnV0dG9uQ2VsbF0sIGJveCwgcGFpbnRJbmZvLCB1bnpv b21lZFJlY3QpOwogICAgIFtbc2VhcmNoIGNhbmNlbEJ1dHRvbkNlbGxdIHNldENvbnRyb2xWaWV3 Om5pbF07CiAgICAgcmV0dXJuIGZhbHNlOwogfQpAQCAtMjE3Myw3ICsyMTczLDcgQEAgYm9vbCBS ZW5kZXJUaGVtZU1hYzo6cGFpbnRTZWFyY2hGaWVsZFJlc3VsdHNCdXR0b24oY29uc3QgUmVuZGVy Qm94JiBib3gsIGNvbnN0IFAKICAgICAgICAgcGFpbnRJbmZvLmNvbnRleHQoKS50cmFuc2xhdGUo LXVuem9vbWVkUmVjdC5sb2NhdGlvbigpKTsKICAgICB9CiAKLSAgICBwYWludENlbGxBbmRTZXRG b2N1c2VkRWxlbWVudE5lZWRzUmVwYWludElmTmVjZXNzYXJ5KFtzZWFyY2ggc2VhcmNoQnV0dG9u Q2VsbF0sIGlucHV0Qm94LCBwYWludEluZm8sIHVuem9vbWVkUmVjdCk7CisgICAgcGFpbnRDZWxs QW5kU2V0Rm9jdXNlZEVsZW1lbnROZWVkc1JlcGFpbnRJZk5lY2Vzc2FyeShbc2VhcmNoIHNlYXJj aEJ1dHRvbkNlbGxdLCBib3gsIHBhaW50SW5mbywgdW56b29tZWRSZWN0KTsKICAgICBbW3NlYXJj aCBzZWFyY2hCdXR0b25DZWxsXSBzZXRDb250cm9sVmlldzpuaWxdOwogCiAgICAgcmV0dXJuIGZh bHNlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IGIzYzI2ODY4Yjg5NDFhOGEwY2EyMzAxY2UzMTUxYWYwNmEyNzJjNzMuLjc1 YzNhOTQyNGQ5YTliODllMTJjNGYxODZhNzhlYWFkZDliNzEyNjIgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx OCBAQAorMjAyMC0wNi0xOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4K KworICAgICAgICBSRUdSRVNTSU9OIChyMjYzMjUzKTogU2VhcmNoIGZpZWxkIHJlc3VsdHMgYW5k IGNhbmNlbCBidXR0b25zIGhhdmUgdGhlaXIgb3duIGZvY3VzIHJpbmdzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM0MTMKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzY0NTQ4NDE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZCBhIHJlZiB0ZXN0IHRvIHZlcmlmeSB0aGF0IHRoZSBzZWFyY2ggYW5k IGNhbmNlbCBidXR0b25zIGRvbid0IGRyYXcgaW5kaXZpZHVhbCBmb2N1cyByaW5ncy4gVGhpcyB0 ZXN0IHdvcmtzCisgICAgICAgIGJ5IHZlcmlmeWluZyB0aGF0IG5vIGZvY3VzIHJpbmcgYXJvdW5k IGVpdGhlciB0aGUgY2FuY2VsIG9yIHJlc3VsdHMgYnV0dG9uIGJsZWVkcyBvdXRzaWRlIG9mIHRo ZSBib3VuZHMgb2YgYSBkaXYKKyAgICAgICAgdGhhdCBvYnNjdXJlcyB0aGUgYnV0dG9ucy4KKwor ICAgICAgICAqIGZhc3QvZm9ybXMvc2VhcmNoLWZpZWxkLWJ1dHRvbnMtZG8tbm90LWhhdmUtZm9j dXMtcmluZ3MtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9zZWFy Y2gtZmllbGQtYnV0dG9ucy1kby1ub3QtaGF2ZS1mb2N1cy1yaW5ncy5odG1sOiBBZGRlZC4KKwog MjAyMC0wNi0xMCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIyNjIyNTQ/KTogW1dQRV0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy93ZWJ4ci9pZGxoYXJuZXNzLmh0dHBzLndpbmRvdy5odG1sIGlzIGZhaWxpbmcK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoLWZpZWxkLWJ1dHRvbnMt ZG8tbm90LWhhdmUtZm9jdXMtcmluZ3MtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvc2VhcmNoLWZpZWxkLWJ1dHRvbnMtZG8tbm90LWhhdmUtZm9jdXMtcmluZ3MtZXhwZWN0 ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi43NjQxMmIyZGI2MWY2M2UyNWQwYzBmOGRjODE3MmM1OTg5YTgz M2Y1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtZmll bGQtYnV0dG9ucy1kby1ub3QtaGF2ZS1mb2N1cy1yaW5ncy1leHBlY3RlZC5odG1sCkBAIC0wLDAg KzEsNDMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5bGU+Cisg ICAgICAgIGlucHV0W3R5cGU9InNlYXJjaCJdOjotd2Via2l0LXNlYXJjaC1yZXN1bHRzLWJ1dHRv biwgaW5wdXRbdHlwZT0ic2VhcmNoIl06Oi13ZWJraXQtc2VhcmNoLWNhbmNlbC1idXR0b24gewor ICAgICAgICAgICAgb3BhY2l0eTogMDsKKyAgICAgICAgfQorCisgICAgICAgIGlucHV0W3R5cGU9 InNlYXJjaCJdIHsKKyAgICAgICAgICAgIGZvbnQtc2l6ZTogMTZweDsKKyAgICAgICAgICAgIHBv c2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgICAgIHRvcDogMDsKKyAgICAgICAgICAgIGxlZnQ6 IDA7CisgICAgICAgICAgICB6b29tOiAxLjQ7CisgICAgICAgICAgICAtd2Via2l0LWFwcGVhcmFu Y2U6IG5vbmU7CisgICAgICAgIH0KKworICAgICAgICBkaXYgeworICAgICAgICAgICAgcG9zaXRp b246IGFic29sdXRlOworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogd2hpdGU7CisgICAg ICAgIH0KKworICAgICAgICAjY292ZXItcmVzdWx0cyB7CisgICAgICAgICAgICB0b3A6IDEwcHg7 CisgICAgICAgICAgICBsZWZ0OiA4cHg7CisgICAgICAgICAgICB3aWR0aDogMjBweDsKKyAgICAg ICAgICAgIGhlaWdodDogMjJweDsKKyAgICAgICAgfQorCisgICAgICAgICNjb3Zlci1jYW5jZWwg eworICAgICAgICAgICAgdG9wOiAxMHB4OworICAgICAgICAgICAgbGVmdDogMzE2cHg7CisgICAg ICAgICAgICB3aWR0aDogMjRweDsKKyAgICAgICAgICAgIGhlaWdodDogMjRweDsKKyAgICAgICAg fQorICAgIDwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8aW5wdXQgdHlwZT0ic2VhcmNo IiByZXN1bHRzPSI1IiB2YWx1ZT0iZm9vIiBhdXRvZm9jdXM+PC9pbnB1dD4KKyAgICA8ZGl2IGlk PSJjb3Zlci1yZXN1bHRzIj48L2Rpdj4KKyAgICA8ZGl2IGlkPSJjb3Zlci1jYW5jZWwiPjwvZGl2 PgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoLWZpZWxkLWJ1dHRvbnMtZG8tbm90LWhh dmUtZm9jdXMtcmluZ3MuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoLWZpZWxk LWJ1dHRvbnMtZG8tbm90LWhhdmUtZm9jdXMtcmluZ3MuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44NzVkZjlk YmI2YzI1NmYyNTkzOWQ1ZWNiODFlNGY4MmViOGE1M2Y2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtZmllbGQtYnV0dG9ucy1kby1ub3QtaGF2ZS1mb2N1 cy1yaW5ncy5odG1sCkBAIC0wLDAgKzEsMzkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8 aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICAgIGlucHV0W3R5cGU9InNlYXJjaCJdIHsKKyAgICAg ICAgICAgIGZvbnQtc2l6ZTogMTZweDsKKyAgICAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsK KyAgICAgICAgICAgIHRvcDogMDsKKyAgICAgICAgICAgIGxlZnQ6IDA7CisgICAgICAgICAgICB6 b29tOiAxLjQ7CisgICAgICAgICAgICAtd2Via2l0LWFwcGVhcmFuY2U6IG5vbmU7CisgICAgICAg IH0KKworICAgICAgICBkaXYgeworICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAg ICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogd2hpdGU7CisgICAgICAgIH0KKworICAgICAgICAj Y292ZXItcmVzdWx0cyB7CisgICAgICAgICAgICB0b3A6IDEwcHg7CisgICAgICAgICAgICBsZWZ0 OiA4cHg7CisgICAgICAgICAgICB3aWR0aDogMjBweDsKKyAgICAgICAgICAgIGhlaWdodDogMjJw eDsKKyAgICAgICAgfQorCisgICAgICAgICNjb3Zlci1jYW5jZWwgeworICAgICAgICAgICAgdG9w OiAxMHB4OworICAgICAgICAgICAgbGVmdDogMzE2cHg7CisgICAgICAgICAgICB3aWR0aDogMjRw eDsKKyAgICAgICAgICAgIGhlaWdodDogMjRweDsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+Cis8 L2hlYWQ+Cis8Ym9keT4KKyAgICA8aW5wdXQgdHlwZT0ic2VhcmNoIiByZXN1bHRzPSI1IiB2YWx1 ZT0iZm9vIiBhdXRvZm9jdXM+PC9pbnB1dD4KKyAgICA8ZGl2IGlkPSJjb3Zlci1yZXN1bHRzIj48 L2Rpdj4KKyAgICA8ZGl2IGlkPSJjb3Zlci1jYW5jZWwiPjwvZGl2PgorPC9ib2R5PgorPC9odG1s PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK