213399 2020-06-19 12:38:08 -0700 [WPE][GTK] Add autocleanup for WebKitWebsitePolicies 2020-06-21 02:11:10 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply cgarcia cturner ews-watchlist gustavo mcatanzaro oldest_to_newest 1664458 0 mcatanzaro 2020-06-19 12:38:08 -0700 We forgot to add an autocleanup for WebKitWebsitePolicies. If we were to switch to G_DECLARE_[FINAL,DERIVABLE]_TYPE for the GTK 4 API, then we wouldn't have to remember to do these manually anymore. ;) 1664459 1 402306 mcatanzaro 2020-06-19 12:39:27 -0700 Created attachment 402306 Patch 1664460 2 ews-watchlist 2020-06-19 12:40:05 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1664480 3 cturner 2020-06-19 13:17:13 -0700 LGTM (not a formal reviewer sadly). Thanks for taking care of it! 1664830 4 402306 cgarcia 2020-06-21 02:08:23 -0700 Comment on attachment 402306 Patch I always forget autoclean. Thanks! 1664831 5 ews-feeder 2020-06-21 02:11:08 -0700 Committed r263325: <https://trac.webkit.org/changeset/263325> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402306. 402306 2020-06-19 12:39:27 -0700 2020-06-21 02:11:09 -0700 Patch bug-213399-20200619143926.patch text/plain 2482 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcxYzZkNzYxNjA5NDJlZmUx ZjRjNjNmMThiN2FmMWY3OWRmNzBmOWYuLmNlMzRhYmY3ODJiMGI3ZGJkMTNhMmJiMzk5MWE0MjIx M2YwOWFiZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDYtMTkgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW1dQRV1bR1RLXSBB ZGQgYXV0b2NsZWFudXAgZm9yIFdlYktpdFdlYnNpdGVQb2xpY2llcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMzk5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgYXV0b2NsZWFudXBz LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0b2NsZWFudXBzLmg6Cisg ICAgICAgICogVUlQcm9jZXNzL0FQSS93cGUvV2ViS2l0QXV0b2NsZWFudXBzLmg6CisKIDIwMjAt MDYtMTkgIEFsZXhhbmRlciBNaWtoYXlsZW5rbyAgPGFsZXhtQGdub21lLm9yZz4KIAogICAgICAg ICBSRUdSRVNTSU9OKHIyNTMzNjApOiBbR1RLXSBQYWdlIHN0YXJ0cyBsb2FkaW5nIGR1cmluZyBh bmltYXRpb24gaW4gYmFjay9mb3J3YXJkIGdlc3R1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0b2NsZWFudXBzLmggYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dG9jbGVhbnVwcy5oCmluZGV4IGQwODNjMTMzNDM2 YjBhNjYyNGE4ZjZlZjI4ZjQ1ZDE2YTAyOTIyMjAuLjJkYjg0ZTk5MTU0MDVhOGM1NDFhMWFmYWY5 YmRiZDdmYTAxNWM0YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0QXV0b2NsZWFudXBzLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRBdXRvY2xlYW51cHMuaApAQCAtNzAsNiArNzAsNyBAQCBHX0RFRklORV9BVVRP UFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2ViSW5zcGVjdG9yLCBnX29iamVjdF91bnJlZikKIEdf REVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRXZWJSZXNvdXJjZSwgZ19vYmplY3Rf dW5yZWYpCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2ViVmlldywgZ19v YmplY3RfdW5yZWYpCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2Vic2l0 ZURhdGFNYW5hZ2VyLCBnX29iamVjdF91bnJlZikKK0dfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9G VU5DIChXZWJLaXRXZWJzaXRlUG9saWNpZXMsIGdfb2JqZWN0X3VucmVmKQogR19ERUZJTkVfQVVU T1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdFdpbmRvd1Byb3BlcnRpZXMsIGdfb2JqZWN0X3VucmVm KQogCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0QXBwbGljYXRpb25JbmZv LCB3ZWJraXRfYXBwbGljYXRpb25faW5mb191bnJlZikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS93cGUvV2ViS2l0QXV0b2NsZWFudXBzLmggYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdEF1dG9jbGVhbnVwcy5oCmluZGV4IGMyODljZGM1YTcz N2NmOGQ4ZjFlMDE5NjE1NDJmNDJhYjBlOTBjNTUuLjQzNDkyMDc5YzlkMzU4YzMyOTg2YjkzZWFi MTk0ZDhhNGYzODc3ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93 cGUvV2ViS2l0QXV0b2NsZWFudXBzLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L3dwZS9XZWJLaXRBdXRvY2xlYW51cHMuaApAQCAtNjQsNiArNjQsNyBAQCBHX0RFRklORV9BVVRP UFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2ViQ29udGV4dCwgZ19vYmplY3RfdW5yZWYpCiBHX0RF RklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2ViUmVzb3VyY2UsIGdfb2JqZWN0X3Vu cmVmKQogR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdFdlYlZpZXcsIGdfb2Jq ZWN0X3VucmVmKQogR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdFdlYnNpdGVE YXRhTWFuYWdlciwgZ19vYmplY3RfdW5yZWYpCitHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVO QyAoV2ViS2l0V2Vic2l0ZVBvbGljaWVzLCBnX29iamVjdF91bnJlZikKIEdfREVGSU5FX0FVVE9Q VFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRXaW5kb3dQcm9wZXJ0aWVzLCBnX29iamVjdF91bnJlZikK IAogR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdEFwcGxpY2F0aW9uSW5mbywg d2Via2l0X2FwcGxpY2F0aW9uX2luZm9fdW5yZWYpCg==