213382 2020-06-19 09:21:18 -0700 [ews] commit-queue should comment on bug if it fails to get contributors information 2020-06-29 09:06:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED WORKSFORME https://bugs.webkit.org/show_bug.cgi?id=213377 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard oldest_to_newest 1664386 0 aakash_jain 2020-06-19 09:21:18 -0700 commit-queue should comment on bug and set cq- flag if it fails to get contributors information (and fails to commit because of that). This is so that people can easily notice that commit-queue failed, and take necessary action. However, the chances of commit-queue hitting this issue (of failing to get contributors information) is almost zero after the improvement in Bug 213377. 1664390 1 402291 aakash_jain 2020-06-19 09:24:04 -0700 Created attachment 402291 Patch 1664397 2 402291 ap 2020-06-19 09:42:52 -0700 Comment on attachment 402291 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402291&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:758 > + self.setProperty('bugzilla_comment_text', 'commit-queue failed to get contributors information, please cq+ patch again.') It is very useful to have specific guidance about what the person needs to do. This one doesn't sound right to me - if the action were to simply mark as cq+ again, we wouldn't need to mark as cq-. Also, this information is noise to everyone except for the person who has set cq+ originally. So I think that two things need to change: 1. Make the guidance accurate (the whole reason to do this is to have people reach out to admins, so we should advise on how to do this). 2. Make it private (e-mail, and don't change cq+ to cq-). Looking at these together, I'm beginning to think that the right action is to notify admins directly, not to ask contributors to do it. 1664405 3 jbedard 2020-06-19 10:05:33 -0700 (In reply to Aakash Jain from comment #0) > commit-queue should comment on bug and set cq- flag if it fails to get > contributors information (and fails to commit because of that). This is so > that people can easily notice that commit-queue failed, and take necessary > action. > > However, the chances of commit-queue hitting this issue (of failing to get > contributors information) is almost zero after the improvement in Bug 213377. I feel like if we manage to hit this issue with the fix from bug 213377, infrastructure is so far broken that there is nothing anyone except for an admin could do to help. 1667120 4 aakash_jain 2020-06-29 09:06:45 -0700 As noted above, the chances of hitting is extremely low (since local file reading should pretty much work). And if we hit this scenario, infrastructure is too much broken already. It's probably not worth to spend more time in trying to improve automatic handling of this rare scenario. Developing mechanism for notifying admins would be done in Bug 207475. 402291 2020-06-19 09:24:04 -0700 2020-06-19 09:42:52 -0700 Patch bug-213382-20200619122402.patch text/plain 3005 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MzI3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA2LTE5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjb21taXQtcXVldWUgc2hvdWxkIGNvbW1lbnQgb24gYnVnIGlm IGl0IGZhaWxzIHRvIGdldCBjb250cmlidXRvcnMgaW5mb3JtYXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzM4MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoVmFsaWRhdGVDb21taXRlckFuZFJldmlld2VyLnN0 YXJ0KToKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRl c3QucHk6IEFkZGVkIHVuaXQtdGVzdC4KKwogMjAyMC0wNi0xOSAgQWFrYXNoIEphaW4gIDxhYWth c2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wcm92ZSBoYW5kbGluZyBvZiB0cmFjIGRv d250aW1lIGJ5IGNvbW1pdC1xdWV1ZQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjYzMjY4KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03NTUsNiArNzU1LDkg QEAgY2xhc3MgVmFsaWRhdGVDb21taXRlckFuZFJldmlld2VyKGJ1aWxkcwogICAgICAgICBpZiBu b3Qgc2VsZi5jb250cmlidXRvcnM6CiAgICAgICAgICAgICBzZWxmLmZpbmlzaGVkKEZBSUxVUkUp CiAgICAgICAgICAgICBzZWxmLmRlc2NyaXB0aW9uRG9uZSA9ICdGYWlsZWQgdG8gZ2V0IGNvbnRy aWJ1dG9ycyBpbmZvcm1hdGlvbicKKyAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1Z3pp bGxhX2NvbW1lbnRfdGV4dCcsICdjb21taXQtcXVldWUgZmFpbGVkIHRvIGdldCBjb250cmlidXRv cnMgaW5mb3JtYXRpb24sIHBsZWFzZSBjcSsgcGF0Y2ggYWdhaW4uJykKKyAgICAgICAgICAgIHNl bGYuc2V0UHJvcGVydHkoJ2J1aWxkX2ZpbmlzaF9zdW1tYXJ5Jywgc2VsZi5kZXNjcmlwdGlvbkRv bmUpCisgICAgICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0ZXJDdXJyZW50U3RlcChbQ29t bWVudE9uQnVnKCksIFNldENvbW1pdFF1ZXVlTWludXNGbGFnT25QYXRjaCgpXSkKICAgICAgICAg ICAgIHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbJ0ZhaWxlZCB0byBnZXQgY29udHJpYnV0b3Jz IGluZm9ybWF0aW9uJ10sIEZBSUxVUkUpCiAgICAgICAgICAgICByZXR1cm4gTm9uZQogICAgICAg ICBwYXRjaF9jb21taXR0ZXIgPSBzZWxmLmdldFByb3BlcnR5KCdwYXRjaF9jb21taXR0ZXInLCAn JykubG93ZXIoKQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjYzMjY4KQorKysgVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBA IC0zNDI2LDYgKzM0MjYsMTYgQEAgY2xhc3MgVGVzdFZhbGlkYXRlQ29tbWl0ZXJBbmRSZXZpZXdl cihCdQogICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0 cmluZz0nY29tbWl0dGVyQHdlYmtpdC5vcmcgZG9lcyBub3QgaGF2ZSByZXZpZXdlciBwZXJtaXNz aW9ucycpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCisgICAgZGVmIHRlc3RfZmFp bHVyZV91bmFibGVfdG9fbG9hZF9jb250cmlidXRvcnMoc2VsZik6CisgICAgICAgIHNlbGYuc2V0 dXBTdGVwKFZhbGlkYXRlQ29tbWl0ZXJBbmRSZXZpZXdlcigpKQorICAgICAgICBWYWxpZGF0ZUNv bW1pdGVyQW5kUmV2aWV3ZXIubG9hZF9jb250cmlidXRvcnMgPSBsYW1iZGEgY2xzOiB7fQorICAg ICAgICBzZWxmLmV4cGVjdEhpZGRlbihGYWxzZSkKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21l KHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J0ZhaWxlZCB0byBnZXQgY29udHJpYnV0b3Jz IGluZm9ybWF0aW9uJykKKyAgICAgICAgcmMgPSBzZWxmLnJ1blN0ZXAoKQorICAgICAgICBzZWxm LmFzc2VydEVxdWFsKHNlbGYuZ2V0UHJvcGVydHkoJ2J1Z3ppbGxhX2NvbW1lbnRfdGV4dCcpLCAn Y29tbWl0LXF1ZXVlIGZhaWxlZCB0byBnZXQgY29udHJpYnV0b3JzIGluZm9ybWF0aW9uLCBwbGVh c2UgY3ErIHBhdGNoIGFnYWluLicpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5nZXRQ cm9wZXJ0eSgnYnVpbGRfZmluaXNoX3N1bW1hcnknKSwgJ0ZhaWxlZCB0byBnZXQgY29udHJpYnV0 b3JzIGluZm9ybWF0aW9uJykKKyAgICAgICAgcmV0dXJuIHJjCisKICAgICBkZWYgdGVzdF9sb2Fk X2NvbnRyaWJ1dG9yc19mcm9tX2Rpc2soc2VsZik6CiAgICAgICAgIFZhbGlkYXRlQ29tbWl0ZXJB bmRSZXZpZXdlci5fYWRkVG9Mb2cgPSBsYW1iZGEgY2xzLCBsb2d0eXBlLCBsb2c6IHN5cy5zdGRv dXQud3JpdGUobG9nKQogICAgICAgICBjb250cmlidXRvcnMgPSBWYWxpZGF0ZUNvbW1pdGVyQW5k UmV2aWV3ZXIoKS5sb2FkX2NvbnRyaWJ1dG9yc19mcm9tX2Rpc2soKQo=