213377 2020-06-19 07:46:11 -0700 Improve handling of trac downtime by commit-queue 2020-06-22 07:08:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=213382 https://bugs.webkit.org/show_bug.cgi?id=213457 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap cdumez clark_wang ddkilzer jbedard stephan.szabo vjaquez webkit-bug-importer wenson_hsieh ysuzuki zalan oldest_to_newest 1664354 0 aakash_jain 2020-06-19 07:46:11 -0700 We should improve the handling of trac downtime by commit-queue. Yesterday trac was down for some time. Meanwhile commit-queue failed to fetch commiters information from trac, and the commit-queue builds failed. e.g.: https://ews-build.webkit.org/#/builders/28/builds/2774 In such case, commit-queue should try to load the local copy of contributors.json from disk (local checkout). 1664356 1 402283 aakash_jain 2020-06-19 07:51:28 -0700 Created attachment 402283 Patch 1664357 2 aakash_jain 2020-06-19 07:53:50 -0700 cc'ed few people for visibility whose patches failed to land by commit-queue yesterday due to trac downtime. 1664366 3 ews-feeder 2020-06-19 08:31:15 -0700 Committed r263267: <https://trac.webkit.org/changeset/263267> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402283. 1664367 4 webkit-bug-importer 2020-06-19 08:32:52 -0700 <rdar://problem/64532488> 1664398 5 ap 2020-06-19 09:43:09 -0700 Good idea! 1664457 6 ysuzuki 2020-06-19 12:35:06 -0700 I have one suggestion: how about getting contributors.json from https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json instead of accessing through trac? It is not involving trac. So I noticed that the above URL was alive during trac is down. Several services are using the above URL, https://webkit.org/team and Tools/WKR slackbot. I think the above one is accessible so long as SVN server is alive, maybe more robust than trac...? 1664992 7 aakash_jain 2020-06-22 05:27:27 -0700 (In reply to Yusuke Suzuki from comment #6) > I have one suggestion: how about getting contributors.json from https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json instead of accessing through trac? Doing it in Bug 213457. 1665007 8 ysuzuki 2020-06-22 07:08:18 -0700 (In reply to Aakash Jain from comment #7) > (In reply to Yusuke Suzuki from comment #6) > > I have one suggestion: how about getting contributors.json from https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json instead of accessing through trac? > Doing it in Bug 213457. Nice! 402283 2020-06-19 07:51:28 -0700 2020-06-19 08:31:15 -0700 Patch bug-213377-20200619105127.patch text/plain 3717 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MzI2NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTA2LTE5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBJbXByb3ZlIGhhbmRsaW5nIG9mIHRyYWMgZG93bnRpbWUgYnkgY29tbWl0 LXF1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTMzNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weTogTG9hZCBjb250cmlidXRvcnMu anNvbiBmcm9tIGRpc2sgd2hlbiBsb2FkaW5nIGZyb20gdHJhYyBmYWlscy4KKyAgICAgICAgKFZh bGlkYXRlQ29tbWl0ZXJBbmRSZXZpZXdlci5sb2FkX2NvbnRyaWJ1dG9yc19mcm9tX2Rpc2spOgor ICAgICAgICAoVmFsaWRhdGVDb21taXRlckFuZFJldmlld2VyLmxvYWRfY29udHJpYnV0b3JzX2Zy b21fdHJhYyk6CisgICAgICAgIChWYWxpZGF0ZUNvbW1pdGVyQW5kUmV2aWV3ZXIubG9hZF9jb250 cmlidXRvcnMpOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191 bml0dGVzdC5weTogQWRkZWQgdW5pdC10ZXN0CisKIDIwMjAtMDYtMTkgIExhdXJvIE1vdXJhICA8 bG1vdXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gV2FybiBwb3RlbnRpYWwgaXNzdWVz IHdoZW4gY3JlYXRpbmcgV2luZG93Vmlld0JhY2tlbmQKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI2MzI2NSkKKysrIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtNjc4 LDE3ICs2NzgsMzIgQEAgY2xhc3MgVmFsaWRhdGVDb21taXRlckFuZFJldmlld2VyKGJ1aWxkcwog ICAgIHVybF90ZXh0ID0gJ3t9P2Zvcm1hdD10eHQnLmZvcm1hdCh1cmwpCiAgICAgY29udHJpYnV0 b3JzID0ge30KIAotICAgIGRlZiBsb2FkX2NvbnRyaWJ1dG9ycyhzZWxmKToKKyAgICBkZWYgbG9h ZF9jb250cmlidXRvcnNfZnJvbV9kaXNrKHNlbGYpOgorICAgICAgICBjd2QgPSBvcy5wYXRoLmFi c3BhdGgob3MucGF0aC5kaXJuYW1lKF9fZmlsZV9fKSkKKyAgICAgICAgdG9vbHNfZGlyX3BhdGgg PSBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5kaXJuYW1lKGN3ZCkpCisgICAgICAgIGNvbnRyaWJ1 dG9yc19wYXRoID0gb3MucGF0aC5qb2luKHRvb2xzX2Rpcl9wYXRoLCAnU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uJykKKyAgICAgICAgdHJ5OgorICAgICAg ICAgICAgcmV0dXJuIGpzb24ubG9hZChvcGVuKGNvbnRyaWJ1dG9yc19wYXRoKSkKKyAgICAgICAg ZXhjZXB0IEV4Y2VwdGlvbiBhcyBlOgorICAgICAgICAgICAgc2VsZi5fYWRkVG9Mb2coJ3N0ZGlv JywgJ0ZhaWxlZCB0byBsb2FkIHt9XG4nLmZvcm1hdChjb250cmlidXRvcnNfcGF0aCkpCisgICAg ICAgICAgICByZXR1cm4ge30KKworICAgIGRlZiBsb2FkX2NvbnRyaWJ1dG9yc19mcm9tX3RyYWMo c2VsZik6CiAgICAgICAgIHRyeToKICAgICAgICAgICAgIHJlc3BvbnNlID0gcmVxdWVzdHMuZ2V0 KHNlbGYudXJsX3RleHQpCiAgICAgICAgICAgICBpZiByZXNwb25zZS5zdGF0dXNfY29kZSAhPSAy MDA6CiAgICAgICAgICAgICAgICAgc2VsZi5fYWRkVG9Mb2coJ3N0ZGlvJywgJ0ZhaWxlZCB0byBh Y2Nlc3Mge30gd2l0aCBzdGF0dXMgY29kZToge31cbicuZm9ybWF0KHNlbGYudXJsX3RleHQsIHJl c3BvbnNlLnN0YXR1c19jb2RlKSkKICAgICAgICAgICAgICAgICByZXR1cm4ge30KKyAgICAgICAg ICAgIHJldHVybiByZXNwb25zZS5qc29uKCkKICAgICAgICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBl OgogICAgICAgICAgICAgc2VsZi5fYWRkVG9Mb2coJ3N0ZGlvJywgJ0ZhaWxlZCB0byBhY2Nlc3Mg e3VybH1cbicuZm9ybWF0KHVybD1zZWxmLnVybF90ZXh0KSkKICAgICAgICAgICAgIHJldHVybiB7 fQogCi0gICAgICAgIGNvbnRyaWJ1dG9yc19qc29uID0gcmVzcG9uc2UuanNvbigpCisgICAgZGVm IGxvYWRfY29udHJpYnV0b3JzKHNlbGYpOgorICAgICAgICBjb250cmlidXRvcnNfanNvbiA9IHNl bGYubG9hZF9jb250cmlidXRvcnNfZnJvbV90cmFjKCkKKyAgICAgICAgaWYgbm90IGNvbnRyaWJ1 dG9yc19qc29uOgorICAgICAgICAgICAgY29udHJpYnV0b3JzX2pzb24gPSBzZWxmLmxvYWRfY29u dHJpYnV0b3JzX2Zyb21fZGlzaygpCisKICAgICAgICAgY29udHJpYnV0b3JzID0ge30KICAgICAg ICAgZm9yIGtleSwgdmFsdWUgaW4gY29udHJpYnV0b3JzX2pzb24uaXRlcml0ZW1zKCk6CiAgICAg ICAgICAgICBlbWFpbHMgPSB2YWx1ZS5nZXQoJ2VtYWlscycpCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lv biAyNjMyNjUpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5p dHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTI0LDYgKzI0LDcgQEAgaW1wb3J0IGluc3BlY3QK IGltcG9ydCBvcGVyYXRvcgogaW1wb3J0IG9zCiBpbXBvcnQgc2h1dGlsCitpbXBvcnQgc3lzCiBp bXBvcnQgdGVtcGZpbGUKIAogZnJvbSBidWlsZGJvdC5wcm9jZXNzIGltcG9ydCByZW1vdGV0cmFu c2ZlcgpAQCAtMzQyNSw2ICszNDI2LDExIEBAIGNsYXNzIFRlc3RWYWxpZGF0ZUNvbW1pdGVyQW5k UmV2aWV3ZXIoQnUKICAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBz dGF0ZV9zdHJpbmc9J2NvbW1pdHRlckB3ZWJraXQub3JnIGRvZXMgbm90IGhhdmUgcmV2aWV3ZXIg cGVybWlzc2lvbnMnKQogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAorICAgIGRlZiB0 ZXN0X2xvYWRfY29udHJpYnV0b3JzX2Zyb21fZGlzayhzZWxmKToKKyAgICAgICAgVmFsaWRhdGVD b21taXRlckFuZFJldmlld2VyLl9hZGRUb0xvZyA9IGxhbWJkYSBjbHMsIGxvZ3R5cGUsIGxvZzog c3lzLnN0ZG91dC53cml0ZShsb2cpCisgICAgICAgIGNvbnRyaWJ1dG9ycyA9IFZhbGlkYXRlQ29t bWl0ZXJBbmRSZXZpZXdlcigpLmxvYWRfY29udHJpYnV0b3JzX2Zyb21fZGlzaygpCisgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwoY29udHJpYnV0b3JzWydBYWthc2ggSmFpbiddWyduaWNrcyddLCBb J2Fha2FzaF9qYWluJ10pCisKIAogY2xhc3MgVGVzdENoZWNrUGF0Y2hTdGF0dXNPbkVXU1F1ZXVl cyhCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiBz ZXRVcChzZWxmKToK