21335 2008-10-03 10:41:26 -0700 CrashTracer reports many crashes at WebCore::CSSFontSelector::getFontData 2008-10-03 11:13:59 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 adele webkit-unassigned oldest_to_newest 93904 0 adele 2008-10-03 10:41:26 -0700 Thread 0 Crashed (i386): >#0 com.apple.WebCore 0x913367e8 WebCore::Frame::settings() const + 8 #1 com.apple.WebCore 0x9156827b WebCore::CSSFontSelector::getFontData(WebCore::FontDescription const&, WebCore::AtomicString const&) + 315 #2 com.apple.WebCore 0x91568028 WebCore::FontCache::getFontData(WebCore::Font const&, int&, WebCore::FontSelector*) + 184 #3 com.apple.WebCore 0x9137a3a9 WebCore::FontFallbackList::fontDataAt(WebCore::Font const*, unsigned int) const + 73 #4 com.apple.WebCore 0x9137a341 WebCore::Font::cachePrimaryFont() const + 33 #5 com.apple.WebCore 0x914c0a0b WebCore::PopupMenu::populate() + 1211 #6 com.apple.WebCore 0x914bfafd WebCore::PopupMenu::show(WebCore::IntRect const&, WebCore::FrameView*, int) + 29 #7 com.apple.WebCore 0x914bfa39 WebCore::RenderMenuList::showPopup() + 185 #8 com.apple.WebCore 0x914bd039 WebCore::HTMLSelectElement::menuListDefaultEventHandler(WebCore::Event*) + 473 #9 com.apple.WebCore 0x914bce02 WebCore::HTMLSelectElement::defaultEventHandler(WebCore::Event*) + 130 #10 com.apple.WebCore 0x91375b23 WebCore::EventTarget::dispatchGenericEvent(WebCore::EventTargetNode*, WTF::PassRefPtr<WebCore::Event>, int&, bool) + 707 #11 com.apple.WebCore 0x9137576f WebCore::EventTargetNode::dispatchEvent(WTF::PassRefPtr<WebCore::Event>, int&, bool) + 255 #12 com.apple.WebCore 0x9153303d WebCore::EventTargetNode::dispatchMouseEvent(WebCore::AtomicString const&, int, int, int, int, int, int, bool, bool, bool, bool, bool, WebCore::Node*, WTF::PassRefPtr<WebCore::Event>) + 509 #13 com.apple.WebCore 0x91532df5 WebCore::EventTargetNode::dispatchMouseEvent(WebCore::PlatformMouseEvent const&, WebCore::AtomicString const&, int, WebCore::Node*) + 165 #14 com.apple.WebCore 0x915328f5 WebCore::EventHandler::dispatchMouseEvent(WebCore::AtomicString const&, WebCore::Node*, bool, int, WebCore::PlatformMouseEvent const&, bool) + 101 #15 com.apple.WebCore 0x914a2647 WebCore::EventHandler::handleMousePressEvent(WebCore::PlatformMouseEvent const&) + 551 #16 com.apple.WebCore 0x914a2376 WebCore::EventHandler::mouseDown(NSEvent*) + 534 #17 com.apple.WebKit 0x91217efe -[WebHTMLView mouseDown:] + 462 #18 com.apple.AppKit 0x9202fac3 -[NSWindow sendEvent:] + 5381 #19 com.apple.Safari 0x0002b3c3 #20 com.apple.AppKit 0x91ffc714 -[NSApplication sendEvent:] + 2780 #21 com.apple.Safari 0x0002ae48 #22 com.apple.AppKit 0x91f5a0f9 -[NSApplication run] + 847 #23 com.apple.AppKit 0x91f2730a NSApplicationMain + 574 #24 com.apple.Safari 0x000b9906 93906 1 adele 2008-10-03 10:42:28 -0700 <rdar://problem/6012018> 93907 2 24055 adele 2008-10-03 10:44:06 -0700 Created attachment 24055 patch Haven't made a test. I don't really know what triggers this, but it seems clear we should be nil checking the frame. 93908 3 adele 2008-10-03 10:45:27 -0700 Probably has something to do with a menu being displayed as the frame goes away. 93911 4 24055 mitz 2008-10-03 10:54:15 -0700 Comment on attachment 24055 patch r=me 93915 5 adele 2008-10-03 11:13:59 -0700 Committed revision 37243. 24055 2008-10-03 10:44:06 -0700 2008-10-03 10:54:15 -0700 patch patch.txt text/plain 1182 adele SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3MjQy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTAt MDMgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzYw MTIwMTg+IAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjEzMzUKKyAgICAgICAgQ3Jhc2hUcmFjZXI6IFtVU0VSXSA0OTU5IGNyYXNoZXMgaW4gU2FmYXJp IGF0IGNvbS5hcHBsZS5XZWJDb3JlOiBXZWJDb3JlOjpGcmFtZTo6c2V0dGluZ3MgY29uc3QgKyA4 CisKKyAgICAgICAgKiBjc3MvQ1NTRm9udFNlbGVjdG9yLmNwcDogKFdlYkNvcmU6OmZvbnREYXRh Rm9yR2VuZXJpY0ZhbWlseSk6IFJldHVybiBlYXJseSBpZiB0aGUgZnJhbWUgaXMgbmlsLgorCiAy MDA4LTEwLTAzICBBcml5YSBIaWRheWF0ICA8YXJpeWEuaGlkYXlhdEB0cm9sbHRlY2guY29tPgog CiAgICAgICAgIEJ1aWxkIGZpeC4KSW5kZXg6IGNzcy9DU1NGb250U2VsZWN0b3IuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIGNzcy9DU1NGb250U2VsZWN0b3IuY3BwCShyZXZpc2lvbiAzNzI0MSkKKysrIGNz cy9DU1NGb250U2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzUsNyArMzc1LDcgQEAg dm9pZCBDU1NGb250U2VsZWN0b3I6OmZvbnRDYWNoZUludmFsaWRhdAogCiBzdGF0aWMgRm9udERh dGEqIGZvbnREYXRhRm9yR2VuZXJpY0ZhbWlseShEb2N1bWVudCogZG9jdW1lbnQsIGNvbnN0IEZv bnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aW9uLCBjb25zdCBBdG9taWNTdHJpbmcmIGZhbWls eU5hbWUpCiB7Ci0gICAgaWYgKCFkb2N1bWVudCkKKyAgICBpZiAoIWRvY3VtZW50IHx8ICFkb2N1 bWVudC0+ZnJhbWUoKSkKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBjb25zdCBTZXR0aW5ncyog c2V0dGluZ3MgPSBkb2N1bWVudC0+ZnJhbWUoKS0+c2V0dGluZ3MoKTsK