213346 2020-06-18 11:48:27 -0700 Workaround for UIKit layout bug in time picker. 2020-06-18 15:16:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton wenson_hsieh oldest_to_newest 1663936 0 megan_gardner 2020-06-18 11:48:27 -0700 Workaround for UIKit layout bug in time picker. 1663941 1 402222 megan_gardner 2020-06-18 11:57:12 -0700 Created attachment 402222 Patch 1663942 2 402222 thorton 2020-06-18 12:06:08 -0700 Comment on attachment 402222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402222&action=review > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:82 > + // FIXME: Workaround, should be able to be readresses after <rdar://problem/64143534> "readdresses" -> readdressed? > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:88 > + view.layoutMargins = (UIEdgeInsets) {16, 16, 16, 16}; We usually use UIEdgeInsetsMake 1663990 3 402237 megan_gardner 2020-06-18 14:35:52 -0700 Created attachment 402237 Patch for landing 1663991 4 megan_gardner 2020-06-18 14:36:23 -0700 <rdar://problem/64042277> 1664006 5 ews-feeder 2020-06-18 15:16:30 -0700 Committed r263232: <https://trac.webkit.org/changeset/263232> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402237. 402222 2020-06-18 11:57:12 -0700 2020-06-18 14:35:51 -0700 Patch bug-213346-20200618115711.patch text/plain 2088 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ3Mzk0ZWIzNmU0MjNiYjVl YWYxY2YwZDcwYjhlZWE2MWQ5NzgzMzkuLjc2YTFiYjFjMGVjYzQ4ZWYyMjcwZWRiMDk3ODczNDQ5 MTA0YjU1NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDYtMTggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBXb3JrYXJvdW5kIGZv ciBVSUtpdCBsYXlvdXQgYnVnIGluIHRpbWUgcGlja2VyLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMzQ2CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS82NDA0MjI3Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGVyZSBpcyBhIGJ1ZyBpbiB0aGUgbGF5b3V0IG9mIFVJS2l0IHRoYXQgbmVlZHMgdG8g YmUgZml4ZWQuCisgICAgICAgIFVudGlsIHRoZW4sIHRoaXMgd29ya2Fyb3VuZCBzaG91bGQgZ2l2 ZSB1cyBhIHZpZXcgdGhhdCBpcyB2aWFibGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyByZXNp Z25GaXJzdFJlc3BvbmRlckZvcldlYlZpZXddKToKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zv cm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW06CisgICAgICAgICgtW1dLRGF0ZVRpbWVDb250 ZXh0TWVudVZpZXdDb250cm9sbGVyIHByZWZlcnJlZENvbnRlbnRTaXplXSk6CisKIDIwMjAtMDYt MTYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIGNhbGxp bmcgdXNlclByZWZlcnJlZExhbmd1YWdlcygpIGluIHRoZSBVSVByb2Nlc3MKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0RhdGVUaW1lSW5wdXRDb250cm9s Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENv bnRyb2wubW0KaW5kZXggYmYyZmE5NDdmMGU3YzY1NTg1Y2I1M2Y2MTU5N2RiNDcxYjczYTA2OC4u OTQyMGIyOWRkMmJlZTNjZjg5YjdiODYxNGZhYjAxMmE1YWUwZDcwMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0K KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENv bnRyb2wubW0KQEAgLTc5LDcgKzc5LDE2IEBAIEBpbXBsZW1lbnRhdGlvbiBXS0RhdGVUaW1lQ29u dGV4dE1lbnVWaWV3Q29udHJvbGxlcgogCiAtIChDR1NpemUpcHJlZmVycmVkQ29udGVudFNpemUK IHsKLSAgICByZXR1cm4gW3NlbGYudmlldyBzeXN0ZW1MYXlvdXRTaXplRml0dGluZ1NpemU6VUlM YXlvdXRGaXR0aW5nQ29tcHJlc3NlZFNpemVdOworICAgIC8vIEZJWE1FOiBXb3JrYXJvdW5kLCBz aG91bGQgYmUgYWJsZSB0byBiZSByZWFkcmVzc2VzIGFmdGVyIDxyZGFyOi8vcHJvYmxlbS82NDE0 MzUzND4KKyAgICBVSVZpZXcgKnZpZXcgPSBzZWxmLnZpZXc7CisgICAgaWYgKFVJRWRnZUluc2V0 c0VxdWFsVG9FZGdlSW5zZXRzKHZpZXcubGF5b3V0TWFyZ2lucywgVUlFZGdlSW5zZXRzWmVybykp IHsKKyAgICAgICAgdmlldy50cmFuc2xhdGVzQXV0b3Jlc2l6aW5nTWFza0ludG9Db25zdHJhaW50 cyA9IE5POworICAgICAgICBbdmlldyBsYXlvdXRJZk5lZWRlZF07CisgICAgICAgIHZpZXcudHJh bnNsYXRlc0F1dG9yZXNpemluZ01hc2tJbnRvQ29uc3RyYWludHMgPSBZRVM7CisgICAgICAgIHZp ZXcubGF5b3V0TWFyZ2lucyA9IChVSUVkZ2VJbnNldHMpIHsxNiwgMTYsIDE2LCAxNn07CisgICAg fQorCisgICAgcmV0dXJuIFt2aWV3IHN5c3RlbUxheW91dFNpemVGaXR0aW5nU2l6ZTpVSUxheW91 dEZpdHRpbmdDb21wcmVzc2VkU2l6ZV07CiB9CiAKIEBlbmQK 402237 2020-06-18 14:35:52 -0700 2020-06-18 15:16:31 -0700 Patch for landing bug-213346-20200618143551.patch text/plain 2086 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ3Mzk0ZWIzNmU0MjNiYjVl YWYxY2YwZDcwYjhlZWE2MWQ5NzgzMzkuLjQzZmEzNmVjYjY4NTVjNjY4YTc0MzQ3NGY4YjU5ZWRl NzAzNTcxMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDYtMTggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBXb3JrYXJvdW5kIGZv ciBVSUtpdCBsYXlvdXQgYnVnIGluIHRpbWUgcGlja2VyLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMzQ2CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS82NDA0MjI3Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAg IFRoZXJlIGlzIGEgYnVnIGluIHRoZSBsYXlvdXQgb2YgVUlLaXQgdGhhdCBuZWVkcyB0byBiZSBm aXhlZC4KKyAgICAgICAgVW50aWwgdGhlbiwgdGhpcyB3b3JrYXJvdW5kIHNob3VsZCBnaXZlIHVz IGEgdmlldyB0aGF0IGlzIHZpYWJsZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHJlc2lnbkZp cnN0UmVzcG9uZGVyRm9yV2ViVmlld10pOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMv V0tEYXRlVGltZUlucHV0Q29udHJvbC5tbToKKyAgICAgICAgKC1bV0tEYXRlVGltZUNvbnRleHRN ZW51Vmlld0NvbnRyb2xsZXIgcHJlZmVycmVkQ29udGVudFNpemVdKToKKwogMjAyMC0wNi0xNiAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgY2FsbGluZyB1 c2VyUHJlZmVycmVkTGFuZ3VhZ2VzKCkgaW4gdGhlIFVJUHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0g Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJv bC5tbQppbmRleCBiZjJmYTk0N2YwZTdjNjU1ODVjYjUzZjYxNTk3ZGI0NzFiNzNhMDY4Li5mMWIz NTg0MGU4YWRjYmIyOTcwNmY3Y2U0MDdlNjAwNDc0NjQ0YmJlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJv bC5tbQpAQCAtNzksNyArNzksMTYgQEAgQGltcGxlbWVudGF0aW9uIFdLRGF0ZVRpbWVDb250ZXh0 TWVudVZpZXdDb250cm9sbGVyCiAKIC0gKENHU2l6ZSlwcmVmZXJyZWRDb250ZW50U2l6ZQogewot ICAgIHJldHVybiBbc2VsZi52aWV3IHN5c3RlbUxheW91dFNpemVGaXR0aW5nU2l6ZTpVSUxheW91 dEZpdHRpbmdDb21wcmVzc2VkU2l6ZV07CisgICAgLy8gRklYTUU6IFdvcmthcm91bmQsIHNob3Vs ZCBiZSBhYmxlIHRvIGJlIHJlYWRkcmVzc2VkIGFmdGVyIDxyZGFyOi8vcHJvYmxlbS82NDE0MzUz ND4KKyAgICBVSVZpZXcgKnZpZXcgPSBzZWxmLnZpZXc7CisgICAgaWYgKFVJRWRnZUluc2V0c0Vx dWFsVG9FZGdlSW5zZXRzKHZpZXcubGF5b3V0TWFyZ2lucywgVUlFZGdlSW5zZXRzWmVybykpIHsK KyAgICAgICAgdmlldy50cmFuc2xhdGVzQXV0b3Jlc2l6aW5nTWFza0ludG9Db25zdHJhaW50cyA9 IE5POworICAgICAgICBbdmlldyBsYXlvdXRJZk5lZWRlZF07CisgICAgICAgIHZpZXcudHJhbnNs YXRlc0F1dG9yZXNpemluZ01hc2tJbnRvQ29uc3RyYWludHMgPSBZRVM7CisgICAgICAgIHZpZXcu bGF5b3V0TWFyZ2lucyA9IFVJRWRnZUluc2V0c01ha2UoMTYsIDE2LCAxNiwgMTYpOworICAgIH0K KworICAgIHJldHVybiBbdmlldyBzeXN0ZW1MYXlvdXRTaXplRml0dGluZ1NpemU6VUlMYXlvdXRG aXR0aW5nQ29tcHJlc3NlZFNpemVdOwogfQogCiBAZW5kCg==