213323 2020-06-17 17:30:05 -0700 [PlayStation] Build fix for errors with structured bindings to const structure 2020-06-18 10:46:19 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo stephan.szabo ews-watchlist fujii hi joepeck pfeldman webkit-bug-importer oldest_to_newest 1663721 0 stephan.szabo 2020-06-17 17:30:05 -0700 The structured bindings in InspectorNetworkAgent.cpp in for loops over the headers gives errors on our compiler. The fix seems similar to the one previously done for clang-cl on the same file. 1663730 1 402173 stephan.szabo 2020-06-17 18:04:28 -0700 Created attachment 402173 Build fix 1663922 2 ews-feeder 2020-06-18 10:45:07 -0700 Committed r263220: <https://trac.webkit.org/changeset/263220> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402173. 1663923 3 webkit-bug-importer 2020-06-18 10:46:19 -0700 <rdar://problem/64495743> 402173 2020-06-17 18:04:28 -0700 2020-06-18 10:45:07 -0700 Build fix 213323.1.diff text/plain 2384 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNjA0N2QxNTFkNi4uOTdmZTYxNGNlMTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNi0xNyAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29u eS5jb20+CisKKyAgICAgICAgW1BsYXlTdGF0aW9uXSBCdWlsZCBmaXggZm9yIGVycm9ycyB3aXRo IHN0cnVjdHVyZWQgYmluZGluZ3MgdG8gY29uc3Qgc3RydWN0dXJlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTMzMjMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdXIgc3lzdGVtIHNlZW1zIHRvIGhhdmUg dHJvdWJsZSB3aXRoIHRoZXNlIHN0cnVjdHVyZWQgYmluZGluZ3MsCisgICAgICAgIHNpbWlsYXIg dG8gd2hhdCB3YXMgcHJldmlvdXNseSBzZWVuIGZvciBjbGFuZy1jbC4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIGJ1aWxkIGZpeC4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVj dG9yTmV0d29ya0FnZW50LmNwcDoKKwogMjAyMC0wNi0xNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYXR0ZW1wdCB0byBmaXggaW50ZXJuYWwg bWFjT1MgYnVpbGQgYWZ0ZXIgcjI2MzE1Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yTmV0d29ya0FnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yTmV0d29ya0FnZW50LmNwcAppbmRleCAxY2NjNWY1 ZGUyNy4uMTkxM2RmY2U3NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9h Z2VudHMvSW5zcGVjdG9yTmV0d29ya0FnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvYWdlbnRzL0luc3BlY3Rvck5ldHdvcmtBZ2VudC5jcHAKQEAgLTExODYsMTAgKzExODYs MTAgQEAgdm9pZCBJbnNwZWN0b3JOZXR3b3JrQWdlbnQ6OmludGVyY2VwdFdpdGhSZXF1ZXN0KEVy cm9yU3RyaW5nJiBlcnJvclN0cmluZywgY29uc3QKICAgICAgICAgcmVxdWVzdC5zZXRIVFRQTWV0 aG9kKCptZXRob2QpOwogICAgIGlmIChoZWFkZXJzKSB7CiAgICAgICAgIEhUVFBIZWFkZXJNYXAg ZXhwbGljaXRIZWFkZXJzOwotICAgICAgICBmb3IgKGF1dG8mIFtrZXksIHZhbHVlXSA6ICpoZWFk ZXJzKSB7CisgICAgICAgIGZvciAoYXV0byYgaGVhZGVyIDogKmhlYWRlcnMpIHsKICAgICAgICAg ICAgIFN0cmluZyBoZWFkZXJWYWx1ZTsKLSAgICAgICAgICAgIGlmICh2YWx1ZS0+YXNTdHJpbmco aGVhZGVyVmFsdWUpKQotICAgICAgICAgICAgICAgIGV4cGxpY2l0SGVhZGVycy5hZGQoa2V5LCBo ZWFkZXJWYWx1ZSk7CisgICAgICAgICAgICBpZiAoaGVhZGVyLnZhbHVlLT5hc1N0cmluZyhoZWFk ZXJWYWx1ZSkpCisgICAgICAgICAgICAgICAgZXhwbGljaXRIZWFkZXJzLmFkZChoZWFkZXIua2V5 LCBoZWFkZXJWYWx1ZSk7CiAgICAgICAgIH0KICAgICAgICAgcmVxdWVzdC5zZXRIVFRQSGVhZGVy RmllbGRzKFdURk1vdmUoZXhwbGljaXRIZWFkZXJzKSk7CiAgICAgfQpAQCAtMTI4MywxMCArMTI4 MywxMCBAQCB2b2lkIEluc3BlY3Rvck5ldHdvcmtBZ2VudDo6aW50ZXJjZXB0UmVxdWVzdFdpdGhS ZXNwb25zZShFcnJvclN0cmluZyYgZXJyb3JTdHJpbgogICAgIHJlc3BvbnNlLnNldEhUVFBTdGF0 dXNDb2RlKHN0YXR1cyk7CiAgICAgcmVzcG9uc2Uuc2V0SFRUUFN0YXR1c1RleHQoc3RhdHVzVGV4 dCk7CiAgICAgSFRUUEhlYWRlck1hcCBleHBsaWNpdEhlYWRlcnM7Ci0gICAgZm9yIChhdXRvJiBb a2V5LCB2YWx1ZV0gOiBoZWFkZXJzKSB7CisgICAgZm9yIChhdXRvJiBoZWFkZXIgOiBoZWFkZXJz KSB7CiAgICAgICAgIFN0cmluZyBoZWFkZXJWYWx1ZTsKLSAgICAgICAgaWYgKHZhbHVlLT5hc1N0 cmluZyhoZWFkZXJWYWx1ZSkpCi0gICAgICAgICAgICBleHBsaWNpdEhlYWRlcnMuYWRkKGtleSwg aGVhZGVyVmFsdWUpOworICAgICAgICBpZiAoaGVhZGVyLnZhbHVlLT5hc1N0cmluZyhoZWFkZXJW YWx1ZSkpCisgICAgICAgICAgICBleHBsaWNpdEhlYWRlcnMuYWRkKGhlYWRlci5rZXksIGhlYWRl clZhbHVlKTsKICAgICB9CiAgICAgcmVzcG9uc2Uuc2V0SFRUUEhlYWRlckZpZWxkcyhXVEZNb3Zl KGV4cGxpY2l0SGVhZGVycykpOwogICAgIHJlc3BvbnNlLnNldEhUVFBIZWFkZXJGaWVsZChIVFRQ SGVhZGVyTmFtZTo6Q29udGVudFR5cGUsIHJlc3BvbnNlLm1pbWVUeXBlKCkpOwo=