213305 2020-06-17 10:33:47 -0700 Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::completeUnconditionally 2020-06-17 11:17:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen beidson webkit-bug-importer oldest_to_newest 1663578 0 achristensen 2020-06-17 10:33:47 -0700 Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::completeUnconditionally 1663579 1 402130 achristensen 2020-06-17 10:34:44 -0700 Created attachment 402130 Patch 1663583 2 402130 ap 2020-06-17 10:43:43 -0700 Comment on attachment 402130 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402130&action=review > Source/WebKit/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). No test? 1663585 3 402130 achristensen 2020-06-17 10:47:05 -0700 Comment on attachment 402130 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402130&action=review >> Source/WebKit/ChangeLog:7 >> + Reviewed by NOBODY (OOPS!). > > No test? No test. I believe our crash logs justify this change, and Brady's comment in radar convinces me that this is an edge case happening during teardown. 1663595 4 402130 beidson 2020-06-17 11:02:18 -0700 Comment on attachment 402130 Patch No test in deed - one of those cases where it's obvious what's happening but not feasible to get it happening reliably for testing. 1663603 5 ews-feeder 2020-06-17 11:16:25 -0700 Committed r263169: <https://trac.webkit.org/changeset/263169> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402130. 1663604 6 webkit-bug-importer 2020-06-17 11:17:19 -0700 <rdar://problem/64455684> 402130 2020-06-17 10:34:44 -0700 2020-06-17 11:16:25 -0700 Patch bug-213305-20200617103444.patch text/plain 1570 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjMxNjUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA2LTE3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBjaGVjayBw bHVnaW4ubV9kYXRhIGJlZm9yZSB1c2luZyBpdCBpbiBQREZQbHVnaW46OkJ5dGVSYW5nZVJlcXVl c3Q6OmNvbXBsZXRlVW5jb25kaXRpb25hbGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTMzMDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYwMzQ5 Mjc5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW06CisgICAgICAgIChXZWJLaXQ6OlBE RlBsdWdpbjo6Qnl0ZVJhbmdlUmVxdWVzdDo6Y29tcGxldGVVbmNvbmRpdGlvbmFsbHkpOgorCiAy MDIwLTA2LTE3ICBEYXJyeWwgUG9ndWUgIDxkYXJyeWxAZHBvZ3VlLmNhPgogCiAgICAgICAgIElu ZGV4ZWREQjogU3VwcG9ydCBJREJGYWN0b3J5IGRhdGFiYXNlcyBtZXRob2QKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbQkocmV2 aXNpb24gMjYzMTMxKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BE RlBsdWdpbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMTA2MCwxMyArMTA2MCwxMSBAQCBib29sIFBE RlBsdWdpbjo6Qnl0ZVJhbmdlUmVxdWVzdDo6bWF5YmVDCiAKIHZvaWQgUERGUGx1Z2luOjpCeXRl UmFuZ2VSZXF1ZXN0Ojpjb21wbGV0ZVVuY29uZGl0aW9uYWxseShQREZQbHVnaW4mIHBsdWdpbikK IHsKLSAgICBpZiAobV9wb3NpdGlvbiA+PSBwbHVnaW4ubV9zdHJlYW1lZEJ5dGVzKSB7CisgICAg aWYgKG1fcG9zaXRpb24gPj0gcGx1Z2luLm1fc3RyZWFtZWRCeXRlcyB8fCAhcGx1Z2luLm1fZGF0 YSkgewogICAgICAgICBjb21wbGV0ZVdpdGhCeXRlcyhudWxscHRyLCAwLCBwbHVnaW4pOwogICAg ICAgICByZXR1cm47CiAgICAgfQogCi0gICAgQVNTRVJUKHBsdWdpbi5tX2RhdGEpOwotCiAgICAg YXV0byBjb3VudCA9IG1fcG9zaXRpb24gKyBtX2NvdW50ID4gcGx1Z2luLm1fc3RyZWFtZWRCeXRl cyA/IHBsdWdpbi5tX3N0cmVhbWVkQnl0ZXMgLSBtX3Bvc2l0aW9uIDogbV9jb3VudDsKICAgICBj b21wbGV0ZVdpdGhCeXRlcyhDRkRhdGFHZXRCeXRlUHRyKHBsdWdpbi5tX2RhdGEuZ2V0KCkpICsg bV9wb3NpdGlvbiwgY291bnQsIHBsdWdpbik7CiB9Cg==