213303 2020-06-17 09:54:04 -0700 REGRESSION (r263098): [Win10] http/tests/security/cross-origin-clean-css-resource-timing.html and http/tests/security/cross-origin-css-resource-timing.html are failing 2020-06-19 00:44:01 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad youennf aakash_jain achristensen cdumez darin ews-watchlist japhet webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1663546 0 ryanhaddad 2020-06-17 09:54:04 -0700 http/tests/security/cross-origin-clean-css-resource-timing.html and http/tests/security/cross-origin-css-resource-timing.html are consistently failing on Win10 bots: --- /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/cross-origin-clean-css-resource-timing-expected.txt +++ /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/cross-origin-clean-css-resource-timing-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: Unhandled Promise Rejection: Error: assert_false: image expected false got true -PASS CSS subresources of a clean stylesheet should populate resource timing entries, but not for imported stylesheets +FAIL CSS subresources of a clean stylesheet should populate resource timing entries, but not for imported stylesheets assert_false: image expected false got true --- /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/cross-origin-css-resource-timing-expected.txt +++ /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/cross-origin-css-resource-timing-actual.txt @@ -1,3 +1,5 @@ +CONSOLE MESSAGE: Unhandled Promise Rejection: Error: assert_false: import expected false got true +Test -PASS CSS subresources of an opaque stylesheet should not populate resource timing entries +FAIL CSS subresources of an opaque stylesheet should not populate resource timing entries assert_false: import expected false got true https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fsecurity%2Fcross-origin-clean-css-resource-timing.html&test=http%2Ftests%2Fsecurity%2Fcross-origin-css-resource-timing.html 1663547 1 webkit-bug-importer 2020-06-17 09:54:24 -0700 <rdar://problem/64452203> 1663548 2 ryanhaddad 2020-06-17 09:54:55 -0700 Test history suggests that this regressed with https://trac.webkit.org/changeset/263098/webkit 1663556 3 ryanhaddad 2020-06-17 10:11:13 -0700 Youenn says he will look at this tomorrow. 1663557 4 ryanhaddad 2020-06-17 10:11:35 -0700 Marked tests as failing to keep EWS moving quickly in the interim. 1663558 5 ryanhaddad 2020-06-17 10:12:04 -0700 (In reply to Ryan Haddad from comment #4) > Marked tests as failing to keep EWS moving quickly in the interim. http://trac.webkit.org/r263162 1663847 6 402199 youennf 2020-06-18 04:55:13 -0700 Created attachment 402199 Patch 1663881 7 youennf 2020-06-18 08:51:12 -0700 Test seem to pass in windows by reverting a change that was not mandatory for https://trac.webkit.org/changeset/263098/webkit. I am not quite sure why and we should probably get back to it at some point. 1663902 8 402199 achristensen 2020-06-18 09:52:17 -0700 Comment on attachment 402199 Patch If this fixes it, I don't oppose. Definitely strange. 1663917 9 ews-feeder 2020-06-18 10:28:44 -0700 Committed r263218: <https://trac.webkit.org/changeset/263218> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402199. 1663918 10 402199 darin 2020-06-18 10:31:03 -0700 Comment on attachment 402199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402199&action=review > Source/WebCore/loader/ResourceLoaderOptions.h:145 > -enum class LoadedFromOpaqueSource : bool { > - No, > - Yes > +enum class LoadedFromOpaqueSource : uint8_t { > + Yes, > + No > }; If this value is sent cross process with Encoder/Decoder, changing from bool to uint8_t might require specializing EnumTraits. So it might be slightly trickier than just reverting. I see no test failures, I guess this is not done with this enumeration? 1664294 11 youennf 2020-06-19 00:44:01 -0700 (In reply to Alex Christensen from comment #8) > Comment on attachment 402199 [details] > Patch > > If this fixes it, I don't oppose. Definitely strange. This fixes it according the bots. > If this value is sent cross process with Encoder/Decoder, changing from bool > to uint8_t might require specializing EnumTraits. So it might be slightly > trickier than just reverting. I see no test failures, I guess this is not > done with this enumeration? Issue is WK1 and I do not think this is encoder/decoder. Maybe this is Windows compiler specific. 402199 2020-06-18 04:55:13 -0700 2020-06-18 10:28:44 -0700 Patch bug-213303-20200618135511.patch text/plain 3202 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzcyY2Q0ZWRjZmVjZDY1 MTY0YmI3ZjMzYTU5YzA4ODRiOTI5M2M2YS4uN2M5NGU1MjJkZjAzZGQwNThlMTI5NWUxODdhODgz NjM4NjJkMTIyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA2LTE4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjYz MDk4KTogW1dpbjEwXSBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLW9yaWdpbi1jbGVhbi1jc3Mt cmVzb3VyY2UtdGltaW5nLmh0bWwgYW5kIGh0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3Mtb3JpZ2lu LWNzcy1yZXNvdXJjZS10aW1pbmcuaHRtbCBhcmUgZmFpbGluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMzAzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS82NDQ1MjIwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogbG9hZGVyL1Jl c291cmNlTG9hZGVyT3B0aW9ucy5oOgorICAgICAgICBSZXZlcnRpbmcgcGFydCBvZiBodHRwczov L3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjYzMDk4L3dlYmtpdCB0aGF0IG1pZ2h0IGhhdmUg YnJva2VuIHdpbjEwIGJvdHMuCisKIDIwMjAtMDYtMTcgIENsYXJrIFdhbmcgIDxjbGFya193YW5n QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGRlZCBtaXNzaW5nIG9yaWVudGF0aW9uIGF0dHJpYnV0 ZXMgdG8gUGFubmVyTm9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291 cmNlTG9hZGVyT3B0aW9ucy5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVy T3B0aW9ucy5oCmluZGV4IDEzZjM2OTFkMWQyYWNhZjYwOTg5NzI3ZmEzZDAwMTcwZDdmYjkzNjUu LjYwNTMwZDM1OTRlYzYyMTNiNjliOTNmZTUxMDA5MWNkOTIyYjE4MGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlck9wdGlvbnMuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXJPcHRpb25zLmgKQEAgLTEzOSw5ICsxMzksOSBA QCBlbnVtIGNsYXNzIFByZWZsaWdodFBvbGljeSA6IHVpbnQ4X3QgewogfTsKIHN0YXRpYyBjb25z dGV4cHIgdW5zaWduZWQgYml0V2lkdGhPZlByZWZsaWdodFBvbGljeSA9IDI7CiAKLWVudW0gY2xh c3MgTG9hZGVkRnJvbU9wYXF1ZVNvdXJjZSA6IGJvb2wgewotICAgIE5vLAotICAgIFllcworZW51 bSBjbGFzcyBMb2FkZWRGcm9tT3BhcXVlU291cmNlIDogdWludDhfdCB7CisgICAgWWVzLAorICAg IE5vCiB9Owogc3RhdGljIGNvbnN0ZXhwciB1bnNpZ25lZCBiaXRXaWR0aE9mTG9hZGVkRnJvbU9w YXF1ZVNvdXJjZSA9IDE7CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlMDM5OGNhZmI1N2JiZGVhODgyZDI5MmRkMDFhODk5 YzU5NWZmMDI2Li4xZGZjNjA5ZjdmNWY4NWFlNzg2MzY5OTZkYTRjOTQxZDQxNzg0YmQ0IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDYtMTggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNjMwOTgpOiBbV2luMTBdIGh0dHAvdGVz dHMvc2VjdXJpdHkvY3Jvc3Mtb3JpZ2luLWNsZWFuLWNzcy1yZXNvdXJjZS10aW1pbmcuaHRtbCBh bmQgaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1vcmlnaW4tY3NzLXJlc291cmNlLXRpbWluZy5o dG1sIGFyZSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTMzMDMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0NDUyMjAzPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vd2lu L1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMjAtMDYtMTggIERpZWdvIFBpbm8gR2FyY2lhICA8ZHBp bm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5n LiBSZW1vdmUgc3RhbGUgZmxha3kgZmFpbHVyZXMgYWZ0ZXIgcjI2MzIwNS4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggODU3ZGU4OTE2ODNmODY3ZjA1Y2Yw NzExOGNiM2NiZWVlZWI2YTAwMy4uZjhiYmI3YjM1ZDQ1OTZkMDIxOThiODU2MWFmYmIyZGRlZmM0 MWYyZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlv bnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTQ0 NjksOSArNDQ2OSw2IEBAIHdlYmtpdC5vcmcvYi8yMDk1ODIgd2ViYW5pbWF0aW9ucy9jc3MtdHJh bnNpdGlvbi1pbi1mbGlnaHQtcmV2ZXJzYWwtYWNjZWxlcmF0ZWQuCiAKIHdlYmtpdC5vcmcvYi8y MDk2MDEgYW5pbWF0aW9ucy9tYW55LXBzZXVkby1hbmltYXRpb25zLmh0bWwgWyBQYXNzIEZhaWx1 cmUgXQogCi13ZWJraXQub3JnL2IvMjEzMzAzIGh0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3Mtb3Jp Z2luLWNsZWFuLWNzcy1yZXNvdXJjZS10aW1pbmcuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9y Zy9iLzIxMzMwMyBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLW9yaWdpbi1jc3MtcmVzb3VyY2Ut dGltaW5nLmh0bWwgWyBGYWlsdXJlIF0KLQogIyBJbnRlcnNlY3Rpb25PYnNlcnZlciBpcyBvZmYg YnkgZGVmYXVsdAogaHR0cC90ZXN0cy9sYXp5bG9hZCBbIFNraXAgXQogaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9lbWJlZGRlZC1jb250ZW50L3RoZS1pbWct ZWxlbWVudC9iZWxvdy12aWV3cG9ydC1pbWFnZS1sb2FkaW5nLWxhenktbG9hZC1ldmVudC5odG1s IFsgU2tpcCBdCg==