213280 2020-06-16 18:47:54 -0700 Web Inspector: Console: add comments for localized strings in execution context picker 2020-06-18 13:12:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1663349 0 hi 2020-06-16 18:47:54 -0700 . 1663351 1 402070 hi 2020-06-16 18:59:28 -0700 Created attachment 402070 Patch 1663357 2 webkit-bug-importer 2020-06-16 19:18:13 -0700 <rdar://problem/64431737> 1663963 3 402070 joepeck 2020-06-18 13:01:14 -0700 Comment on attachment 402070 Patch r=me 1663965 4 402070 bburg 2020-06-18 13:03:56 -0700 Comment on attachment 402070 Patch rs=me We should clarify the style for localization disambiguation is to use '@'. I am more used to using '(explanation)', but all I seek is consistency. 1663970 5 ews-feeder 2020-06-18 13:12:52 -0700 Committed r263225: <https://trac.webkit.org/changeset/263225> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402070. 402070 2020-06-16 18:59:28 -0700 2020-06-18 13:12:53 -0700 Patch bug-213280-20200616185927.patch text/plain 3752 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFkMzI1NjY0ZDRiZTNlNjA1OTI1OWI5YTFlZmJl ODgyMmQ1MDIyZTQuLjQzNDk5YzM3YjM5YjExM2I2MTRjZmFjMzBkMWM3MWU1NmI5OTNiOGUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA2LTE2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD b25zb2xlOiBhZGQgY29tbWVudHMgZm9yIGxvY2FsaXplZCBzdHJpbmdzIGluIGV4ZWN1dGlvbiBj b250ZXh0IHBpY2tlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjEzMjgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1F1aWNrQ29uc29sZS5qczoKKyAgICAgICAgKFdJ LlF1aWNrQ29uc29sZS5wcm90b3R5cGUuX3BvcHVsYXRlQWN0aXZlRXhlY3V0aW9uQ29udGV4dE5h dmlnYXRpb25JdGVtQ29udGV4dE1lbnUpOgorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5s cHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorCiAyMDIwLTA2LTE2ICBEZXZpbiBSb3Vzc28gIDxk cm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTb3VyY2VzOiBvYmpl Y3RzIGluIFNjb3BlIENoYWluIHBhbmVsIGZsaWNrZXIgd2hlbiByZXNpemluZyBkZXRhaWxzIHNp ZGViYXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2Vu Lmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxp emF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDA1MmM0M2FmMjA3ZDRk YjQ0MmQ5ZmUzNTJhMDkyODJlYzUxMDM3YWMuLjhmMDgyNTFiYTFlNjJmZDQyMGY4Y2QwYzI2Mzdh ZTM3YzJiMDY3ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRp b25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpAQCAtNjA1LDYg KzYwNSw4IEBAIGxvY2FsaXplZFN0cmluZ3NbIkZyYW1lICVkIl0gPSAiRnJhbWUgJWQiOwogbG9j YWxpemVkU3RyaW5nc1siRnJhbWUgVVJMIl0gPSAiRnJhbWUgVVJMIjsKIGxvY2FsaXplZFN0cmlu Z3NbIkZyYW1lcyJdID0gIkZyYW1lcyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJGcmFtZXMgJWQgXHUy MDEzICVkIl0gPSAiRnJhbWVzICVkIFx1MjAxMyAlZCI7CisvKiBUaXRsZSBmb3IgbGlzdCBvZiBI VE1MIHN1YmZyYW1lIEphdmFTY3JpcHQgZXhlY3V0aW9uIGNvbnRleHRzICovCitsb2NhbGl6ZWRT dHJpbmdzWyJGcmFtZXMgQCBFeGVjdXRpb24gQ29udGV4dCBQaWNrZXIiXSA9ICJGcmFtZXMiOwog bG9jYWxpemVkU3RyaW5nc1siRnVsbCBHYXJiYWdlIENvbGxlY3Rpb24iXSA9ICJGdWxsIEdhcmJh Z2UgQ29sbGVjdGlvbiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJGdWxsIFVSTCJdID0gIkZ1bGwgVVJM IjsKIGxvY2FsaXplZFN0cmluZ3NbIkZ1bGwtU2NyZWVuIl0gPSAiRnVsbC1TY3JlZW4iOwpAQCAt MTQ0MSw3ICsxNDQzLDggQEAgbG9jYWxpemVkU3RyaW5nc1siV29ya2VyIl0gPSAiV29ya2VyIjsK IGxvY2FsaXplZFN0cmluZ3NbIldvcmtlciBUaHJlYWQiXSA9ICJXb3JrZXIgVGhyZWFkIjsKIGxv Y2FsaXplZFN0cmluZ3NbIldvcmtlciBUaHJlYWRzIl0gPSAiV29ya2VyIFRocmVhZHMiOwogbG9j YWxpemVkU3RyaW5nc1siV29ya2VyOiAlcyJdID0gIldvcmtlcjogJXMiOwotbG9jYWxpemVkU3Ry aW5nc1siV29ya2VycyJdID0gIldvcmtlcnMiOworLyogVGl0bGUgZm9yIGxpc3Qgb2YgSmF2YVNj cmlwdCB3ZWIgd29ya2VyIGV4ZWN1dGlvbiBjb250ZXh0cyAqLworbG9jYWxpemVkU3RyaW5nc1si V29ya2VycyBAIEV4ZWN1dGlvbiBDb250ZXh0IFBpY2tlciJdID0gIldvcmtlcnMiOwogbG9jYWxp emVkU3RyaW5nc1siV3JhcCBsaW5lcyB0byBlZGl0b3Igd2lkdGgiXSA9ICJXcmFwIGxpbmVzIHRv IGVkaXRvciB3aWR0aCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJYQk0iXSA9ICJYQk0iOwogbG9jYWxp emVkU3RyaW5nc1siWEhSIl0gPSAiWEhSIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1F1aWNrQ29uc29sZS5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1F1aWNrQ29uc29sZS5qcwppbmRleCA0NDg3Zjgx ZjhlM2Q1ZTQxODI2NjI3ZWQ3NTExZjlhZDc1Yjc2MTRjLi5hZWJlOTc5NWQ0YTNlMDRmOGJkNmY5 N2YwZmVhMWI3YTUwNGQzOGMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9RdWlja0NvbnNvbGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUXVpY2tDb25zb2xlLmpzCkBAIC0yODIsNyArMjgyLDcg QEAgV0kuUXVpY2tDb25zb2xlID0gY2xhc3MgUXVpY2tDb25zb2xlIGV4dGVuZHMgV0kuVmlldwog CiAgICAgICAgIGxldCBvdGhlckZyYW1lcyA9IFdJLm5ldHdvcmtNYW5hZ2VyLmZyYW1lcy5maWx0 ZXIoKGZyYW1lKSA9PiBmcmFtZSAhPT0gbWFpbkZyYW1lICYmIGZyYW1lLmV4ZWN1dGlvbkNvbnRl eHRMaXN0LnBhZ2VFeGVjdXRpb25Db250ZXh0KTsKICAgICAgICAgaWYgKG90aGVyRnJhbWVzLmxl bmd0aCkgewotICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSGVhZGVyKFdJLlVJU3RyaW5n KCJGcmFtZXMiKSk7CisgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRIZWFkZXIoV0kuVUlT dHJpbmcoIkZyYW1lcyIsICJGcmFtZXMgQCBFeGVjdXRpb24gQ29udGV4dCBQaWNrZXIiLCAiVGl0 bGUgZm9yIGxpc3Qgb2YgSFRNTCBzdWJmcmFtZSBKYXZhU2NyaXB0IGV4ZWN1dGlvbiBjb250ZXh0 cyIpKTsKIAogICAgICAgICAgICAgZm9yIChsZXQgZnJhbWUgb2Ygb3RoZXJGcmFtZXMpCiAgICAg ICAgICAgICAgICAgYWRkRXhlY3V0aW9uQ29udGV4dHNGb3JGcmFtZShmcmFtZSk7CkBAIC0yOTAs NyArMjkwLDcgQEAgV0kuUXVpY2tDb25zb2xlID0gY2xhc3MgUXVpY2tDb25zb2xlIGV4dGVuZHMg V0kuVmlldwogCiAgICAgICAgIGxldCB3b3JrZXJUYXJnZXRzID0gV0kudGFyZ2V0TWFuYWdlci53 b3JrZXJUYXJnZXRzOwogICAgICAgICBpZiAod29ya2VyVGFyZ2V0cy5sZW5ndGgpIHsKLSAgICAg ICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEhlYWRlcihXSS5VSVN0cmluZygiV29ya2VycyIpKTsK KyAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEhlYWRlcihXSS5VSVN0cmluZygiV29ya2Vy cyIsICJXb3JrZXJzIEAgRXhlY3V0aW9uIENvbnRleHQgUGlja2VyIiwgIlRpdGxlIGZvciBsaXN0 IG9mIEphdmFTY3JpcHQgd2ViIHdvcmtlciBleGVjdXRpb24gY29udGV4dHMiKSk7CiAKICAgICAg ICAgICAgIGZvciAobGV0IHRhcmdldCBvZiB3b3JrZXJUYXJnZXRzKQogICAgICAgICAgICAgICAg IGFkZEV4ZWN1dGlvbkNvbnRleHQodGFyZ2V0LmV4ZWN1dGlvbkNvbnRleHQpOwo=