213274 2020-06-16 17:04:01 -0700 update-webkit-localizable-strings exits without writing localized strings because of an R"" string 2020-07-06 13:19:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa katherine_cheney aestes darin katherine_cheney thorton webkit-bug-importer oldest_to_newest 1663313 0 sabouhallawa 2020-06-16 17:04:01 -0700 When adding new localized strings in WebKit and running update-webkit-localizable-strings, I get the following errors: Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:929: mismatched quotes Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:946: mismatched quotes 577 localizable strings 41665 strings not marked for localization Errors encountered. Exiting without writing to Source/WebCore/en.lproj/Localizable.strings. When commenting the R"" string in joinSubStatisticsForSorting() and rerunning the tool, the localized strings are generated as expected. 1663315 1 webkit-bug-importer 2020-06-16 17:04:37 -0700 <rdar://problem/64427891> 1663318 2 aestes 2020-06-16 17:06:47 -0700 *** Bug 213273 has been marked as a duplicate of this bug. *** 1669076 3 403602 katherine_cheney 2020-07-06 11:49:33 -0700 Created attachment 403602 Patch 1669132 4 ews-feeder 2020-07-06 13:19:55 -0700 Committed r263982: <https://trac.webkit.org/changeset/263982> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403602. 403602 2020-07-06 11:49:33 -0700 2020-07-06 13:19:56 -0700 Patch bug-213274-20200706114932.patch text/plain 3645 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEzNDM5YTMyNmU0ZjgxNGU5 ZTUzMWQ5N2I3NWVmZWMwZDNlMjBhMzYuLjc3NTdiYTA0OTc1MjM3Zjg4YjlkYTY2YjRiOWMzZmU1 NGRmNDFkMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDctMDYgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgdXBkYXRlLXdlYmtp dC1sb2NhbGl6YWJsZS1zdHJpbmdzIGV4aXRzIHdpdGhvdXQgd3JpdGluZyBsb2NhbGl6ZWQgc3Ry aW5ncyBiZWNhdXNlIG9mIGFuIFIiIiBzdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzI3NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQ0 Mjc4OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIFIiIiBzdHJpbmcsIHVzZSBhZGphY2VudCBzdHJpbmcgbGl0ZXJhbHMgaW5zdGVhZC4K KworICAgICAgICBObyBuZXcgdGVzdHMsIGZ1bmN0aW9uYWxpdHkgdGVzdGVkIGJ5IGV4aXN0aW5n IHRlc3RzLCBzcGVjaWZpY2FsbHkKKyAgICAgICAgKGh0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3Rh dGlzdGljcy90ZWxlbWV0cnktZ2VuZXJhdGlvbi1iYXNpYy1mdW5jdGlvbmFsaXR5LWRhdGFiYXNl Lmh0bWwKKyAgICAgICAgYW5kIGh0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy90ZWxl bWV0cnktZ2VuZXJhdGlvbi1hZHZhbmNlZC1mdW5jdGlvbmFsaXR5LWRhdGFiYXNlLmh0bWwpLgor CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0 aWNzRGF0YWJhc2VTdG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OmpvaW5TdWJTdGF0aXN0aWNz Rm9yU29ydGluZyk6CisgICAgICAgIChXZWJLaXQ6OkNvbXBsZXRpb25IYW5kbGVyPHZvaWQpOiBE ZWxldGVkLgorCiAyMDIwLTA3LTA2ICBIYWVsd2VubiAobGFub2RhbikgTW9ubmllciAgPGNvbnRh Y3RAaGFja3RpdmlzLm1lPgogCiAgICAgICAgIEJ1YmJsZXdyYXBMYXVuY2hlci5jcHA6IEFkZCBw YXRocyByZXF1aXJlZCBmb3Igc25kaW8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2Fk U3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwCmluZGV4IDIxYjgzY2I0ZWRkYmIyNDU2MWFiNDhl YTY2Yzk3NWM5YjQyNjRiODcuLmUzYjM0YTY5OTVlNDgyY2QwMTg3MzJkN2Y0ZTVjNDIzMjYxOTJl ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9S ZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFz ZVN0b3JlLmNwcApAQCAtOTI2LDI0ICs5MjYsMjIgQEAgdm9pZCBSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzRGF0YWJhc2VTdG9yZTo6bWVyZ2VTdGF0aXN0aWNzKFZlY3RvcjxSZXNvdXJjZUxvYWRTdGEK IAogc3RhdGljIGNvbnN0IFN0cmluZ1ZpZXcgam9pblN1YlN0YXRpc3RpY3NGb3JTb3J0aW5nKCkK IHsKLSAgICByZXR1cm4gUiJxdWVyeSgKLSAgICAgICAgZG9tYWluSUQsCi0gICAgICAgIChjb3Vu dFN1YkZyYW1lVW5kZXJUb3BGcmFtZSArIGNvdW50U3ViUmVzb3VyY2VVbmRlclRvcEZyYW1lICsg Y291bnRVbmlxdWVSZWRpcmVjdFRvKSBhcyBzdW0KLSAgICAgICAgRlJPTSAoCi0gICAgICAgIFNF TEVDVAotICAgICAgICAgICAgZG9tYWluSUQsCi0gICAgICAgICAgICBDT1VOVChESVNUSU5DVCBm LnRvcEZyYW1lRG9tYWluSUQpIGFzIGNvdW50U3ViRnJhbWVVbmRlclRvcEZyYW1lLAotICAgICAg ICAgICAgQ09VTlQoRElTVElOQ1Qgci50b3BGcmFtZURvbWFpbklEKSBhcyBjb3VudFN1YlJlc291 cmNlVW5kZXJUb3BGcmFtZSwKLSAgICAgICAgICAgIENPVU5UKERJU1RJTkNUIHRvRG9tYWluSUQp IGFzIGNvdW50VW5pcXVlUmVkaXJlY3RUbwotICAgICAgICBGUk9NCi0gICAgICAgIE9ic2VydmVk RG9tYWlucyBvCi0gICAgICAgIExFRlQgSk9JTiBTdWJmcmFtZVVuZGVyVG9wRnJhbWVEb21haW5z IGYgT04gby5kb21haW5JRCA9IGYuc3ViRnJhbWVEb21haW5JRAotICAgICAgICBMRUZUIEpPSU4g U3VicmVzb3VyY2VVbmRlclRvcEZyYW1lRG9tYWlucyByIE9OIG8uZG9tYWluSUQgPSByLnN1YnJl c291cmNlRG9tYWluSUQKLSAgICAgICAgTEVGVCBKT0lOIFN1YnJlc291cmNlVW5pcXVlUmVkaXJl Y3RzVG8gdSBPTiBvLmRvbWFpbklEID0gdS5zdWJyZXNvdXJjZURvbWFpbklECi0gICAgICAgIFdI RVJFIGlzUHJldmFsZW50IExJS0UgPwotICAgICAgICBhbmQgaGFkVXNlckludGVyYWN0aW9uIExJ S0UgPwotICAgICAgICBHUk9VUCBCWSBkb21haW5JRCkgT1JERVIgQlkgc3VtIERFU0MKLSAgICAg ICAgKXF1ZXJ5IjsKKyAgICByZXR1cm4gImRvbWFpbklELCIKKyAgICAgICAgIihjb3VudFN1YkZy YW1lVW5kZXJUb3BGcmFtZSArIGNvdW50U3ViUmVzb3VyY2VVbmRlclRvcEZyYW1lICsgY291bnRV bmlxdWVSZWRpcmVjdFRvKSBhcyBzdW0gICIKKyAgICAgICAgIkZST00gKCAiCisgICAgICAgICJT RUxFQ1QgIgorICAgICAgICAgICAgImRvbWFpbklELCAiCisgICAgICAgICAgICAiQ09VTlQoRElT VElOQ1QgZi50b3BGcmFtZURvbWFpbklEKSBhcyBjb3VudFN1YkZyYW1lVW5kZXJUb3BGcmFtZSwg IgorICAgICAgICAgICAgIkNPVU5UKERJU1RJTkNUIHIudG9wRnJhbWVEb21haW5JRCkgYXMgY291 bnRTdWJSZXNvdXJjZVVuZGVyVG9wRnJhbWUsICIKKyAgICAgICAgICAgICJDT1VOVChESVNUSU5D VCB0b0RvbWFpbklEKSBhcyBjb3VudFVuaXF1ZVJlZGlyZWN0VG8gIgorICAgICAgICAiRlJPTSAi CisgICAgICAgICJPYnNlcnZlZERvbWFpbnMgbyAiCisgICAgICAgICJMRUZUIEpPSU4gU3ViZnJh bWVVbmRlclRvcEZyYW1lRG9tYWlucyBmIE9OIG8uZG9tYWluSUQgPSBmLnN1YkZyYW1lRG9tYWlu SUQgIgorICAgICAgICAiTEVGVCBKT0lOIFN1YnJlc291cmNlVW5kZXJUb3BGcmFtZURvbWFpbnMg ciBPTiBvLmRvbWFpbklEID0gci5zdWJyZXNvdXJjZURvbWFpbklEICIKKyAgICAgICAgIkxFRlQg Sk9JTiBTdWJyZXNvdXJjZVVuaXF1ZVJlZGlyZWN0c1RvIHUgT04gby5kb21haW5JRCA9IHUuc3Vi cmVzb3VyY2VEb21haW5JRCAiCisgICAgICAgICJXSEVSRSBpc1ByZXZhbGVudCBMSUtFID8gIgor ICAgICAgICAiYW5kIGhhZFVzZXJJbnRlcmFjdGlvbiBMSUtFID8gIgorICAgICAgICAiR1JPVVAg QlkgZG9tYWluSUQpIE9SREVSIEJZIHN1bSBERVNDICI7CiB9CiAKIHN0YXRpYyBTUUxpdGVTdGF0 ZW1lbnQgbWFrZU1lZGlhbldpdGhVSVF1ZXJ5KFNRTGl0ZURhdGFiYXNlJiBkYXRhYmFzZSkK