213271 2020-06-16 16:52:47 -0700 Web Inspector: ASSERTION FAILED: decodedLength >= dataLength at WebCore::NetworkResourcesData::ResourceData::decodeDataToContent() 2020-06-18 15:11:27 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg ews-watchlist hi inspector-bugzilla-changes joepeck mjs webkit-bug-importer oldest_to_newest 1663305 0 hi 2020-06-16 16:52:47 -0700 . 1663307 1 hi 2020-06-16 16:53:07 -0700 <rdar://problem/64168350> 1663308 2 402055 hi 2020-06-16 16:57:39 -0700 Created attachment 402055 Patch 1663359 3 402055 mjs 2020-06-16 19:30:09 -0700 Comment on attachment 402055 Patch Is it possible to add a test case for this? 1663995 4 hi 2020-06-18 14:44:21 -0700 (In reply to Maciej Stachowiak from comment #3) > Comment on attachment 402055 [details] > Patch > > Is it possible to add a test case for this? I'm not really sure what's to test here. The primary change/fix is just removing an incorrect `ASSERT` (specifically, it's possible for the decoded size of a resource to be smaller than its encoded size). Furthermore, this logic (meaning `m_contentSize`) only really starts taking effect once there's 200MB (`maximumResourcesContentSize`) of data being stored, at which point the oldest content is evicted. It exists just to make sure Web Inspector doesn't hold onto data forever, eventually crashing when we hit our 4GB limit. 1664001 5 ews-feeder 2020-06-18 15:11:26 -0700 Committed r263231: <https://trac.webkit.org/changeset/263231> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402055. 402055 2020-06-16 16:57:39 -0700 2020-06-18 15:11:27 -0700 Patch bug-213271-20200616165738.patch text/plain 4645 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MzM5NDdlYTUzNGZiOGY4Y2FhNzkwOTM0OTY4Y2RkYjA0YWNlYWEwLi4y NDIyYzRmODdkYzYyYTZlM2UxNjY0ZjE5ZDYwYWZjNjQwNTgwMTljIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjYgQEAKKzIwMjAtMDYtMTYgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFTU0VSVElPTiBGQUlMRUQ6IGRlY29kZWRMZW5n dGggPj0gZGF0YUxlbmd0aCBhdCBXZWJDb3JlOjpOZXR3b3JrUmVzb3VyY2VzRGF0YTo6UmVzb3Vy Y2VEYXRhOjpkZWNvZGVEYXRhVG9Db250ZW50KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzI3MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQx NjgzNTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIHRoZSBpbnZhbGlkIGBBU1NFUlQoZGVjb2RlZExlbmd0aCA+PSBkYXRhTGVuZ3RoKWAg YXMgaXQncyB2ZXJ5IHBvc3NpYmxlIGZvciBkZWNvZGVkCisgICAgICAgIGNvbnRlbnQgdG8gYmUg c21hbGxlciB0aGFuIGVuY29kZWQgY29udGVudCAoZS5nLiBzb21ldGhpbmcgZ3ppcHBlZCkuCisK KyAgICAgICAgVXNlIGBTdHJpbmc6OnNpemVJbkJ5dGVzYCBpbnN0ZWFkIG9mIGBTdHJpbmdJbXBs OjpzaXplSW5CeXRlc2AgYXMgdGhlIGxhdHRlciBhbHNvIGluY2x1ZGVzCisgICAgICAgIGBzaXpl b2YoKnRoaXMpYCwgd2hpY2ggaXMgbm90IHJlYWxseSBwYXJ0IG9mIHRoZSByZXNvdXJjZSdzIHNp emUsIGFzIGl0J3MgcmVhbGx5IG1vcmUgb2YgYW4KKyAgICAgICAgaW1wbGVtZW50YXRpb24gZGV0 YWlsLgorCisgICAgICAgICogaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmg6CisgICAg ICAgICogaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok5ldHdvcmtSZXNvdXJjZXNEYXRhOjpSZXNvdXJjZURhdGE6OnJlbW92ZUNvbnRlbnQpOgor ICAgICAgICAoV2ViQ29yZTo6TmV0d29ya1Jlc291cmNlc0RhdGE6OlJlc291cmNlRGF0YTo6ZGVj b2RlRGF0YVRvQ29udGVudCk6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrUmVzb3VyY2VzRGF0 YTo6c2V0UmVzb3VyY2VDb250ZW50KToKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtSZXNvdXJj ZXNEYXRhOjptYXliZURlY29kZURhdGFUb0NvbnRlbnQpOgorICAgICAgICAoV2ViQ29yZTo6Y29u dGVudFNpemVJbkJ5dGVzKTogRGVsZXRlZC4KKwogMjAyMC0wNi0xNiAgU2FtIFdlaW5pZyAgPHdl aW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgW1dQVF0gZm9ybS5hY3Rpb24gZG9lcyBub3QgcmV0 dXJuIGRvY3VtZW50LnVybCB3aGVuIHVuc2V0IChwYXJ0IG9mIGh0dHBzOi8vd3B0LmxpdmUvaHRt bC9kb20vcmVmbGVjdGlvbi1mb3Jtcy5odG1sKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9OZXR3b3JrUmVzb3VyY2VzRGF0YS5jcHAKaW5kZXggN2I1OTY3MGE5Mjg0ZDkzYzM0ZTM0 Yjk4NDUxNDRkMDE2ZTk5MGY2OS4uNzQzMjUwOWVkZTQ0NmU3NzhjNGRmZDQ0MzQ5MDFlZTRlMzA0 YzI1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJj ZXNEYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvTmV0d29ya1Jlc291cmNl c0RhdGEuY3BwCkBAIC01OCwxMSArNTgsNiBAQCB2b2lkIE5ldHdvcmtSZXNvdXJjZXNEYXRhOjpS ZXNvdXJjZURhdGE6OnNldENvbnRlbnQoY29uc3QgU3RyaW5nJiBjb250ZW50LCBib29sCiAgICAg bV9iYXNlNjRFbmNvZGVkID0gYmFzZTY0RW5jb2RlZDsKIH0KIAotc3RhdGljIHNpemVfdCBjb250 ZW50U2l6ZUluQnl0ZXMoY29uc3QgU3RyaW5nJiBjb250ZW50KQotewotICAgIHJldHVybiBjb250 ZW50LmlzTnVsbCgpID8gMCA6IGNvbnRlbnQuaW1wbCgpLT5zaXplSW5CeXRlcygpOwotfQotCiB1 bnNpZ25lZCBOZXR3b3JrUmVzb3VyY2VzRGF0YTo6UmVzb3VyY2VEYXRhOjpyZW1vdmVDb250ZW50 KCkKIHsKICAgICB1bnNpZ25lZCByZXN1bHQgPSAwOwpAQCAtNzQsNyArNjksNyBAQCB1bnNpZ25l ZCBOZXR3b3JrUmVzb3VyY2VzRGF0YTo6UmVzb3VyY2VEYXRhOjpyZW1vdmVDb250ZW50KCkKIAog ICAgIGlmIChoYXNDb250ZW50KCkpIHsKICAgICAgICAgQVNTRVJUKCFoYXNEYXRhKCkpOwotICAg ICAgICByZXN1bHQgPSBjb250ZW50U2l6ZUluQnl0ZXMobV9jb250ZW50KTsKKyAgICAgICAgcmVz dWx0ID0gbV9jb250ZW50LnNpemVJbkJ5dGVzKCk7CiAgICAgICAgIG1fY29udGVudCA9IFN0cmlu ZygpOwogICAgIH0KICAgICByZXR1cm4gcmVzdWx0OwpAQCAtMTAwLDcgKzk1LDcgQEAgdm9pZCBO ZXR3b3JrUmVzb3VyY2VzRGF0YTo6UmVzb3VyY2VEYXRhOjphcHBlbmREYXRhKGNvbnN0IGNoYXIq IGRhdGEsIHNpemVfdCBkYXQKICAgICAgICAgbV9kYXRhQnVmZmVyLT5hcHBlbmQoZGF0YSwgZGF0 YUxlbmd0aCk7CiB9CiAKLXNpemVfdCBOZXR3b3JrUmVzb3VyY2VzRGF0YTo6UmVzb3VyY2VEYXRh OjpkZWNvZGVEYXRhVG9Db250ZW50KCkKK3Vuc2lnbmVkIE5ldHdvcmtSZXNvdXJjZXNEYXRhOjpS ZXNvdXJjZURhdGE6OmRlY29kZURhdGFUb0NvbnRlbnQoKQogewogICAgIEFTU0VSVCghaGFzQ29u dGVudCgpKTsKIApAQCAtMTE2LDkgKzExMSw3IEBAIHNpemVfdCBOZXR3b3JrUmVzb3VyY2VzRGF0 YTo6UmVzb3VyY2VEYXRhOjpkZWNvZGVEYXRhVG9Db250ZW50KCkKIAogICAgIG1fZGF0YUJ1ZmZl ciA9IG51bGxwdHI7CiAKLSAgICBzaXplX3QgZGVjb2RlZExlbmd0aCA9IGNvbnRlbnRTaXplSW5C eXRlcyhtX2NvbnRlbnQpOwotICAgIEFTU0VSVChkZWNvZGVkTGVuZ3RoID49IGRhdGFMZW5ndGgp OwotICAgIHJldHVybiBkZWNvZGVkTGVuZ3RoIC0gZGF0YUxlbmd0aDsKKyAgICByZXR1cm4gbV9j b250ZW50LnNpemVJbkJ5dGVzKCkgLSBkYXRhTGVuZ3RoOwogfQogCiBOZXR3b3JrUmVzb3VyY2Vz RGF0YTo6TmV0d29ya1Jlc291cmNlc0RhdGEoKQpAQCAtMTk0LDcgKzE4Nyw3IEBAIHZvaWQgTmV0 d29ya1Jlc291cmNlc0RhdGE6OnNldFJlc291cmNlQ29udGVudChjb25zdCBTdHJpbmcmIHJlcXVl c3RJZCwgY29uc3QgU3RyCiAgICAgaWYgKCFyZXNvdXJjZURhdGEpCiAgICAgICAgIHJldHVybjsK IAotICAgIHNpemVfdCBkYXRhTGVuZ3RoID0gY29udGVudFNpemVJbkJ5dGVzKGNvbnRlbnQpOwor ICAgIHNpemVfdCBkYXRhTGVuZ3RoID0gY29udGVudC5zaXplSW5CeXRlcygpOwogICAgIGlmIChk YXRhTGVuZ3RoID4gbV9tYXhpbXVtU2luZ2xlUmVzb3VyY2VDb250ZW50U2l6ZSkKICAgICAgICAg cmV0dXJuOwogICAgIGlmIChyZXNvdXJjZURhdGEtPmlzQ29udGVudEV2aWN0ZWQoKSkKQEAgLTI1 OCw3ICsyNTEsNyBAQCB2b2lkIE5ldHdvcmtSZXNvdXJjZXNEYXRhOjptYXliZURlY29kZURhdGFU b0NvbnRlbnQoY29uc3QgU3RyaW5nJiByZXF1ZXN0SWQpCiAgICAgICAgIHJldHVybjsKIAogICAg IG1fY29udGVudFNpemUgKz0gcmVzb3VyY2VEYXRhLT5kZWNvZGVEYXRhVG9Db250ZW50KCk7Ci0g ICAgc2l6ZV90IGRhdGFMZW5ndGggPSBjb250ZW50U2l6ZUluQnl0ZXMocmVzb3VyY2VEYXRhLT5j b250ZW50KCkpOworICAgIHNpemVfdCBkYXRhTGVuZ3RoID0gcmVzb3VyY2VEYXRhLT5jb250ZW50 KCkuc2l6ZUluQnl0ZXMoKTsKICAgICBpZiAoZGF0YUxlbmd0aCA+IG1fbWF4aW11bVNpbmdsZVJl c291cmNlQ29udGVudFNpemUpCiAgICAgICAgIG1fY29udGVudFNpemUgLT0gcmVzb3VyY2VEYXRh LT5ldmljdENvbnRlbnQoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9OZXR3b3JrUmVzb3VyY2VzRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL05ldHdv cmtSZXNvdXJjZXNEYXRhLmgKaW5kZXggOGM0MjhmY2NkNTA2MmNhMzM3NzIwMDllZDRjOTkxZGEz MWNlOWFmZC4uMjk1MDgyYTY4YzlkZTMzOWZjNjUzNmU2NDBkMWRkYWJjMmM5ZjZkMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmgKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmgKQEAgLTk5 LDcgKzk5LDcgQEAgcHVibGljOgogICAgICAgICBib29sIGhhc0RhdGEoKSBjb25zdCB7IHJldHVy biBtX2RhdGFCdWZmZXI7IH0KICAgICAgICAgc2l6ZV90IGRhdGFMZW5ndGgoKSBjb25zdDsKICAg ICAgICAgdm9pZCBhcHBlbmREYXRhKGNvbnN0IGNoYXIqIGRhdGEsIHNpemVfdCBkYXRhTGVuZ3Ro KTsKLSAgICAgICAgc2l6ZV90IGRlY29kZURhdGFUb0NvbnRlbnQoKTsKKyAgICAgICAgdW5zaWdu ZWQgZGVjb2RlRGF0YVRvQ29udGVudCgpOwogCiAgICAgICAgIFN0cmluZyBtX3JlcXVlc3RJZDsK ICAgICAgICAgU3RyaW5nIG1fbG9hZGVySWQ7Cg==