213270 2020-06-16 16:52:02 -0700 REGRESSION: ASSERTION FAILED: g_jscConfig.options.allowUnfinalizedAccess || g_jscConfig.options.isFinalized seen with TestWebKitAPI.WebCore.WildcardStringMatching 2020-06-16 19:16:19 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212556 InRadar P2 Normal --- 1 ryanhaddad mark.lam mark.lam webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1663303 0 ryanhaddad 2020-06-16 16:52:02 -0700 The following API test is asserting on macOS debug bots: TestWebKitAPI.WebCore.WildcardStringMatching ASSERTION FAILED: g_jscConfig.options.allowUnfinalizedAccess || g_jscConfig.options.isFinalized /Volumes/Data/slave/catalina-debug/build/Source/JavaScriptCore/runtime/Options.h(132) : static OptionsStorage::Bool &JSC::Options::dumpCompiledRegExpPatterns() 1 0x108083539 WTFCrash 2 0x10884b19b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x109aa68a9 JSC::Options::dumpCompiledRegExpPatterns() 4 0x109e51d88 JSC::Yarr::YarrPattern::compile(WTF::String const&) 5 0x109e52765 JSC::Yarr::YarrPattern::YarrPattern(WTF::String const&, WTF::OptionSet<JSC::Yarr::Flags>, JSC::Yarr::ErrorCode&) 6 0x109e527ec JSC::Yarr::YarrPattern::YarrPattern(WTF::String const&, WTF::OptionSet<JSC::Yarr::Flags>, JSC::Yarr::ErrorCode&) 7 0x109e09933 JSC::Yarr::RegularExpression::Private::compile(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode) 8 0x109e0981f JSC::Yarr::RegularExpression::Private::Private(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode) 9 0x109e09751 JSC::Yarr::RegularExpression::Private::Private(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode) 10 0x109e055b8 JSC::Yarr::RegularExpression::Private::create(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode) 11 0x109e0554c JSC::Yarr::RegularExpression::RegularExpression(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode) 12 0x109e05651 JSC::Yarr::RegularExpression::RegularExpression(WTF::String const&, JSC::Yarr::TextCaseSensitivity, JSC::Yarr::MultilineMode, JSC::Yarr::UnicodeMode) 13 0x11e74ad3f WebCore::stringMatchesWildcardString(WTF::String const&, WTF::String const&) 14 0x1054c2ce6 TestWebKitAPI::WebCore_WildcardStringMatching_Test::TestBody() 15 0x10581ae14 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 16 0x1057e95db void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 17 0x1057e9516 testing::Test::Run() 18 0x1057ea6aa testing::TestInfo::Run() 19 0x1057eb594 testing::TestCase::Run() 20 0x1057f6c48 testing::internal::UnitTestImpl::RunAllTests() 21 0x10581fe14 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 22 0x1057f673b bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 23 0x1057f660d testing::UnitTest::Run() 24 0x1055cda51 RUN_ALL_TESTS() 25 0x1055cd9e2 TestWebKitAPI::TestsController::run(int, char**) 26 0x1057b5d5c main 27 0x7fff709fdcc9 start https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebCore.WildcardStringMatching 1663304 1 ryanhaddad 2020-06-16 16:52:40 -0700 This is related to https://trac.webkit.org/changeset/263117/webkit 1663306 2 webkit-bug-importer 2020-06-16 16:52:55 -0700 <rdar://problem/64427499> 1663343 3 402066 mark.lam 2020-06-16 18:31:34 -0700 Created attachment 402066 proposed patch. 1663345 4 402066 ysuzuki 2020-06-16 18:33:01 -0700 Comment on attachment 402066 proposed patch. r=me 1663356 5 mark.lam 2020-06-16 19:16:19 -0700 Thanks for the review. Landed in r263133: <http://trac.webkit.org/r263133>. 402066 2020-06-16 18:31:34 -0700 2020-06-16 18:33:01 -0700 proposed patch. bug-213270.patch text/plain 1431 mark.lam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MzEzMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA2LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBUZXN0V2ViS2l0QVBJLldlYkNvcmUuV2lsZGNhcmRTdHJpbmdNYXRjaGluZyBuZWVk cyB0byBpbml0aWFsaXplIE9wdGlvbnMgYmVmb3JlIGFjY2Vzc2luZyB0aGVtLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMjcwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82NDQyNzQ5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9TdHJpbmdVdGls aXRpZXMubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMC0wNi0xNiAg U2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdHdvIHR5cG9z ICJzaWduaWZjYW50IiBhbmQgInNpZ25maWNhbmNlIi4gU2hvdWxkIGJlICJzaWduaWZpY2FudCIg YW5kICJzaWduaWZpY2FuY2UiCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNv cmUvU3RyaW5nVXRpbGl0aWVzLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViQ29yZS9TdHJpbmdVdGlsaXRpZXMubW0JKHJldmlzaW9uIDI2MzEzMSkKKysrIFRv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9TdHJpbmdVdGlsaXRpZXMubW0JKHdvcmtp bmcgY29weSkKQEAgLTI1LDYgKzI1LDcgQEAKIAogI2ltcG9ydCAiY29uZmlnLmgiCiAKKyNpbXBv cnQgPEphdmFTY3JpcHRDb3JlL0luaXRpYWxpemVUaHJlYWRpbmcuaD4KICNpbXBvcnQgPFdlYkNv cmUvU3RyaW5nVXRpbGl0aWVzLmg+CiAjaW1wb3J0IDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIApA QCAtMzQsNiArMzUsOCBAQCBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiAKIFRFU1QoV2ViQ29y ZSwgV2lsZGNhcmRTdHJpbmdNYXRjaGluZykKIHsKKyAgICBKU0M6OmluaXRpYWxpemVUaHJlYWRp bmcoKTsKKwogICAgIFN0cmluZyB3aWxkY2FyZFN0cmluZyA9ICJhKmIiOwogICAgIEVYUEVDVF9U UlVFKHN0cmluZ01hdGNoZXNXaWxkY2FyZFN0cmluZygiYWFhYWJiIiwgImEqYiIpKTsKICAgICBF WFBFQ1RfVFJVRShzdHJpbmdNYXRjaGVzV2lsZGNhcmRTdHJpbmcoImFiIiwgd2lsZGNhcmRTdHJp bmcpKTsK