213234 2020-06-15 22:00:17 -0700 Web Inspector: Sources: objects in Scope Chain panel flicker when resizing details sidebar 2020-06-16 14:11:30 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi ddkilzer hi inspector-bugzilla-changes mjs webkit-bug-importer oldest_to_newest 1662981 0 hi 2020-06-15 22:00:17 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. set a JavaScript breakpoint 3. trigger the breakpoint from step #2 4. select the Scope Chain panel in the details sidebar 5. resize the details sidebar => objects in the Scope Chain panel flicker 1662983 1 hi 2020-06-15 22:00:34 -0700 <rdar://problem/64391213> 1662984 2 401981 hi 2020-06-15 22:02:31 -0700 Created attachment 401981 Patch 1663191 3 401981 ddkilzer 2020-06-16 12:08:34 -0700 Comment on attachment 401981 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401981&action=review > Source/WebInspectorUI/ChangeLog:12 > + Don't regenerate the DOM if the `layout` unless the reason is `WI.View.LayoutReason.Dirty`, > + such as if the current call frame changes or a watch expression is added/updated/removed. "Don't regenerate the DOM if the `layout`..." does what? (Sentence doesn't read properly.) 1663215 4 401981 hi 2020-06-16 13:38:35 -0700 Comment on attachment 401981 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401981&action=review >> Source/WebInspectorUI/ChangeLog:12 >> + such as if the current call frame changes or a watch expression is added/updated/removed. > > "Don't regenerate the DOM if the `layout`..." does what? (Sentence doesn't read properly.) Oh oops I meant "Don't regenerate the DOM in `layout` unless ..." 😅 1663218 5 402035 hi 2020-06-16 13:46:36 -0700 Created attachment 402035 Patch 1663234 6 ews-feeder 2020-06-16 14:11:29 -0700 Committed r263115: <https://trac.webkit.org/changeset/263115> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402035. 401981 2020-06-15 22:02:31 -0700 2020-06-16 13:46:36 -0700 Patch bug-213234-20200615220231.patch text/plain 1818 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdlNzJlNzM5ODE2ZTQ3YTQ3OGVmYTdmYzEzMGZk NzMzZjc2YmZmM2MuLjM3NzkxOTMyMDcyZjJiNTE5NDdjYjk3ZjVmNDdkM2E5MWQ0YjU3NGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA2LTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT b3VyY2VzOiBvYmplY3RzIGluIFNjb3BlIENoYWluIHBhbmVsIGZsaWNrZXIgd2hlbiByZXNpemlu ZyBkZXRhaWxzIHNpZGViYXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMzIzNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQzOTEyMTM+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL1Njb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV0ku U2NvcGVDaGFpbkRldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLmxheW91dCk6CisgICAgICAg IERvbid0IHJlZ2VuZXJhdGUgdGhlIERPTSBpZiB0aGUgYGxheW91dGAgdW5sZXNzIHRoZSByZWFz b24gaXMgYFdJLlZpZXcuTGF5b3V0UmVhc29uLkRpcnR5YCwKKyAgICAgICAgc3VjaCBhcyBpZiB0 aGUgY3VycmVudCBjYWxsIGZyYW1lIGNoYW5nZXMgb3IgYSB3YXRjaCBleHByZXNzaW9uIGlzIGFk ZGVkL3VwZGF0ZWQvcmVtb3ZlZC4KKwogMjAyMC0wNi0xNSAgUGF2ZWwgRmVsZG1hbiA8cGF2ZWwu ZmVsZG1hbkBnbWFpbC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogaW50cm9kdWNlIHJl cXVlc3QgaW50ZXJjZXB0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9TY29wZUNoYWluRGV0YWlsc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Njb3BlQ2hhaW5EZXRhaWxzU2lk ZWJhclBhbmVsLmpzCmluZGV4IDRjOTQ4OWEwMTAzNDc3MmQxN2JmZDNkZTg5NTk4ZjQ4ZjFlMTFm ZDkuLjI5OGYxNDY5MzA1Njc2OWIyZTlkMGMzNmFmODQ5YTM4NjAyNjZkN2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Njb3BlQ2hhaW5EZXRh aWxzU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1Njb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC0xMjQsNiArMTI0 LDExIEBAIFdJLlNjb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgU2NvcGVDaGFp bkRldGFpbHNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXCiAKICAgICBsYXlvdXQoKQogICAgIHsKKyAg ICAgICAgc3VwZXIubGF5b3V0KCk7CisKKyAgICAgICAgaWYgKHRoaXMubGF5b3V0UmVhc29uICE9 PSBXSS5WaWV3LkxheW91dFJlYXNvbi5EaXJ0eSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAg ICAgICBsZXQgY2FsbEZyYW1lID0gdGhpcy5fY2FsbEZyYW1lOwogCiAgICAgICAgIFByb21pc2Uu YWxsKFt0aGlzLl9nZW5lcmF0ZVdhdGNoRXhwcmVzc2lvbnNTZWN0aW9uKCksIHRoaXMuX2dlbmVy YXRlQ2FsbEZyYW1lc1NlY3Rpb24oKV0pLnRoZW4oZnVuY3Rpb24oc2VjdGlvbnMpIHsK 402035 2020-06-16 13:46:36 -0700 2020-06-16 14:11:30 -0700 Patch bug-213234.patch text/plain 1812 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdlNzJlNzM5ODE2ZTQ3YTQ3OGVmYTdmYzEzMGZk NzMzZjc2YmZmM2MuLjM3NzkxOTMyMDcyZjJiNTE5NDdjYjk3ZjVmNDdkM2E5MWQ0YjU3NGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA2LTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT b3VyY2VzOiBvYmplY3RzIGluIFNjb3BlIENoYWluIHBhbmVsIGZsaWNrZXIgd2hlbiByZXNpemlu ZyBkZXRhaWxzIHNpZGViYXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMzIzNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQzOTEyMTM+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgS2lsemVyLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9TY29wZUNoYWluRGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdJLlNj b3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5sYXlvdXQpOgorICAgICAgICBE b24ndCByZWdlbmVyYXRlIHRoZSBET00gaW4gYGxheW91dGAgdW5sZXNzIHRoZSByZWFzb24gaXMg YFdJLlZpZXcuTGF5b3V0UmVhc29uLkRpcnR5YCwgc3VjaAorICAgICAgICBhcyBpZiB0aGUgY3Vy cmVudCBjYWxsIGZyYW1lIGNoYW5nZXMgb3IgYSB3YXRjaCBleHByZXNzaW9uIGlzIGFkZGVkL3Vw ZGF0ZWQvcmVtb3ZlZC4KKwogMjAyMC0wNi0xNSAgUGF2ZWwgRmVsZG1hbiA8cGF2ZWwuZmVsZG1h bkBnbWFpbC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogaW50cm9kdWNlIHJlcXVlc3Qg aW50ZXJjZXB0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9TY29wZUNoYWluRGV0YWlsc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Njb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBh bmVsLmpzCmluZGV4IDRjOTQ4OWEwMTAzNDc3MmQxN2JmZDNkZTg5NTk4ZjQ4ZjFlMTFmZDkuLjI5 OGYxNDY5MzA1Njc2OWIyZTlkMGMzNmFmODQ5YTM4NjAyNjZkN2EgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Njb3BlQ2hhaW5EZXRhaWxzU2lk ZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1Njb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC0xMjQsNiArMTI0LDExIEBA IFdJLlNjb3BlQ2hhaW5EZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgU2NvcGVDaGFpbkRldGFp bHNTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXCiAKICAgICBsYXlvdXQoKQogICAgIHsKKyAgICAgICAg c3VwZXIubGF5b3V0KCk7CisKKyAgICAgICAgaWYgKHRoaXMubGF5b3V0UmVhc29uICE9PSBXSS5W aWV3LkxheW91dFJlYXNvbi5EaXJ0eSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBs ZXQgY2FsbEZyYW1lID0gdGhpcy5fY2FsbEZyYW1lOwogCiAgICAgICAgIFByb21pc2UuYWxsKFt0 aGlzLl9nZW5lcmF0ZVdhdGNoRXhwcmVzc2lvbnNTZWN0aW9uKCksIHRoaXMuX2dlbmVyYXRlQ2Fs bEZyYW1lc1NlY3Rpb24oKV0pLnRoZW4oZnVuY3Rpb24oc2VjdGlvbnMpIHsK