<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>213225</bug_id>
          
          <creation_ts>2020-06-15 19:13:29 -0700</creation_ts>
          <short_desc>[CMake][Visual Studio] CombinedDomains.json is generated twice in JavaScriptCore.vcxproj and InspectorBackendCommands.vcxproj</short_desc>
          <delta_ts>2020-06-16 12:47:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>annulen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>pvollan</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>saam</cc>
    
    <cc>sergio</cc>
    
    <cc>tzagallo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1662944</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-06-15 19:13:29 -0700</bug_when>
    <thetext>[CMake][Visual Studio] CombinedDomains.json is generated twice in JavaScriptCore.vcxproj and InspectorBackendCommands.vcxproj

&gt;  Generating ../../JavaScriptCore/DerivedSources/CombinedDomains.json
&gt; (...)
&gt;  Generating ../../JavaScriptCore/DerivedSources/CombinedDomains.json


r262203 (Bug 210014) added InspectorBackendCommands target.

This is similar with r246587 (Bug 198853).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1662947</commentid>
    <comment_count>1</comment_count>
      <attachid>401970</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-06-15 19:27:50 -0700</bug_when>
    <thetext>Created attachment 401970
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1663200</commentid>
    <comment_count>2</comment_count>
      <attachid>401970</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-06-16 12:47:30 -0700</bug_when>
    <thetext>Comment on attachment 401970
Patch

Clearing flags on attachment: 401970

Committed r263108: &lt;https://trac.webkit.org/changeset/263108&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1663201</commentid>
    <comment_count>3</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-06-16 12:47:34 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>401970</attachid>
            <date>2020-06-15 19:27:50 -0700</date>
            <delta_ts>2020-06-16 12:47:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-213225-20200616112749.patch</filename>
            <type>text/plain</type>
            <size>2328</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm
ZDE1ODNkZTdjZDc5MDg0Njc0YjdiMmUyYzM3ZjI4YWIwM2IyMThhLi5hMjljOTdiNTkwZjk1N2Jh
MDgzMmY0ZGE5YWQ4NzM4MGY1NWQzNWU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyMyBAQAorMjAyMC0wNi0xNSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz
b255LmNvbT4KKworICAgICAgICBbQ01ha2VdW1Zpc3VhbCBTdHVkaW9dIENvbWJpbmVkRG9tYWlu
cy5qc29uIGlzIGdlbmVyYXRlZCB0d2ljZSBpbiBKYXZhU2NyaXB0Q29yZS52Y3hwcm9qIGFuZCBJ
bnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMudmN4cHJvagorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgcjI2MjIwMyAoQnVnIDIxMDAxNCkgYWRkZWQg
YSBuZXcgdGFyZ2V0CisgICAgICAgIEluc3BlY3RvckJhY2tlbmRDb21tYW5kcywgQ29tYmluZWRE
b21haW5zLmpzb24gaXMgZ2VuZXJhdGVkIHR3aWNlCisgICAgICAgIGluIEphdmFTY3JpcHRDb3Jl
LnZjeHByb2ogYW5kIEluc3BlY3RvckJhY2tlbmRDb21tYW5kcy52Y3hwcm9qLgorICAgICAgICBU
aGlzIGNhdXNlZCB1bm5lY2Vzc2FyeSBpbmNyZW1lbnRhbCBidWlsZHMuCisKKyAgICAgICAgVGhl
IGZ1bmRhbWVudGFsIGlzc3VlIG9mIHRoaXMgaXNzdWUgd2FzIGZpeGVkIGluIENNYWtlIHNpZGUu
CisgICAgICAgIDxodHRwczovL2dpdGxhYi5raXR3YXJlLmNvbS9jbWFrZS9jbWFrZS9pc3N1ZXMv
MTY3Njc+CisgICAgICAgIEhvd2V2ZXIsIEphdmFTY3JpcHRDb3JlIHRhcmdldCBuZWVkcyB0byBo
YXZlIGEgZGlyZWN0IG9yIGluZGlyZWN0CisgICAgICAgIGRlcGVuZGVuY3kgb2YgSW5zcGVjdG9y
QmFja2VuZENvbW1hbmRzIHRhcmdldCBmb3IgQ01ha2UgVmlzdWFsCisgICAgICAgIFN0dWRpbyBn
ZW5lcmF0b3IgdG8gZWxpbWluYXRlIGR1cGxpY2F0ZWQgY3VzdG9tIGNvbW1hbmRzLgorCisgICAg
ICAgICogQ01ha2VMaXN0cy50eHQ6IEFkZGVkIGFkZF9kZXBlbmRlbmNpZXMoSmF2YVNjcmlwdENv
cmUgSW5zcGVjdG9yQmFja2VuZENvbW1hbmRzKS4KKwogMjAyMC0wNi0xNSAgUm9iaW4gTW9yaXNz
ZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgogCiAgICAgICAgIHRlc3RCMzo6dGVzdFJlcG9ydFVz
ZWRSZWdpc3RlcnNMYXRlVXNlRm9sbG93ZWRCeUVhcmx5RGVmRG9lc05vdE1hcmtVc2VBc0RlYWQo
KSBoYXMgYSB2YWxpZGF0aW9uIGZhaWx1cmUgaW4gZGVidWcgbW9kZQpkaWZmIC0tZ2l0IGEvU291
cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3Jl
L0NNYWtlTGlzdHMudHh0CmluZGV4IGE1Yzc0YzEyYzE0YWM5NDQ3YjcyYzRlNDU4ZDJlODg5NjMz
MTVkNDkuLjkxNzhkNmNmZjI3MWI0ZTIyYjRlODVmMjM0NzNjYWE3MDNmMjBmZDAgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTE0MTIsNiArMTQxMiwxMiBAQCBlbmRpZiAo
KQogYWRkX2N1c3RvbV90YXJnZXQoc3RhZ2VTaGFyZWRTY3JpcHRzIERFUEVORFMgJHtKYXZhU2Ny
aXB0Q29yZV9TQ1JJUFRTfSkKIGFkZF9kZXBlbmRlbmNpZXMoSmF2YVNjcmlwdENvcmUgc3RhZ2VT
aGFyZWRTY3JpcHRzICR7SmF2YVNjcmlwdENvcmVfRVhUUkFfREVQRU5ERU5DSUVTfSkKIAorIyBK
YXZhU2NyaXB0Q29yZSB0YXJnZXQgbmVlZHMgdG8gaGF2ZSBhIGRpcmVjdCBvciBpbmRpcmVjdCBk
ZXBlbmRlbmN5CisjIG9mIEluc3BlY3RvckJhY2tlbmRDb21tYW5kcyBmb3IgQ01ha2UgVmlzdWFs
IFN0dWRpbyBnZW5lcmF0b3IgdG8KKyMgZWxpbWluYXRlIGR1cGxpY2F0ZWQgY3VzdG9tIGNvbW1h
bmRzLiBPdGhlcndpc2UsCisjIENvbWJpbmVkRG9tYWlucy5qc29uIHdpbGwgYmUgZ2VuZXJhdGVk
IGluIGJvdGggcHJvamVjdHMuCithZGRfZGVwZW5kZW5jaWVzKEphdmFTY3JpcHRDb3JlIEluc3Bl
Y3RvckJhY2tlbmRDb21tYW5kcykKKwogaWYgKFVTRV9WRVJTSU9OX1NUQU1QRVIpCiAgICAgYWRk
X2N1c3RvbV9jb21tYW5kKAogICAgICAgICBUQVJHRVQgSmF2YVNjcmlwdENvcmUK
</data>

          </attachment>
      

    </bug>

</bugzilla>