213223 2020-06-15 17:08:19 -0700 WTF signal machinery is guarded by #if USE(PTHREADS) && HAVE(MACHINE_CONTEXT) but does not use pthreads or machine context 2020-06-16 16:23:04 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=173590 https://bugs.webkit.org/show_bug.cgi?id=213200 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro benjamin cdumez cmarcelo ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tpopela tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1662906 0 mcatanzaro 2020-06-15 17:08:19 -0700 WTF signal machinery is guarded by #if USE(PTHREADS) && HAVE(MACHINE_CONTEXT) but does not use pthreads or machine context. This is a follow-up to bug #213200. Mark's patch there should fix jsc-stress-tests when running cloop on architectures that enable HAVE(MACHINE_CONTEXT). This bug should fix it for other architectures. History: I found this guard was added in bug #173590 to fix the build on ports where HAVE(MACHINE_CONTEXT) was false. I'm testing a build with this setting disabled right now to make sure it works. 1662909 1 401960 mcatanzaro 2020-06-15 17:10:53 -0700 Created attachment 401960 Patch 1662910 2 mcatanzaro 2020-06-15 17:17:03 -0700 (In reply to Michael Catanzaro from comment #0) > I'm testing a build with this setting disabled right now to make sure it works. All good. I looked over the history of the file, but didn't immediately see which commit removed the dependency on machine context. Remaining problem is that the code lives under Source/WTF/wtf/threads/ but is not related to threading. 1662915 3 401960 mark.lam 2020-06-15 17:24:46 -0700 Comment on attachment 401960 Patch r=me if the EWS is green. 1662948 4 mcatanzaro 2020-06-15 19:45:12 -0700 (In reply to Michael Catanzaro from comment #2) > Remaining problem is that the code lives under Source/WTF/wtf/threads/ but > is not related to threading. Source/WTF/wtf/unix would probably be a better place.... 1662951 5 ews-feeder 2020-06-15 20:03:07 -0700 Committed r263074: <https://trac.webkit.org/changeset/263074> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401960. 1662952 6 webkit-bug-importer 2020-06-15 20:04:20 -0700 <rdar://problem/64390209> 1663046 7 mcatanzaro 2020-06-16 05:11:14 -0700 So although this code does not use MACHINE_CONTEXT and builds successfully with !HAVE(MACHINE_CONTEXT), this still failed because it does use ucontext_t in WTF::jscSignalHandler: PlatformRegisters& registers = registersFromUContext(reinterpret_cast<ucontext_t*>(ucontext)); bool didHandle = false; bool restoreDefaultHandler = false; handlers.forEachHandler(signal, [&] (const SignalHandler& handler) { switch (handler(signal, sigInfo, registers)) { case SignalAction::Handled: didHandle = true; break; case SignalAction::ForceDefault: restoreDefaultHandler = true; break; default: break; } }); registersFromUContext is not implemented for all supported architectures. I need to think about how to handle this. 1663060 8 mcatanzaro 2020-06-16 07:14:47 -0700 Reopening 1663280 9 mcatanzaro 2020-06-16 15:41:13 -0700 (In reply to Michael Catanzaro from comment #0) > WTF signal machinery is guarded by #if USE(PTHREADS) && > HAVE(MACHINE_CONTEXT) but does not use pthreads or machine context. So although this code compiles fine on x86_64 with HAVE(MACHINE_CONTEXT) enabled, it fails to build on ppc64le and s390x due to lacking registersFromUContext, which is guarded by HAVE(MACHINE_CONTEXT). That's my fault for failing to notice this. jscSignalHandler doesn't directly read the PlatformRegisters, but it does need to pass it on to the installed signal handler. Anyway, the solution here is also simple: we can just create an empty PlatformRegisters object when HAVE(MACHINE_CONTEXT) is false. Then signal handlers that depend on HAVE(MACHINE_CONTEXT) can then use MachineContext to make use of the PlatformRegisters, while signal handlers that don't depend on HAVE(MACHINE_CONTEXT) are not affected. At first, I was worried that passing an empty PlatformRegisters could be open to misuse, but it's actually kinda hard to misuse it because the only sensible thing you can do with it is pass it to MachineContext (otherwise it's just gobbledygook), and you can't use MachineContext outside HAVE(MACHINE_CONTEXT), so... we should be good. Patch incoming for this solution. An alternative solution would be to have a separate function signature for our signal handlers that lacks the PlatformRegisters parameter when HAVE(MACHINE_CONTEXT) is disabled, but then we have to define every signal handler twice if the signal handler is installed outside HAVE(MACHINE_CONTEXT) guards, so that's not ideal. Finally, we could attempt to implement every possible architecture in MachineContext.h, but I don't think it's reasonable. Distros support too many CPU architectures nowadays. Fedora only supports a handful of architectures, but Debian has 27. Not going to work. 1663284 10 mcatanzaro 2020-06-16 15:52:53 -0700 (In reply to Michael Catanzaro from comment #9) > So although this code compiles fine on x86_64 with HAVE(MACHINE_CONTEXT) > enabled, it fails to build on ppc64le and s390x due to lacking > registersFromUContext, which is guarded by HAVE(MACHINE_CONTEXT). I meant to write: "So although this code compiles fine on x86_64 with HAVE(MACHINE_CONTEXT) *disabled*" because that's what I tested yesterday. That said, I must have seriously messed up somehow, because there's no way it should have built without registersFromUContext. 1663286 11 402052 mcatanzaro 2020-06-16 15:55:54 -0700 Created attachment 402052 Patch 1663289 12 402052 ysuzuki 2020-06-16 15:58:34 -0700 Comment on attachment 402052 Patch r=me 1663297 13 ews-feeder 2020-06-16 16:23:03 -0700 Committed r263123: <https://trac.webkit.org/changeset/263123> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402052. 401960 2020-06-15 17:10:53 -0700 2020-06-15 20:03:07 -0700 Patch bug-213223-20200615191053.patch text/plain 4560 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ZTVmZmUxNTY0YjYzZjkyMGI2YzQ2N2U2Y2EzZmIxMTVlNzhmODU4Li45ZGY2YmFjMDc3MTI0Njk2 NmRiYTcwMGI4NDkwNGU0NTgzYWIyNTI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNi0xNSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu b21lLm9yZz4KKworICAgICAgICBXVEYgc2lnbmFsIG1hY2hpbmVyeSBpcyBndWFyZGVkIGJ5ICNp ZiBVU0UoUFRIUkVBRFMpICYmIEhBVkUoTUFDSElORV9DT05URVhUKSBidXQgZG9lcyBub3QgdXNl IHB0aHJlYWRzIG9yIG1hY2hpbmUgY29udGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXNlICNpZiBPUyhVTklYKSBoZXJlIHRvby4gVGhpcyBzaG91 bGQgZml4IHN0cmVzcy9lbnN1cmUtY3Jhc2guanMgd2hlbgorICAgICAgICBIQVZFKE1BQ0hJTkVf Q09OVEVYVCkgaXMgZmFsc2UuCisKKyAgICAgICAgKiBqc2MuY3BwOgorICAgICAgICAocHJpbnRV c2FnZVN0YXRlbWVudCk6CisgICAgICAgIChDb21tYW5kTGluZTo6cGFyc2VBcmd1bWVudHMpOgor CiAyMDIwLTA2LTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBE byBub3QgaW5zdGFsbCB0aGUgVk1UcmFwcyBzaWduYWwgaGFuZGxlciBpZiBPcHRpb25zOjp1c2VK SVQ9ZmFsc2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCmluZGV4IDE0ZmM4NjM0YTVhM2Q1ZjcwNjNkZmY5YjQ0YTk3Yzk0MDBkODhiNWQu LjBhZTk3NTUzYThmY2Y2NGUwNzNlYzNlOTg1NWQ5OTM0NzhiNDI3ZjAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMjAtMDYtMTUgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5v cmc+CisKKyAgICAgICAgV1RGIHNpZ25hbCBtYWNoaW5lcnkgaXMgZ3VhcmRlZCBieSAjaWYgVVNF KFBUSFJFQURTKSAmJiBIQVZFKE1BQ0hJTkVfQ09OVEVYVCkgYnV0IGRvZXMgbm90IHVzZSBwdGhy ZWFkcyBvciBtYWNoaW5lIGNvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxMzIyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVzZSAjaWYgT1MoVU5JWCkgaW5zdGVhZC4KKworICAgICAgICAqIHd0 Zi9XVEZDb25maWcuaDoKKyAgICAgICAgKiB3dGYvdGhyZWFkcy9TaWduYWxzLmNwcDoKKyAgICAg ICAgKiB3dGYvdGhyZWFkcy9TaWduYWxzLmg6CisKIDIwMjAtMDYtMTUgIEtlaXRoIE1pbGxlciAg PGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI2MzA0NSk6 IFRlc3RXVEYuU2lnbmFscy5TaWduYWxzV29ya09uRXhpdCBjcmFzaGluZwpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNj LmNwcAppbmRleCBiN2IwMjEzMGI3OTYyYzRlOGUwNzQ5MjA4ZDIzYzg2MTRjY2FlYmE5Li5iYTEz NGMzY2VlYjQyNTE1N2VjOTAwZTQ5NjQ0ZTI1MjFkMjE4ZGFhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvanNjLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNw cApAQCAtMjg4OCw3ICsyODg4LDcgQEAgc3RhdGljIE5PX1JFVFVSTiB2b2lkIHByaW50VXNhZ2VT dGF0ZW1lbnQoYm9vbCBoZWxwID0gZmFsc2UpCiAgICAgZnByaW50ZihzdGRlcnIsICIgIC1ofC0t aGVscCAgUHJpbnRzIHRoaXMgaGVscCBtZXNzYWdlXG4iKTsKICAgICBmcHJpbnRmKHN0ZGVyciwg IiAgLWkgICAgICAgICBFbmFibGVzIGludGVyYWN0aXZlIG1vZGUgKGRlZmF1bHQgaWYgbm8gZmls ZXMgYXJlIHNwZWNpZmllZClcbiIpOwogICAgIGZwcmludGYoc3RkZXJyLCAiICAtbSAgICAgICAg IEV4ZWN1dGUgYXMgYSBtb2R1bGVcbiIpOwotI2lmIFVTRShQVEhSRUFEUykgJiYgSEFWRShNQUNI SU5FX0NPTlRFWFQpCisjaWYgT1MoVU5JWCkKICAgICBmcHJpbnRmKHN0ZGVyciwgIiAgLXMgICAg ICAgICBJbnN0YWxscyBzaWduYWwgaGFuZGxlcnMgdGhhdCBleGl0IG9uIGEgY3Jhc2ggKFVuaXgg cGxhdGZvcm1zIG9ubHksIGxsZGIgd2lsbCBub3Qgd29yayB3aXRoIHRoaXMgb3B0aW9uKSBcbiIp OwogI2VuZGlmCiAgICAgZnByaW50ZihzdGRlcnIsICIgIC1wIDxmaWxlPiAgT3V0cHV0cyBwcm9m aWxpbmcgZGF0YSB0byBhIGZpbGVcbiIpOwpAQCAtMjk4MCw3ICsyOTgwLDcgQEAgdm9pZCBDb21t YW5kTGluZTo6cGFyc2VBcmd1bWVudHMoaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgICAgICAg ICAgY29udGludWU7CiAgICAgICAgIH0KICAgICAgICAgaWYgKCFzdHJjbXAoYXJnLCAiLXMiKSkg ewotI2lmIFVTRShQVEhSRUFEUykgJiYgSEFWRShNQUNISU5FX0NPTlRFWFQpCisjaWYgT1MoVU5J WCkKICAgICAgICAgICAgIFNpZ25hbEFjdGlvbiAoKmV4aXQpKFNpZ25hbCwgU2lnSW5mbyYsIFBs YXRmb3JtUmVnaXN0ZXJzJikgPSBbXSAoU2lnbmFsLCBTaWdJbmZvJiwgUGxhdGZvcm1SZWdpc3Rl cnMmKSB7CiAgICAgICAgICAgICAgICAgZGF0YUxvZ0xuKCJTaWduYWwgaGFuZGxlciBoaXQuIEV4 aXRpbmcgd2l0aCBzdGF0dXMgMCIpOwogICAgICAgICAgICAgICAgIF9leGl0KDApOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvV1RGQ29uZmlnLmggYi9Tb3VyY2UvV1RGL3d0Zi9XVEZDb25m aWcuaAppbmRleCAxYTUyZmMwZGI5ZTdkZWMxNmRhN2MwNjQ5NTA2YTUwNzRhNTlhOWZkLi5jZmFi NDYzYzVkOGYyZTk3ZDg2NWMxM2M1YTA5YzlkNjkxZDRhM2ExIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9XVEZDb25maWcuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9XVEZDb25maWcuaApAQCAt NjcsNyArNjcsNyBAQCBzdHJ1Y3QgQ29uZmlnIHsKIAogICAgIGJvb2wgaXNQZXJtYW5lbnRseUZy b3plbjsKIAotI2lmIFVTRShQVEhSRUFEUykgJiYgSEFWRShNQUNISU5FX0NPTlRFWFQpCisjaWYg T1MoVU5JWCkKICAgICBTaWduYWxIYW5kbGVycyBzaWduYWxIYW5kbGVyczsKICNlbmRpZgogICAg IFB0clRhZ0xvb2t1cCogcHRyVGFnTG9va3VwSGVhZDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL3RocmVhZHMvU2lnbmFscy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMu Y3BwCmluZGV4IGM0YzlhOTYwMzE3YzZiYzhiNTM2OGI4ZDRhNTM3NzAwZjEyNTY2YjYuLjBiNWNm Yjg2YTk5Y2IwNzE1ZDgyMjE4N2NiYWNhZTViZDU3ZjYzZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X VEYvd3RmL3RocmVhZHMvU2lnbmFscy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvdGhyZWFkcy9T aWduYWxzLmNwcApAQCAtMjYsNyArMjYsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1 ZGUgPHd0Zi90aHJlYWRzL1NpZ25hbHMuaD4KIAotI2lmIFVTRShQVEhSRUFEUykgJiYgSEFWRShN QUNISU5FX0NPTlRFWFQpCisjaWYgT1MoVU5JWCkKIAogI2lmIEhBVkUoTUFDSF9FWENFUFRJT05T KQogZXh0ZXJuICJDIiB7CkBAIC00MTcsNCArNDE3LDQgQEAgdm9pZCBTaWduYWxIYW5kbGVyczo6 aW5pdGlhbGl6ZSgpCiAKIH0gLy8gbmFtZXNwYWNlIFdURgogCi0jZW5kaWYgLy8gVVNFKFBUSFJF QURTKSAmJiBIQVZFKE1BQ0hJTkVfQ09OVEVYVCkKKyNlbmRpZiAvLyBPUyhVTklYKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmggYi9Tb3VyY2UvV1RGL3d0Zi90 aHJlYWRzL1NpZ25hbHMuaAppbmRleCBhNjAyYWQzMzUwZWZjZTlhZWFhNGU1ZmVlNWFjMTE0M2Fh MjdmMmY2Li5mZjUyNWY0YmIxYTEzYjgwNGNkODM1MzVlMzhlNDA4YzJkYWNlOWUzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuaAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi90aHJlYWRzL1NpZ25hbHMuaApAQCAtMjUsNyArMjUsNyBAQAogCiAjcHJhZ21hIG9uY2UKIAot I2lmIFVTRShQVEhSRUFEUykgJiYgSEFWRShNQUNISU5FX0NPTlRFWFQpCisjaWYgT1MoVU5JWCkK IAogI2luY2x1ZGUgPHNpZ25hbC5oPgogI2luY2x1ZGUgPHR1cGxlPgpAQCAtMTU0LDQgKzE1NCw0 IEBAIHVzaW5nIFdURjo6U2lnbmFsSGFuZGxlcjsKIHVzaW5nIFdURjo6YWRkU2lnbmFsSGFuZGxl cjsKIHVzaW5nIFdURjo6YWN0aXZhdGVTaWduYWxIYW5kbGVyc0ZvcjsKIAotI2VuZGlmIC8vIFVT RShQVEhSRUFEUykgJiYgSEFWRShNQUNISU5FX0NPTlRFWFQpCisjZW5kaWYgLy8gT1MoVU5JWCkK 402052 2020-06-16 15:55:54 -0700 2020-06-16 16:23:03 -0700 Patch bug-213223-20200616175553.patch text/plain 2273 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZkZDE0ODlhYmU0MTFlNGVjODEyOTZk OGZhMTM3MWM4NzczZWQ4MGMuLjljYzI0YzNmNGJiM2RkOTQwNmU1ODg4Y2U1YmY1NjM5NGEzNDkz NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDYtMTYgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgRml4IGJ1aWxkIHdpdGggIUhBVkUoTUFD SElORV9DT05URVhUKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjEzMjIzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NDM5MDIwOT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjYzMDc0LCBJIG1l c3NlZCB1cCBhbmQgYnJva2UgdGhlIGJ1aWxkIHdpdGggIUhBVkUoTUFDSElORV9DT05URVhUKS4g RXZlbiB0aG91Z2ggdGhlCisgICAgICAgIHNvbGUgcHVycG9zZSBvZiB0aGF0IGNvbW1pdCB3YXMg dG8gZml4ICFIQVZFKE1BQ0hJTkVfQ09OVEVYVCksIEkgbXVzdCBoYXZlIHNvbWVob3cgbWVzc2Vk IHVwCisgICAgICAgIHdoZW4gdGVzdGluZyBteSBjaGFuZ2UuCisKKyAgICAgICAgQW55d2F5LCB3 ZSBjYW4ganVzdCBjcmVhdGUgYW4gZW1wdHkgUGxhdGZvcm1SZWdpc3RlcnMgb2JqZWN0IHdoZW4g SEFWRShNQUNISU5FX0NPTlRFWFQpIGlzCisgICAgICAgIGZhbHNlLiBBdCBmaXJzdCwgSSB3YXMg d29ycmllZCB0aGF0IHBhc3NpbmcgYW4gZW1wdHkgUGxhdGZvcm1SZWdpc3RlcnMgY291bGQgYmUg b3BlbiB0bworICAgICAgICBtaXN1c2UsIGJ1dCBpdCdzIGFjdHVhbGx5IGhhcmQgdG8gbWlzdXNl IGl0IGJlY2F1c2UgdGhlIG9ubHkgc2Vuc2libGUgdGhpbmcgeW91IGNhbiBkbyB3aXRoCisgICAg ICAgIGl0IGlzIHBhc3MgaXQgdG8gTWFjaGluZUNvbnRleHQsIGFuZCB5b3UgY2FuJ3QgdXNlIE1h Y2hpbmVDb250ZXh0IG91dHNpZGUKKyAgICAgICAgSEFWRShNQUNISU5FX0NPTlRFWFQpLCBzbyB3 ZSBzaG91bGQgYmUgZ29vZC4KKworICAgICAgICAqIHd0Zi90aHJlYWRzL1NpZ25hbHMuY3BwOgor ICAgICAgICAoV1RGOjpqc2NTaWduYWxIYW5kbGVyKToKKwogMjAyMC0wNi0xNiAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgY2FsbGluZyB1c2VyUHJlZmVy cmVkTGFuZ3VhZ2VzKCkgaW4gdGhlIFVJUHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvdGhyZWFkcy9TaWduYWxzLmNwcCBiL1NvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5j cHAKaW5kZXggMGI1Y2ZiODZhOTljYjA3MTVkODIyMTg3Y2JhY2FlNWJkNTdmNjNlMy4uMmJjNGRm YWFhYmVjNWZkZDgyNjcxYjRhZjkxMWJjMTA1YjkxYmQ4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvdGhyZWFkcy9TaWduYWxzLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1Np Z25hbHMuY3BwCkBAIC00Nyw2ICs0Nyw3IEBAIGV4dGVybiAiQyIgewogI2luY2x1ZGUgPHd0Zi9B dG9taWNzLmg+CiAjaW5jbHVkZSA8d3RmL0RhdGFMb2cuaD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJE ZXN0cm95ZWQuaD4KKyNpbmNsdWRlIDx3dGYvUGxhdGZvcm1SZWdpc3RlcnMuaD4KICNpbmNsdWRl IDx3dGYvVGhyZWFkR3JvdXAuaD4KICNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAjaW5jbHVk ZSA8d3RmL1dURkNvbmZpZy5oPgpAQCAtMzYyLDcgKzM2MywxMSBAQCB2b2lkIGpzY1NpZ25hbEhh bmRsZXIoaW50IHNpZywgc2lnaW5mb190KiBpbmZvLCB2b2lkKiB1Y29udGV4dCkKICAgICBpZiAo c2lnbmFsID09IFNpZ25hbDo6QWNjZXNzRmF1bHQpCiAgICAgICAgIHNpZ0luZm8uZmF1bHRpbmdB ZGRyZXNzID0gaW5mby0+c2lfYWRkcjsKIAorI2lmIEhBVkUoTUFDSElORV9DT05URVhUKQogICAg IFBsYXRmb3JtUmVnaXN0ZXJzJiByZWdpc3RlcnMgPSByZWdpc3RlcnNGcm9tVUNvbnRleHQocmVp bnRlcnByZXRfY2FzdDx1Y29udGV4dF90Kj4odWNvbnRleHQpKTsKKyNlbHNlCisgICAgUGxhdGZv cm1SZWdpc3RlcnMgcmVnaXN0ZXJzIHsgfTsKKyNlbmRpZgogCiAgICAgYm9vbCBkaWRIYW5kbGUg PSBmYWxzZTsKICAgICBib29sIHJlc3RvcmVEZWZhdWx0SGFuZGxlciA9IGZhbHNlOwo=