21320 2008-10-02 16:09:10 -0700 leaks of PropertyNameArrayData seen on buildbot 2008-10-13 16:03:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P1 Normal --- 21513 1 ggaren sam oldest_to_newest 93816 0 ggaren 2008-10-02 16:09:10 -0700 StructureID holds a RefPtr to PropertyNameArrayData, and vice-versa. That's the leak. Sam mentioned that PropertyNameArrayData's pointer could be a weak pointer instead, cleared in the StructureID destructor. 94105 1 24092 sam 2008-10-04 14:32:18 -0700 Created attachment 24092 patch 94111 2 24092 oliver 2008-10-04 14:44:31 -0700 Comment on attachment 24092 patch r=me -- test case? 94113 3 sam 2008-10-04 14:59:16 -0700 Fixed in r37300. 24092 2008-10-04 14:32:18 -0700 2008-10-04 14:44:31 -0700 patch leak.diff text/plain 3370 sam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3Mjk3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMTAt MDQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMzIwCisgICAgICAgIGxlYWtzIG9mIFByb3BlcnR5TmFtZUFycmF5RGF0 YSBzZWVuIG9uIGJ1aWxkYm90CisKKyAgICAgICAgLSBGaXggUmVmUHRyIGN5Y2xlIGJ5IG1ha2lu ZyBQcm9wZXJ0eU5hbWVBcnJheURhdGEncyBwb2ludGVyIGJhY2sKKyAgICAgICAgICB0byB0aGUg U3RydWN0dXJlSUQgYSB3ZWFrIHBvaW50ZXIuCisKKyAgICAgICAgKiBranMvUHJvcGVydHlOYW1l QXJyYXkuaDoKKyAgICAgICAgKEpTQzo6UHJvcGVydHlOYW1lQXJyYXlEYXRhOjpzZXRDYWNoZWRT dHJ1Y3R1cmVJRCk6CisgICAgICAgIChKU0M6OlByb3BlcnR5TmFtZUFycmF5RGF0YTo6Y2FjaGVk U3RydWN0dXJlSUQpOgorICAgICAgICAqIGtqcy9TdHJ1Y3R1cmVJRC5jcHA6CisgICAgICAgIChK U0M6OlN0cnVjdHVyZUlEOjpnZXRFbnVtZXJhYmxlUHJvcGVydHlOYW1lcyk6CisgICAgICAgIChK U0M6OlN0cnVjdHVyZUlEOjpjbGVhckVudW1lcmF0aW9uQ2FjaGUpOgorICAgICAgICAoSlNDOjpT dHJ1Y3R1cmVJRDo6flN0cnVjdHVyZUlEKToKKwogMjAwOC0xMC0wNCAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2FtZXJvbiBad2FyaWNoLgpJ bmRleDoga2pzL1Byb3BlcnR5TmFtZUFycmF5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL1Byb3BlcnR5 TmFtZUFycmF5LmgJKHJldmlzaW9uIDM3MjY2KQorKysga2pzL1Byb3BlcnR5TmFtZUFycmF5LmgJ KHdvcmtpbmcgY29weSkKQEAgLTQxLDggKzQxLDggQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICAg ICAgUHJvcGVydHlOYW1lVmVjdG9yJiBwcm9wZXJ0eU5hbWVWZWN0b3IoKSB7IHJldHVybiBtX3By b3BlcnR5TmFtZVZlY3RvcjsgfQogCi0gICAgICAgIHZvaWQgc2V0Q2FjaGVkU3RydWN0dXJlSUQo UGFzc1JlZlB0cjxTdHJ1Y3R1cmVJRD4gc3RydWN0dXJlSUQpIHsgbV9jYWNoZWRTdHJ1Y3R1cmVJ RCA9IHN0cnVjdHVyZUlEOyB9Ci0gICAgICAgIFN0cnVjdHVyZUlEKiBjYWNoZWRTdHJ1Y3R1cmVJ RCgpIGNvbnN0IHsgcmV0dXJuIG1fY2FjaGVkU3RydWN0dXJlSUQuZ2V0KCk7IH0KKyAgICAgICAg dm9pZCBzZXRDYWNoZWRTdHJ1Y3R1cmVJRChTdHJ1Y3R1cmVJRCogc3RydWN0dXJlSUQpIHsgbV9j YWNoZWRTdHJ1Y3R1cmVJRCA9IHN0cnVjdHVyZUlEOyB9CisgICAgICAgIFN0cnVjdHVyZUlEKiBj YWNoZWRTdHJ1Y3R1cmVJRCgpIGNvbnN0IHsgcmV0dXJuIG1fY2FjaGVkU3RydWN0dXJlSUQ7IH0K IAogICAgICAgICB2b2lkIHNldENhY2hlZFByb3RvdHlwZUNoYWluKFBhc3NSZWZQdHI8U3RydWN0 dXJlSURDaGFpbj4gY2FjaGVkUHJvdG90eXBlQ2hhaW4pIHsgbV9jYWNoZWRQcm90b3R5cGVDaGFp biA9IGNhY2hlZFByb3RvdHlwZUNoYWluOyB9CiAgICAgICAgIFN0cnVjdHVyZUlEQ2hhaW4qIGNh Y2hlZFByb3RvdHlwZUNoYWluKCkgeyByZXR1cm4gbV9jYWNoZWRQcm90b3R5cGVDaGFpbi5nZXQo KTsgfQpAQCAtNTMsNyArNTMsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgfQogCiAgICAg ICAgIFByb3BlcnR5TmFtZVZlY3RvciBtX3Byb3BlcnR5TmFtZVZlY3RvcjsKLSAgICAgICAgUmVm UHRyPFN0cnVjdHVyZUlEPiBtX2NhY2hlZFN0cnVjdHVyZUlEOworICAgICAgICBTdHJ1Y3R1cmVJ RCogbV9jYWNoZWRTdHJ1Y3R1cmVJRDsKICAgICAgICAgUmVmUHRyPFN0cnVjdHVyZUlEQ2hhaW4+ IG1fY2FjaGVkUHJvdG90eXBlQ2hhaW47CiAgICAgfTsKIApJbmRleDoga2pzL1N0cnVjdHVyZUlE LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBranMvU3RydWN0dXJlSUQuY3BwCShyZXZpc2lvbiAzNzI2NikK KysrIGtqcy9TdHJ1Y3R1cmVJRC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxLDYgKzgxLDkgQEAg dm9pZCBTdHJ1Y3R1cmVJRDo6Z2V0RW51bWVyYWJsZVByb3BlcnR5TgogICAgICAgICBzdGF0aWNf Y2FzdDxKU09iamVjdCo+KG1fcHJvdG90eXBlKS0+Z2V0UHJvcGVydHlOYW1lcyhleGVjLCBwcm9w ZXJ0eU5hbWVzKTsKIAogICAgIGlmIChzaG91bGRDYWNoZSkgeworICAgICAgICBpZiAobV9jYWNo ZWRQcm9wZXJ0eU5hbWVBcnJheURhdGEpCisgICAgICAgICAgICBtX2NhY2hlZFByb3BlcnR5TmFt ZUFycmF5RGF0YS0+c2V0Q2FjaGVkU3RydWN0dXJlSUQoMCk7CisKICAgICAgICAgbV9jYWNoZWRQ cm9wZXJ0eU5hbWVBcnJheURhdGEgPSBwcm9wZXJ0eU5hbWVzLmRhdGEoKTsKIAogICAgICAgICBT dHJ1Y3R1cmVJRENoYWluKiBjaGFpbiA9IGNhY2hlZFByb3RvdHlwZUNoYWluKCk7CkBAIC05Myw2 ICs5Niw4IEBAIHZvaWQgU3RydWN0dXJlSUQ6OmdldEVudW1lcmFibGVQcm9wZXJ0eU4KIAogdm9p ZCBTdHJ1Y3R1cmVJRDo6Y2xlYXJFbnVtZXJhdGlvbkNhY2hlKCkKIHsKKyAgICBpZiAobV9jYWNo ZWRQcm9wZXJ0eU5hbWVBcnJheURhdGEpCisgICAgICAgIG1fY2FjaGVkUHJvcGVydHlOYW1lQXJy YXlEYXRhLT5zZXRDYWNoZWRTdHJ1Y3R1cmVJRCgwKTsKICAgICBtX2NhY2hlZFByb3BlcnR5TmFt ZUFycmF5RGF0YS5jbGVhcigpOwogfQogCkBAIC0xODIsNiArMTg3LDkgQEAgU3RydWN0dXJlSUQ6 On5TdHJ1Y3R1cmVJRCgpCiAgICAgICAgIEFTU0VSVChtX3ByZXZpb3VzLT5tX3RyYW5zaXRpb25U YWJsZS5jb250YWlucyhtYWtlX3BhaXIobV9uYW1lSW5QcmV2aW91cywgbV9hdHRyaWJ1dGVzSW5Q cmV2aW91cykpKTsKICAgICAgICAgbV9wcmV2aW91cy0+bV90cmFuc2l0aW9uVGFibGUucmVtb3Zl KG1ha2VfcGFpcihtX25hbWVJblByZXZpb3VzLCBtX2F0dHJpYnV0ZXNJblByZXZpb3VzKSk7CiAg ICAgfQorCisgICAgaWYgKG1fY2FjaGVkUHJvcGVydHlOYW1lQXJyYXlEYXRhKQorICAgICAgICBt X2NhY2hlZFByb3BlcnR5TmFtZUFycmF5RGF0YS0+c2V0Q2FjaGVkU3RydWN0dXJlSUQoMCk7CiB9 CiAKIFN0cnVjdHVyZUlEQ2hhaW4qIFN0cnVjdHVyZUlEOjpjcmVhdGVDYWNoZWRQcm90b3R5cGVD aGFpbigpCg==