213178 2020-06-14 04:33:06 -0700 [GStreamer] ImageDecoder hits Debug ASSERTs 2020-06-15 03:35:14 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia ews-watchlist gustavo menard vjaquez webkit-bug-importer oldest_to_newest 1662471 0 pnormand 2020-06-14 04:33:06 -0700 fast/images/animated-image-mp4{,-crash}.html crash in Debug bots, because we create a WeakPtr from a thread and access it from another one: Thread 1 (Thread 0x7f51590ff700 (LWP 32346)): #0 0x00007f51b4300b68 in WTFCrash() () at ../../Source/WTF/wtf/Assertions.cpp:293 #1 0x00007f51c24564c2 in _Z15CRASH_WITH_INFOz () at DerivedSources/ForwardingHeaders/wtf/Assertions.h:713 #2 0x00007f51c6c78c61 in _ZNK3WTF14WeakPtrFactoryIN7WebCore21ImageDecoderGStreamerENS_12EmptyCounterEE18initializeIfNeededERKS2_ (this=0x7f51aacc77f8, object=warning: can't find linker symbol for virtual table for `WebCore::ImageDecoderGStreamer' value warning: found `_ZTVN7WebCore21ImageDecoderGStreamerE' instead ...) at DerivedSources/ForwardingHeaders/wtf/WeakPtr.h:158 #3 0x00007f51c6c77db8 in _ZNK3WTF14WeakPtrFactoryIN7WebCore21ImageDecoderGStreamerENS_12EmptyCounterEE13createWeakPtrIS2_EENS_7WeakPtrIT_S3_EERS7_ (this=0x7f51aacc77f8, object=warning: can't find linker symbol for virtual table for `WebCore::ImageDecoderGStreamer' value warning: found `_ZTVN7WebCore21ImageDecoderGStreamerE' instead ...) at DerivedSources/ForwardingHeaders/wtf/WeakPtr.h:164 #4 0x00007f51c6c77116 in _ZN3WTF11makeWeakPtrIN7WebCore21ImageDecoderGStreamerEEEDaRT_ (object=warning: can't find linker symbol for virtual table for `WebCore::ImageDecoderGStreamer' value warning: found `_ZTVN7WebCore21ImageDecoderGStreamerE' instead ...) at DerivedSources/ForwardingHeaders/wtf/WeakPtr.h:240 #5 0x00007f51c6c771de in _ZN7WebCore21ImageDecoderGStreamer12InnerDecoderC2ERS0_PKcl (this=0x7f5159399000, decoder=warning: can't find linker symbol for virtual table for `WebCore::ImageDecoderGStreamer' value warning: found `_ZTVN7WebCore21ImageDecoderGStreamerE' instead ..., data=0x7f51686eba00 "", size=1600) at ../../Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h:89 #6 0x00007f51c6c77068 in _ZN7WebCore21ImageDecoderGStreamer12InnerDecoder6createERS0_PKcl (decoder=warning: can't find linker symbol for virtual table for `WebCore::ImageDecoderGStreamer' value warning: found `_ZTVN7WebCore21ImageDecoderGStreamerE' instead ..., data=0x7f51686eba00 "", size=1600) at ../../Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h:84 #7 0x00007f51c6c74555 in WebCore::ImageDecoderGStreamer::<lambda()>::operator()(void) const (__closure=0x7f51593ec828) at ../../Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:352 #8 0x00007f51c6c76cee in WTF::Detail::CallableWrapper<WebCore::ImageDecoderGStreamer::pushEncodedData(const WebCore::SharedBuffer&)::<lambda()>, void>::call(void) (this=0x7f51593ec820) at DerivedSources/ForwardingHeaders/wtf/Function.h:52 #9 0x00007f51c2459acb in _ZNK3WTF8FunctionIFvvEEclEv (this=0x7f51590fec30) at DerivedSources/ForwardingHeaders/wtf/Function.h:84 #10 0x00007f51b4338327 in _ZN3WTF6Thread10entryPointEPNS0_16NewThreadContextE (newThreadContext=0x7f51593cfa50) at ../../Source/WTF/wtf/Threading.cpp:167 #11 0x00007f51b43c1081 in WTF::wtfThreadEntryPoint(void*) (context=0x7f51593cfa50) at ../../Source/WTF/wtf/posix/ThreadingPOSIX.cpp:197 #12 0x00007f51ae81c5e2 in start_thread (arg=<optimized out>) at pthread_create.c:479 #13 0x00007f51ac4ad473 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95 1662473 1 401854 pnormand 2020-06-14 04:54:58 -0700 Created attachment 401854 Patch 1662603 2 ews-feeder 2020-06-15 03:34:02 -0700 Committed r263031: <https://trac.webkit.org/changeset/263031> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401854. 1662605 3 webkit-bug-importer 2020-06-15 03:35:14 -0700 <rdar://problem/64357040> 401854 2020-06-14 04:54:58 -0700 2020-06-15 03:34:03 -0700 Patch bug-213178-20200614045457.patch text/plain 3313 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM3OGQ4YzZlNTc4YTI1 ZDRjNDQ3ODUxNTg1YWY1ZjA1N2ZhYWRkMC4uNTFmNjE3NjUyNzEyYzY3YjE0NDZmODY3M2Y2NjM5 MThiZDk0YjI0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA2LTE0ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBJbWFnZURlY29kZXIgaGl0cyBEZWJ1ZyBBU1NFUlRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTMxNzgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXNzIGEgcmVmZXJlbmNlIG9mIHRoZSBkZWNvZGVy IHRvIGl0cyBpbm5lciBpbXBsZW1lbnRhdGlvbiBpbnN0ZWFkIG9mIGEgV2Vha1B0ciwgd2hpY2gK KyAgICAgICAgY2FuJ3QgYmUgdXNlZCBhY3Jvc3MgbXVsdGlwbGUgdGhyZWFkcy4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGZhc3QvaW1hZ2VzL2FuaW1hdGVkLWltYWdlLW1wNHssLWNyYXNofS5odG1s IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0ltYWdlRGVj b2RlckdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZURlY29kZXJHU3RyZWFt ZXI6OklubmVyRGVjb2Rlcjo6Y29ubmVjdERlY29kZXJQYWQpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZURlY29kZXJHU3RyZWFtZXIuaDoKKwogMjAyMC0wNi0x NCAgVGV0c3VoYXJ1IE9oemVraSAgPHRldHN1aGFydS5vaHpla2lAZ21haWwuY29tPgogCiAgICAg ICAgIFdpdGhkcmF3IEZpbGVSZWFkZXJTeW5jIGZyb20gU2VydmljZVdvcmtlcgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0ltYWdlRGVjb2Rl ckdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvSW1hZ2VEZWNvZGVyR1N0cmVhbWVyLmNwcAppbmRleCA4N2E0NGQyMWQyY2U3Nzk0OWExZDI4 MzFhOWI3OWVhODFhZGNhZmJiLi4zMjkzYzJiZjczNDExMDc2MmRmMmQ2OTdlYTJiNDBkNTY3MmI0 NzY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvSW1hZ2VEZWNvZGVyR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VEZWNvZGVyR1N0cmVhbWVyLmNwcApAQCAtMjM4LDcg KzIzOCw3IEBAIHZvaWQgSW1hZ2VEZWNvZGVyR1N0cmVhbWVyOjpJbm5lckRlY29kZXI6OmNvbm5l Y3REZWNvZGVyUGFkKEdzdFBhZCogcGFkKQogICAgICAgICB9LAogICAgICAgICB7IG51bGxwdHIg fQogICAgIH07Ci0gICAgZ3N0X2FwcF9zaW5rX3NldF9jYWxsYmFja3MoR1NUX0FQUF9TSU5LKHNp bmspLCAmY2FsbGJhY2tzLCBtX2RlY29kZXIuZ2V0KCksIG51bGxwdHIpOworICAgIGdzdF9hcHBf c2lua19zZXRfY2FsbGJhY2tzKEdTVF9BUFBfU0lOSyhzaW5rKSwgJmNhbGxiYWNrcywgJm1fZGVj b2RlciwgbnVsbHB0cik7CiAKICAgICBHUmVmUHRyPEdzdENhcHM+IGNhcHMgPSBhZG9wdEdSZWYo Z3N0X2NhcHNfZnJvbV9zdHJpbmcoInZpZGVvL3gtcmF3LCBmb3JtYXQ9KHN0cmluZylSR0JBIikp OwogICAgIGdfb2JqZWN0X3NldChzaW5rLCAic3luYyIsIGZhbHNlLCAiY2FwcyIsIGNhcHMuZ2V0 KCksIG51bGxwdHIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL0ltYWdlRGVjb2RlckdTdHJlYW1lci5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0ltYWdlRGVjb2RlckdTdHJlYW1lci5oCmluZGV4IDdl M2E2MDhhNjkyN2IzNjA4ZmUzMjM1OGUwNjVjZWM2ZWVjNTczMDkuLjZlYzEzYzAwNTVhMmU5NDAz MDM2MDYwOGM5YzRhNjk5YjdjZTNkYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9JbWFnZURlY29kZXJHU3RyZWFtZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VEZWNvZGVyR1N0cmVh bWVyLmgKQEAgLTM1LDcgKzM1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgQ29udGVu dFR5cGU7CiBjbGFzcyBJbWFnZURlY29kZXJHU3RyZWFtZXJTYW1wbGU7CiAKLWNsYXNzIEltYWdl RGVjb2RlckdTdHJlYW1lciBmaW5hbCA6IHB1YmxpYyBJbWFnZURlY29kZXIsIHB1YmxpYyBDYW5N YWtlV2Vha1B0cjxJbWFnZURlY29kZXJHU3RyZWFtZXI+IHsKK2NsYXNzIEltYWdlRGVjb2RlckdT dHJlYW1lciBmaW5hbCA6IHB1YmxpYyBJbWFnZURlY29kZXIgewogICAgIFdURl9NQUtFX0ZBU1Rf QUxMT0NBVEVEOwogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKEltYWdlRGVjb2RlckdTdHJlYW1l cik7CiBwdWJsaWM6CkBAIC04NSw3ICs4NSw3IEBAIHByaXZhdGU6CiAgICAgICAgIH0KIAogICAg ICAgICBJbm5lckRlY29kZXIoSW1hZ2VEZWNvZGVyR1N0cmVhbWVyJiBkZWNvZGVyLCBjb25zdCBj aGFyKiBkYXRhLCBnc3NpemUgc2l6ZSkKLSAgICAgICAgICAgIDogbV9kZWNvZGVyKG1ha2VXZWFr UHRyKGRlY29kZXIpKQorICAgICAgICAgICAgOiBtX2RlY29kZXIoZGVjb2RlcikKICAgICAgICAg ICAgICwgbV9ydW5Mb29wKFJ1bkxvb3A6OmN1cnJlbnQoKSkKICAgICAgICAgewogICAgICAgICAg ICAgbV9tZW1vcnlTdHJlYW0gPSBhZG9wdEdSZWYoZ19tZW1vcnlfaW5wdXRfc3RyZWFtX25ld19m cm9tX2RhdGEoZGF0YSwgc2l6ZSwgbnVsbHB0cikpOwpAQCAtMTAwLDcgKzEwMCw3IEBAIHByaXZh dGU6CiAgICAgICAgIHZvaWQgcHJlcGFyZVBpcGVsaW5lKCk7CiAgICAgICAgIHZvaWQgY29ubmVj dERlY29kZXJQYWQoR3N0UGFkKik7CiAKLSAgICAgICAgV2Vha1B0cjxJbWFnZURlY29kZXJHU3Ry ZWFtZXI+IG1fZGVjb2RlcjsKKyAgICAgICAgSW1hZ2VEZWNvZGVyR1N0cmVhbWVyJiBtX2RlY29k ZXI7CiAgICAgICAgIEdSZWZQdHI8R3N0RWxlbWVudD4gbV9waXBlbGluZTsKICAgICAgICAgR1Jl ZlB0cjxHSW5wdXRTdHJlYW0+IG1fbWVtb3J5U3RyZWFtOwogICAgICAgICBSdW5Mb29wJiBtX3J1 bkxvb3A7Cg==