213176 2020-06-14 00:07:10 -0700 Add wasm regresion test for loop 2020-06-14 11:56:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki darin takuo.kihira webkit-bug-importer oldest_to_newest 1662454 0 ysuzuki 2020-06-14 00:07:10 -0700 https://twitter.com/tkihira/status/1272041643990937600 (module (func $test (param f64) (result f64) f64.const 1.0 f64.const 2.0 local.get 0 i64.reinterpret_f64 i32.wrap_i64 i32.const 4096 i32.lt_u select ) (export "test" (func $test))) shows bug in iOS11, not in iOS13 according to the above tweet. It is worth adding this to our stress testing mechanism to ensure this regression does not happen in the future. 1662455 1 ysuzuki 2020-06-14 00:10:14 -0700 iOS11 => no OSR entry from the loop. There is BBQ & OMG and BBQ uses B3 O1. iOS13 => there is OSR entry from the loop. There are three tiers, LLInt, BBQ, and OMG. And BBQ uses Air instead of B3 O1. 1662457 2 takuo.kihira 2020-06-14 00:11:47 -0700 Thanks for filing, Yusuke! It should return either 1.0 or 2.0 (usually 2.0), but on the Mobile Safari in iOS 11.4.1 it returns 0 always. When I changed `i32.const 4096` to `i32.const 4095` (or less) it works well suddenly. 1662460 3 takuo.kihira 2020-06-14 00:16:53 -0700 As far as I checked, any inputs will occur the behavior always. If you need arguments, 0.5 would a good input to reproduce at least in my env. 1662461 4 ysuzuki 2020-06-14 00:19:37 -0700 Looked into the test more, and I guess this is https://bugs.webkit.org/show_bug.cgi?id=198106 1662462 5 ysuzuki 2020-06-14 00:22:06 -0700 (In reply to Yusuke Suzuki from comment #4) > Looked into the test more, and I guess this is > https://bugs.webkit.org/show_bug.cgi?id=198106 Yes, I think this is definitely this one. It is nice that we can have one more regression test :) 1662463 6 401852 ysuzuki 2020-06-14 00:28:15 -0700 Created attachment 401852 Patch 1662508 7 ews-feeder 2020-06-14 11:55:19 -0700 Committed r263011: <https://trac.webkit.org/changeset/263011> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401852. 1662509 8 webkit-bug-importer 2020-06-14 11:56:25 -0700 <rdar://problem/64343185> 401852 2020-06-14 00:28:15 -0700 2020-06-14 11:55:20 -0700 Patch bug-213176-20200614002814.patch text/plain 1863 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMDA4CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDgzZmNhZDIwMzU3MjYyNmY4MGE0NWQ1ZmQ0M2Nj ZmUzMzNiOWQ2OWMuLjEzZmMzYWJlMmE5NjMyN2NiYmQ5MDA4MzFkZDI2OThmYmE2NjI2OGEgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMjAtMDYtMTQgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgd2FzbSByZWdyZXNpb24gdGVzdCBmb3IgbG9vcAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMTc2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIG9u ZSBtb3JlIHJlZ3Jlc3Npb24gdGVzdCBmb3IgcjI0NjEzNC4KKworICAgICAgICAqIHdhc20vcmVn cmVzcy9yZWdyZXNzaW9uLXdpdGgtbG9vcC5qczogQWRkZWQuCisKIDIwMjAtMDYtMTMgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgYGVycm9yc2AgYW4g b3duIHByb3BlcnR5IG9mIGBBZ2dyZWdhdGVFcnJvcmAgaW5zdGVhZCBvZiBhIHByb3RvdHlwZSBh Y2Nlc3NvcgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy93YXNtL3JlZ3Jlc3MvcmVncmVzc2lvbi13aXRo LWxvb3AuanMgYi9KU1Rlc3RzL3dhc20vcmVncmVzcy9yZWdyZXNzaW9uLXdpdGgtbG9vcC5qcwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi40MDExZmU0ZDdiZTM1OGUzYTIxNzc1MmUwZDk3YmFjMWYzNDkyOTVmCi0tLSAv ZGV2L251bGwKKysrIGIvSlNUZXN0cy93YXNtL3JlZ3Jlc3MvcmVncmVzc2lvbi13aXRoLWxvb3Au anMKQEAgLTAsMCArMSwzMSBAQAoraW1wb3J0ICogYXMgYXNzZXJ0IGZyb20gJy4uL2Fzc2VydC5q cyc7CitpbXBvcnQgeyBpbnN0YW50aWF0ZSB9IGZyb20gJy4uL3dhYnQtd3JhcHBlci5qcyc7CisK K2NvbnN0IGluc3RhbmNlID0gaW5zdGFudGlhdGUoYAorKG1vZHVsZQorICAoZnVuYyAkdGVzdCAo cGFyYW0gZjY0KSAocmVzdWx0IGY2NCkKKyAgICBmNjQuY29uc3QgMS4wCisgICAgZjY0LmNvbnN0 IDIuMAorCisgICAgbG9jYWwuZ2V0IDAKKyAgICBpNjQucmVpbnRlcnByZXRfZjY0CisgICAgaTMy LndyYXBfaTY0CisKKyAgICBpMzIuY29uc3QgNDA5NgorICAgIGkzMi5sdF91CisgICAgc2VsZWN0 CispCisoZXhwb3J0ICJ0ZXN0IiAoZnVuYyAkdGVzdCkpKQorYCk7CisKK2ZvciAodmFyIGkgPSAw OyBpIDwgMWU0OyArK2kpIHsKKyAgICBhc3NlcnQuZXEoaW5zdGFuY2UuZXhwb3J0cy50ZXN0KDAu MTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMTExMSksIDIuMCk7CisgICAgYXNzZXJ0LmVx KGluc3RhbmNlLmV4cG9ydHMudGVzdCgwKSwgMS4wKTsKKyAgICBhc3NlcnQuZXEoaW5zdGFuY2Uu ZXhwb3J0cy50ZXN0KDEpLCAxLjApOworICAgIGFzc2VydC5lcShpbnN0YW5jZS5leHBvcnRzLnRl c3QoMiksIDEuMCk7CisgICAgYXNzZXJ0LmVxKGluc3RhbmNlLmV4cG9ydHMudGVzdCgzKSwgMS4w KTsKKyAgICBhc3NlcnQuZXEoaW5zdGFuY2UuZXhwb3J0cy50ZXN0KDAuNSksIDEuMCk7CisgICAg YXNzZXJ0LmVxKGluc3RhbmNlLmV4cG9ydHMudGVzdCgtMC41KSwgMS4wKTsKKyAgICBhc3NlcnQu ZXEoaW5zdGFuY2UuZXhwb3J0cy50ZXN0KDIwMDAwMCksIDEuMCk7CisgICAgYXNzZXJ0LmVxKGlu c3RhbmNlLmV4cG9ydHMudGVzdCgtMjAwMDAwKSwgMS4wKTsKK30K