213173 2020-06-13 14:02:30 -0700 REGRESSION(r262994): [GTK] More than 100 tests are failing 2020-06-17 18:28:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206738 InRadar P2 Normal --- 211988 1 dpino dpino ddkilzer webkit-bug-importer oldest_to_newest 1662423 0 dpino 2020-06-13 14:02:30 -0700 Many tests started failing in GTK Release (Tests) build #14065 (https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/14065) https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r262995%20(14065)/results.html There are only two revisions in the build. I bisected the revisions and verified the failures started happening in r262994. 1662470 1 dpino 2020-06-14 04:07:07 -0700 https://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20(Tests)/r263006%20(6439)/fast/loader/javascript-url-in-embed-crash-log.txt STDERR: STDERR: warning: core file may not match specified executable file. STDERR: ASSERTION FAILED: WTF::isValidEnum<E>(WTF::enumToUnderlyingType<E>(enumValue)) STDERR: ../../Source/WebKit/Platform/IPC/Encoder.h(108) : void IPC::Encoder::encode(E) [with E = WebCore::PluginLoadClientPolicy; std::enable_if_t<std::is_enum<_Tp>::value>* <anonymous> = 0] STDERR: 1 0x7f70a743bb63 WTFCrash 1663376 2 ddkilzer 2020-06-16 21:52:05 -0700 Sorry, just noticed this. Will look into it tomorrow. (Also forgot that GTK tests aren't run by EWS.) 1663377 3 ddkilzer 2020-06-16 22:01:19 -0700 I wonder if we just need to provide a default initializer for WebCore::PluginInfo::clientLoadPolicy (and ::isApplicationPlugin while we're here): diff --git a/Source/WebCore/plugins/PluginData.h b/Source/WebCore/plugins/PluginData.h index 259e3dc847e..1ca828883cc 100644 --- a/Source/WebCore/plugins/PluginData.h +++ b/Source/WebCore/plugins/PluginData.h @@ -67,7 +67,7 @@ struct PluginInfo { Vector<MimeClassInfo> mimes; - bool isApplicationPlugin; + bool isApplicationPlugin { false }; - PluginLoadClientPolicy clientLoadPolicy; + PluginLoadClientPolicy clientLoadPolicy { PluginLoadClientPolicy::Undefined }; String bundleIdentifier; #if PLATFORM(MAC) 1663395 4 402085 dpino 2020-06-17 00:26:25 -0700 Created attachment 402085 Patch 1663396 5 402086 dpino 2020-06-17 00:28:37 -0700 Created attachment 402086 Patch 1663403 6 dpino 2020-06-17 01:17:56 -0700 Committed r263139: <https://trac.webkit.org/changeset/263139> 1663404 7 webkit-bug-importer 2020-06-17 01:18:16 -0700 <rdar://problem/64439668> 1663405 8 dpino 2020-06-17 01:18:59 -0700 Thank you David. Your patch fixed the regression (I run the tests locally to verify it). 1663525 9 ddkilzer 2020-06-17 09:20:56 -0700 (In reply to Diego Pino from comment #8) > Thank you David. Your patch fixed the regression (I run the tests locally to > verify it). Great! Thanks for testing the fix and committing it. 402085 2020-06-17 00:26:25 -0700 2020-06-17 00:28:34 -0700 Patch bug-213173-20200617092624.patch text/plain 1381 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTkwOTg0YmI1YWE5NzBm MmYyZDRjZDRhZjlhZDA0NTNkZjNmM2ZjMC4uMDBkZDYxM2QwOGZjMDVkNzRlN2M2NTU1MTdlM2Ex OWExNDZlMzJkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA2LTE3ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjYyOTk0KTogW0dUS10gTW9yZSB0aGFuIDEwMCB0ZXN0cyBhcmUgZmFpbGluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMTczCisKKyAgICAgICAg QWRkIGRlZmF1bHQgaW5pdGlhbGl6YXRpb24gZm9yIFdlYkNvcmU6OlBsdWdpbkluZm86OmNsaWVu dExvYWRQb2xpY3kgYW5kCisgICAgICAgIFdlYkNvcmU6OlBsdWdpbkluZm86OmlzQXBwbGljYXRp b25QbHVnaW4uCisKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpbkRhdGEuaDoKKwogMjAyMC0wNi0x NiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtTdWJwaXhlbF0g UmVwbGFjZWQgY29udGVudCBibGVlZHMgb3ZlciBjb250ZW50IGJveCB3aGVuIGJvcmRlciByYWRp dXMgaXMgc2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpbkRhdGEu aCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5oCmluZGV4IDI1OWUzZGM4NDdl MDI0YmUxN2E3MWNmOTc1ZDcwMmJiODY3N2FiMTEuLmVhYTY0M2U0NWU4MTAzYjJhZTQ2ZWZiYzE1 M2U3MjlhNzkyZGJjNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2lu RGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5oCkBAIC02NSw5 ICs2NSw5IEBAIHN0cnVjdCBQbHVnaW5JbmZvIHsKICAgICBTdHJpbmcgZmlsZTsKICAgICBTdHJp bmcgZGVzYzsKICAgICBWZWN0b3I8TWltZUNsYXNzSW5mbz4gbWltZXM7Ci0gICAgYm9vbCBpc0Fw cGxpY2F0aW9uUGx1Z2luOworICAgIGJvb2wgaXNBcHBsaWNhdGlvblBsdWdpbiB7IGZhbHNlIH07 CiAKLSAgICBQbHVnaW5Mb2FkQ2xpZW50UG9saWN5IGNsaWVudExvYWRQb2xpY3k7CisgICAgUGx1 Z2luTG9hZENsaWVudFBvbGljeSBjbGllbnRMb2FkUG9saWN5IHsgUGx1Z2luTG9hZENsaWVudFBv bGljeTo6VW5kZWZpbmVkIH07CiAKICAgICBTdHJpbmcgYnVuZGxlSWRlbnRpZmllcjsKICNpZiBQ TEFURk9STShNQUMpCg== 402086 2020-06-17 00:28:37 -0700 2020-06-17 00:28:37 -0700 Patch bug-213173-20200617092836.patch text/plain 1414 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTkwOTg0YmI1YWE5NzBm MmYyZDRjZDRhZjlhZDA0NTNkZjNmM2ZjMC4uYTllNTQwN2UwODEzZmY3NzY4YTk1MzgyYmU4ODgx MTlmYWJjMWNkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA2LTE3ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjYyOTk0KTogW0dUS10gTW9yZSB0aGFuIDEwMCB0ZXN0cyBhcmUgZmFpbGluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMTczCisKKyAgICAgICAg VW5yZXZpZXdlZCBnYXJkZW5pbmcuCisKKyAgICAgICAgQWRkIGRlZmF1bHQgaW5pdGlhbGl6YXRp b24gZm9yIFdlYkNvcmU6OlBsdWdpbkluZm86OmNsaWVudExvYWRQb2xpY3kgYW5kCisgICAgICAg IFdlYkNvcmU6OlBsdWdpbkluZm86OmlzQXBwbGljYXRpb25QbHVnaW4uCisKKyAgICAgICAgKiBw bHVnaW5zL1BsdWdpbkRhdGEuaDoKKwogMjAyMC0wNi0xNiAgWmFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtTdWJwaXhlbF0gUmVwbGFjZWQgY29udGVudCBibGVlZHMg b3ZlciBjb250ZW50IGJveCB3aGVuIGJvcmRlciByYWRpdXMgaXMgc2V0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpbkRhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdp bnMvUGx1Z2luRGF0YS5oCmluZGV4IDI1OWUzZGM4NDdlMDI0YmUxN2E3MWNmOTc1ZDcwMmJiODY3 N2FiMTEuLmVhYTY0M2U0NWU4MTAzYjJhZTQ2ZWZiYzE1M2U3MjlhNzkyZGJjNWUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsdWdpbnMvUGx1Z2luRGF0YS5oCkBAIC02NSw5ICs2NSw5IEBAIHN0cnVjdCBQbHVnaW5J bmZvIHsKICAgICBTdHJpbmcgZmlsZTsKICAgICBTdHJpbmcgZGVzYzsKICAgICBWZWN0b3I8TWlt ZUNsYXNzSW5mbz4gbWltZXM7Ci0gICAgYm9vbCBpc0FwcGxpY2F0aW9uUGx1Z2luOworICAgIGJv b2wgaXNBcHBsaWNhdGlvblBsdWdpbiB7IGZhbHNlIH07CiAKLSAgICBQbHVnaW5Mb2FkQ2xpZW50 UG9saWN5IGNsaWVudExvYWRQb2xpY3k7CisgICAgUGx1Z2luTG9hZENsaWVudFBvbGljeSBjbGll bnRMb2FkUG9saWN5IHsgUGx1Z2luTG9hZENsaWVudFBvbGljeTo6VW5kZWZpbmVkIH07CiAKICAg ICBTdHJpbmcgYnVuZGxlSWRlbnRpZmllcjsKICNpZiBQTEFURk9STShNQUMpCg==