213162 2020-06-12 20:50:09 -0700 [LFC][Floats] Floating positioned box is always a float avoider. 2020-06-13 17:40:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham darin koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1662319 0 zalan 2020-06-12 20:50:09 -0700 it avoids other floats. 1662328 1 401825 zalan 2020-06-12 21:52:58 -0700 Created attachment 401825 Patch 1662433 2 401825 darin 2020-06-13 14:38:20 -0700 Comment on attachment 401825 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401825&action=review > Source/WebCore/layout/layouttree/LayoutBox.cpp:180 > + if (isFloatingPositioned() || hasFloatClear()) > + return true; > + > + return establishesTableFormattingContext() || establishesIndependentFormattingContext() || (establishesBlockFormattingContext() && !establishesInlineFormattingContext()); Would one long chain of conditions separated by || be more logical and readable than a separate if statement? Or are we making a point by using a separate if? 1662437 3 zalan 2020-06-13 15:20:54 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 401825 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401825&action=review > > > Source/WebCore/layout/layouttree/LayoutBox.cpp:180 > > + if (isFloatingPositioned() || hasFloatClear()) > > + return true; > > + > > + return establishesTableFormattingContext() || establishesIndependentFormattingContext() || (establishesBlockFormattingContext() && !establishesInlineFormattingContext()); > > Would one long chain of conditions separated by || be more logical and > readable than a separate if statement? Or are we making a point by using a > separate if? Yes, I was trying to make dedicated explicit/implicit groups here (whether the reason for the float avoiding behavior is some float related styles such as clear or some other seemingly unrelated reasons like table element etc.) 1662444 4 ews-feeder 2020-06-13 17:39:16 -0700 Committed r263007: <https://trac.webkit.org/changeset/263007> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401825. 1662445 5 webkit-bug-importer 2020-06-13 17:40:17 -0700 <rdar://problem/64334402> 401825 2020-06-12 21:52:58 -0700 2020-06-13 17:39:17 -0700 Patch bug-213162-20200612215257.patch text/plain 3805 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTUwZjQ5NTVhY2QxMjkx YWViZjMxZjBlYWE1YTlkOTE4OTJkMTE0NC4uN2IxM2RiZjJhYzZmMGUzOTlmMzYxNjkyM2RhN2Nj OGY0YjBmNjZhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA2LTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRzXSBGbG9h dGluZyBwb3NpdGlvbmVkIGJveCBpcyBhbHdheXMgYSBmbG9hdCBhdm9pZGVyLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMTYyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9sYXlvdXRm b3JtYXR0aW5nY29udGV4dC9pbmxpbmUtZmxvYXQtc2ltcGxlLmh0bWwKKworICAgICAgICAqIGxh eW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6 OkJveDo6aXNGbG9hdEF2b2lkZXIgY29uc3QpOiBhbHNvIGZpeCB0aGUgaW5kZXBlbmRlbnQgZm9y bWF0dGluZyBjb250ZXh0IGNhc2UuCisKIDIwMjAtMDYtMTEgIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtURkNdIEFkZCBzdXBwb3J0IGZvciBtaW4vbWF4 LXdpZHRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlv dXRCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNw cAppbmRleCA3ZDE5OGQxNDZiM2JlYTdmYmUzYWE2OTI3NWQ4OTZhMzIwOWI5ZDcxLi44ZTNjMGI3 YzExN2U1NTRkZDAyNTRhMWIzZjIyNmI5YzdhMzdmYWI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHAKQEAgLTE3NCw5ICsxNzQsMTAgQEAgYm9v bCBCb3g6Omhhc0Zsb2F0Q2xlYXIoKSBjb25zdAogCiBib29sIEJveDo6aXNGbG9hdEF2b2lkZXIo KSBjb25zdAogewotICAgIGlmIChlc3RhYmxpc2hlc0luZGVwZW5kZW50Rm9ybWF0dGluZ0NvbnRl eHQoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIHJldHVybiAoZXN0YWJsaXNoZXNCbG9j a0Zvcm1hdHRpbmdDb250ZXh0KCkgJiYgIWVzdGFibGlzaGVzSW5saW5lRm9ybWF0dGluZ0NvbnRl eHQoKSkgfHwgZXN0YWJsaXNoZXNUYWJsZUZvcm1hdHRpbmdDb250ZXh0KCkgfHwgaGFzRmxvYXRD bGVhcigpOworICAgIGlmIChpc0Zsb2F0aW5nUG9zaXRpb25lZCgpIHx8IGhhc0Zsb2F0Q2xlYXIo KSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICByZXR1cm4gZXN0YWJsaXNoZXNUYWJsZUZv cm1hdHRpbmdDb250ZXh0KCkgfHwgZXN0YWJsaXNoZXNJbmRlcGVuZGVudEZvcm1hdHRpbmdDb250 ZXh0KCkgfHwgKGVzdGFibGlzaGVzQmxvY2tGb3JtYXR0aW5nQ29udGV4dCgpICYmICFlc3RhYmxp c2hlc0lubGluZUZvcm1hdHRpbmdDb250ZXh0KCkpOwogfQogCiBjb25zdCBDb250YWluZXJCb3gm IEJveDo6Y29udGFpbmluZ0Jsb2NrKCkgY29uc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhMDM2MTEzOWU3YTI4MGZkNTlj YjRmMTEzYjdhNTg2OTQ1MWY3NDQzLi4xMzA3NTk2MmYzMWU1ZTYzZTQ3ZmU2OTAzYjJmOTkxMzMz ZjZlZjI4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDYtMTIgIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtGbG9hdHNdIEZsb2F0aW5nIHBvc2l0 aW9uZWQgYm94IGlzIGFsd2F5cyBhIGZsb2F0IGF2b2lkZXIuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTMxNjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRl eHQvaW5saW5lLWZsb2F0LXNpbXBsZS1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2lubGluZS1mbG9hdC1zaW1wbGUuaHRtbDogQWRk ZWQuCisKIDIwMjAtMDYtMTEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBbTEZDXVtURkNdIEFkZCBzdXBwb3J0IGZvciBtaW4vbWF4LXdpZHRoCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2lubGluZS1mbG9hdC1z aW1wbGUtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2Nv bnRleHQvaW5saW5lLWZsb2F0LXNpbXBsZS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjcyODM3 NTYyYzE0NDA1OTk0MTNkNjM2YzQ0M2JjYjY3YjJmNzBlNjIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2lubGluZS1mbG9hdC1zaW1w bGUtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDEwIEBACis8IURPQ1RZUEUgaHRtbD4gPCEtLSB3 ZWJraXQtdGVzdC1ydW5uZXIgWyBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0aW5nQ29udGV4dEVuYWJs ZWQ9dHJ1ZSBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0aW5nQ29udGV4dEludGVncmF0aW9uRW5hYmxl ZD1mYWxzZSBdIC0tPgorPHN0eWxlPgorICBkaXYgeworICAgIGZsb2F0OiByaWdodDsKKyAgICB3 aWR0aCA6IDQyMHB4OworICAgIGhlaWdodDogMjBweDsgCisgICAgYm9yZGVyOiAxcHggc29saWQg Z3JlZW47CisgIH0KKzwvc3R5bGU+Cis8ZGl2PjwvZGl2PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC9pbmxpbmUtZmxvYXQtc2ltcGxlLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2lubGluZS1mbG9hdC1z aW1wbGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mMGU5OWRiYmZhNTQzODZmYTQ5MjU4NTFhM2U3ODAzMzdk YTBiOWNkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9sYXlvdXRmb3JtYXR0 aW5nY29udGV4dC9pbmxpbmUtZmxvYXQtc2ltcGxlLmh0bWwKQEAgLTAsMCArMSwxMSBAQAorPCFE T0NUWVBFIGh0bWw+IDwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgaW50ZXJuYWw6TGF5b3V0Rm9y bWF0dGluZ0NvbnRleHRFbmFibGVkPXRydWUgaW50ZXJuYWw6TGF5b3V0Rm9ybWF0dGluZ0NvbnRl eHRJbnRlZ3JhdGlvbkVuYWJsZWQ9ZmFsc2UgXSAtLT4KKzxzdHlsZT4KKyAgZGl2IHsKKyAgICBm bG9hdDogcmlnaHQ7CisgICAgZm9udC1mYW1pbHk6IEFoZW07CisgICAgZm9udC1zaXplOiAyMHB4 OworICAgIGNvbG9yOiB3aGl0ZTsKKyAgICBib3JkZXI6IDFweCBzb2xpZCBncmVlbjsKKyAgfQor PC9zdHlsZT4KKzxkaXY+ZmxvYXRpbmcgdGV4dCBjb250ZW50PC9kaXY+Cg==