213157 2020-06-12 17:06:49 -0700 [Mac Catalyst] Color inputs and selects fail to display popovers when clicked 2020-06-13 11:14:20 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin cdumez megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1662247 0 wenson_hsieh 2020-06-12 17:06:49 -0700 <rdar://problem/64004135> 1662335 1 401828 wenson_hsieh 2020-06-13 00:51:42 -0700 Created attachment 401828 Patch 1662337 2 401828 thorton 2020-06-13 01:17:23 -0700 Comment on attachment 401828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401828&action=review > Source/WebKit/ChangeLog:9 > + In Mac Catalyst, presenting popovers using `UIPopoverController` causes the first responder to change. This Not totally clear why presenting a popover on iOS doesn't also cause the first responder to change, but ... OK? 1662382 3 wenson_hsieh 2020-06-13 11:00:26 -0700 (In reply to Tim Horton from comment #2) > Comment on attachment 401828 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401828&action=review > > > Source/WebKit/ChangeLog:9 > > + In Mac Catalyst, presenting popovers using `UIPopoverController` causes the first responder to change. This > > Not totally clear why presenting a popover on iOS doesn't also cause the > first responder to change, but ... OK? It looks like it's pretty much due to UIKit implementation details. On Mac Catalyst, _UIPopoverSceneManager is used to present popovers, which resigns first responder underneath -createPopoverSceneForContentViewController:sourceView:sourceRectInParentUIWindow:contentSize:permittedArrowDirections:showsArrow:userInterfaceStyle:withCompletionBlock:]. This codepath isn't taken on iOS and iPadOS. 1662387 4 ews-feeder 2020-06-13 11:14:19 -0700 Committed r263001: <https://trac.webkit.org/changeset/263001> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401828. 401828 2020-06-13 00:51:42 -0700 2020-06-13 11:14:20 -0700 Patch bug-213157-20200613005141.patch text/plain 2895 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyOTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI4MThmNTAxMjAxNDhjMDRj OWFkOTc3ZTRhYjFlNzlkZjFkZjFiNWQuLmRiYmI0YTVhMGJlOGFiZjZmOWVmMzI1OGU5ZmIzZDIw YmZiNjIzNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDYtMTMgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW01hYyBDYXRhbHlzdF0g Q29sb3IgaW5wdXRzIGFuZCBzZWxlY3RzIGZhaWwgdG8gZGlzcGxheSBwb3BvdmVycyB3aGVuIGNs aWNrZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MzE1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQwMDQxMzU+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gTWFjIENhdGFseXN0LCBwcmVzZW50 aW5nIHBvcG92ZXJzIHVzaW5nIGBVSVBvcG92ZXJDb250cm9sbGVyYCBjYXVzZXMgdGhlIGZpcnN0 IHJlc3BvbmRlciB0byBjaGFuZ2UuIFRoaXMKKyAgICAgICAgbWVhbnMgdGhhdCB0aGUgV0tDb250 ZW50VmlldyB3aWxsIHJlc2lnbiBmaXJzdCByZXNwb25kZXIsIHdoaWNoIGluIHR1cm4gY2F1c2Vz IHRoZSBjdXJyZW50bHkgcHJlc2VudGVkIHBvcG92ZXIKKyAgICAgICAgdG8gYmUgZGlzbWlzc2Vk LiBUaGlzIG1lYW5zIHRoYXQgcG9wb3ZlcnMgZm9yIGNvbG9yIGlucHV0cyBhbmQgc2VsZWN0IGVs ZW1lbnRzIHdpbGwgYmUgZGlzbWlzc2VkIGltbWVkaWF0ZWx5CisgICAgICAgIGFmdGVyIHByZXNl bnRhdGlvbi4KKworICAgICAgICBUbyBtaXRpZ2F0ZSB0aGlzLCBhZGFwdCB0aGUgYXBwcm9hY2gg dGFrZW4gaW4gcjI1OTg0MCB0byBgV0tDb2xvclBvcG92ZXJgIGFuZCBgV0tTZWxlY3RQb3BvdmVy YCBieSB0ZWFjaGluZyB0aGUKKyAgICAgICAgYmFzZSBjbGFzcyAoYFdLUm90YXRpbmdQb3BvdmVy YCkgdG8gdGVtcG9yYXJpbHkgcHJlc2VydmUgdGhlIGZvY3VzZWQgZWxlbWVudCBpbiBsaWdodCBv ZiBmaXJzdCByZXNwb25kZXIgY2hhbmdlcworICAgICAgICB3aGlsZSBwcmVzZW50aW5nIGEgcG9w b3ZlciBvbiBNYWMgQ2F0YWx5c3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dL Rm9ybVBvcG92ZXIubW06CisgICAgICAgICgtW1dLUm90YXRpbmdQb3BvdmVyIHByZXNlbnRQb3Bv dmVyQW5pbWF0ZWQ6XSk6CisgICAgICAgICgtW1dLUm90YXRpbmdQb3BvdmVyIGRpc21pc3NQb3Bv dmVyQW5pbWF0ZWQ6XSk6CisKIDIwMjAtMDYtMTIgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2ll aEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lQYWRPU10gRm9jdXNpbmcgc2VsZWN0cyBhbmQgY29s b3IgaW5wdXRzIHNob3VsZCBub3QgYnJpbmcgdXAgdGhlIHNvZnR3YXJlIGtleWJvYXJkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3JtUG9wb3Zlci5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zvcm1Qb3BvdmVyLm1tCmlu ZGV4IDA5ODY2ZWFlMmMyZDYyNGY0MzAxNmQyMTY5NDVhOGVlNDdhNTIwMTkuLjYzMTljOTUxOGQ4 MzA5MGQ4YjYwYjg3ZDY1ZWRlNzM1YzE4YjgyNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zvcm1Qb3BvdmVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zvcm1Qb3BvdmVyLm1tCkBAIC03NSw2ICs3NSw3IEBAIEBp bXBsZW1lbnRhdGlvbiBXS1JvdGF0aW5nUG9wb3ZlciB7CiAgICAgV0tDb250ZW50VmlldyAqX3Zp ZXc7CiAKICAgICBCT09MIF9pc1JvdGF0aW5nOworICAgIEJPT0wgX2lzUHJlc2VydmluZ0ZvY3Vz OwogICAgIENHUG9pbnQgX3ByZXNlbnRhdGlvblBvaW50OwogICAgIFJldGFpblB0cjxVSVBvcG92 ZXJDb250cm9sbGVyPiBfcG9wb3ZlckNvbnRyb2xsZXI7CiAgICAgaWQgPFdLUm90YXRpbmdQb3Bv dmVyRGVsZWdhdGU+IF9kaXNtaXNzaW9uRGVsZWdhdGU7CkBAIC0xMzIsNiArMTMzLDEzIEBAIC0g KFVJUG9wb3ZlckFycm93RGlyZWN0aW9uKXBvcG92ZXJBcnJvd0RpcmVjdGlvbnMKIAogLSAodm9p ZClwcmVzZW50UG9wb3ZlckFuaW1hdGVkOihCT09MKWFuaW1hdGVkCiB7CisjaWYgUExBVEZPUk0o TUFDQ0FUQUxZU1QpCisgICAgaWYgKCFfaXNQcmVzZXJ2aW5nRm9jdXMpIHsKKyAgICAgICAgX2lz UHJlc2VydmluZ0ZvY3VzID0gWUVTOworICAgICAgICBbX3ZpZXcgcHJlc2VydmVGb2N1c107Cisg ICAgfQorI2VuZGlmCisKICAgICBVSVBvcG92ZXJBcnJvd0RpcmVjdGlvbiBkaXJlY3Rpb25zID0g W3NlbGYgcG9wb3ZlckFycm93RGlyZWN0aW9uc107CiAKICAgICBCT09MIHByZXNlbnRXaXRoUG9p bnQgPSAhQ0dQb2ludEVxdWFsVG9Qb2ludChzZWxmLnByZXNlbnRhdGlvblBvaW50LCBDR1BvaW50 WmVybyk7CkBAIC0xNTIsNiArMTYwLDEzIEBAIC0gKHZvaWQpcHJlc2VudFBvcG92ZXJBbmltYXRl ZDooQk9PTClhbmltYXRlZAogCiAtICh2b2lkKWRpc21pc3NQb3BvdmVyQW5pbWF0ZWQ6KEJPT0wp YW5pbWF0ZWQKIHsKKyNpZiBQTEFURk9STShNQUNDQVRBTFlTVCkKKyAgICBpZiAoX2lzUHJlc2Vy dmluZ0ZvY3VzKSB7CisgICAgICAgIF9pc1ByZXNlcnZpbmdGb2N1cyA9IE5POworICAgICAgICBb X3ZpZXcgcmVsZWFzZUZvY3VzXTsKKyAgICB9CisjZW5kaWYKKwogICAgIFtfcG9wb3ZlckNvbnRy b2xsZXIgZGlzbWlzc1BvcG92ZXJBbmltYXRlZDphbmltYXRlZF07CiB9CiAK