213149 2020-06-12 14:35:54 -0700 [iPadOS] Focusing selects and color inputs should not bring up the software keyboard 2020-07-01 22:31:25 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin darin megan_gardner thorton tim.pruessing webkit-bug-importer wenson_hsieh oldest_to_newest 1662165 0 wenson_hsieh 2020-06-12 14:35:54 -0700 SSIA 1662166 1 webkit-bug-importer 2020-06-12 14:36:13 -0700 <rdar://problem/64312450> 1662189 2 401792 wenson_hsieh 2020-06-12 15:09:00 -0700 Created attachment 401792 Patch 1662219 3 401792 darin 2020-06-12 16:28:24 -0700 Comment on attachment 401792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401792&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1932 > + return !WebKit::currentUserInterfaceIdiomIsPad(); This changes the behavior for read-only <input type=select> and <input type=color> on iPhone. They will now return true. Is this what we want? 1662235 4 401792 wenson_hsieh 2020-06-12 16:54:39 -0700 Comment on attachment 401792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401792&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1932 >> + return !WebKit::currentUserInterfaceIdiomIsPad(); > > This changes the behavior for read-only <input type=select> and <input type=color> on iPhone. They will now return true. Is this what we want? (I assume you mean <select> and <input type=color>) This patch will make us match shipping behavior, but it does seem strange that we would allow the keyboard to be presented on iPhone for readonly color inputs. (Note that it doesn't change behavior for select elements, since the readonly attribute does not apply to select elements). We probably do want to avoid showing any input view for readonly color inputs on iPhone though, so while I'm here I'll preserve that behavior. But this does highlight another issue, which is that on iPad, the `readonly` attribute doesn't prevent us from mutating form controls that show a popover or context menu (i.e. date, time, color). We probably should address this in a separate followup. 1662244 5 401807 wenson_hsieh 2020-06-12 17:02:13 -0700 Created attachment 401807 v2 1662263 6 wenson_hsieh 2020-06-12 17:31:52 -0700 Thanks for the review! (I filed https://bugs.webkit.org/show_bug.cgi?id=213159 to track the followup I mentioned above) 1662292 7 ews-feeder 2020-06-12 19:01:48 -0700 Committed r262993: <https://trac.webkit.org/changeset/262993> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401807. 1668150 8 wenson_hsieh 2020-07-01 22:31:25 -0700 *** Bug 213835 has been marked as a duplicate of this bug. *** 401792 2020-06-12 15:09:00 -0700 2020-06-12 17:02:12 -0700 Patch bug-213149-20200612150900.patch text/plain 5821 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyOTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJlYWFhYmU5MDQ5MGJlYTUy ODQ2N2U0OTcyY2MwZWNjZjEwOGRjYmUuLjYyNmYyZjJlN2I5ZWViMGM4YjNlMDc1ZGZmMGM2N2Y0 MzEwZTlkNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjAtMDYtMTIgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lQYWRPU10gRm9jdXNp bmcgc2VsZWN0cyBhbmQgY29sb3IgaW5wdXRzIHNob3VsZCBub3QgYnJpbmcgdXAgdGhlIHNvZnR3 YXJlIGtleWJvYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTMxNDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0MzEyNDUwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIDx0cmFjLndlYmtp dC5vcmcvcjI2MTY1OD4sIHdlIG5vdyBvcHQgaW50byBicmluZ2luZyB1cCB0aGUgc29mdHdhcmUg a2V5Ym9hcmQgd2hlbiBmb2N1c2luZyBjb2xvciBpbnB1dHMKKyAgICAgICAgYW5kIHNlbGVjdCBl bGVtZW50cy4gVGhpcyBpcyBkdWUgdG8gdGhlIGNoYW5nZXMgaW4gYC1fc2hvdWxkU2hvd0F1dG9t YXRpY0tleWJvYXJkVUlJZ25vcmluZ0lucHV0TW9kZWAsIHdoaWNoCisgICAgICAgIHdlcmUgaW50 ZW5kZWQgdG8gbWFrZSB1cyByZXR1cm4gYE5PYCBmb3IgZGF0ZSBhbmQgdGltZSBpbnB1dHMsIGJ1 dCBhbHNvIHVuaW50ZW50aW9uYWxseSBtYWtlcyB1cyByZXR1cm4gYFlFU2AKKyAgICAgICAgb24g aVBhZE9TLgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVzdG9yZXMgc2hpcHBpbmcgYmVoYXZpb3Ig YnkgcmV0dXJuaW5nIGAhV2ViS2l0OjpjdXJyZW50VXNlckludGVyZmFjZUlkaW9tSXNQYWQoKWAg aW5zdGVhZC4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL2lvcy9pcGFkL3NlbGVjdC1zaG91 bGQtbm90LWJyaW5nLXVwLXNvZnR3YXJlLWtleWJvYXJkLmh0bWwKKworICAgICAgICAqIFVJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRl bnRWaWV3IGJlY29tZUZpcnN0UmVzcG9uZGVyRm9yV2ViVmlld10pOgorICAgICAgICAoLVtXS0Nv bnRlbnRWaWV3IHJlc2lnbkZpcnN0UmVzcG9uZGVyRm9yV2ViVmlld10pOgorICAgICAgICAoLVtX S0NvbnRlbnRWaWV3IF9zaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSUlnbm9yaW5nSW5wdXRN b2RlXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2VsZW1lbnREaWRGb2N1czp1c2VySXNJ bnRlcmFjdGluZzpibHVyUHJldmlvdXNOb2RlOmFjdGl2aXR5U3RhdGVDaGFuZ2VzOnVzZXJPYmpl Y3Q6XSk6CisKIDIwMjAtMDYtMTIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBBZGQgV0tVc2VyU2NyaXB0IGluaXRpYWxpemVyIFNQSSB3aXRo IGFsdGVybmF0aXZlIG5hbWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCBlYTlmOTkyZjVjODBmYjYzYTMx MDk1YTVjNjU4NDMwYWY4ZTQwZjUzLi4wNWY3N2EzNTc4NjdjYzIyNWY1NjBhODNjY2QyMWVlZjhm NzZlMDBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0Nv bnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTE5MjksNiArMTkyOSw3IEBAIC0gKEJPT0wpX3No b3VsZFNob3dBdXRvbWF0aWNLZXlib2FyZFVJSWdub3JpbmdJbnB1dE1vZGUKICNpZiBFTkFCTEUo SU5QVVRfVFlQRV9DT0xPUikKICAgICBjYXNlIFdlYktpdDo6SW5wdXRUeXBlOjpDb2xvcjoKICNl bmRpZgorICAgICAgICByZXR1cm4gIVdlYktpdDo6Y3VycmVudFVzZXJJbnRlcmZhY2VJZGlvbUlz UGFkKCk7CiAgICAgZGVmYXVsdDoKICAgICAgICAgcmV0dXJuICFfZm9jdXNlZEVsZW1lbnRJbmZv cm1hdGlvbi5pc1JlYWRPbmx5OwogICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwYTM2YmE0MzJmNWFjZGM0ZmYyY2Iy YzQzZGZjYTNhYjhmYWY5MjY3Li4yYmQ3MGFmOWQxNTUyOGJlMTExZjQ2OTdhMjRkYTFiYzQyYzc4 YzM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDYtMTIgIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lQYWRPU10gRm9jdXNpbmcgc2VsZWN0 cyBhbmQgY29sb3IgaW5wdXRzIHNob3VsZCBub3QgYnJpbmcgdXAgdGhlIHNvZnR3YXJlIGtleWJv YXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTMx NDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0MzEyNDUwPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5ldyBsYXlvdXQgdGVzdC4KKwor ICAgICAgICAqIGZhc3QvZm9ybXMvaW9zL2lwYWQvc2VsZWN0LXNob3VsZC1ub3QtYnJpbmctdXAt c29mdHdhcmUta2V5Ym9hcmQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zv cm1zL2lvcy9pcGFkL3NlbGVjdC1zaG91bGQtbm90LWJyaW5nLXVwLXNvZnR3YXJlLWtleWJvYXJk Lmh0bWw6IEFkZGVkLgorCiAyMDIwLTA2LTEyICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxl LmNvbT4KIAogICAgICAgICBSZWxhdGl2ZSBmb250IHNpemUgdmFsdWVzIChlbSkgd2l0aGluIENT UyBhbmltYXRpb25zIGNvbXBvdW5kCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2lvcy9pcGFkL3NlbGVjdC1zaG91bGQtbm90LWJyaW5nLXVwLXNvZnR3YXJlLWtleWJvYXJkLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2lwYWQvc2VsZWN0LXNob3Vs ZC1ub3QtYnJpbmctdXAtc29mdHdhcmUta2V5Ym9hcmQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjRiYzFlMjY5ZmNmZWMwMjU0MjgxMzNmZDA1NTIyZTBiNWRhZjE2ZWUKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9pcGFkL3NlbGVjdC1zaG91bGQtbm90LWJy aW5nLXVwLXNvZnR3YXJlLWtleWJvYXJkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDExIEBACitU aGlzIHRlc3QgdmVyaWZpZXMgdGhhdCB0YXBwaW5nIGEgc2VsZWN0IGVsZW1lbnQgb24gaVBhZCBk b2VzIG5vdCBicmluZyB1cCB0aGUgc29mdHdhcmUga2V5Ym9hcmQuCisKK09uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KKworCitQQVNTIGlzU2hvd2luZ0tleWJvYXJkQWZ0ZXJGb2N1c2luZ1NlbGVj dCBpcyBmYWxzZQorUEFTUyBpc1Nob3dpbmdLZXlib2FyZEFmdGVyRm9jdXNpbmdDb2xvcklucHV0 IGlzIGZhbHNlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExF VEUKKyAgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9pcGFkL3NlbGVj dC1zaG91bGQtbm90LWJyaW5nLXVwLXNvZnR3YXJlLWtleWJvYXJkLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2lvcy9pcGFkL3NlbGVjdC1zaG91bGQtbm90LWJyaW5nLXVwLXNvZnR3YXJl LWtleWJvYXJkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTFmNWZjNWFhMjA1N2Q4OGRmN2M0MTlmMDA2YTZk YzMxNjM3NjIzZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9z L2lwYWQvc2VsZWN0LXNob3VsZC1ub3QtYnJpbmctdXAtc29mdHdhcmUta2V5Ym9hcmQuaHRtbApA QCAtMCwwICsxLDQyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPG1ldGEgbmFtZT0idmll d3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xIj4KKzxo ZWFkPgorICAgIDxzY3JpcHQgc3JjPSIuLi8uLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC5qcyI+ PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uLy4uLy4uL3Jlc291cmNlcy91aS1oZWxw ZXIuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQ+CisgICAgICAgIGpzVGVzdElzQXN5bmMgPSB0 cnVlOworCisgICAgICAgIGFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBhc3luYyAoKSA9PiB7Cisg ICAgICAgICAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgdGFwcGluZyBh IHNlbGVjdCBlbGVtZW50IG9uIGlQYWQgZG9lcyBub3QgYnJpbmcgdXAgdGhlIHNvZnR3YXJlIGtl eWJvYXJkLiIpOworCisgICAgICAgICAgICBpZiAoIXdpbmRvdy50ZXN0UnVubmVyKQorICAgICAg ICAgICAgICAgIHJldHVybjsKKworICAgICAgICAgICAgYXdhaXQgVUlIZWxwZXIuc2V0SGFyZHdh cmVLZXlib2FyZEF0dGFjaGVkKGZhbHNlKTsKKworICAgICAgICAgICAgY29uc3Qgc2VsZWN0ID0g ZG9jdW1lbnQucXVlcnlTZWxlY3Rvcigic2VsZWN0Iik7CisgICAgICAgICAgICBhd2FpdCBVSUhl bHBlci5hY3RpdmF0ZUVsZW1lbnRBbmRXYWl0Rm9ySW5wdXRTZXNzaW9uKHNlbGVjdCk7CisgICAg ICAgICAgICBpc1Nob3dpbmdLZXlib2FyZEFmdGVyRm9jdXNpbmdTZWxlY3QgPSBhd2FpdCBVSUhl bHBlci5pc1Nob3dpbmdLZXlib2FyZCgpOworICAgICAgICAgICAgc2VsZWN0LmJsdXIoKTsKKwor ICAgICAgICAgICAgY29uc3QgY29sb3JJbnB1dCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoImlu cHV0Iik7CisgICAgICAgICAgICBhd2FpdCBVSUhlbHBlci5hY3RpdmF0ZUVsZW1lbnRBbmRXYWl0 Rm9ySW5wdXRTZXNzaW9uKGNvbG9ySW5wdXQpOworICAgICAgICAgICAgaXNTaG93aW5nS2V5Ym9h cmRBZnRlckZvY3VzaW5nQ29sb3JJbnB1dCA9IGF3YWl0IFVJSGVscGVyLmlzU2hvd2luZ0tleWJv YXJkKCk7CisgICAgICAgICAgICBjb2xvcklucHV0LmJsdXIoKTsKKworICAgICAgICAgICAgc2hv dWxkQmVGYWxzZSgiaXNTaG93aW5nS2V5Ym9hcmRBZnRlckZvY3VzaW5nU2VsZWN0Iik7CisgICAg ICAgICAgICBzaG91bGRCZUZhbHNlKCJpc1Nob3dpbmdLZXlib2FyZEFmdGVyRm9jdXNpbmdDb2xv cklucHV0Iik7CisgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICAgICAgfSk7CisgICAg PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8c2VsZWN0PgorICAgICAgICA8b3B0aW9u IHNlbGVjdGVkPkZvbzwvb3B0aW9uPgorICAgICAgICA8b3B0aW9uPkJhcjwvb3B0aW9uPgorICAg ICAgICA8b3B0aW9uPkJhejwvb3B0aW9uPgorICAgIDwvc2VsZWN0PgorICAgIDxpbnB1dCB0eXBl PSJjb2xvciI+PC9pbnB1dD4KKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBmaWxlCg== 401807 2020-06-12 17:02:13 -0700 2020-06-12 19:01:49 -0700 v2 bug-213149-20200612170212.patch text/plain 6303 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyOTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJlYWFhYmU5MDQ5MGJlYTUy ODQ2N2U0OTcyY2MwZWNjZjEwOGRjYmUuLmI4MThmNTAxMjAxNDhjMDRjOWFkOTc3ZTRhYjFlNzlk ZjFkZjFiNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjAtMDYtMTIgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lQYWRPU10gRm9jdXNp bmcgc2VsZWN0cyBhbmQgY29sb3IgaW5wdXRzIHNob3VsZCBub3QgYnJpbmcgdXAgdGhlIHNvZnR3 YXJlIGtleWJvYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTMxNDkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0MzEyNDUwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIDx0cmFjLndlYmtp dC5vcmcvcjI2MTY1OD4sIHdlIG5vdyBvcHQgaW50byBicmluZ2luZyB1cCB0aGUgc29mdHdhcmUg a2V5Ym9hcmQgd2hlbiBmb2N1c2luZyBjb2xvciBpbnB1dHMKKyAgICAgICAgYW5kIHNlbGVjdCBl bGVtZW50cy4gVGhpcyBpcyBkdWUgdG8gdGhlIGNoYW5nZXMgaW4gYC1fc2hvdWxkU2hvd0F1dG9t YXRpY0tleWJvYXJkVUlJZ25vcmluZ0lucHV0TW9kZWAsIHdoaWNoCisgICAgICAgIHdlcmUgaW50 ZW5kZWQgdG8gbWFrZSB1cyByZXR1cm4gYE5PYCBmb3IgZGF0ZSBhbmQgdGltZSBpbnB1dHMsIGJ1 dCBhbHNvIHVuaW50ZW50aW9uYWxseSBtYWtlcyB1cyByZXR1cm4gYFlFU2AKKyAgICAgICAgb24g aVBhZE9TLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGJ1ZyBieSByZXR1cm5pbmcg YCFXZWJLaXQ6OmN1cnJlbnRVc2VySW50ZXJmYWNlSWRpb21Jc1BhZCgpYCBpbnN0ZWFkLCBhbmQg YWRkaXRpb25hbGx5CisgICAgICAgIHByZXNlcnZlcyB0aGUgZXhpc3RpbmcgYmVoYXZpb3Igb2Yg bm93IHNob3dpbmcgYSBjb2xvciBwaWNrZXIgZm9yIGA8aW5wdXQgdHlwZT0iY29sb3IiIHJlYWRv bmx5PmAgb24gaVBob25lLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvaW9zL2lwYWQvc2Vs ZWN0LXNob3VsZC1ub3QtYnJpbmctdXAtc29mdHdhcmUta2V5Ym9hcmQuaHRtbAorCisgICAgICAg ICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgt W1dLQ29udGVudFZpZXcgYmVjb21lRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3XSk6CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgcmVzaWduRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3XSk6CisgICAg ICAgICgtW1dLQ29udGVudFZpZXcgX3Nob3VsZFNob3dBdXRvbWF0aWNLZXlib2FyZFVJSWdub3Jp bmdJbnB1dE1vZGVdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZWxlbWVudERpZEZvY3Vz OnVzZXJJc0ludGVyYWN0aW5nOmJsdXJQcmV2aW91c05vZGU6YWN0aXZpdHlTdGF0ZUNoYW5nZXM6 dXNlck9iamVjdDpdKToKKwogMjAyMC0wNi0xMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBXS1VzZXJTY3JpcHQgaW5pdGlhbGl6ZXIg U1BJIHdpdGggYWx0ZXJuYXRpdmUgbmFtZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGVhOWY5OTJmNWM4 MGZiNjNhMzEwOTVhNWM2NTg0MzBhZjhlNDBmNTMuLjFmYTQ3NTkwNzhiZGM1MTljNjg5YzA1OTA0 ZTMzZTM5YzFmNzVkN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMTkxNyw2ICsxOTE3LDkgQEAgLSAo Qk9PTClzaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSQogCiAtIChCT09MKV9zaG91bGRTaG93 QXV0b21hdGljS2V5Ym9hcmRVSUlnbm9yaW5nSW5wdXRNb2RlCiB7CisgICAgaWYgKF9mb2N1c2Vk RWxlbWVudEluZm9ybWF0aW9uLmlzUmVhZE9ubHkpCisgICAgICAgIHJldHVybiBOTzsKKwogICAg IHN3aXRjaCAoX2ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24uZWxlbWVudFR5cGUpIHsKICAgICBj YXNlIFdlYktpdDo6SW5wdXRUeXBlOjpOb25lOgogICAgIGNhc2UgV2ViS2l0OjpJbnB1dFR5cGU6 OkRyYXdpbmc6CkBAIC0xOTI5LDggKzE5MzIsOSBAQCAtIChCT09MKV9zaG91bGRTaG93QXV0b21h dGljS2V5Ym9hcmRVSUlnbm9yaW5nSW5wdXRNb2RlCiAjaWYgRU5BQkxFKElOUFVUX1RZUEVfQ09M T1IpCiAgICAgY2FzZSBXZWJLaXQ6OklucHV0VHlwZTo6Q29sb3I6CiAjZW5kaWYKKyAgICAgICAg cmV0dXJuICFXZWJLaXQ6OmN1cnJlbnRVc2VySW50ZXJmYWNlSWRpb21Jc1BhZCgpOwogICAgIGRl ZmF1bHQ6Ci0gICAgICAgIHJldHVybiAhX2ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24uaXNSZWFk T25seTsKKyAgICAgICAgcmV0dXJuIFlFUzsKICAgICB9CiAgICAgcmV0dXJuIE5POwogfQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IDBhMzZiYTQzMmY1YWNkYzRmZjJjYjJjNDNkZmNhM2FiOGZhZjkyNjcuLjJiZDcwYWY5ZDE1 NTI4YmUxMTFmNDY5N2EyNGRhMWJjNDJjNzhjMzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAy MC0wNi0xMiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKworICAgICAg ICBbaVBhZE9TXSBGb2N1c2luZyBzZWxlY3RzIGFuZCBjb2xvciBpbnB1dHMgc2hvdWxkIG5vdCBi cmluZyB1cCB0aGUgc29mdHdhcmUga2V5Ym9hcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzE0OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQz MTI0NTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIGEgbmV3IGxheW91dCB0ZXN0LgorCisgICAgICAgICogZmFzdC9mb3Jtcy9pb3MvaXBhZC9z ZWxlY3Qtc2hvdWxkLW5vdC1icmluZy11cC1zb2Z0d2FyZS1rZXlib2FyZC1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvaW9zL2lwYWQvc2VsZWN0LXNob3VsZC1ub3Qt YnJpbmctdXAtc29mdHdhcmUta2V5Ym9hcmQuaHRtbDogQWRkZWQuCisKIDIwMjAtMDYtMTIgIEFu dHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbGF0aXZlIGZvbnQg c2l6ZSB2YWx1ZXMgKGVtKSB3aXRoaW4gQ1NTIGFuaW1hdGlvbnMgY29tcG91bmQKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2lwYWQvc2VsZWN0LXNob3VsZC1ub3QtYnJp bmctdXAtc29mdHdhcmUta2V5Ym9hcmQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9pb3MvaXBhZC9zZWxlY3Qtc2hvdWxkLW5vdC1icmluZy11cC1zb2Z0d2FyZS1rZXlib2Fy ZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNGJjMWUyNjlmY2ZlYzAyNTQyODEzM2ZkMDU1MjJl MGI1ZGFmMTZlZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9z L2lwYWQvc2VsZWN0LXNob3VsZC1ub3QtYnJpbmctdXAtc29mdHdhcmUta2V5Ym9hcmQtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMTEgQEAKK1RoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IHRhcHBpbmcg YSBzZWxlY3QgZWxlbWVudCBvbiBpUGFkIGRvZXMgbm90IGJyaW5nIHVwIHRoZSBzb2Z0d2FyZSBr ZXlib2FyZC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBt ZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgaXNTaG93aW5n S2V5Ym9hcmRBZnRlckZvY3VzaW5nU2VsZWN0IGlzIGZhbHNlCitQQVNTIGlzU2hvd2luZ0tleWJv YXJkQWZ0ZXJGb2N1c2luZ0NvbG9ySW5wdXQgaXMgZmFsc2UKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorICAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvaW9zL2lwYWQvc2VsZWN0LXNob3VsZC1ub3QtYnJpbmctdXAtc29mdHdhcmUt a2V5Ym9hcmQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2lwYWQvc2VsZWN0LXNo b3VsZC1ub3QtYnJpbmctdXAtc29mdHdhcmUta2V5Ym9hcmQuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45MWY1 ZmM1YWEyMDU3ZDg4ZGY3YzQxOWYwMDZhNmRjMzE2Mzc2MjNmCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvaXBhZC9zZWxlY3Qtc2hvdWxkLW5vdC1icmluZy11 cC1zb2Z0d2FyZS1rZXlib2FyZC5odG1sCkBAIC0wLDAgKzEsNDIgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdp ZHRoLCBpbml0aWFsLXNjYWxlPTEiPgorPGhlYWQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uLy4u Ly4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4v Li4vLi4vLi4vcmVzb3VyY2VzL3VpLWhlbHBlci5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdD4K KyAgICAgICAganNUZXN0SXNBc3luYyA9IHRydWU7CisKKyAgICAgICAgYWRkRXZlbnRMaXN0ZW5l cigibG9hZCIsIGFzeW5jICgpID0+IHsKKyAgICAgICAgICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRl c3QgdmVyaWZpZXMgdGhhdCB0YXBwaW5nIGEgc2VsZWN0IGVsZW1lbnQgb24gaVBhZCBkb2VzIG5v dCBicmluZyB1cCB0aGUgc29mdHdhcmUga2V5Ym9hcmQuIik7CisKKyAgICAgICAgICAgIGlmICgh d2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgICAg ICBhd2FpdCBVSUhlbHBlci5zZXRIYXJkd2FyZUtleWJvYXJkQXR0YWNoZWQoZmFsc2UpOworCisg ICAgICAgICAgICBjb25zdCBzZWxlY3QgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJzZWxlY3Qi KTsKKyAgICAgICAgICAgIGF3YWl0IFVJSGVscGVyLmFjdGl2YXRlRWxlbWVudEFuZFdhaXRGb3JJ bnB1dFNlc3Npb24oc2VsZWN0KTsKKyAgICAgICAgICAgIGlzU2hvd2luZ0tleWJvYXJkQWZ0ZXJG b2N1c2luZ1NlbGVjdCA9IGF3YWl0IFVJSGVscGVyLmlzU2hvd2luZ0tleWJvYXJkKCk7CisgICAg ICAgICAgICBzZWxlY3QuYmx1cigpOworCisgICAgICAgICAgICBjb25zdCBjb2xvcklucHV0ID0g ZG9jdW1lbnQucXVlcnlTZWxlY3RvcigiaW5wdXQiKTsKKyAgICAgICAgICAgIGF3YWl0IFVJSGVs cGVyLmFjdGl2YXRlRWxlbWVudEFuZFdhaXRGb3JJbnB1dFNlc3Npb24oY29sb3JJbnB1dCk7Cisg ICAgICAgICAgICBpc1Nob3dpbmdLZXlib2FyZEFmdGVyRm9jdXNpbmdDb2xvcklucHV0ID0gYXdh aXQgVUlIZWxwZXIuaXNTaG93aW5nS2V5Ym9hcmQoKTsKKyAgICAgICAgICAgIGNvbG9ySW5wdXQu Ymx1cigpOworCisgICAgICAgICAgICBzaG91bGRCZUZhbHNlKCJpc1Nob3dpbmdLZXlib2FyZEFm dGVyRm9jdXNpbmdTZWxlY3QiKTsKKyAgICAgICAgICAgIHNob3VsZEJlRmFsc2UoImlzU2hvd2lu Z0tleWJvYXJkQWZ0ZXJGb2N1c2luZ0NvbG9ySW5wdXQiKTsKKyAgICAgICAgICAgIGZpbmlzaEpT VGVzdCgpOworICAgICAgICB9KTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorICAg IDxzZWxlY3Q+CisgICAgICAgIDxvcHRpb24gc2VsZWN0ZWQ+Rm9vPC9vcHRpb24+CisgICAgICAg IDxvcHRpb24+QmFyPC9vcHRpb24+CisgICAgICAgIDxvcHRpb24+QmF6PC9vcHRpb24+CisgICAg PC9zZWxlY3Q+CisgICAgPGlucHV0IHR5cGU9ImNvbG9yIj48L2lucHV0PgorPC9ib2R5PgorPC9o dG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK