213138 2020-06-12 10:36:19 -0700 Windows layout tests fail when changing ContentSniffingPolicy/ContentEncodingSniffingPolicy enum values 2020-06-12 16:06:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=213093 P2 Normal --- 1 ddkilzer webkit-unassigned achristensen cdumez darin eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim japhet jer.noble macpherson menard philipj sergio oldest_to_newest 1662026 0 ddkilzer 2020-06-12 10:36:19 -0700 Windows layout tests fail when changing ContentSniffingPolicy/ContentEncodingSniffingPolicy enum values as seen in Bug 213093. However, the build doesn't break, so it seems the Apple Windows port is likely using hard-coded numeric values instead of enum values somewhere. Here are the two enums I had to revert (in Bug 213093) to fix Windows layout tests in Source/WebCore/loader/ResourceLoaderOptions.h: enum class ContentSniffingPolicy : bool { SniffContent, DoNotSniffContent }; enum class ContentEncodingSniffingPolicy : bool { Sniff, DoNotSniff }; See: <https://bugs.webkit.org/attachment.cgi?oldid=401700&action=interdiff&newid=401704&headers=1> Failing EWS test run: <https://ews-build.webkit.org/#/builders/10/builds/21380> Failing EWS test results: <https://ews-build.webkit.org/results/Windows-EWS/r401700-21380/results.html> 1662035 1 ddkilzer 2020-06-12 10:53:23 -0700 My usual trick of looking for a C-style cast or a static_cast<> back to one of the enum values didn't turn up anything: $ grep -r 'SniffingPolicy)' Source/WebCore Source/WebKitLegacy $ grep -r 'SniffingPolicy>' Source/WebCore Source/WebKitLegacy 1662041 2 darin 2020-06-12 10:58:06 -0700 I suggest looking for an if statement: if (policy) { xxx } 1662059 3 ddkilzer 2020-06-12 11:27:40 -0700 (In reply to Darin Adler from comment #2) > I suggest looking for an if statement: > > if (policy) { > xxx > } Couldn't find anything. Another guess is that an incremental build didn't rebuild some source file (with the new values) because it didn't include ResourceLoaderOptions.h explicitly. 1662062 4 401756 ddkilzer 2020-06-12 11:36:44 -0700 Created attachment 401756 Patch v1 Try including ResourceLoaderOptions.h everywhere that *SniffingPolicy enums are used. 1662077 5 401756 darin 2020-06-12 12:00:28 -0700 Comment on attachment 401756 Patch v1 If this works and passes tests, that will tell us it was a recompilation issues, but I don’t think we should land it this way. We will have proved that those files need to be touched to work around a bug in the dependency tracking of the Windows build tools, and it’s good to do that so we don’t need a full recompile on Windows, but let’s not add includes. Just touch each of the files some other way. 1662195 6 ddkilzer 2020-06-12 15:23:49 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 401756 [details] > Patch v1 > > If this works and passes tests, that will tell us it was a recompilation > issues, but I don’t think we should land it this way. We will have proved > that those files need to be touched to work around a bug in the dependency > tracking of the Windows build tools, and it’s good to do that so we don’t > need a full recompile on Windows, but let’s not add includes. Just touch > each of the files some other way. Well, that didn't work. The failures have to do with HTTP/0.9, so that should narrow down the area of code affected. I don't have time to look into this further right now. 1662214 7 darin 2020-06-12 16:06:41 -0700 (In reply to David Kilzer (:ddkilzer) from comment #6) > The failures have to do with HTTP/0.9, so that > should narrow down the area of code affected. > > I don't have time to look into this further right now. We’ll figure it out eventually! No rush, I think. 401756 2020-06-12 11:36:44 -0700 2020-06-12 11:36:44 -0700 Patch v1 bug-213138-v1.diff text/plain 5558 ddkilzer ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJ1bGVJbXBvcnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvY3NzL1N0eWxlUnVsZUltcG9ydC5jcHAKaW5kZXggY2UxN2ZiNGMyODkuLmM3 MDljNTUxNWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSdWxlSW1wb3J0 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSdWxlSW1wb3J0LmNwcApAQCAtMzAs NiArMzAsNyBAQAogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiTWVkaWFMaXN0Lmgi CiAjaW5jbHVkZSAiTWVkaWFRdWVyeVBhcnNlci5oIgorI2luY2x1ZGUgIlJlc291cmNlTG9hZGVy T3B0aW9ucy5oIgogI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAjaW5jbHVkZSAiU3R5bGVT aGVldENvbnRlbnRzLmgiCiAjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0FwcGxpY2F0aW9uTWFuaWZlc3RMb2FkZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL0FwcGxpY2F0aW9uTWFuaWZlc3RMb2FkZXIuY3BwCmluZGV4 IDMzMWQzMDU3ZjgyLi44NTQ0MDk2OTUyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9h ZGVyL0FwcGxpY2F0aW9uTWFuaWZlc3RMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9BcHBsaWNhdGlvbk1hbmlmZXN0TG9hZGVyLmNwcApAQCAtMzQsNiArMzQsNyBAQAogI2lu Y2x1ZGUgIkNhY2hlZFJlc291cmNlUmVxdWVzdEluaXRpYXRvcnMuaCIKICNpbmNsdWRlICJEb2N1 bWVudExvYWRlci5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCisjaW5jbHVkZSAiUmVzb3VyY2VMb2Fk ZXJPcHRpb25zLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAKaW5kZXggYzdhMjVjODZiOWYuLjA2OTUyNjA3YmE0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKQEAgLTczLDYgKzczLDcgQEAK ICNpbmNsdWRlICJQb2xpY3lDaGVja2VyLmgiCiAjaW5jbHVkZSAiUHJvZ3Jlc3NUcmFja2VyLmgi CiAjaW5jbHVkZSAiUmVzb3VyY2VIYW5kbGUuaCIKKyNpbmNsdWRlICJSZXNvdXJjZUxvYWRlck9w dGlvbnMuaCIKICNpbmNsdWRlICJSZXNvdXJjZUxvYWRPYnNlcnZlci5oIgogI2luY2x1ZGUgIlJ1 bnRpbWVFbmFibGVkRmVhdHVyZXMuaCIKICNpbmNsdWRlICJTV0NsaWVudENvbm5lY3Rpb24uaCIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9NZWRpYVJlc291cmNlTG9hZGVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9NZWRpYVJlc291cmNlTG9hZGVyLmNwcAppbmRleCA4 NTliOTA2NTg3Yi4uYmM1MGI1YTNhOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9NZWRpYVJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvTWVk aWFSZXNvdXJjZUxvYWRlci5jcHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlICJEb2N1bWVu dC5oIgogI2luY2x1ZGUgIkhUTUxNZWRpYUVsZW1lbnQuaCIKICNpbmNsdWRlICJJbnNwZWN0b3JJ bnN0cnVtZW50YXRpb24uaCIKKyNpbmNsdWRlICJSZXNvdXJjZUxvYWRlck9wdGlvbnMuaCIKICNp bmNsdWRlICJTZWN1cml0eU9yaWdpbi5oIgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5o PgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvTmV0c2NhcGVQbHVnSW5TdHJl YW1Mb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL05ldHNjYXBlUGx1Z0luU3RyZWFt TG9hZGVyLmNwcAppbmRleCBmOWJiMTBmYmYxOC4uZDhmY2NjNGQzYjkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9OZXRzY2FwZVBsdWdJblN0cmVhbUxvYWRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvbG9hZGVyL05ldHNjYXBlUGx1Z0luU3RyZWFtTG9hZGVyLmNwcApAQCAt MzIsNiArMzIsNyBAQAogI2luY2x1ZGUgIkRvY3VtZW50TG9hZGVyLmgiCiAjaW5jbHVkZSAiRnJh bWVMb2FkZXIuaCIKICNpbmNsdWRlICJGcmFtZUxvYWRlckNsaWVudC5oIgorI2luY2x1ZGUgIlJl c291cmNlTG9hZGVyT3B0aW9ucy5oIgogI2luY2x1ZGUgPHd0Zi9Db21wbGV0aW9uSGFuZGxlci5o PgogI2luY2x1ZGUgPHd0Zi9SZWYuaD4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9h ZGVyL1Jlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxv YWRlci5jcHAKaW5kZXggN2FiY2VjYmFkN2UuLjQ5MWJhMWM0OTE0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAKQEAgLTQ5LDYgKzQ5LDcgQEAKICNpbmNsdWRlICJQ cm9ncmVzc1RyYWNrZXIuaCIKICNpbmNsdWRlICJSZXNvdXJjZUVycm9yLmgiCiAjaW5jbHVkZSAi UmVzb3VyY2VIYW5kbGUuaCIKKyNpbmNsdWRlICJSZXNvdXJjZUxvYWRlck9wdGlvbnMuaCIKICNp bmNsdWRlICJTZWN1cml0eU9yaWdpbi5oIgogI2luY2x1ZGUgIlNoYXJlZEJ1ZmZlci5oIgogI2lu Y2x1ZGUgPHd0Zi9Db21wbGV0aW9uSGFuZGxlci5oPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyT3B0aW9ucy5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L1Jlc291cmNlTG9hZGVyT3B0aW9ucy5oCmluZGV4IDYwNTMwZDM1OTRlLi5hODI3ZjE1N2MyNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyT3B0aW9ucy5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlck9wdGlvbnMuaApAQCAt MzQsNiArMzQsNyBAQAogI2luY2x1ZGUgIkNyb3NzT3JpZ2luQWNjZXNzQ29udHJvbC5oIgogI2lu Y2x1ZGUgIkZldGNoT3B0aW9ucy5oIgogI2luY2x1ZGUgIkhUVFBIZWFkZXJOYW1lcy5oIgorI2lu Y2x1ZGUgIlJlc291cmNlTG9hZGVyT3B0aW9ucy5oIgogI2luY2x1ZGUgIlNlcnZpY2VXb3JrZXJU eXBlcy5oIgogI2luY2x1ZGUgIlN0b3JlZENyZWRlbnRpYWxzUG9saWN5LmgiCiAjaW5jbHVkZSA8 d3RmL0VudW1UcmFpdHMuaD4KQEAgLTUyLDggKzUzLDggQEAgc3RhdGljIGNvbnN0ZXhwciB1bnNp Z25lZCBiaXRXaWR0aE9mU2VuZENhbGxiYWNrUG9saWN5ID0gMTsKIC8vIEZJWE1FOiBUaGVzZSBv cHRpb25zIGFyZSBuYW1lZCBwb29ybHkuIFdlIG9ubHkgaW1wbGVtZW50IGZvcmNlIGRpc2FibGlu ZyBjb250ZW50IHNuaWZmaW5nLCBub3QgZW5hYmxpbmcgaXQsCiAvLyBhbmQgZXZlbiB0aGF0IG9u bHkgb24gc29tZSBwbGF0Zm9ybXMuCiBlbnVtIGNsYXNzIENvbnRlbnRTbmlmZmluZ1BvbGljeSA6 IGJvb2wgewotICAgIFNuaWZmQ29udGVudCwKLSAgICBEb05vdFNuaWZmQ29udGVudAorICAgIERv Tm90U25pZmZDb250ZW50LAorICAgIFNuaWZmQ29udGVudAogfTsKIHN0YXRpYyBjb25zdGV4cHIg dW5zaWduZWQgYml0V2lkdGhPZkNvbnRlbnRTbmlmZmluZ1BvbGljeSA9IDE7CiAKQEAgLTEyNyw4 ICsxMjgsOCBAQCBzdGF0aWMgY29uc3RleHByIHVuc2lnbmVkIGJpdFdpZHRoT2ZBcHBsaWNhdGlv bkNhY2hlTW9kZSA9IDE7CiAvLyBGSVhNRTogVGhlc2Ugb3B0aW9ucyBhcmUgbmFtZWQgcG9vcmx5 LiBXZSBvbmx5IGltcGxlbWVudCBmb3JjZSBkaXNhYmxpbmcgY29udGVudCBlbmNvZGluZyBzbmlm ZmluZywgbm90IGVuYWJsaW5nIGl0LAogLy8gYW5kIGV2ZW4gdGhhdCBvbmx5IG9uIHNvbWUgcGxh dGZvcm1zLgogZW51bSBjbGFzcyBDb250ZW50RW5jb2RpbmdTbmlmZmluZ1BvbGljeSA6IGJvb2wg ewotICAgIFNuaWZmLAotICAgIERvTm90U25pZmYKKyAgICBEb05vdFNuaWZmLAorICAgIFNuaWZm CiB9Owogc3RhdGljIGNvbnN0ZXhwciB1bnNpZ25lZCBiaXRXaWR0aE9mQ29udGVudEVuY29kaW5n U25pZmZpbmdQb2xpY3kgPSAxOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv Y2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2Nh Y2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcAppbmRleCA3ODczYmY5OWJkMi4uMTM5NjYwN2Nj NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJj ZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291 cmNlTG9hZGVyLmNwcApAQCAtNjYsNiArNjYsNyBAQAogI2luY2x1ZGUgIlBpbmdMb2FkZXIuaCIK ICNpbmNsdWRlICJQbGF0Zm9ybVN0cmF0ZWdpZXMuaCIKICNpbmNsdWRlICJSZW5kZXJFbGVtZW50 LmgiCisjaW5jbHVkZSAiUmVzb3VyY2VMb2FkZXJPcHRpb25zLmgiCiAjaW5jbHVkZSAiUmVzb3Vy Y2VMb2FkSW5mby5oIgogI2luY2x1ZGUgIlJlc291cmNlVGltaW5nLmgiCiAjaW5jbHVkZSAiUnVu dGltZUFwcGxpY2F0aW9uQ2hlY2tzLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvaWNvbi9JY29uTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25M b2FkZXIuY3BwCmluZGV4IDkxOTU5ZDYyOTkzLi40MTRmOTdhMTVkMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRl ICJGcmFtZUxvYWRlci5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50LmgiCiAjaW5jbHVk ZSAiTG9nZ2luZy5oIgorI2luY2x1ZGUgIlJlc291cmNlTG9hZGVyT3B0aW9ucy5oIgogI2luY2x1 ZGUgIlJlc291cmNlUmVxdWVzdC5oIgogI2luY2x1ZGUgIlNoYXJlZEJ1ZmZlci5oIgogI2luY2x1 ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3htbC9Y TUxIdHRwUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3Bw CmluZGV4IGM2ZmE0OGI4OGZiLi43MTU3MDkxYjkwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0 cFJlcXVlc3QuY3BwCkBAIC00NCw2ICs0NCw3IEBACiAjaW5jbHVkZSAiTWVtb3J5Q2FjaGUuaCIK ICNpbmNsdWRlICJQYXJzZWRDb250ZW50VHlwZS5oIgogI2luY2x1ZGUgIlJlc291cmNlRXJyb3Iu aCIKKyNpbmNsdWRlICJSZXNvdXJjZUxvYWRlck9wdGlvbnMuaCIKICNpbmNsdWRlICJSZXNvdXJj ZVJlcXVlc3QuaCIKICNpbmNsdWRlICJSdW50aW1lQXBwbGljYXRpb25DaGVja3MuaCIKICNpbmNs dWRlICJTZWN1cml0eU9yaWdpblBvbGljeS5oIgo=