21313 2008-10-02 12:39:46 -0700 wtf/ThreadingWin.cpp expects pthreads 2008-10-06 18:22:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 tony webkit-unassigned oldest_to_newest 93768 0 tony 2008-10-02 12:39:46 -0700 This is causing a problem for Chromium because it doesn't use pthreads. Patch coming up... 93777 1 24026 tony 2008-10-02 12:57:17 -0700 Created attachment 24026 [1/2] Chromium doesn't use pthreads on windows, so make its use conditional. Also convert a WORD to a DWORD to avoid a compiler warning. This matches the other methods around it. --- JavaScriptCore/wtf/ThreadingWin.cpp | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) 93778 2 24027 tony 2008-10-02 12:57:18 -0700 Created attachment 24027 [2/2] update changelog JavaScriptCore/ChangeLog | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) 93794 3 24026 ap 2008-10-02 13:47:44 -0700 Comment on attachment 24026 [1/2] Chromium doesn't use pthreads on windows, so make its use conditional. r=me 93795 4 24027 ap 2008-10-02 13:48:50 -0700 Comment on attachment 24027 [2/2] update changelog r=me In the future, please submit patches as a single file, as this makes both reviewing and landing easier. 94317 5 eric 2008-10-06 18:22:02 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/ThreadingWin.cpp Committed r37364 24026 2008-10-02 12:57:17 -0700 2008-10-02 13:47:44 -0700 [1/2] Chromium doesn't use pthreads on windows, so make its use conditional. -Chromium-doesn-t-use-pthreads-on-windows-so-make-its-use-conditional..patch text/plain 1295 tony MTQ3ZGMwOTdkNzJkMDliZTk3ODViNGM1ZmI1ZTI4ZGI5MzA2OTU5ZQpkaWZmIC0tZ2l0IGEvSmF2 YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1dpbi5jcHAgYi9KYXZhU2NyaXB0Q29yZS93dGYvVGhy ZWFkaW5nV2luLmNwcAppbmRleCBlYTRjY2UwLi4zMDBmZTFhIDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS93dGYvVGhyZWFkaW5nV2luLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvVGhy ZWFkaW5nV2luLmNwcApAQCAtNjksNyArNjksNyBAQAogI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+ CiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KIAotI2lmIFBMQVRGT1JNKFdJTikKKyNpZiBQ TEFURk9STShXSU4pICYmIFVTRShQVEhSRUFEUykKIC8vIEN1cnJlbnRseSwgQXBwbGUncyBXaW5k b3dzIHBvcnQgdXNlcyBhIG1peHR1cmUgb2YgbmF0aXZlIGFuZCBwdGhyZWFkcyBmdW5jdGlvbnMg aW4gRmFzdE1hbGxvYy4KIC8vIFRvIGVuc3VyZSB0aGF0IHRocmVhZC1zcGVjaWZpYyBkYXRhIGlz IHByb3Blcmx5IGRlc3Ryb3llZCwgd2UgbmVlZCB0byBlbmQgZWFjaCB0aHJlYWQgd2l0aCBwdGhy ZWFkX2V4aXQoKS4KICNpbmNsdWRlIDxwdGhyZWFkLmg+CkBAIC0xNjgsNyArMTY4LDcgQEAgc3Rh dGljIHVuc2lnbmVkIF9fc3RkY2FsbCB3dGZUaHJlYWRFbnRyeVBvaW50KHZvaWQqIHBhcmFtKQog CiAgICAgdm9pZCogcmVzdWx0ID0gaW52b2NhdGlvbi5mdW5jdGlvbihpbnZvY2F0aW9uLmRhdGEp OwogCi0jaWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JNKFdJTikgJiYgVVNFKFBUSFJFQURT KQogICAgIC8vIHB0aHJlYWRzLXdpbjMyIGtub3dzIGhvdyB0byB3b3JrIHdpdGggdGhyZWFkcyBj cmVhdGVkIHdpdGggV2luMzIgb3IgQ1JUIGZ1bmN0aW9ucywgc28gaXQncyBPSyB0byBtaXggQVBJ cy4KICAgICBwdGhyZWFkX2V4aXQocmVzdWx0KTsKICNlbmRpZgpAQCAtNDI5LDcgKzQyOSw3IEBA IHZvaWQgVGhyZWFkQ29uZGl0aW9uOjpicm9hZGNhc3QoKQogewogICAgIHVuc2lnbmVkIHNpZ25h bHMgPSAwOwogCi0gICAgV09SRCByZXMgPSA6OldhaXRGb3JTaW5nbGVPYmplY3QobV9jb25kaXRp b24ubV9tdXRleCwgSU5GSU5JVEUpOworICAgIERXT1JEIHJlcyA9IDo6V2FpdEZvclNpbmdsZU9i amVjdChtX2NvbmRpdGlvbi5tX211dGV4LCBJTkZJTklURSk7CiAgICAgQVNTRVJUKHJlcyA9PSBX QUlUX09CSkVDVF8wKTsKIAogICAgIGlmIChtX2NvbmRpdGlvbi5tX3dhaXRpbmdGb3JSZW1vdmFs ICE9IDApIHsgLy8gdGhlIG1fZ2F0ZSBpcyBhbHJlYWR5IGNsb3NlZAo= 24027 2008-10-02 12:57:18 -0700 2008-10-02 13:48:50 -0700 [2/2] update changelog -update-changelog.patch text/plain 722 tony NzY5MDVhYmNmYWZkNjM0NDAxZjYzMWY0OGE2YTUzZDdkYzIyMDkwNwpkaWZmIC0tZ2l0IGEvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDYw ZTcwODkuLmNiMjVlMjEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysg Yi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOC0xMC0wMiAg VG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9taXVtIGRvZXNuJ3QgdXNlIHB0aHJlYWRzIG9u IHdpbmRvd3MsIHNvIG1ha2UgaXRzIHVzZSBjb25kaXRpb25hbC4KKyAgICAgICAgCisgICAgICAg IEFsc28gY29udmVydCBhIFdPUkQgdG8gYSBEV09SRCB0byBhdm9pZCBhIGNvbXBpbGVyIHdhcm5p bmcuICBUaGlzCisgICAgICAgIG1hdGNoZXMgdGhlIG90aGVyIG1ldGhvZHMgYXJvdW5kIGl0Lgor CisgICAgICAgICogd3RmL1RocmVhZGluZ1dpbi5jcHA6CisgICAgICAgIChXVEY6Ond0ZlRocmVh ZEVudHJ5UG9pbnQpOgorICAgICAgICAoV1RGOjpUaHJlYWRDb25kaXRpb246OmJyb2FkY2FzdCk6 CisKIDIwMDgtMTAtMDIgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgogCiAg ICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IERhcmluIEFkbGVyLgo=