213118 2020-06-12 02:30:58 -0700 Add a quirk to allow starting AudioContext if document was interacted 2023-08-14 01:27:19 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 260134 1 youennf youennf eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1661894 0 youennf 2020-06-12 02:30:58 -0700 Add a quirk to allow starting AudioContext if document was interacted 1661897 1 401715 youennf 2020-06-12 02:39:14 -0700 Created attachment 401715 Patch 1662017 2 401715 eric.carlson 2020-06-12 10:22:46 -0700 Comment on attachment 401715 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401715&action=review > Source/WebCore/Modules/webaudio/AudioContext.cpp:1089 > +static bool isDocumentAllowingAutoplayWebAudio(const Document& document) Minor nit: "is ... allowing" isn't quite right. Maybe something like "documentAllowsWebAudioToAutoPlay", or "doesDocumentAllowWebAudioToAutoPlay"? 1662111 3 youennf 2020-06-12 13:17:40 -0700 <rdar://problem/64147813> 1662576 4 401887 youennf 2020-06-15 01:30:09 -0700 Created attachment 401887 Patch for landing 1662589 5 ews-feeder 2020-06-15 02:13:13 -0700 Committed r263025: <https://trac.webkit.org/changeset/263025> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401887. 1662591 6 youennf 2020-06-15 02:19:30 -0700 (In reply to Eric Carlson from comment #2) > Comment on attachment 401715 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401715&action=review > > > Source/WebCore/Modules/webaudio/AudioContext.cpp:1089 > > +static bool isDocumentAllowingAutoplayWebAudio(const Document& document) > > Minor nit: "is ... allowing" isn't quite right. Maybe something like > "documentAllowsWebAudioToAutoPlay", or "doesDocumentAllowWebAudioToAutoPlay"? I chose shouldDocumentAllowWebAudioToAutoPlay 401715 2020-06-12 02:39:14 -0700 2020-06-15 01:30:05 -0700 Patch bug-213118-20200612113912.patch text/plain 3486 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyOTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWI1ODcwY2E3Y2Q5ZDEy ZGE0MTA4NTYyZGExNDdkYjE3ZDg4YTY2OS4uMDI4NGMxNGE3NzAxMWI0ODA3YjYyMmQ5OWYzYjAx ZDEzNGM4OWJjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA2LTEyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBxdWlyayB0byBh bGxvdyBzdGFydGluZyBBdWRpb0NvbnRleHQgaWYgZG9jdW1lbnQgd2FzIGludGVyYWN0ZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzExOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hbnVhbGx5IHRl c3RlZCBvbiBiaW5nLmNvbS4KKworICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250 ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzRG9jdW1lbnRBbGxvd2luZ0F1dG9wbGF5V2Vi QXVkaW8pOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0Ojp3aWxsQmVnaW5QbGF5YmFj ayk6CisgICAgICAgICogcGFnZS9RdWlya3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UXVpcmtz OjpzaG91bGRBdXRvcGxheVdlYkF1ZGlvRm9yQXJiaXRyYXJ5VXNlckdlc3R1cmUgY29uc3QpOgor ICAgICAgICAqIHBhZ2UvUXVpcmtzLmg6CisKIDIwMjAtMDYtMTEgIERhdmlkIEtpbHplciAgPGRk a2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBbSVBDXSBBZGQgV1RGOjpFbnVtVHJhaXRzPD4g Zm9yIGV2ZXJ5IGVudW0gdHlwZSB1c2VkIGluIElQQwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCmluZGV4IDgyMWU1MTlkOWY2MWNiNDZiMjM2 YjNlYjE3OWNmM2RhMTM0NWM0NzQuLmYzYTYyOWUxNjlmMzRjYWY1Y2M1ZWU5OTIwNzI2MjY0ZWZk Y2RiYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9D b250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29u dGV4dC5jcHAKQEAgLTEwODYsNiArMTA4NiwxMyBAQCB2b2lkIEF1ZGlvQ29udGV4dDo6bm9kZVdp bGxCZWdpblBsYXliYWNrKCkKICAgICAgICAgc3RhcnRSZW5kZXJpbmcoKTsKIH0KIAorc3RhdGlj IGJvb2wgaXNEb2N1bWVudEFsbG93aW5nQXV0b3BsYXlXZWJBdWRpbyhjb25zdCBEb2N1bWVudCYg ZG9jdW1lbnQpCit7CisgICAgaWYgKGRvY3VtZW50LnByb2Nlc3NpbmdVc2VyR2VzdHVyZUZvck1l ZGlhKCkgfHwgZG9jdW1lbnQuaXNDYXB0dXJpbmcoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7Cisg ICAgcmV0dXJuIGRvY3VtZW50LnF1aXJrcygpLnNob3VsZEF1dG9wbGF5V2ViQXVkaW9Gb3JBcmJp dHJhcnlVc2VyR2VzdHVyZSgpICYmIGRvY3VtZW50LnRvcERvY3VtZW50KCkuaGFzSGFkVXNlcklu dGVyYWN0aW9uKCk7Cit9CisKIGJvb2wgQXVkaW9Db250ZXh0Ojp3aWxsQmVnaW5QbGF5YmFjaygp CiB7CiAgICAgYXV0byogZG9jdW1lbnQgPSB0aGlzLT5kb2N1bWVudCgpOwpAQCAtMTA5Myw3ICsx MTAwLDcgQEAgYm9vbCBBdWRpb0NvbnRleHQ6OndpbGxCZWdpblBsYXliYWNrKCkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogCiAgICAgaWYgKHVzZXJHZXN0dXJlUmVxdWlyZWRGb3JBdWRpb1N0YXJ0 KCkpIHsKLSAgICAgICAgaWYgKCFkb2N1bWVudC0+cHJvY2Vzc2luZ1VzZXJHZXN0dXJlRm9yTWVk aWEoKSAmJiAhZG9jdW1lbnQtPmlzQ2FwdHVyaW5nKCkpIHsKKyAgICAgICAgaWYgKCFpc0RvY3Vt ZW50QWxsb3dpbmdBdXRvcGxheVdlYkF1ZGlvKCpkb2N1bWVudCkpIHsKICAgICAgICAgICAgIEFM V0FZU19MT0coTE9HSURFTlRJRklFUiwgInJldHVybmluZyBmYWxzZSwgbm90IHByb2Nlc3Npbmcg dXNlciBnZXN0dXJlIG9yIGNhcHR1cmluZyIpOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKaW5kZXggNWYzYmM2MzIwZWJjZjZjNjM3YzA3 OTI5ZDExMDVmNWJmNGZkMDU0Yy4uOWMxODllMWY3NTJhMGI3MjIwMzc2NWZiMzU3YzAxZTljMTQy MDBlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcApAQCAtMTMwLDYgKzEzMCwxNSBAQCBib29sIFF1 aXJrczo6c2hvdWxkQXV0b3BsYXlGb3JBcmJpdHJhcnlVc2VyR2VzdHVyZSgpIGNvbnN0CiAjZW5k aWYKIH0KIAorYm9vbCBRdWlya3M6OnNob3VsZEF1dG9wbGF5V2ViQXVkaW9Gb3JBcmJpdHJhcnlV c2VyR2VzdHVyZSgpIGNvbnN0Cit7CisgICAgaWYgKCFuZWVkc1F1aXJrcygpKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisKKyAgICBhdXRvIGhvc3QgPSBtX2RvY3VtZW50LT50b3BEb2N1bWVudCgp LnVybCgpLmhvc3QoKTsKKyAgICByZXR1cm4gZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2Uo aG9zdCwgInd3dy5iaW5nLmNvbSIpOworfQorCiBib29sIFF1aXJrczo6aGFzQnJva2VuRW5jcnlw dGVkTWVkaWFBUElTdXBwb3J0UXVpcmsoKSBjb25zdAogewogICAgIGlmICghbmVlZHNRdWlya3Mo KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmggYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1F1aXJrcy5oCmluZGV4IDJkYTZlMzBjNzAxYmJjMzU0MzgyOTZkZTU5ZWRjMjVk NGE2NmNmNmIuLjYzODZlNzQyZGVhYTg4MjM3OGRjNDc5NmNmNDAxYjRlZWY0ZjU5MjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9RdWlya3MuaApAQCAtNDksNiArNDksNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBuZWVkc1Nl ZWtpbmdTdXBwb3J0RGlzYWJsZWQoKSBjb25zdDsKICAgICBib29sIG5lZWRzUGVyRG9jdW1lbnRB dXRvcGxheUJlaGF2aW9yKCkgY29uc3Q7CiAgICAgYm9vbCBzaG91bGRBdXRvcGxheUZvckFyYml0 cmFyeVVzZXJHZXN0dXJlKCkgY29uc3Q7CisgICAgYm9vbCBzaG91bGRBdXRvcGxheVdlYkF1ZGlv Rm9yQXJiaXRyYXJ5VXNlckdlc3R1cmUoKSBjb25zdDsKICAgICBib29sIGhhc0Jyb2tlbkVuY3J5 cHRlZE1lZGlhQVBJU3VwcG9ydFF1aXJrKCkgY29uc3Q7CiAgICAgYm9vbCBzaG91bGRTdHJpcFF1 b3RhdGlvbk1hcmtJbkZvbnRGYWNlU2V0RmFtaWx5KCkgY29uc3Q7CiAjaWYgRU5BQkxFKFRPVUNI X0VWRU5UUykK 401887 2020-06-15 01:30:09 -0700 2020-06-15 02:13:13 -0700 Patch for landing bug-213118-20200615103007.patch text/plain 3486 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTA0M2NkNjk3ZmRkNDAx YzI3ZGNhYTlkOGRkZTU3MzE0OWIxYzQwZC4uNjgxMzIzYmQzYmRhNDFkMGUzYWZiYTBlZjNmYjJm YWY3NjllNjEyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA2LTE1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBxdWlyayB0byBh bGxvdyBzdGFydGluZyBBdWRpb0NvbnRleHQgaWYgZG9jdW1lbnQgd2FzIGludGVyYWN0ZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzExOAorCisg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KKworICAgICAgICBNYW51YWxseSB0ZXN0 ZWQgb24gYmluZy5jb20uCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4 dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0RvY3VtZW50QWxsb3dpbmdBdXRvcGxheVdlYkF1 ZGlvKToKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ29udGV4dDo6d2lsbEJlZ2luUGxheWJhY2sp OgorICAgICAgICAqIHBhZ2UvUXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlF1aXJrczo6 c2hvdWxkQXV0b3BsYXlXZWJBdWRpb0ZvckFyYml0cmFyeVVzZXJHZXN0dXJlIGNvbnN0KToKKyAg ICAgICAgKiBwYWdlL1F1aXJrcy5oOgorCiAyMDIwLTA2LTE1ICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGlmeSBNZWRpYVJlY29yZGVyUHJpdmF0ZVdy aXRlckNvY29hIHRocmVhZGluZyBsb2dpYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCmluZGV4IDgyMWU1MTlkOWY2MWNiNDZiMjM2YjNlYjE3 OWNmM2RhMTM0NWM0NzQuLjM4MmRjN2NmMGNkMGY1ZDVkMzAyNzZlNjNkOTJkYmUwYjUzN2VhNTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5j cHAKQEAgLTEwODYsNiArMTA4NiwxMyBAQCB2b2lkIEF1ZGlvQ29udGV4dDo6bm9kZVdpbGxCZWdp blBsYXliYWNrKCkKICAgICAgICAgc3RhcnRSZW5kZXJpbmcoKTsKIH0KIAorc3RhdGljIGJvb2wg c2hvdWxkRG9jdW1lbnRBbGxvd1dlYkF1ZGlvVG9BdXRvUGxheShjb25zdCBEb2N1bWVudCYgZG9j dW1lbnQpCit7CisgICAgaWYgKGRvY3VtZW50LnByb2Nlc3NpbmdVc2VyR2VzdHVyZUZvck1lZGlh KCkgfHwgZG9jdW1lbnQuaXNDYXB0dXJpbmcoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAg cmV0dXJuIGRvY3VtZW50LnF1aXJrcygpLnNob3VsZEF1dG9wbGF5V2ViQXVkaW9Gb3JBcmJpdHJh cnlVc2VyR2VzdHVyZSgpICYmIGRvY3VtZW50LnRvcERvY3VtZW50KCkuaGFzSGFkVXNlckludGVy YWN0aW9uKCk7Cit9CisKIGJvb2wgQXVkaW9Db250ZXh0Ojp3aWxsQmVnaW5QbGF5YmFjaygpCiB7 CiAgICAgYXV0byogZG9jdW1lbnQgPSB0aGlzLT5kb2N1bWVudCgpOwpAQCAtMTA5Myw3ICsxMTAw LDcgQEAgYm9vbCBBdWRpb0NvbnRleHQ6OndpbGxCZWdpblBsYXliYWNrKCkKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogCiAgICAgaWYgKHVzZXJHZXN0dXJlUmVxdWlyZWRGb3JBdWRpb1N0YXJ0KCkp IHsKLSAgICAgICAgaWYgKCFkb2N1bWVudC0+cHJvY2Vzc2luZ1VzZXJHZXN0dXJlRm9yTWVkaWEo KSAmJiAhZG9jdW1lbnQtPmlzQ2FwdHVyaW5nKCkpIHsKKyAgICAgICAgaWYgKCFzaG91bGREb2N1 bWVudEFsbG93V2ViQXVkaW9Ub0F1dG9QbGF5KCpkb2N1bWVudCkpIHsKICAgICAgICAgICAgIEFM V0FZU19MT0coTE9HSURFTlRJRklFUiwgInJldHVybmluZyBmYWxzZSwgbm90IHByb2Nlc3Npbmcg dXNlciBnZXN0dXJlIG9yIGNhcHR1cmluZyIpOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKaW5kZXggNWYzYmM2MzIwZWJjZjZjNjM3YzA3 OTI5ZDExMDVmNWJmNGZkMDU0Yy4uOWMxODllMWY3NTJhMGI3MjIwMzc2NWZiMzU3YzAxZTljMTQy MDBlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcApAQCAtMTMwLDYgKzEzMCwxNSBAQCBib29sIFF1 aXJrczo6c2hvdWxkQXV0b3BsYXlGb3JBcmJpdHJhcnlVc2VyR2VzdHVyZSgpIGNvbnN0CiAjZW5k aWYKIH0KIAorYm9vbCBRdWlya3M6OnNob3VsZEF1dG9wbGF5V2ViQXVkaW9Gb3JBcmJpdHJhcnlV c2VyR2VzdHVyZSgpIGNvbnN0Cit7CisgICAgaWYgKCFuZWVkc1F1aXJrcygpKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisKKyAgICBhdXRvIGhvc3QgPSBtX2RvY3VtZW50LT50b3BEb2N1bWVudCgp LnVybCgpLmhvc3QoKTsKKyAgICByZXR1cm4gZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2Uo aG9zdCwgInd3dy5iaW5nLmNvbSIpOworfQorCiBib29sIFF1aXJrczo6aGFzQnJva2VuRW5jcnlw dGVkTWVkaWFBUElTdXBwb3J0UXVpcmsoKSBjb25zdAogewogICAgIGlmICghbmVlZHNRdWlya3Mo KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmggYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1F1aXJrcy5oCmluZGV4IDJkYTZlMzBjNzAxYmJjMzU0MzgyOTZkZTU5ZWRjMjVk NGE2NmNmNmIuLjYzODZlNzQyZGVhYTg4MjM3OGRjNDc5NmNmNDAxYjRlZWY0ZjU5MjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9RdWlya3MuaApAQCAtNDksNiArNDksNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBuZWVkc1Nl ZWtpbmdTdXBwb3J0RGlzYWJsZWQoKSBjb25zdDsKICAgICBib29sIG5lZWRzUGVyRG9jdW1lbnRB dXRvcGxheUJlaGF2aW9yKCkgY29uc3Q7CiAgICAgYm9vbCBzaG91bGRBdXRvcGxheUZvckFyYml0 cmFyeVVzZXJHZXN0dXJlKCkgY29uc3Q7CisgICAgYm9vbCBzaG91bGRBdXRvcGxheVdlYkF1ZGlv Rm9yQXJiaXRyYXJ5VXNlckdlc3R1cmUoKSBjb25zdDsKICAgICBib29sIGhhc0Jyb2tlbkVuY3J5 cHRlZE1lZGlhQVBJU3VwcG9ydFF1aXJrKCkgY29uc3Q7CiAgICAgYm9vbCBzaG91bGRTdHJpcFF1 b3RhdGlvbk1hcmtJbkZvbnRGYWNlU2V0RmFtaWx5KCkgY29uc3Q7CiAjaWYgRU5BQkxFKFRPVUNI X0VWRU5UUykK