213112 2020-06-11 21:55:17 -0700 Remove WTF::setMainThreadCallbacksPaused 2020-06-23 17:28:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren benjamin cdumez cmarcelo ews-watchlist hi joepeck simon.fraser thorton timothy webkit-bug-importer oldest_to_newest 1661849 0 ggaren 2020-06-11 21:55:17 -0700 Remove WTF::setMainThreadCallbacksPaused 1661850 1 401706 ggaren 2020-06-11 21:59:21 -0700 Created attachment 401706 Patch 1661854 2 401706 simon.fraser 2020-06-11 22:32:25 -0700 Comment on attachment 401706 Patch What impact will removing this have on JS debugging? It's been there since 2010. 1661861 3 401706 thorton 2020-06-11 23:04:41 -0700 Comment on attachment 401706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401706&action=review > Source/WTF/ChangeLog:16 > + even queue. That should suspend JavaScript-visible stuff without s/even/event/ Also... if we can really do this, why don't we use this for JS-synchronous-but-ideally-not-engine-synchronous things like alert()? 1661987 4 ggaren 2020-06-12 09:38:18 -0700 > Also... if we can really do this, why don't we use this for > JS-synchronous-but-ideally-not-engine-synchronous things like alert()? Use... what? :P alert() still needs to run a nested run loop or a sync IPC because it's not possible to tear down the whole stack and return to the main run loop -- that's not currently a feature of C++ or of the JS engine. Also, the debugger intends to allow a little more continuing execution than alert(). For example, the debugger intends to allow scrolling, selection, re-layout, and nested JS execution, and alert() does not. 1662005 5 thorton 2020-06-12 10:03:32 -0700 Aha! Ok, makes sense. 1662011 6 ggaren 2020-06-12 10:18:12 -0700 > What impact will removing this have on JS debugging? It's been there since > 2010. This code is all about how WebCore behaves when stopped at a breakpoint. Some edge case oddities will be fixed. For example, large images will be able to paint now. If I've overlooked something, some JS code will still run. So, you won't be as stopped as you wanted to be. The good news is, we can find and fix that kind of bug by migrating the code to the explicit JS event queue, which is much more reliable than just pausing all scheduled main thread code, including non-JS code. All of this being said, EWS says I did break a WK2 inspector test. Time for some fun debugging. 1662228 7 ggaren 2020-06-12 16:38:26 -0700 > All of this being said, EWS says I did break a WK2 inspector test. Time for > some fun debugging. Actually, that inspector test was broken by r262904, not this patch. So, back up for review. 1665594 8 ggaren 2020-06-23 16:38:41 -0700 Re-testing rdar://problem/14133001 still passes. 1665595 9 402607 ggaren 2020-06-23 16:41:56 -0700 Created attachment 402607 Patch for landing 1665604 10 ews-feeder 2020-06-23 17:27:48 -0700 Committed r263432: <https://trac.webkit.org/changeset/263432> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402607. 1665605 11 webkit-bug-importer 2020-06-23 17:28:17 -0700 <rdar://problem/64673032> 401706 2020-06-11 21:59:21 -0700 2020-06-19 15:53:52 -0700 Patch bug-213112-20200611215920.patch text/plain 4420 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjI5MzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDIwLTA2LTExICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIFdURjo6c2V0TWFpblRocmVhZENhbGxi YWNrc1BhdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEzMTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgc2V0TWFpblRocmVhZENhbGxiYWNrc1BhdXNlZCBwYXVzZXMgYWxsIHVzZXMgb2YgY2FsbE9u TWFpblRocmVhZC4gVGhhdAorICAgICAgICBoYXMgdG9vIG1hbnkgc2lkZS1lZmZlY3RzLiBGb3Ig ZXhhbXBsZSwgeW91IGNhbiBzY3JvbGwsIGJ1dCB5b3UgY2FuJ3QKKyAgICAgICAgcGFpbnQgYW55 IGxhcmdlIGltYWdlcyAoc2luY2UgdGhleSBkbyBhc3luYyBpbWFnZSBkZWNvZGluZykuCisKKyAg ICAgICAgTWVhbndoaWxlLCBzZXRNYWluVGhyZWFkQ2FsbGJhY2tzUGF1c2VkIGRvZXNuJ3QgcGF1 c2UgUnVuTG9vcDo6ZGlzcGF0Y2guCisgICAgICAgIFNvLCBvdGhlciB0aGluZ3MgZG9uJ3QgZ2V0 IHBhdXNlZC4KKworICAgICAgICBMZXQncyBqdXN0IHJlbHkgb24gc3VzcGVuZGluZyB0aGUgU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCBhbmQgZG9jdW1lbnQKKyAgICAgICAgZXZlbiBxdWV1ZS4gVGhh dCBzaG91bGQgc3VzcGVuZCBKYXZhU2NyaXB0LXZpc2libGUgc3R1ZmYgd2l0aG91dAorICAgICAg ICBzdXNwZW5kaW5nIGVuZ2luZS1jcml0aWNhbCBzdHVmZi4KKworICAgICAgICAqIHd0Zi9NYWlu VGhyZWFkLmNwcDoKKyAgICAgICAgKFdURjo6ZGlzcGF0Y2hGdW5jdGlvbnNGcm9tTWFpblRocmVh ZCk6CisgICAgICAgIChXVEY6OnNldE1haW5UaHJlYWRDYWxsYmFja3NQYXVzZWQpOiBEZWxldGVk LgorICAgICAgICAqIHd0Zi9NYWluVGhyZWFkLmg6CisKIDIwMjAtMDYtMTEgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZS1lbmFibGUgZG93 bmxvYWQgcmVzdW1lIHRlc3RzCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFkLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFkLmNwcAkocmV2aXNpb24gMjYy OTMyKQorKysgU291cmNlL1dURi93dGYvTWFpblRocmVhZC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTQxLDcgKzQxLDYgQEAKIAogbmFtZXNwYWNlIFdURiB7CiAKLXN0YXRpYyBib29sIGNhbGxiYWNr c1BhdXNlZDsgLy8gVGhpcyBnbG9iYWwgdmFyaWFibGUgaXMgb25seSBhY2Nlc3NlZCBmcm9tIG1h aW4gdGhyZWFkLgogc3RhdGljIExvY2sgbWFpblRocmVhZEZ1bmN0aW9uUXVldWVNdXRleDsKIAog c3RhdGljIERlcXVlPEZ1bmN0aW9uPHZvaWQgKCk+PiYgZnVuY3Rpb25RdWV1ZSgpCkBAIC03NCw5 ICs3Myw2IEBAIHZvaWQgZGlzcGF0Y2hGdW5jdGlvbnNGcm9tTWFpblRocmVhZCgpCiB7CiAgICAg QVNTRVJUKGlzTWFpblRocmVhZCgpKTsKIAotICAgIGlmIChjYWxsYmFja3NQYXVzZWQpCi0gICAg ICAgIHJldHVybjsKLQogICAgIGF1dG8gc3RhcnRUaW1lID0gTW9ub3RvbmljVGltZTo6bm93KCk7 CiAKICAgICBGdW5jdGlvbjx2b2lkICgpPiBmdW5jdGlvbjsKQEAgLTEzMiwxOSArMTI4LDYgQEAg dm9pZCBjYWxsT25NYWluVGhyZWFkKEZ1bmN0aW9uPHZvaWQoKT4mJgogICAgICAgICBzY2hlZHVs ZURpc3BhdGNoRnVuY3Rpb25zT25NYWluVGhyZWFkKCk7CiB9CiAKLXZvaWQgc2V0TWFpblRocmVh ZENhbGxiYWNrc1BhdXNlZChib29sIHBhdXNlZCkKLXsKLSAgICBBU1NFUlQoaXNNYWluVGhyZWFk KCkpOwotCi0gICAgaWYgKGNhbGxiYWNrc1BhdXNlZCA9PSBwYXVzZWQpCi0gICAgICAgIHJldHVy bjsKLQotICAgIGNhbGxiYWNrc1BhdXNlZCA9IHBhdXNlZDsKLQotICAgIGlmICghY2FsbGJhY2tz UGF1c2VkKQotICAgICAgICBzY2hlZHVsZURpc3BhdGNoRnVuY3Rpb25zT25NYWluVGhyZWFkKCk7 Ci19Ci0KIGJvb2wgaXNNYWluVGhyZWFkT3JHQ1RocmVhZCgpCiB7CiAgICAgaWYgKFRocmVhZDo6 bWF5QmVHQ1RocmVhZCgpKQpJbmRleDogU291cmNlL1dURi93dGYvTWFpblRocmVhZC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL01haW5UaHJlYWQuaAkocmV2aXNpb24gMjYyOTMyKQor KysgU291cmNlL1dURi93dGYvTWFpblRocmVhZC5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCw4ICs1 MCw2IEBAIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIGRpc3BhdGNoQXN5bmNPbk0KIFdURl9FWFBP UlRfUFJJVkFURSB2b2lkIGNhbGxPbldlYlRocmVhZE9yRGlzcGF0Y2hBc3luY09uTWFpblRocmVh ZCh2b2lkICheYmxvY2spKCkpOwogI2VuZGlmCiAKLVdURl9FWFBPUlRfUFJJVkFURSB2b2lkIHNl dE1haW5UaHJlYWRDYWxsYmFja3NQYXVzZWQoYm9vbCBwYXVzZWQpOwotCiBXVEZfRVhQT1JUX1BS SVZBVEUgYm9vbCBpc01haW5UaHJlYWQoKTsKIAogV1RGX0VYUE9SVF9QUklWQVRFIGJvb2wgY2Fu Q3VycmVudFRocmVhZEFjY2Vzc1RocmVhZExvY2FsRGF0YShUaHJlYWQmKTsKQEAgLTg4LDcgKzg2 LDYgQEAgdXNpbmcgV1RGOjppc01haW5UaHJlYWQ7CiB1c2luZyBXVEY6OmlzTWFpblRocmVhZE9y R0NUaHJlYWQ7CiB1c2luZyBXVEY6OmlzVUlUaHJlYWQ7CiB1c2luZyBXVEY6OmlzV2ViVGhyZWFk OwotdXNpbmcgV1RGOjpzZXRNYWluVGhyZWFkQ2FsbGJhY2tzUGF1c2VkOwogI2lmIFBMQVRGT1JN KENPQ09BKQogdXNpbmcgV1RGOjpkaXNwYXRjaEFzeW5jT25NYWluVGhyZWFkV2l0aFdlYlRocmVh ZExvY2tJZk5lZWRlZDsKIHVzaW5nIFdURjo6Y2FsbE9uV2ViVGhyZWFkT3JEaXNwYXRjaEFzeW5j T25NYWluVGhyZWFkOwpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYyOTMyKQorKysgU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAt MDYtMTEgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1v dmUgV1RGOjpzZXRNYWluVGhyZWFkQ2FsbGJhY2tzUGF1c2VkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTMxMTIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9QYWdlU2NyaXB0RGVidWdT ZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZVNjcmlwdERlYnVnU2VydmVyOjpzZXRK YXZhU2NyaXB0UGF1c2VkKToKKwogMjAyMC0wNi0xMSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgRml4IGNvbW1lbnQgYWZ0ZXIgYmxvY2tsaXN0IHRyYW5zaXRpb24K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9QYWdlU2NyaXB0RGVidWdTZXJ2ZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9QYWdlU2NyaXB0RGVidWdT ZXJ2ZXIuY3BwCShyZXZpc2lvbiAyNjI5MzIpCisrKyBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv UGFnZVNjcmlwdERlYnVnU2VydmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM1LDggKzEzNSw2 IEBAIHZvaWQgUGFnZVNjcmlwdERlYnVnU2VydmVyOjpyZXBvcnRFeGNlcHQKIAogdm9pZCBQYWdl U2NyaXB0RGVidWdTZXJ2ZXI6OnNldEphdmFTY3JpcHRQYXVzZWQoY29uc3QgUGFnZUdyb3VwJiBw YWdlR3JvdXAsIGJvb2wgcGF1c2VkKQogewotICAgIHNldE1haW5UaHJlYWRDYWxsYmFja3NQYXVz ZWQocGF1c2VkKTsKLQogICAgIGZvciAoYXV0byYgcGFnZSA6IHBhZ2VHcm91cC5wYWdlcygpKSB7 CiAgICAgICAgIGZvciAoRnJhbWUqIGZyYW1lID0gJnBhZ2UtPm1haW5GcmFtZSgpOyBmcmFtZTsg ZnJhbWUgPSBmcmFtZS0+dHJlZSgpLnRyYXZlcnNlTmV4dCgpKQogICAgICAgICAgICAgc2V0SmF2 YVNjcmlwdFBhdXNlZCgqZnJhbWUsIHBhdXNlZCk7Cg== 402607 2020-06-23 16:41:56 -0700 2020-06-23 17:27:48 -0700 Patch for landing bug-213112-20200623164155.patch text/plain 4391 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjMzNzQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDIwLTA2LTIyICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIFdURjo6c2V0TWFpblRocmVhZENhbGxi YWNrc1BhdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEzMTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBz ZXRNYWluVGhyZWFkQ2FsbGJhY2tzUGF1c2VkIHBhdXNlcyBhbGwgdXNlcyBvZiBjYWxsT25NYWlu VGhyZWFkLiBUaGF0CisgICAgICAgIGhhcyB0b28gbWFueSBzaWRlLWVmZmVjdHMuIEZvciBleGFt cGxlLCB5b3UgY2FuIHNjcm9sbCwgYnV0IHlvdSBjYW4ndAorICAgICAgICBwYWludCBhbnkgbGFy Z2UgaW1hZ2VzIChzaW5jZSB0aGV5IGRvIGFzeW5jIGltYWdlIGRlY29kaW5nKS4KKworICAgICAg ICBNZWFud2hpbGUsIHNldE1haW5UaHJlYWRDYWxsYmFja3NQYXVzZWQgZG9lc24ndCBwYXVzZSBS dW5Mb29wOjpkaXNwYXRjaC4KKyAgICAgICAgU28sIG90aGVyIHRoaW5ncyBkb24ndCBnZXQgcGF1 c2VkLgorCisgICAgICAgIExldCdzIGp1c3QgcmVseSBvbiBzdXNwZW5kaW5nIHRoZSBTY3JpcHRF eGVjdXRpb25Db250ZXh0IGFuZCBkb2N1bWVudAorICAgICAgICBldmVudCBxdWV1ZS4gVGhhdCBz aG91bGQgc3VzcGVuZCBKYXZhU2NyaXB0LXZpc2libGUgc3R1ZmYgd2l0aG91dAorICAgICAgICBz dXNwZW5kaW5nIGVuZ2luZS1jcml0aWNhbCBzdHVmZi4KKworICAgICAgICAqIHd0Zi9NYWluVGhy ZWFkLmNwcDoKKyAgICAgICAgKFdURjo6ZGlzcGF0Y2hGdW5jdGlvbnNGcm9tTWFpblRocmVhZCk6 CisgICAgICAgIChXVEY6OnNldE1haW5UaHJlYWRDYWxsYmFja3NQYXVzZWQpOiBEZWxldGVkLgor ICAgICAgICAqIHd0Zi9NYWluVGhyZWFkLmg6CisKIDIwMjAtMDYtMjIgIFRpbW90aHkgSG9ydG9u ICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQKSW5k ZXg6IFNvdXJjZS9XVEYvd3RmL01haW5UaHJlYWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X VEYvd3RmL01haW5UaHJlYWQuY3BwCShyZXZpc2lvbiAyNjMzNzQpCisrKyBTb3VyY2UvV1RGL3d0 Zi9NYWluVGhyZWFkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDEsNyArNDEsNiBAQAogCiBuYW1l c3BhY2UgV1RGIHsKIAotc3RhdGljIGJvb2wgY2FsbGJhY2tzUGF1c2VkOyAvLyBUaGlzIGdsb2Jh bCB2YXJpYWJsZSBpcyBvbmx5IGFjY2Vzc2VkIGZyb20gbWFpbiB0aHJlYWQuCiBzdGF0aWMgTG9j ayBtYWluVGhyZWFkRnVuY3Rpb25RdWV1ZU11dGV4OwogCiBzdGF0aWMgRGVxdWU8RnVuY3Rpb248 dm9pZCAoKT4+JiBmdW5jdGlvblF1ZXVlKCkKQEAgLTc0LDkgKzczLDYgQEAgdm9pZCBkaXNwYXRj aEZ1bmN0aW9uc0Zyb21NYWluVGhyZWFkKCkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkp OwogCi0gICAgaWYgKGNhbGxiYWNrc1BhdXNlZCkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgYXV0 byBzdGFydFRpbWUgPSBNb25vdG9uaWNUaW1lOjpub3coKTsKIAogICAgIEZ1bmN0aW9uPHZvaWQg KCk+IGZ1bmN0aW9uOwpAQCAtMTMyLDE5ICsxMjgsNiBAQCB2b2lkIGNhbGxPbk1haW5UaHJlYWQo RnVuY3Rpb248dm9pZCgpPiYmCiAgICAgICAgIHNjaGVkdWxlRGlzcGF0Y2hGdW5jdGlvbnNPbk1h aW5UaHJlYWQoKTsKIH0KIAotdm9pZCBzZXRNYWluVGhyZWFkQ2FsbGJhY2tzUGF1c2VkKGJvb2wg cGF1c2VkKQotewotICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0KLSAgICBpZiAoY2FsbGJh Y2tzUGF1c2VkID09IHBhdXNlZCkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgY2FsbGJhY2tzUGF1 c2VkID0gcGF1c2VkOwotCi0gICAgaWYgKCFjYWxsYmFja3NQYXVzZWQpCi0gICAgICAgIHNjaGVk dWxlRGlzcGF0Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQoKTsKLX0KLQogYm9vbCBpc01haW5UaHJl YWRPckdDVGhyZWFkKCkKIHsKICAgICBpZiAoVGhyZWFkOjptYXlCZUdDVGhyZWFkKCkpCkluZGV4 OiBTb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93 dGYvTWFpblRocmVhZC5oCShyZXZpc2lvbiAyNjMzNzQpCisrKyBTb3VyY2UvV1RGL3d0Zi9NYWlu VGhyZWFkLmgJKHdvcmtpbmcgY29weSkKQEAgLTUwLDggKzUwLDYgQEAgV1RGX0VYUE9SVF9QUklW QVRFIHZvaWQgZGlzcGF0Y2hBc3luY09uTQogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgY2FsbE9u V2ViVGhyZWFkT3JEaXNwYXRjaEFzeW5jT25NYWluVGhyZWFkKHZvaWQgKF5ibG9jaykoKSk7CiAj ZW5kaWYKIAotV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgc2V0TWFpblRocmVhZENhbGxiYWNrc1Bh dXNlZChib29sIHBhdXNlZCk7Ci0KIFdURl9FWFBPUlRfUFJJVkFURSBib29sIGlzTWFpblRocmVh ZCgpOwogCiBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBjYW5DdXJyZW50VGhyZWFkQWNjZXNzVGhy ZWFkTG9jYWxEYXRhKFRocmVhZCYpOwpAQCAtODgsNyArODYsNiBAQCB1c2luZyBXVEY6OmlzTWFp blRocmVhZDsKIHVzaW5nIFdURjo6aXNNYWluVGhyZWFkT3JHQ1RocmVhZDsKIHVzaW5nIFdURjo6 aXNVSVRocmVhZDsKIHVzaW5nIFdURjo6aXNXZWJUaHJlYWQ7Ci11c2luZyBXVEY6OnNldE1haW5U aHJlYWRDYWxsYmFja3NQYXVzZWQ7CiAjaWYgUExBVEZPUk0oQ09DT0EpCiB1c2luZyBXVEY6OmRp c3BhdGNoQXN5bmNPbk1haW5UaHJlYWRXaXRoV2ViVGhyZWFkTG9ja0lmTmVlZGVkOwogdXNpbmcg V1RGOjpjYWxsT25XZWJUaHJlYWRPckRpc3BhdGNoQXN5bmNPbk1haW5UaHJlYWQ7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjMzNzQpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wNi0yMiAgR2VvZmZyZXkgR2FyZW4g IDxnZ2FyZW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBXVEY6OnNldE1haW5UaHJlYWRD YWxsYmFja3NQYXVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxMzExMgorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvUGFnZVNjcmlwdERlYnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBhZ2VTY3JpcHREZWJ1Z1NlcnZlcjo6c2V0SmF2YVNjcmlwdFBhdXNlZCk6CisKIDIwMjAt MDYtMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAg VXBkYXRlIG1hY09TIHZlcnNpb24gbWFjcm9zCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvUGFnZVNjcmlwdERlYnVnU2VydmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvUGFnZVNjcmlwdERlYnVnU2VydmVyLmNwcAkocmV2aXNpb24gMjYzMzc0KQor KysgU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1BhZ2VTY3JpcHREZWJ1Z1NlcnZlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEzNSw4ICsxMzUsNiBAQCB2b2lkIFBhZ2VTY3JpcHREZWJ1Z1NlcnZl cjo6cmVwb3J0RXhjZXB0CiAKIHZvaWQgUGFnZVNjcmlwdERlYnVnU2VydmVyOjpzZXRKYXZhU2Ny aXB0UGF1c2VkKGNvbnN0IFBhZ2VHcm91cCYgcGFnZUdyb3VwLCBib29sIHBhdXNlZCkKIHsKLSAg ICBzZXRNYWluVGhyZWFkQ2FsbGJhY2tzUGF1c2VkKHBhdXNlZCk7Ci0KICAgICBmb3IgKGF1dG8m IHBhZ2UgOiBwYWdlR3JvdXAucGFnZXMoKSkgewogICAgICAgICBmb3IgKEZyYW1lKiBmcmFtZSA9 ICZwYWdlLT5tYWluRnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS50cmF2ZXJz ZU5leHQoKSkKICAgICAgICAgICAgIHNldEphdmFTY3JpcHRQYXVzZWQoKmZyYW1lLCBwYXVzZWQp Owo=