213110 2020-06-11 20:29:13 -0700 REGRESSION (r262124): Twitter videos go blank after exiting fullscreen 2020-09-01 12:18:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212264 InRadar P2 Normal --- 1 simon.fraser svillar bfulgham changseok darin dino eric.carlson esprehn+autocc ews-watchlist glenn jer.noble kondapallykalyan pdr peng.liu6 philipj rackler sergio simon.fraser svillar webkit-bug-importer zalan oldest_to_newest 1661836 0 simon.fraser 2020-06-11 20:29:13 -0700 Summary: Twitter videos go blank after exiting fullscreen Steps To Reproduce: 1. Load https://twitter.com/stephentyrone/status/1271230268762992642 in Safari 2. Take the video fullscreen 3. Exit fullscreen Results: The area where the video should be is blank. Regression: I regressed this to https://trac.webkit.org/changeset/262124/webkit 1661873 1 svillar 2020-06-12 00:53:28 -0700 We'll check. It's weird because I cannot reproduce it with WebKitGTK 1662217 2 peng.liu6 2020-06-12 16:25:22 -0700 Is FULLSCREEN_API enabled for WebKitGTK? Looks like it is not. Then this issue affects Mac version only. 1662218 3 peng.liu6 2020-06-12 16:26:55 -0700 <rdar://problem/64282632> 1662275 4 simon.fraser 2020-06-12 17:54:29 -0700 Can we revert the change for now? 1662557 5 svillar 2020-06-14 22:57:53 -0700 (In reply to Simon Fraser (smfr) from comment #4) > Can we revert the change for now? Reverted for now while investigating. 1662595 6 svillar 2020-06-15 02:22:41 -0700 (In reply to Peng Liu from comment #2) > Is FULLSCREEN_API enabled for WebKitGTK? Looks like it is not. Then this > issue affects Mac version only. Not by default, but it's implemented. After building with it enabled I cannot reproduce the test case in WebKitGtk either. I'm wondering whether there is some special code in twitter depending on the UA that could cause the issue. Still checking 1662604 7 svillar 2020-06-15 03:34:57 -0700 (In reply to Sergio Villar Senin from comment #6) > (In reply to Peng Liu from comment #2) > > Is FULLSCREEN_API enabled for WebKitGTK? Looks like it is not. Then this > > issue affects Mac version only. > > Not by default, but it's implemented. After building with it enabled I > cannot reproduce the test case in WebKitGtk either. I'm wondering whether > there is some special code in twitter depending on the UA that could cause > the issue. Still checking BTW the issue if any will be with the interaction between RenderFlexibleBox and RenderFullscreen (derived) more than with the FULLSCREEN_API which is different stuff. 1662616 8 svillar 2020-06-15 06:07:49 -0700 (In reply to Sergio Villar Senin from comment #7) > (In reply to Sergio Villar Senin from comment #6) > > (In reply to Peng Liu from comment #2) > > > Is FULLSCREEN_API enabled for WebKitGTK? Looks like it is not. Then this > > > issue affects Mac version only. > > > > Not by default, but it's implemented. After building with it enabled I > > cannot reproduce the test case in WebKitGtk either. I'm wondering whether > > there is some special code in twitter depending on the UA that could cause > > the issue. Still checking > > BTW the issue if any will be with the interaction between RenderFlexibleBox > and RenderFullscreen (derived) more than with the FULLSCREEN_API which is > different stuff. Good news is that I managed to repro it using WebKitGtk so it'll be much easier to get a fix. 1662656 9 simon.fraser 2020-06-15 08:28:28 -0700 Was reverted in https://trac.webkit.org/changeset/263018/webkit 1663972 10 402230 svillar 2020-06-18 13:26:10 -0700 Created attachment 402230 Patch 1664991 11 402464 svillar 2020-06-22 05:24:53 -0700 Created attachment 402464 Patch Test working now in Mac/iOS 1665311 12 svillar 2020-06-23 00:27:36 -0700 Committed r263389: <https://trac.webkit.org/changeset/263389> 1665396 13 rackler 2020-06-23 08:38:12 -0700 Created https://bugs.webkit.org/show_bug.cgi?id=213517 for the test because it is flaky failing since introduction. 402230 2020-06-18 13:26:10 -0700 2020-06-22 05:24:48 -0700 Patch bug-213110-20200618222608.patch text/plain 6846 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU1MmQ4MjQ1OWVjODY3 YzFhZTEyYjJkZDBjYmFjNjQ0NjQ3ZjdiYS4uYmRmOTE4ZjYxNzdkMjY5NjNkOGRiYTY2OTQyMzRh NWIwZGJkNzVlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQxIEBACisyMDIwLTA2LTE4ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIyNjIxMjQpOiBUd2l0dGVyIHZpZGVvcyBnbyBibGFuayBhZnRlciBleGl0aW5nIGZ1bGxz Y3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MzExMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IGZ1bGxzY3JlZW4vdmlkZW8taW5zaWRlLWZsZXgtaXRlbS5odG1sCisKKyAgICAgICAgU2V0 dGluZy91bnNldHRpbmcgcG9zaXRpb246YWJzb2x1dGUgb24gYSBmbGV4L2dyaWQgaXRlbSBjYW4g cG90ZW50aWFsbHkgY3JlYXRlL3JlbW92ZSBmbGV4L2dyaWQgaXRlbXMgYmVjYXVzZQorICAgICAg ICBhYnNvbHV0ZWx5IHBvc2l0aW9uZWQgY2hpbGRyZW4gb2YgdGhvc2UgY29udGFpbmVycyBhcmUg b3V0LW9mLWZsb3cgYW5kIHRodXMsIGRvIG5vdCBnZW5lcmF0ZSBmbGV4L2dyaWQgaXRlbXMuCisg ICAgICAgIEZsZXgvZ3JpZCBpdGVtcyBhcmUgcG90ZW50aWFsbHkgc3RyZXRjaGVkIGJ5IHRoZWly IGNvbnRhaW5lcnMgc28gdGhlIHN0eWxlIHJlY2FsY3VsYXRpb24gaXMgbm90IGVub3VnaCB0byBn ZXQKKyAgICAgICAgYSBjb3JyZWN0IGxheW91dCBiZWNhdXNlIHRoZSBvdmVycmlkZSBzaXplIHNl dCBieSBmbGV4L2dyaWQgY29udGFpbmVycyBpcyBub3QgcmVzZXQuCisgICAgICAgIEluIHRoZSBw YXJ0aWN1bGFyIGNhc2Ugb2YgdGhpcyBidWcgd2UgaGFkIHRoaXMgaGllcmFyY2h5IChoaWdobHkg c2ltcGxpZmllZCBmcm9tIHR3aXR0ZXIgcGFnZSk6CisKKyAgICAgICAgRmxleGJveCBjb250YWlu ZXIKKyAgICAgICAgfF9fX0RJViAoYWJzb2x1dGVsbHkgcG9zaXRpb25lZCkKKyAgICAgICAgICAg IHxfX188dmlkZW8+IChoZWlnaHQ6IDEwMCUgd2lkdGg6IDEwMCUpCisKKyAgICAgICAgV2hlbiB0 aGUgPHZpZGVvPiBnb2VzIGZ1bGxzY3JlZW4gdGhlIEZ1bGxzY3JlZW5NYW5hZ2VyIHJlcGxhY2Vz IHRoZQorICAgICAgICBzdHlsZSBvZiB0aGUgRElWIGJlY2F1c2UgaXQgaW5zZXJ0cyBhIFJlbmRl ckZ1bGxTY3JlZW4gb2JqZWN0IGluIGJldHdlZW4KKyAgICAgICAgdGhlIERJViBhbmQgdGhlIDx2 aWRlbz4gKGFsb25nIHdpdGggc29tZSBhbm9ueW1vdXMgYmxvY2tzKS4gVGhpcyBtZWFucworICAg ICAgICB0aGF0IHRoZSBESVYgd2hpY2ggd2FzIG5vdCBhIGZsZXggaXRlbSAoYXMgaXQgd2FzIGFi c29sdXRlbHkgcG9zaXRpb25lZCkKKyAgICAgICAgYmVjYW1lIGEgZmxleCBpdGVtIGFuZCB0aHVz IGl0cyBzaXplIGlzIHN0cmV0Y2hlZCBhcyB0aGUgZmxleGJveAorICAgICAgICBjb250YWluZXIg bWFuZGF0ZXMuIFdoZW4gZXhpdGluZyBmdWxsc2NyZWVuLCB0aGUgb3JpZ2luYWwgc3R5bGUgaXMK KyAgICAgICAgcmVzdG9yZWQgKGFuZCB0aHVzIHRoZSBwb3NpdGlvbiBhYnNvbHV0ZSkuIFRoZSBE SVYgaXMgdGhlbiBubyBsb25nZXIgYQorICAgICAgICBmbGV4IGl0ZW0gYnV0IHRoZSBzdHJldGNo ZWQgc2l6ZSAob3ZlcnJpZGVDb250ZW50U2l6ZSkgaXMgc3RpbGwgc2V0LAorICAgICAgICBjYXVz aW5nIGlzc3VlcyB3aXRoIHRoZSBzaXplcyBvZiB0aGUgPHZpZGVvPi4KKworICAgICAgICBOb3Rl IHRoYXQgaXQgaXNuJ3QgcG9zc2libGUgdG8gcmVwcm9kdWNlIHRoaXMgYnVnIHdpdGggdGhlIGN1 cnJlbnQgdHJ1bmsgYmVjYXVzZSB0aGVyZSBpcyBhIGJ1ZyBpbiB0aGUgZmxleGJveAorICAgICAg ICBpbXBsZW1lbnRhdGlvbiAoc2VlIGJ1ZyAyMTIyNjQpIHByZXZlbnRpbmcgdGhpcyB0byBoYXBw ZW4uIEhvd2V2ZXIgaXQgYmVjb21lcyAxMDAlIHJlcHJvZHVjaWJsZSB3aXRoIHRoZSBwYXRjaCBm b3IgYnVnIDIxMjI2NAorICAgICAgICB3aGljaCBpcyBjb3JyZWN0IGFuZCBmaXhlcyBzZXZlcmFs IHRlc3RzIHJlbGF0ZWQgdG8gd3JhcHBpbmcgaW4gZmxleGJveC4gSXQncyBhbHNvIHJlcHJvZHVj aWJsZSB3aGVuIHRoZSBGVUxMU0NSRUVOX0FQSSBpcworICAgICAgICBlbmFibGVkLCBvdGhlcndp c2UgdGhlIGNvZGVwYXRoIGZvciBmdWxsIHNjcmVlbiBpcyB0b3RhbGx5IGRpZmZlcmVudCAodGhl cmUgYXJlIG5vIHBsYWNlaG9sZGVycykuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6c3R5bGVEaWRDaGFuZ2UpOiBjbGVh ciB0aGUgb3ZlcnJpZGUgc2l6ZXMgZm9yIGdyaWQvZmxleCB3aGVuIGZsZXgvZ3JpZCBpdGVtcyBi ZWNvbWUgb3V0LW9mLWZsb3csCisgICAgICAgIGZvciBleGFtcGxlIGJ5IGNoYW5naW5nIHBvc2l0 aW9uIHRvIGFic29sdXRlLgorCiAyMDIwLTA2LTE0ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3Zp bGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjYyMTI0 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCA2YWNiYWI0ZWZhMjlh MzYyODBmN2YzMjkxYTY5M2RiMTQxYWI5MjMzLi4zZDJjNGQwMDc0OTE1NTk1NjllZTYwZjVhYTg1 ZjZhNjMxOTY5MWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAt NDA1LDYgKzQwNSwxMiBAQCB2b2lkIFJlbmRlckJveDo6c3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZm ZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZQogICAgIGlmICgob2xkU3R5 bGUgJiYgb2xkU3R5bGUtPnNoYXBlT3V0c2lkZSgpKSB8fCBzdHlsZSgpLnNoYXBlT3V0c2lkZSgp KQogICAgICAgICB1cGRhdGVTaGFwZU91dHNpZGVJbmZvQWZ0ZXJTdHlsZUNoYW5nZShzdHlsZSgp LCBvbGRTdHlsZSk7CiAgICAgdXBkYXRlR3JpZFBvc2l0aW9uQWZ0ZXJTdHlsZUNoYW5nZShzdHls ZSgpLCBvbGRTdHlsZSk7CisKKyAgICAvLyBDaGFuZ2luZyB0aGUgcG9zaXRpb24gZnJvbS90byBh YnNvbHV0ZSBjYW4gcG90ZW50aWFsbHkgY3JlYXRlL3JlbW92ZSBmbGV4L2dyaWQgaXRlbXMsIGFz IGFic29sdXRlbHkgcG9zaXRpb25lZAorICAgIC8vIGNoaWxkcmVuIG9mIGEgZmxleC9ncmlkIGJv eCBhcmUgb3V0LW9mLWZsb3csIGFuZCB0aHVzLCBub3QgZmxleC9ncmlkIGl0ZW1zLiBUaGlzIG1l YW5zIHRoYXQgd2UgbmVlZCB0byBjbGVhcgorICAgIC8vIGFueSBvdmVycmlkZSBjb250ZW50IHNp emUgc2V0IGJ5IG91ciBjb250YWluZXIsIGJlY2F1c2UgaXQgd291bGQgbGlrZWx5IGJlIGluY29y cmVjdCBhZnRlciB0aGUgc3R5bGUgY2hhbmdlLgorICAgIGlmIChpc091dE9mRmxvd1Bvc2l0aW9u ZWQoKSAmJiBwYXJlbnQoKSAmJiBwYXJlbnQoKS0+c3R5bGUoKS5pc0Rpc3BsYXlGbGV4aWJsZU9y R3JpZEJveCgpKQorICAgICAgICBjbGVhck92ZXJyaWRlQ29udGVudFNpemUoKTsKIH0KIAogdm9p ZCBSZW5kZXJCb3g6OnVwZGF0ZUdyaWRQb3NpdGlvbkFmdGVyU3R5bGVDaGFuZ2UoY29uc3QgUmVu ZGVyU3R5bGUmIHN0eWxlLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkU3R5bGUpCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGI1 ODBiMTQ0NjIxODkyZjBlZDkxNzY2NTQ5MmNjMWI3YzNlYzAwMi4uY2UzNjk3ZWMzZDM5M2VlMTEx ZjIyM2I2MDRhNTc3MjlhMjY3ZmU4ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA2LTE4 ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04gKHIyNjIxMjQpOiBUd2l0dGVyIHZpZGVvcyBnbyBibGFuayBhZnRlciBleGl0aW5n IGZ1bGxzY3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxMzExMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVtLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVtLmh0bWw6IEFk ZGVkLgorCiAyMDIwLTA2LTE0ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjYyMTI0LgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVtLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8taW5zaWRlLWZsZXgtaXRlbS1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uMzNhNWI4NDlhM2ZlMzI4MThhZDU2MjkxYzI2YmU1ZGZjNmQx YTJlYQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8taW5z aWRlLWZsZXgtaXRlbS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw4IEBACisKK0VWRU5UKHdlYmtp dGZ1bGxzY3JlZW5jaGFuZ2UpCitFWFBFQ1RFRCAoODAwID09ICc4MDAnKSBPSworRVZFTlQod2Vi a2l0ZnVsbHNjcmVlbmNoYW5nZSkKK0VYUEVDVEVEICgzMDAgPT0gJzMwMCcpIE9LCitFWFBFQ1RF RCAoMTUwID09ICcxNTAnKSBPSworRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVtLmh0bWwgYi9MYXlvdXRUZXN0cy9m dWxsc2NyZWVuL3ZpZGVvLWluc2lkZS1mbGV4LWl0ZW0uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zZjU4YTJm Zjg5ZTVkOTAxYWExMTJjN2U5OTMwZTFiYzk0ODE4N2Q3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVtLmh0bWwKQEAgLTAsMCAr MSw0MiBAQAorPCFET0NUWVBFIGh0bWw+Cis8c3R5bGU+Citib2R5IHsKKyAgICBtYXJnaW46IDBw eDsKK30KKy5wZXJjZW50MTAwIHsKKyAgICB3aWR0aDogMTAwJTsKKyAgICBoZWlnaHQ6IDEwMCU7 Cit9Cis8L3N0eWxlPgorPHNjcmlwdCBzcmM9ImZ1bGwtc2NyZWVuLXRlc3QuanMiPjwvc2NyaXB0 PgorPHNjcmlwdCBzcmM9Li4vbWVkaWEvbWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KKworPGRpdiBz dHlsZT0iZGlzcGxheTogZmxleDsgZmxleC1kaXJlY3Rpb246IGNvbHVtbjsiPgorICAgIDxkaXYg c3R5bGU9InBvc2l0aW9uOiBhYnNvbHV0ZTsgYmFja2dyb3VuZDogZ3JlZW47Ij4KKyAgICAgICAg PHZpZGVvIGlkPSJ2aWRlbyIgY2xhc3M9InBlcmNlbnQxMDAiIGNvbnRyb2xzPjwvdmlkZW8+Cisg ICAgPC9kaXY+Cis8L2Rpdj4KKworPHNjcmlwdD4KK3NldFNyY0J5SWQoInZpZGVvIiwgZmluZE1l ZGlhRmlsZSgidmlkZW8iLCAiLi4vbWVkaWEvY29udGVudC90ZXN0IikpOwordmFyIHZpZGVvID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3ZpZGVvJyk7CisvLyBCYWlsIG91dCBlYXJseSBpZiB0 aGUgZnVsbCBzY3JlZW4gQVBJIGlzIG5vdCBlbmFibGVkIG9yIGlzIG1pc3Npbmc6CitpZiAoRWxl bWVudC5wcm90b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5kZWZpbmVkKSB7Cisg ICAgbG9nUmVzdWx0KGZhbHNlLCAiRWxlbWVudC5wcm90b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxT Y3JlZW4gPT0gdW5kZWZpbmVkIik7CisgICAgZW5kVGVzdCgpOworfSBlbHNlIHsKKyAgICB3YWl0 Rm9yRXZlbnRPbmNlKGRvY3VtZW50LCAnd2Via2l0ZnVsbHNjcmVlbmNoYW5nZScsIGZ1bmN0aW9u IChldmVudCkgeworICAgICAgICAvLyBGaXJzdCBjaGVjayB0aGF0IHdlIHdlbnQgZnVsbHNjcmVl bi4KKyAgICAgICAgdGVzdEV4cGVjdGVkKHZpZGVvLmNsaWVudFdpZHRoLCBkb2N1bWVudC5ib2R5 LmNsaWVudFdpZHRoKTsKKyAgICAgICAgd2FpdEZvckV2ZW50T25jZShkb2N1bWVudCwgJ3dlYmtp dGZ1bGxzY3JlZW5jaGFuZ2UnLCBmdW5jdGlvbiAoZXZlbnQpIHsKKyAgICAgICAgICAgIC8vIFRo ZW4gY2hlY2sgdGhhdCBzaXplIGlzIHByb3Blcmx5IHJlc3RvcmVkLgorICAgICAgICAgICAgdGVz dEV4cGVjdGVkKHZpZGVvLmNsaWVudFdpZHRoLCAzMDApOworICAgICAgICAgICAgdGVzdEV4cGVj dGVkKHZpZGVvLmNsaWVudEhlaWdodCwgMTUwKTsKKyAgICAgICAgICAgIGVuZFRlc3QoKTsKKyAg ICAgICAgfSk7CisgICAgICAgIHJ1bldpdGhLZXlEb3duKGZ1bmN0aW9uICgpIHsgZG9jdW1lbnQu d2Via2l0Q2FuY2VsRnVsbFNjcmVlbigpIH0pOworICAgIH0pOworICAgIHJ1bldpdGhLZXlEb3du KGZ1bmN0aW9uKCl7dmlkZW8ud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4oKX0pOworfQorPC9zY3Jp cHQ+CisK 402464 2020-06-22 05:24:53 -0700 2020-06-22 08:20:57 -0700 Patch bug-213110-20200622142451.patch text/plain 6998 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzMjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzU4NmYwYzE2ZjQ0Yzdm NjQzNDdlYjcwMzYzZDIwZjA0NjZmYTIzMy4uMjJiYzQ1MmJkMmQ4YmQ0NGRiNTg1NzI5NmU2YTlk NWFlYjFjZGU0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQxIEBACisyMDIwLTA2LTE4ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIyNjIxMjQpOiBUd2l0dGVyIHZpZGVvcyBnbyBibGFuayBhZnRlciBleGl0aW5nIGZ1bGxz Y3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MzExMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IGZ1bGxzY3JlZW4vdmlkZW8taW5zaWRlLWZsZXgtaXRlbS5odG1sCisKKyAgICAgICAgU2V0 dGluZy91bnNldHRpbmcgcG9zaXRpb246YWJzb2x1dGUgb24gYSBmbGV4L2dyaWQgaXRlbSBjYW4g cG90ZW50aWFsbHkgY3JlYXRlL3JlbW92ZSBmbGV4L2dyaWQgaXRlbXMgYmVjYXVzZQorICAgICAg ICBhYnNvbHV0ZWx5IHBvc2l0aW9uZWQgY2hpbGRyZW4gb2YgdGhvc2UgY29udGFpbmVycyBhcmUg b3V0LW9mLWZsb3cgYW5kIHRodXMsIGRvIG5vdCBnZW5lcmF0ZSBmbGV4L2dyaWQgaXRlbXMuCisg ICAgICAgIEZsZXgvZ3JpZCBpdGVtcyBhcmUgcG90ZW50aWFsbHkgc3RyZXRjaGVkIGJ5IHRoZWly IGNvbnRhaW5lcnMgc28gdGhlIHN0eWxlIHJlY2FsY3VsYXRpb24gaXMgbm90IGVub3VnaCB0byBn ZXQKKyAgICAgICAgYSBjb3JyZWN0IGxheW91dCBiZWNhdXNlIHRoZSBvdmVycmlkZSBzaXplIHNl dCBieSBmbGV4L2dyaWQgY29udGFpbmVycyBpcyBub3QgcmVzZXQuCisgICAgICAgIEluIHRoZSBw YXJ0aWN1bGFyIGNhc2Ugb2YgdGhpcyBidWcgd2UgaGFkIHRoaXMgaGllcmFyY2h5IChoaWdobHkg c2ltcGxpZmllZCBmcm9tIHR3aXR0ZXIgcGFnZSk6CisKKyAgICAgICAgRmxleGJveCBjb250YWlu ZXIKKyAgICAgICAgfF9fX0RJViAoYWJzb2x1dGVsbHkgcG9zaXRpb25lZCkKKyAgICAgICAgICAg IHxfX188dmlkZW8+IChoZWlnaHQ6IDEwMCUgd2lkdGg6IDEwMCUpCisKKyAgICAgICAgV2hlbiB0 aGUgPHZpZGVvPiBnb2VzIGZ1bGxzY3JlZW4gdGhlIEZ1bGxzY3JlZW5NYW5hZ2VyIHJlcGxhY2Vz IHRoZQorICAgICAgICBzdHlsZSBvZiB0aGUgRElWIGJlY2F1c2UgaXQgaW5zZXJ0cyBhIFJlbmRl ckZ1bGxTY3JlZW4gb2JqZWN0IGluIGJldHdlZW4KKyAgICAgICAgdGhlIERJViBhbmQgdGhlIDx2 aWRlbz4gKGFsb25nIHdpdGggc29tZSBhbm9ueW1vdXMgYmxvY2tzKS4gVGhpcyBtZWFucworICAg ICAgICB0aGF0IHRoZSBESVYgd2hpY2ggd2FzIG5vdCBhIGZsZXggaXRlbSAoYXMgaXQgd2FzIGFi c29sdXRlbHkgcG9zaXRpb25lZCkKKyAgICAgICAgYmVjYW1lIGEgZmxleCBpdGVtIGFuZCB0aHVz IGl0cyBzaXplIGlzIHN0cmV0Y2hlZCBhcyB0aGUgZmxleGJveAorICAgICAgICBjb250YWluZXIg bWFuZGF0ZXMuIFdoZW4gZXhpdGluZyBmdWxsc2NyZWVuLCB0aGUgb3JpZ2luYWwgc3R5bGUgaXMK KyAgICAgICAgcmVzdG9yZWQgKGFuZCB0aHVzIHRoZSBwb3NpdGlvbiBhYnNvbHV0ZSkuIFRoZSBE SVYgaXMgdGhlbiBubyBsb25nZXIgYQorICAgICAgICBmbGV4IGl0ZW0gYnV0IHRoZSBzdHJldGNo ZWQgc2l6ZSAob3ZlcnJpZGVDb250ZW50U2l6ZSkgaXMgc3RpbGwgc2V0LAorICAgICAgICBjYXVz aW5nIGlzc3VlcyB3aXRoIHRoZSBzaXplcyBvZiB0aGUgPHZpZGVvPi4KKworICAgICAgICBOb3Rl IHRoYXQgaXQgaXNuJ3QgcG9zc2libGUgdG8gcmVwcm9kdWNlIHRoaXMgYnVnIHdpdGggdGhlIGN1 cnJlbnQgdHJ1bmsgYmVjYXVzZSB0aGVyZSBpcyBhIGJ1ZyBpbiB0aGUgZmxleGJveAorICAgICAg ICBpbXBsZW1lbnRhdGlvbiAoc2VlIGJ1ZyAyMTIyNjQpIHByZXZlbnRpbmcgdGhpcyB0byBoYXBw ZW4uIEhvd2V2ZXIgaXQgYmVjb21lcyAxMDAlIHJlcHJvZHVjaWJsZSB3aXRoIHRoZSBwYXRjaCBm b3IgYnVnIDIxMjI2NAorICAgICAgICB3aGljaCBpcyBjb3JyZWN0IGFuZCBmaXhlcyBzZXZlcmFs IHRlc3RzIHJlbGF0ZWQgdG8gd3JhcHBpbmcgaW4gZmxleGJveC4gSXQncyBhbHNvIHJlcHJvZHVj aWJsZSB3aGVuIHRoZSBGVUxMU0NSRUVOX0FQSSBpcworICAgICAgICBlbmFibGVkLCBvdGhlcndp c2UgdGhlIGNvZGVwYXRoIGZvciBmdWxsIHNjcmVlbiBpcyB0b3RhbGx5IGRpZmZlcmVudCAodGhl cmUgYXJlIG5vIHBsYWNlaG9sZGVycykuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6c3R5bGVEaWRDaGFuZ2UpOiBjbGVh ciB0aGUgb3ZlcnJpZGUgc2l6ZXMgZm9yIGdyaWQvZmxleCB3aGVuIGZsZXgvZ3JpZCBpdGVtcyBi ZWNvbWUgb3V0LW9mLWZsb3csCisgICAgICAgIGZvciBleGFtcGxlIGJ5IGNoYW5naW5nIHBvc2l0 aW9uIHRvIGFic29sdXRlLgorCiAyMDIwLTA2LTEwICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3Zp bGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2MjI1ND8pOiBbV1BFXSBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYnhyL2lkbGhhcm5lc3MuaHR0cHMud2lu ZG93Lmh0bWwgaXMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApp bmRleCA3OWIxMjhiYTZlZWM2ZDc0Y2NiNzQwYzhhZDAxN2JlNmNkNDllMGZlLi4wMzM3YzAwYzY3 NTUwNzVhOGRkMWI0MWVhOTBhODFmZmQ3OWI1Mzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcApAQCAtNDA1LDYgKzQwNSwxMiBAQCB2b2lkIFJlbmRlckJveDo6c3R5bGVE aWRDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHls ZQogICAgIGlmICgob2xkU3R5bGUgJiYgb2xkU3R5bGUtPnNoYXBlT3V0c2lkZSgpKSB8fCBzdHls ZSgpLnNoYXBlT3V0c2lkZSgpKQogICAgICAgICB1cGRhdGVTaGFwZU91dHNpZGVJbmZvQWZ0ZXJT dHlsZUNoYW5nZShzdHlsZSgpLCBvbGRTdHlsZSk7CiAgICAgdXBkYXRlR3JpZFBvc2l0aW9uQWZ0 ZXJTdHlsZUNoYW5nZShzdHlsZSgpLCBvbGRTdHlsZSk7CisKKyAgICAvLyBDaGFuZ2luZyB0aGUg cG9zaXRpb24gZnJvbS90byBhYnNvbHV0ZSBjYW4gcG90ZW50aWFsbHkgY3JlYXRlL3JlbW92ZSBm bGV4L2dyaWQgaXRlbXMsIGFzIGFic29sdXRlbHkgcG9zaXRpb25lZAorICAgIC8vIGNoaWxkcmVu IG9mIGEgZmxleC9ncmlkIGJveCBhcmUgb3V0LW9mLWZsb3csIGFuZCB0aHVzLCBub3QgZmxleC9n cmlkIGl0ZW1zLiBUaGlzIG1lYW5zIHRoYXQgd2UgbmVlZCB0byBjbGVhcgorICAgIC8vIGFueSBv dmVycmlkZSBjb250ZW50IHNpemUgc2V0IGJ5IG91ciBjb250YWluZXIsIGJlY2F1c2UgaXQgd291 bGQgbGlrZWx5IGJlIGluY29ycmVjdCBhZnRlciB0aGUgc3R5bGUgY2hhbmdlLgorICAgIGlmIChp c091dE9mRmxvd1Bvc2l0aW9uZWQoKSAmJiBwYXJlbnQoKSAmJiBwYXJlbnQoKS0+c3R5bGUoKS5p c0Rpc3BsYXlGbGV4aWJsZU9yR3JpZEJveCgpKQorICAgICAgICBjbGVhck92ZXJyaWRlQ29udGVu dFNpemUoKTsKIH0KIAogdm9pZCBSZW5kZXJCb3g6OnVwZGF0ZUdyaWRQb3NpdGlvbkFmdGVyU3R5 bGVDaGFuZ2UoY29uc3QgUmVuZGVyU3R5bGUmIHN0eWxlLCBjb25zdCBSZW5kZXJTdHlsZSogb2xk U3R5bGUpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggYjNjMjY4NjhiODk0MWE4YTBjYTIzMDFjZTMxNTFhZjA2YTI3MmM3My4u NjY3NzEyNjQ5ZDdkM2I3YWRkMDY4NTk2ZGY2OGRkNGVlMTE5MDM4YSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDIwLTA2LTE4ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEu Y29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNjIxMjQpOiBUd2l0dGVyIHZpZGVvcyBnbyBi bGFuayBhZnRlciBleGl0aW5nIGZ1bGxzY3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzExMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZnVsbHNjcmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVt LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZnVsbHNjcmVlbi92aWRlby1pbnNpZGUt ZmxleC1pdGVtLmh0bWw6IEFkZGVkLgorCiAyMDIwLTA2LTEwICBTZXJnaW8gVmlsbGFyIFNlbmlu ICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2MjI1ND8pOiBb V1BFXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYnhyL2lkbGhhcm5lc3MuaHR0 cHMud2luZG93Lmh0bWwgaXMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNj cmVlbi92aWRlby1pbnNpZGUtZmxleC1pdGVtLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Z1 bGxzY3JlZW4vdmlkZW8taW5zaWRlLWZsZXgtaXRlbS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u MzNhNWI4NDlhM2ZlMzI4MThhZDU2MjkxYzI2YmU1ZGZjNmQxYTJlYQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8taW5zaWRlLWZsZXgtaXRlbS1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSw4IEBACisKK0VWRU5UKHdlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UpCitF WFBFQ1RFRCAoODAwID09ICc4MDAnKSBPSworRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNoYW5nZSkK K0VYUEVDVEVEICgzMDAgPT0gJzMwMCcpIE9LCitFWFBFQ1RFRCAoMTUwID09ICcxNTAnKSBPSwor RU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1p bnNpZGUtZmxleC1pdGVtLmh0bWwgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLWluc2lk ZS1mbGV4LWl0ZW0uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kOTExNGIxMTU2YmZjN2QyOTJkY2NmMDI1YWE5 OWJiMzgzYmNhNTUwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92 aWRlby1pbnNpZGUtZmxleC1pdGVtLmh0bWwKQEAgLTAsMCArMSw0NSBAQAorPCFET0NUWVBFIGh0 bWw+Cis8c3R5bGU+Citib2R5IHsKKyAgICBtYXJnaW46IDBweDsKK30KKy5wZXJjZW50MTAwIHsK KyAgICB3aWR0aDogMTAwJTsKKyAgICBoZWlnaHQ6IDEwMCU7Cit9Cis8L3N0eWxlPgorPHNjcmlw dCBzcmM9ImZ1bGwtc2NyZWVuLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Li4vbWVk aWEvbWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KKworPGRpdiBzdHlsZT0iZGlzcGxheTogZmxleDsg ZmxleC1kaXJlY3Rpb246IGNvbHVtbjsiPgorICAgIDxkaXYgc3R5bGU9InBvc2l0aW9uOiBhYnNv bHV0ZTsgYmFja2dyb3VuZDogZ3JlZW47Ij4KKyAgICAgICAgPHZpZGVvIGlkPSJ2aWRlbyIgY2xh c3M9InBlcmNlbnQxMDAiIGNvbnRyb2xzPjwvdmlkZW8+CisgICAgPC9kaXY+Cis8L2Rpdj4KKwor PHNjcmlwdD4KK3NldFNyY0J5SWQoInZpZGVvIiwgZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiLi4v bWVkaWEvY29udGVudC90ZXN0IikpOwordmFyIHZpZGVvID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3ZpZGVvJyk7CisvLyBCYWlsIG91dCBlYXJseSBpZiB0aGUgZnVsbCBzY3JlZW4gQVBJIGlz IG5vdCBlbmFibGVkIG9yIGlzIG1pc3Npbmc6CitpZiAoRWxlbWVudC5wcm90b3R5cGUud2Via2l0 UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5kZWZpbmVkKSB7CisgICAgbG9nUmVzdWx0KGZhbHNlLCAi RWxlbWVudC5wcm90b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0gdW5kZWZpbmVkIik7 CisgICAgZW5kVGVzdCgpOworfSBlbHNlIHsKKyAgICB3YWl0Rm9yRXZlbnRPbmNlKGRvY3VtZW50 LCAnd2Via2l0ZnVsbHNjcmVlbmNoYW5nZScsIGZ1bmN0aW9uKCkgeworICAgICAgICAvLyBGaXJz dCBjaGVjayB0aGF0IHRoZSB2aWRlbyB3ZW50IGZ1bGxzY3JlZW4uCisgICAgICAgIHRlc3RFeHBl Y3RlZCh2aWRlby5jbGllbnRXaWR0aCwgZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aCk7CisgICAg ICAgIHdhaXRGb3JFdmVudE9uY2UoZG9jdW1lbnQsICd3ZWJraXRmdWxsc2NyZWVuY2hhbmdlJywg ZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAvLyBUaGVuIGNoZWNrIHRoYXQgdGhlIG9yaWdpbmFs IHZpZGVvIHNpemUgaXMgcHJvcGVybHkgcmVzdG9yZWQuCisgICAgICAgICAgICB0ZXN0RXhwZWN0 ZWQodmlkZW8uY2xpZW50V2lkdGgsIDMwMCk7CisgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQodmlk ZW8uY2xpZW50SGVpZ2h0LCAxNTApOworICAgICAgICAgICAgZW5kVGVzdCgpOworICAgICAgICB9 KTsKKyAgICAgICAgZG9jdW1lbnQud2Via2l0Q2FuY2VsRnVsbFNjcmVlbigpOworICAgIH0pOwor CisgICAgcnVuV2l0aEtleURvd24oZnVuY3Rpb24oKSB7CisgICAgICAgIHZpZGVvLndlYmtpdFJl cXVlc3RGdWxsU2NyZWVuKCk7CisgICAgfSk7Cit9Cis8L3NjcmlwdD4KKwo=