213082 2020-06-11 09:23:22 -0700 [iOS] editing/selection/ios/update-selection-after-overflow-scroll.html times out 2020-06-11 10:57:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin megan_gardner thorton webkit-bug-importer oldest_to_newest 1661615 0 wenson_hsieh 2020-06-11 09:23:22 -0700 <rdar://problem/64228007> 1661621 1 401655 wenson_hsieh 2020-06-11 09:31:02 -0700 Created attachment 401655 Patch 1661624 2 megan_gardner 2020-06-11 09:52:34 -0700 Is there a way you can programmatically find a point that will always be ok, even if more things change in the future? I want to suggest making another line a target and clicking the the middle of that, but there's no guarantee that the callout bar won't appear over that area. 1661625 3 wenson_hsieh 2020-06-11 09:58:16 -0700 (In reply to Megan Gardner from comment #2) > Is there a way you can programmatically find a point that will always be ok, > even if more things change in the future? I want to suggest making another > line a target and clicking the the middle of that, but there's no guarantee > that the callout bar won't appear over that area. I’m not sure what you mean by “making another line a target”. If the callout bar does appear over (40, 40), then I think that would indicate a Real Bug™. 1661627 4 401655 megan_gardner 2020-06-11 10:09:00 -0700 Comment on attachment 401655 Patch I mean something like: <p id='scroll-target'>The quick brown fox jumped over the lazy dog.</p> and var scrollTargetRect = document.getElementById('scroll-target').getBoundingClientRect(); await UIHelper.UIHelper.immediateScrollElementAtContentPointToOffset(scrollTargetRect.x,scrollTargetRect.y); // or do the center of the line if that makes more sense instead of hardcoding numbers that might need to be changed. 1661629 5 wenson_hsieh 2020-06-11 10:12:25 -0700 (In reply to Megan Gardner from comment #4) > Comment on attachment 401655 [details] > Patch > > I mean something like: > <p id='scroll-target'>The quick brown fox jumped over the lazy dog.</p> > and > var scrollTargetRect = > document.getElementById('scroll-target').getBoundingClientRect(); > await > UIHelper.UIHelper. > immediateScrollElementAtContentPointToOffset(scrollTargetRect.x, > scrollTargetRect.y); // or do the center of the line if that makes more sense > > instead of hardcoding numbers that might need to be changed. I designed the test so that the scrollable editor area’s origin is always at (0, 0) in the document, so I chose (40, 40) to mean “an offset slightly away from the top left corner of the scrollable area“. I could use the bounding rect top/left, but I don’t think it adds much here. 1661632 6 401658 wenson_hsieh 2020-06-11 10:21:23 -0700 Created attachment 401658 Patch 1661635 7 megan_gardner 2020-06-11 10:30:57 -0700 Ok, I'm sold enough then. 1661636 8 401658 wenson_hsieh 2020-06-11 10:31:41 -0700 Comment on attachment 401658 Patch Thanks for the review! 1661643 9 ews-feeder 2020-06-11 10:57:18 -0700 Committed r262910: <https://trac.webkit.org/changeset/262910> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401658. 401655 2020-06-11 09:31:02 -0700 2020-06-11 10:21:22 -0700 Patch bug-213082-20200611093101.patch text/plain 2300 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyODkxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWVmNzhlNjJlNzU5YmIzNDQ1NmYx NDFkMDE5Yjc1YmQ5MWVlNWI3Zi4uZGZlN2IwMTM4OThkZjc5ZTM4NmU2OThmOWI1ZDMxMTUyYjhm ZWRlMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA2LTExICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGVkaXRpbmcvc2VsZWN0aW9u L2lvcy91cGRhdGUtc2VsZWN0aW9uLWFmdGVyLW92ZXJmbG93LXNjcm9sbC5odG1sIHRpbWVzIG91 dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMDgy CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NDIyODAwNz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3QgbWFrZXMgYSBwcm9ncmFtbWF0 aWMgc2VsZWN0aW9uLCBhbmQgdGhlbiBzY3JvbGxzIGFuIG92ZXJmbG93IGFyZWEgd2l0aCBhY2Nl bGVyYXRlZCBzY3JvbGxpbmcgYnkgdXNpbmcKKyAgICAgICAgYFVJSGVscGVyLmltbWVkaWF0ZVNj cm9sbEVsZW1lbnRBdENvbnRlbnRQb2ludFRvT2Zmc2V0KClgLiBUaGlzIGhlbHBlciBtZXRob2Qg aGl0LXRlc3RzIGZvciBhIHN1YnNjcm9sbGFibGUKKyAgICAgICAgcmVnaW9uLCBhbmQgdGhlbiB1 c2VzIHBsYXRmb3JtIEFQSSB0byBjaGFuZ2UgdGhlIGNvbnRlbnQgb2Zmc2V0LiBIb3dldmVyLCBh ZnRlciB0aW1pbmcgY2hhbmdlcyBpbiB0aGUgc3lzdGVtLAorICAgICAgICB0aGlzIGhpdC10ZXN0 aW5nIG5vdyBmYWlscyBiZWNhdXNlIGl0IGVuZHMgdXAgZmluZGluZyB0aGUgY2FsbG91dCBtZW51 IHRoYXQgc2hvd3MgdXAgYWZ0ZXIgbWFraW5nIHRoZSB0ZXh0CisgICAgICAgIHNlbGVjdGlvbiwg YW5kIHNvIHNjcm9sbGluZyBmYWlscy4KKworICAgICAgICBGaXggdGhpcyBieSB1c2luZyAoNDAs IDQwKSBpbnN0ZWFkIG9mICgxNTAsIDEwMCkgd2hlbiBoaXQtdGVzdGluZyB0aGUgY2hpbGQgc2Ny b2xsIHZpZXcgd2hlbiBzY3JvbGxpbmcuCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9p b3MvdXBkYXRlLXNlbGVjdGlvbi1hZnRlci1vdmVyZmxvdy1zY3JvbGwuaHRtbDoKKwogMjAyMC0w Ni0xMCAgSGlybyAobXpwKSBNaXp1bm8gIDxtenBAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1Nd IE9wdGlvbiArIEZvcndhcmQgRGVsZXRlIHNob3VsZCBkZWxldGUgbmV4dCB3b3JkCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvdXBkYXRlLXNlbGVjdGlvbi1h ZnRlci1vdmVyZmxvdy1zY3JvbGwuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9u L2lvcy91cGRhdGUtc2VsZWN0aW9uLWFmdGVyLW92ZXJmbG93LXNjcm9sbC5odG1sCmluZGV4IDQx YmY5MzE0OTBjYzE2NGEzNjExMjE4ODkwMjdkOGZkNDFkZTFmNjUuLjNiZmY0Mjk0Njc4YWQxNTgz YThiYzhhZDBlOGMxN2E5MmU1NGFhNzMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2VkaXRpbmcv c2VsZWN0aW9uL2lvcy91cGRhdGUtc2VsZWN0aW9uLWFmdGVyLW92ZXJmbG93LXNjcm9sbC5odG1s CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lvcy91cGRhdGUtc2VsZWN0aW9u LWFmdGVyLW92ZXJmbG93LXNjcm9sbC5odG1sCkBAIC02Myw3ICs2Myw3IEBAIGFkZEV2ZW50TGlz dGVuZXIoImxvYWQiLCBhc3luYyBmdW5jdGlvbigpIHsKICAgICBhd2FpdCBVSUhlbHBlci5hY3Rp dmF0ZUVsZW1lbnRBbmRXYWl0Rm9ySW5wdXRTZXNzaW9uKGJ1dHRvbik7CiAgICAgc2VsZWN0aW9u UmVjdHNCZWZvcmUgPSBhd2FpdCB3YWl0Rm9yU2VsZWN0aW9uUmVjdHNUb0NoYW5nZShbXSk7CiAK LSAgICBhd2FpdCBVSUhlbHBlci5pbW1lZGlhdGVTY3JvbGxFbGVtZW50QXRDb250ZW50UG9pbnRU b09mZnNldCgxNTAsIDEwMCwgMCwgNTApOworICAgIGF3YWl0IFVJSGVscGVyLmltbWVkaWF0ZVNj cm9sbEVsZW1lbnRBdENvbnRlbnRQb2ludFRvT2Zmc2V0KDQwLCA0MCwgMCwgNTApOwogICAgIHNl bGVjdGlvblJlY3RzQWZ0ZXIgPSBhd2FpdCB3YWl0Rm9yU2VsZWN0aW9uUmVjdHNUb0NoYW5nZShz ZWxlY3Rpb25SZWN0c0JlZm9yZSk7CiAKICAgICBzaG91bGRCZSgic2VsZWN0aW9uUmVjdHNCZWZv cmVbMF0udG9wIiwgIjEwOSIpOwo= 401658 2020-06-11 10:21:23 -0700 2020-06-11 10:57:18 -0700 Patch bug-213082-20200611102122.patch text/plain 2373 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyODkxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWVmNzhlNjJlNzU5YmIzNDQ1NmYx NDFkMDE5Yjc1YmQ5MWVlNWI3Zi4uZGZlN2IwMTM4OThkZjc5ZTM4NmU2OThmOWI1ZDMxMTUyYjhm ZWRlMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA2LTExICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGVkaXRpbmcvc2VsZWN0aW9u L2lvcy91cGRhdGUtc2VsZWN0aW9uLWFmdGVyLW92ZXJmbG93LXNjcm9sbC5odG1sIHRpbWVzIG91 dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMDgy CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NDIyODAwNz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3QgbWFrZXMgYSBwcm9ncmFtbWF0 aWMgc2VsZWN0aW9uLCBhbmQgdGhlbiBzY3JvbGxzIGFuIG92ZXJmbG93IGFyZWEgd2l0aCBhY2Nl bGVyYXRlZCBzY3JvbGxpbmcgYnkgdXNpbmcKKyAgICAgICAgYFVJSGVscGVyLmltbWVkaWF0ZVNj cm9sbEVsZW1lbnRBdENvbnRlbnRQb2ludFRvT2Zmc2V0KClgLiBUaGlzIGhlbHBlciBtZXRob2Qg aGl0LXRlc3RzIGZvciBhIHN1YnNjcm9sbGFibGUKKyAgICAgICAgcmVnaW9uLCBhbmQgdGhlbiB1 c2VzIHBsYXRmb3JtIEFQSSB0byBjaGFuZ2UgdGhlIGNvbnRlbnQgb2Zmc2V0LiBIb3dldmVyLCBh ZnRlciB0aW1pbmcgY2hhbmdlcyBpbiB0aGUgc3lzdGVtLAorICAgICAgICB0aGlzIGhpdC10ZXN0 aW5nIG5vdyBmYWlscyBiZWNhdXNlIGl0IGVuZHMgdXAgZmluZGluZyB0aGUgY2FsbG91dCBtZW51 IHRoYXQgc2hvd3MgdXAgYWZ0ZXIgbWFraW5nIHRoZSB0ZXh0CisgICAgICAgIHNlbGVjdGlvbiwg YW5kIHNvIHNjcm9sbGluZyBmYWlscy4KKworICAgICAgICBGaXggdGhpcyBieSB1c2luZyAoNDAs IDQwKSBpbnN0ZWFkIG9mICgxNTAsIDEwMCkgd2hlbiBoaXQtdGVzdGluZyB0aGUgY2hpbGQgc2Ny b2xsIHZpZXcgd2hlbiBzY3JvbGxpbmcuCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9p b3MvdXBkYXRlLXNlbGVjdGlvbi1hZnRlci1vdmVyZmxvdy1zY3JvbGwuaHRtbDoKKwogMjAyMC0w Ni0xMCAgSGlybyAobXpwKSBNaXp1bm8gIDxtenBAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1Nd IE9wdGlvbiArIEZvcndhcmQgRGVsZXRlIHNob3VsZCBkZWxldGUgbmV4dCB3b3JkCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3MvdXBkYXRlLXNlbGVjdGlvbi1h ZnRlci1vdmVyZmxvdy1zY3JvbGwuaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9u L2lvcy91cGRhdGUtc2VsZWN0aW9uLWFmdGVyLW92ZXJmbG93LXNjcm9sbC5odG1sCmluZGV4IDQx YmY5MzE0OTBjYzE2NGEzNjExMjE4ODkwMjdkOGZkNDFkZTFmNjUuLjBmMmE1Njg4YjRmMDczN2E2 Zjk0MDE4MTIyMzAwZDExNDU4ZGJhNmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2VkaXRpbmcv c2VsZWN0aW9uL2lvcy91cGRhdGUtc2VsZWN0aW9uLWFmdGVyLW92ZXJmbG93LXNjcm9sbC5odG1s CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lvcy91cGRhdGUtc2VsZWN0aW9u LWFmdGVyLW92ZXJmbG93LXNjcm9sbC5odG1sCkBAIC02Myw3ICs2Myw4IEBAIGFkZEV2ZW50TGlz dGVuZXIoImxvYWQiLCBhc3luYyBmdW5jdGlvbigpIHsKICAgICBhd2FpdCBVSUhlbHBlci5hY3Rp dmF0ZUVsZW1lbnRBbmRXYWl0Rm9ySW5wdXRTZXNzaW9uKGJ1dHRvbik7CiAgICAgc2VsZWN0aW9u UmVjdHNCZWZvcmUgPSBhd2FpdCB3YWl0Rm9yU2VsZWN0aW9uUmVjdHNUb0NoYW5nZShbXSk7CiAK LSAgICBhd2FpdCBVSUhlbHBlci5pbW1lZGlhdGVTY3JvbGxFbGVtZW50QXRDb250ZW50UG9pbnRU b09mZnNldCgxNTAsIDEwMCwgMCwgNTApOworICAgIGNvbnN0IHJlY3QgPSBlZGl0b3IuZ2V0Qm91 bmRpbmdDbGllbnRSZWN0KCk7CisgICAgYXdhaXQgVUlIZWxwZXIuaW1tZWRpYXRlU2Nyb2xsRWxl bWVudEF0Q29udGVudFBvaW50VG9PZmZzZXQocmVjdC5sZWZ0ICsgNDAsIHJlY3QudG9wICsgNDAs IDAsIDUwKTsKICAgICBzZWxlY3Rpb25SZWN0c0FmdGVyID0gYXdhaXQgd2FpdEZvclNlbGVjdGlv blJlY3RzVG9DaGFuZ2Uoc2VsZWN0aW9uUmVjdHNCZWZvcmUpOwogCiAgICAgc2hvdWxkQmUoInNl bGVjdGlvblJlY3RzQmVmb3JlWzBdLnRvcCIsICIxMDkiKTsK