213076 2020-06-11 08:03:55 -0700 WebKit: Guard requestDocumentContext with HAVE(UI_WK_DOCUMENT_CONTEXT) 2020-06-11 12:42:04 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212718 InRadar P2 Normal --- 1 jbedard jbedard aestes ap dbates thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1661582 0 jbedard 2020-06-11 08:03:55 -0700 HAVE(UI_WK_DOCUMENT_CONTEXT) is only available on iOS and MacCaatalyst, watchOS and tvOS cannot retrieve document contexts. 1661583 1 webkit-bug-importer 2020-06-11 08:05:22 -0700 <rdar://problem/64254698> 1661584 2 401645 jbedard 2020-06-11 08:10:01 -0700 Created attachment 401645 Patch 1661586 3 jbedard 2020-06-11 08:11:45 -0700 I'm not totally certain about this change, but it strikes me as wrong that requestDocumentContext is used when HAVE(UI_WK_DOCUMENT_CONTEXT) is false. 1661637 4 401645 thorton 2020-06-11 10:46:35 -0700 Comment on attachment 401645 Patch Seems fine to me. 1661700 5 ews-feeder 2020-06-11 12:42:03 -0700 Committed r262917: <https://trac.webkit.org/changeset/262917> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401645. 401645 2020-06-11 08:10:01 -0700 2020-06-11 12:42:03 -0700 Patch bug-213076-20200611081000.patch text/plain 3251 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjI5MDIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA2LTExICBKb25hdGhhbiBC ZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXQ6IEd1YXJkIHJlcXVl c3REb2N1bWVudENvbnRleHQgd2l0aCBIQVZFKFVJX1dLX0RPQ1VNRU5UX0NPTlRFWFQpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTMwNzYKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzY0MjU0Njk4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVoYXZpb3IgdW5jaGFuZ2VkLgor CisgICAgICAgICogUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oOgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvaW9zL1dLV2ViVmlld1Rlc3RpbmdJT1MubW06CisgICAgICAgICgtW1dLV2ViVmll dyBfcmVxdWVzdERvY3VtZW50Q29udGV4dDpjb21wbGV0aW9uSGFuZGxlcjpdKTogR3VhcmQgcmVx dWVzdERvY3VtZW50Q29udGV4dCB3aXRoIEhBVkUoVUlfV0tfRE9DVU1FTlRfQ09OVEVYVCkuCisg ICAgICAgICgtW1dLV2ViVmlldyBfYWRqdXN0U2VsZWN0aW9uV2l0aERlbHRhOmNvbXBsZXRpb25I YW5kbGVyOl0pOiBEaXR0by4KKwogMjAyMC0wNi0xMSAgQ2hhbmdTZW9rIE9oICA8Y2hhbmdzZW9r QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0dUS10gSW1wbGVtZW50IGJ1dHRvbi1wcmVzcy1ldmVu dCwgYnV0dG9uLXJlbGVhc2UtZXZlbnQsIGFuZCBhYnNvbHV0ZS1heGlzLWV2ZW50IG9mIEdBTUVQ QUQgQVBJLgpJbmRleDogU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgJ KHJldmlzaW9uIDI2MjkwMSkKKysrIFNvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtp dFNQSS5oCSh3b3JraW5nIGNvcHkpCkBAIC02OTMsOSArNjkzLDEyIEBAIHR5cGVkZWYgTlNfRU5V TShOU0ludGVnZXIsIFVJV0tHZXN0dXJlVHkKIEBjbGFzcyBVSVdLRG9jdW1lbnRDb250ZXh0Owog CiBAcHJvdG9jb2wgVUlXS0ludGVyYWN0aW9uVmlld1Byb3RvY29sCisjaWYgSEFWRShVSV9XS19E T0NVTUVOVF9DT05URVhUKQogLSAodm9pZClhZGp1c3RTZWxlY3Rpb25XaXRoRGVsdGE6KE5TUmFu Z2UpZGVsdGFSYW5nZSBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikodm9pZCkpY29tcGxldGlv bkhhbmRsZXI7CiAtICh2b2lkKXJlcXVlc3REb2N1bWVudENvbnRleHQ6KFVJV0tEb2N1bWVudFJl cXVlc3QgKilyZXF1ZXN0IGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShVSVdLRG9jdW1lbnRD b250ZXh0ICopKWNvbXBsZXRpb25IYW5kbGVyOwogLSAodm9pZClzZWxlY3RQb3NpdGlvbkF0UG9p bnQ6KENHUG9pbnQpcG9pbnQgd2l0aENvbnRleHRSZXF1ZXN0OihVSVdLRG9jdW1lbnRSZXF1ZXN0 ICopcmVxdWVzdCBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoVUlXS0RvY3VtZW50Q29udGV4 dCAqKSljb21wbGV0aW9uSGFuZGxlcjsKKyNlbmRpZgorCiAtICh2b2lkKWNoYW5nZVNlbGVjdGlv bldpdGhHZXN0dXJlQXQ6KENHUG9pbnQpcG9pbnQgd2l0aEdlc3R1cmU6KFVJV0tHZXN0dXJlVHlw ZSlnZXN0dXJlVHlwZSB3aXRoU3RhdGU6KFVJR2VzdHVyZVJlY29nbml6ZXJTdGF0ZSlzdGF0ZTsK IC0gKHZvaWQpY2hhbmdlU2VsZWN0aW9uV2l0aFRvdWNoQXQ6KENHUG9pbnQpcG9pbnQgd2l0aFNl bGVjdGlvblRvdWNoOihVSVdLU2VsZWN0aW9uVG91Y2gpdG91Y2ggYmFzZUlzU3RhcnQ6KEJPT0wp YmFzZUlzU3RhcnQgd2l0aEZsYWdzOihVSVdLU2VsZWN0aW9uRmxhZ3MpZmxhZ3M7CiAtICh2b2lk KWNoYW5nZVNlbGVjdGlvbldpdGhUb3VjaGVzRnJvbTooQ0dQb2ludClmcm9tIHRvOihDR1BvaW50 KXRvIHdpdGhHZXN0dXJlOihVSVdLR2VzdHVyZVR5cGUpZ2VzdHVyZVR5cGUgd2l0aFN0YXRlOihV SUdlc3R1cmVSZWNvZ25pemVyU3RhdGUpZ2VzdHVyZVN0YXRlOwpJbmRleDogU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL2lvcy9XS1dlYlZpZXdUZXN0aW5nSU9TLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9pb3MvV0tXZWJWaWV3VGVzdGluZ0lPUy5tbQko cmV2aXNpb24gMjYyOTAxKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2lvcy9XS1dl YlZpZXdUZXN0aW5nSU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC04MCwxMiArODAsMjAgQEAgLSAo dm9pZClfZGlkRmluaXNoVGV4dEludGVyYWN0aW9uSW5UZXh0SQogCiAtICh2b2lkKV9yZXF1ZXN0 RG9jdW1lbnRDb250ZXh0OihVSVdLRG9jdW1lbnRSZXF1ZXN0ICopcmVxdWVzdCBjb21wbGV0aW9u SGFuZGxlcjoodm9pZCAoXikoVUlXS0RvY3VtZW50Q29udGV4dCAqKSljb21wbGV0aW9uSGFuZGxl cgogeworI2lmIEhBVkUoVUlfV0tfRE9DVU1FTlRfQ09OVEVYVCkKICAgICBbX2NvbnRlbnRWaWV3 IHJlcXVlc3REb2N1bWVudENvbnRleHQ6cmVxdWVzdCBjb21wbGV0aW9uSGFuZGxlcjpjb21wbGV0 aW9uSGFuZGxlcl07CisjZWxzZQorICAgIGNvbXBsZXRpb25IYW5kbGVyKG5pbCk7CisjZW5kaWYK IH0KIAogLSAodm9pZClfYWRqdXN0U2VsZWN0aW9uV2l0aERlbHRhOihOU1JhbmdlKWRlbHRhUmFu Z2UgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKHZvaWQpKWNvbXBsZXRpb25IYW5kbGVyCiB7 CisjaWYgSEFWRShVSV9XS19ET0NVTUVOVF9DT05URVhUKQogICAgIFtfY29udGVudFZpZXcgYWRq dXN0U2VsZWN0aW9uV2l0aERlbHRhOmRlbHRhUmFuZ2UgY29tcGxldGlvbkhhbmRsZXI6Y29tcGxl dGlvbkhhbmRsZXJdOworI2Vsc2UKKyAgICBjb21wbGV0aW9uSGFuZGxlcigpOworI2VuZGlmCiB9 CiAKIC0gKEJPT0wpX21heUNvbnRhaW5FZGl0YWJsZUVsZW1lbnRzSW5SZWN0OihDR1JlY3QpcmVj dAo=