213050 2020-06-10 14:47:06 -0700 [Cocoa] Return early from preference change notification handler if there is no observer 2020-06-10 15:35:33 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham darin webkit-bug-importer oldest_to_newest 1661368 0 pvollan 2020-06-10 14:47:06 -0700 Currently, the observer member is checked inside the loop iterating over all the keys, but this check should be moved outside of the loop. 1661371 1 401586 pvollan 2020-06-10 14:49:03 -0700 Created attachment 401586 Patch 1661378 2 401586 pvollan 2020-06-10 15:02:39 -0700 Comment on attachment 401586 Patch Thanks for reviewing! 1661398 3 ews-feeder 2020-06-10 15:34:39 -0700 Committed r262865: <https://trac.webkit.org/changeset/262865> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401586. 1661400 4 webkit-bug-importer 2020-06-10 15:35:33 -0700 <rdar://problem/64227791> 401586 2020-06-10 14:49:03 -0700 2020-06-10 15:34:39 -0700 Patch bug-213050-20200610144902.patch text/plain 2041 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjI4NjIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA2LTEwICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIFJldHVybiBlYXJs eSBmcm9tIHByZWZlcmVuY2UgY2hhbmdlIG5vdGlmaWNhdGlvbiBoYW5kbGVyIGlmIHRoZXJlIGlz IG5vIG9ic2VydmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTMwNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDdXJyZW50bHksIHRoZSBvYnNlcnZlciBtZW1iZXIgaXMgY2hlY2tlZCBpbnNpZGUgdGhl IGxvb3AgaXRlcmF0aW5nIG92ZXIgYWxsIHRoZSBrZXlzLAorICAgICAgICBidXQgdGhpcyBjaGVj ayBzaG91bGQgYmUgbW92ZWQgb3V0c2lkZSBvZiB0aGUgbG9vcC4KKworICAgICAgICBObyBuZXcg dGVzdHMsIHNpbmNlIHRoaXMgaXMgbm90IGEgY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAg ICogVUlQcm9jZXNzL0NvY29hL1ByZWZlcmVuY2VPYnNlcnZlci5tbToKKyAgICAgICAgKC1bV0tV c2VyRGVmYXVsdHMgX25vdGlmeU9ic2VydmVyc09mQ2hhbmdlRnJvbVZhbHVlc0ZvcktleXM6dG9W YWx1ZXNGb3JLZXlzOl0pOgorCiAyMDIwLTA2LTEwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJk QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXQ6IEFkZCBDbG9ja0tpdFNQSS5oCkluZGV4OiBT b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9QcmVmZXJlbmNlT2JzZXJ2ZXIubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvUHJlZmVyZW5jZU9ic2VydmVy Lm1tCShyZXZpc2lvbiAyNjI3MjkpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9Q cmVmZXJlbmNlT2JzZXJ2ZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ5LDYgKzQ5LDkgQEAgLSAo dm9pZClfbm90aWZ5T2JzZXJ2ZXJzT2ZDaGFuZ2VGcm9tVmFsdQogewogICAgIFtzdXBlciBfbm90 aWZ5T2JzZXJ2ZXJzT2ZDaGFuZ2VGcm9tVmFsdWVzRm9yS2V5czpvbGRWYWx1ZXMgdG9WYWx1ZXNG b3JLZXlzOm5ld1ZhbHVlc107CiAKKyAgICBpZiAoIW1fb2JzZXJ2ZXIpCisgICAgICAgIHJldHVy bjsKKwogICAgIGZvciAoTlNTdHJpbmcgKmtleSBpbiBvbGRWYWx1ZXMpIHsKICAgICAgICAgaWQg b2xkVmFsdWUgPSBvbGRWYWx1ZXNba2V5XTsKICAgICAgICAgaWQgbmV3VmFsdWUgPSBuZXdWYWx1 ZXNba2V5XTsKQEAgLTY4LDkgKzcxLDYgQEAgLSAodm9pZClfbm90aWZ5T2JzZXJ2ZXJzT2ZDaGFu Z2VGcm9tVmFsdQogICAgICAgICAgICAgZW5jb2RlZFN0cmluZyA9IFtkYXRhIGJhc2U2NEVuY29k ZWRTdHJpbmdXaXRoT3B0aW9uczowXTsKICAgICAgICAgfQogCi0gICAgICAgIGlmICghbV9vYnNl cnZlcikKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgCiAgICAgICAgIGF1dG8gZ2xvYmFs VmFsdWUgPSBhZG9wdENGKENGUHJlZmVyZW5jZXNDb3B5VmFsdWUoKF9fYnJpZGdlIENGU3RyaW5n UmVmKWtleSwga0NGUHJlZmVyZW5jZXNBbnlBcHBsaWNhdGlvbiwga0NGUHJlZmVyZW5jZXNDdXJy ZW50VXNlciwga0NGUHJlZmVyZW5jZXNBbnlIb3N0KSk7CiAgICAgICAgIGF1dG8gZG9tYWluVmFs dWUgPSBhZG9wdENGKENGUHJlZmVyZW5jZXNDb3B5VmFsdWUoKF9fYnJpZGdlIENGU3RyaW5nUmVm KWtleSwgKF9fYnJpZGdlIENGU3RyaW5nUmVmKW1fc3VpdGVOYW1lLCBrQ0ZQcmVmZXJlbmNlc0N1 cnJlbnRVc2VyLCBrQ0ZQcmVmZXJlbmNlc0FueUhvc3QpKTsKICAgICAgICAgCg==