213038 2020-06-10 11:36:23 -0700 WebKit: Make UIGestureRecognizer build for watchOS and tvOS 2020-06-11 14:02:57 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212718 InRadar P2 Normal --- 1 jbedard jbedard benjamin cdumez cmarcelo darin ews-watchlist thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1661253 0 jbedard 2020-06-10 11:36:23 -0700 UIGestureRecognizer SPI is guarded by an iOS macro, but we need the definition for watchOS and tvOS. 1661254 1 webkit-bug-importer 2020-06-10 11:37:44 -0700 <rdar://problem/64217654> 1661257 2 401561 jbedard 2020-06-10 11:41:16 -0700 Created attachment 401561 Patch 1661258 3 401561 jbedard 2020-06-10 11:43:11 -0700 Comment on attachment 401561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401561&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1457 > + return [recognizer respondsToSelector:@selector(modifierFlags)] ? [recognizer modifierFlags] : 0; This gets watchOS and tvOS building, but I'm pretty sure it's wrong. 1661264 4 401561 darin 2020-06-10 11:59:00 -0700 Comment on attachment 401561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401561&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1457 >> + return [recognizer respondsToSelector:@selector(modifierFlags)] ? [recognizer modifierFlags] : 0; > > This gets watchOS and tvOS building, but I'm pretty sure it's wrong. Let's not commit something that we are pretty sure is wrong. 1661272 5 401561 thorton 2020-06-10 12:08:48 -0700 Comment on attachment 401561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401561&action=review >>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1457 >>> + return [recognizer respondsToSelector:@selector(modifierFlags)] ? [recognizer modifierFlags] : 0; >> >> This gets watchOS and tvOS building, but I'm pretty sure it's wrong. > > Let's not commit something that we are pretty sure is wrong. Jonathan, don't you just want to make UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS be true on watchOS and tvOS? 1661273 6 thorton 2020-06-10 12:08:58 -0700 (In reply to Tim Horton from comment #5) > Comment on attachment 401561 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401561&action=review > > >>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1457 > >>> + return [recognizer respondsToSelector:@selector(modifierFlags)] ? [recognizer modifierFlags] : 0; > >> > >> This gets watchOS and tvOS building, but I'm pretty sure it's wrong. > > > > Let's not commit something that we are pretty sure is wrong. > > Jonathan, don't you just want to make UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS > be true on watchOS and tvOS? err, HAVE() 1661279 7 401561 jbedard 2020-06-10 12:15:24 -0700 Comment on attachment 401561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401561&action=review >>>>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1457 >>>>> + return [recognizer respondsToSelector:@selector(modifierFlags)] ? [recognizer modifierFlags] : 0; >>>> >>>> This gets watchOS and tvOS building, but I'm pretty sure it's wrong. >>> >>> Let's not commit something that we are pretty sure is wrong. >> >> Jonathan, don't you just want to make UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS be true on watchOS and tvOS? > > err, HAVE() Maybe? Shouldn't the definition of modifierFlags also be guarded by HAVE(UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS), in that case? I'm a bit confused by the original content of this line in the first place. It seems like it would only compile if the recognizer had a _modifierFlags member variable, which it doesn't seem to have for watchOS. I would expect this code to read: #if HAVE(UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS) return recognizer.modifierFlags; #else return 0; #endif 1661290 8 thorton 2020-06-10 12:30:10 -0700 (In reply to Jonathan Bedard from comment #7) > Comment on attachment 401561 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401561&action=review > > >>>>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1457 > >>>>> + return [recognizer respondsToSelector:@selector(modifierFlags)] ? [recognizer modifierFlags] : 0; > >>>> > >>>> This gets watchOS and tvOS building, but I'm pretty sure it's wrong. > >>> > >>> Let's not commit something that we are pretty sure is wrong. > >> > >> Jonathan, don't you just want to make UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS be true on watchOS and tvOS? > > > > err, HAVE() > > Maybe? Shouldn't the definition of modifierFlags also be guarded by > HAVE(UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS), in that case? > > I'm a bit confused by the original content of this line in the first place. > It seems like it would only compile if the recognizer had a _modifierFlags > member variable, which it doesn't seem to have for watchOS. I would expect > this code to read: > > #if HAVE(UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS) > return recognizer.modifierFlags; > #else > return 0; > #endif 1) That's a method, not a member variable. 2) This is all because _modifierFlags used to exist on iOS as SPI and then became API (without the underscore) in iOS 13.4, it's got nothing to do with watchOS/etc., but your substitution is definitely wrong. 3) The header suggests that the watchOS 6 SDK has both the SPI and API versions available. So I think my suggestion is probably the right path forward, but you have alternative paths available if necessary. 1661577 9 401642 jbedard 2020-06-11 07:47:12 -0700 Created attachment 401642 Patch 1661579 10 401643 jbedard 2020-06-11 07:52:36 -0700 Created attachment 401643 Patch 1661638 11 401643 thorton 2020-06-11 10:47:40 -0700 Comment on attachment 401643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401643&action=review > Source/WTF/wtf/PlatformHave.h:450 > +#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130400) As previously mentioned, a IOS_FAMILY + IPHONE_OS_VERSION* check is always wrong. > Source/WebKit/Platform/spi/ios/UIKitSPI.h:422 > -#if PLATFORM(IOS) && !defined(__IPHONE_13_4) > +#if !HAVE(UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS) This used defined(__IPHONE_13_4) instead of MIN_REQUIRED for a reason! Blame it and see. 1661639 12 401643 thorton 2020-06-11 10:47:42 -0700 Comment on attachment 401643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401643&action=review > Source/WTF/wtf/PlatformHave.h:450 > +#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130400) As previously mentioned, a IOS_FAMILY + IPHONE_OS_VERSION* check is always wrong. > Source/WebKit/Platform/spi/ios/UIKitSPI.h:422 > -#if PLATFORM(IOS) && !defined(__IPHONE_13_4) > +#if !HAVE(UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS) This used defined(__IPHONE_13_4) instead of MIN_REQUIRED for a reason! Blame it and see. 1661690 13 401668 jbedard 2020-06-11 12:30:50 -0700 Created attachment 401668 Patch 1661697 14 jbedard 2020-06-11 12:35:52 -0700 (In reply to Jonathan Bedard from comment #13) > Created attachment 401668 [details] > Patch I think I was trying way too hard. Seems that we don't need the SPI header at all. And actually, do we still need the SPI declaration for iOS once we move to 13.5, the old macros only work on 13.4, right? 1661707 15 401668 darin 2020-06-11 12:51:12 -0700 Comment on attachment 401668 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401668&action=review > Source/WTF/wtf/PlatformHave.h:450 > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130400 || PLATFORM(WATCHOS) || PLATFORM(APPLETV)) Seems like we could either remove the () entirely, or put them just around the && section. 1661719 16 401677 jbedard 2020-06-11 13:21:06 -0700 Created attachment 401677 Patch for landing 1661733 17 ews-feeder 2020-06-11 14:02:57 -0700 Committed r262924: <https://trac.webkit.org/changeset/262924> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401677. 401561 2020-06-10 11:41:16 -0700 2020-06-11 07:47:11 -0700 Patch bug-213038-20200610114116.patch text/plain 1909 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjI4NDUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA2LTEwICBKb25hdGhhbiBC ZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXQ6IE1ha2UgVUlHZXN0 dXJlUmVjb2duaXplciBidWlsZCBmb3Igd2F0Y2hPUyBhbmQgdHZPUworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMDM4CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS82NDIxNzY1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMsIGJlaGF2aW9yIHVuY2hhbmdlZC4KKworICAgICAgICAq IFBsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKGdlc3R1cmVSZWNvZ25pemVyTW9k aWZpZXJGbGFncyk6CisKIDIwMjAtMDYtMTAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5z ZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZlcnQgcjI1OTc3MApJbmRleDogU291cmNlL1dl YktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgJKHJldmlzaW9uIDI2Mjg0NSkKKysrIFNv dXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCSh3b3JraW5nIGNvcHkpCkBA IC00MTksNyArNDE5LDcgQEAgdHlwZWRlZiBlbnVtIHsKIEBlbmQKIAogQGludGVyZmFjZSBVSUdl c3R1cmVSZWNvZ25pemVyICgpCi0jaWYgUExBVEZPUk0oSU9TKSAmJiAhZGVmaW5lZChfX0lQSE9O RV8xM180KQorI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpICYmICFkZWZpbmVkKF9fSVBIT05FXzEz XzQpCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGdldHRlcj1fbW9kaWZpZXJGbGFn cykgVUlLZXlNb2RpZmllckZsYWdzIG1vZGlmaWVyRmxhZ3M7CiAjZW5kaWYKIEBlbmQKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMjYyODQ1KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMTQ1 NCw3ICsxNDU0LDcgQEAgaW5saW5lIHN0YXRpYyBVSUtleU1vZGlmaWVyRmxhZ3MgZ2VzdHVyZQog I2lmIEhBVkUoVUlfR0VTVFVSRV9SRUNPR05JWkVSX01PRElGSUVSX0ZMQUdTKQogICAgIHJldHVy biByZWNvZ25pemVyLm1vZGlmaWVyRmxhZ3M7CiAjZWxzZQotICAgIHJldHVybiBbcmVjb2duaXpl ciByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF9tb2RpZmllckZsYWdzKV0gPyBbcmVjb2du aXplciBfbW9kaWZpZXJGbGFnc10gOiAwOworICAgIHJldHVybiBbcmVjb2duaXplciByZXNwb25k c1RvU2VsZWN0b3I6QHNlbGVjdG9yKG1vZGlmaWVyRmxhZ3MpXSA/IFtyZWNvZ25pemVyIG1vZGlm aWVyRmxhZ3NdIDogMDsKICNlbmRpZgogfQogCg== 401642 2020-06-11 07:47:12 -0700 2020-06-11 07:52:34 -0700 Patch bug-213038-20200611074712.patch text/plain 2428 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjI5MDEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA2LTExICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkPgorCisgICAgICAgIFdlYktpdDogTWFrZSBVSUdlc3R1cmVSZWNvZ25pemVyIGJ1aWxk IGZvciB3YXRjaE9TIGFuZCB0dk9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTMwMzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0MjE3NjU0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1Bs YXRmb3JtSGF2ZS5oOiBFbmFibGUgSEFWRShVSV9HRVNUVVJFX1JFQ09HTklaRVJfTU9ESUZJRVJf RkxBR1MpIGZvciB3YXRjaE9TIGFuZCB0dk9TLgorCiAyMDIwLTA2LTEwICBHZW9mZnJleSBHYXJl biAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgU29tZSBzdHlsZSBpbXByb3ZlbWVudHMg dG8gbWFpbiB0aHJlYWQgY29kZQpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgJKHJldmlzaW9uIDI2 MjkwMSkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCSh3b3JraW5nIGNvcHkpCkBA IC00NDUsNiArNDQ1LDkgQEAKIAogI2lmIChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDEzMDQwMCkKICNkZWZpbmUgSEFWRV9VSV9DVVJTT1JfSU5U RVJBQ1RJT04gMQorI2VuZGlmCisKKyNpZiAoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhP TkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwNDAwKQogI2RlZmluZSBIQVZFX1VJX0dF U1RVUkVfUkVDT0dOSVpFUl9NT0RJRklFUl9GTEFHUyAxCiAjZW5kaWYKIApJbmRleDogU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJ KHJldmlzaW9uIDI2MjkwMSkKKysrIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDYtMTEgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRh cmQ+CisKKyAgICAgICAgV2ViS2l0OiBNYWtlIFVJR2VzdHVyZVJlY29nbml6ZXIgYnVpbGQgZm9y IHdhdGNoT1MgYW5kIHR2T1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMzAzOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQyMTc2NTQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBiZWhhdmlvciB1bmNoYW5nZWQuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0 U1BJLmg6IEd1YXJkIFVJR2VzdHVyZVJlY29nbml6ZXIgbW9kaWZpZXJGbGFncyB3aXRoIEhBVkUo VUlfR0VTVFVSRV9SRUNPR05JWkVSX01PRElGSUVSX0ZMQUdTKS4KKwogMjAyMC0wNi0xMSAgQ2hh bmdTZW9rIE9oICA8Y2hhbmdzZW9rQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0dUS10gSW1wbGVt ZW50IGJ1dHRvbi1wcmVzcy1ldmVudCwgYnV0dG9uLXJlbGVhc2UtZXZlbnQsIGFuZCBhYnNvbHV0 ZS1heGlzLWV2ZW50IG9mIEdBTUVQQUQgQVBJLgpJbmRleDogU291cmNlL1dlYktpdC9QbGF0Zm9y bS9zcGkvaW9zL1VJS2l0U1BJLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9QbGF0Zm9y bS9zcGkvaW9zL1VJS2l0U1BJLmgJKHJldmlzaW9uIDI2MjkwMSkKKysrIFNvdXJjZS9XZWJLaXQv UGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MTksNyArNDE5 LDcgQEAgdHlwZWRlZiBlbnVtIHsKIEBlbmQKIAogQGludGVyZmFjZSBVSUdlc3R1cmVSZWNvZ25p emVyICgpCi0jaWYgUExBVEZPUk0oSU9TKSAmJiAhZGVmaW5lZChfX0lQSE9ORV8xM180KQorI2lm IEhBVkUoVUlfR0VTVFVSRV9SRUNPR05JWkVSX01PRElGSUVSX0ZMQUdTKQogQHByb3BlcnR5IChu b25hdG9taWMsIHJlYWRvbmx5LCBnZXR0ZXI9X21vZGlmaWVyRmxhZ3MpIFVJS2V5TW9kaWZpZXJG bGFncyBtb2RpZmllckZsYWdzOwogI2VuZGlmCiBAZW5kCg== 401643 2020-06-11 07:52:36 -0700 2020-06-11 12:30:48 -0700 Patch bug-213038-20200611075235.patch text/plain 2429 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjI5MDEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA2LTExICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkPgorCisgICAgICAgIFdlYktpdDogTWFrZSBVSUdlc3R1cmVSZWNvZ25pemVyIGJ1aWxk IGZvciB3YXRjaE9TIGFuZCB0dk9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTMwMzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0MjE3NjU0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1Bs YXRmb3JtSGF2ZS5oOiBFbmFibGUgSEFWRShVSV9HRVNUVVJFX1JFQ09HTklaRVJfTU9ESUZJRVJf RkxBR1MpIGZvciB3YXRjaE9TIGFuZCB0dk9TLgorCiAyMDIwLTA2LTEwICBHZW9mZnJleSBHYXJl biAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgU29tZSBzdHlsZSBpbXByb3ZlbWVudHMg dG8gbWFpbiB0aHJlYWQgY29kZQpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgJKHJldmlzaW9uIDI2 MjkwMSkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCSh3b3JraW5nIGNvcHkpCkBA IC00NDUsNiArNDQ1LDkgQEAKIAogI2lmIChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDEzMDQwMCkKICNkZWZpbmUgSEFWRV9VSV9DVVJTT1JfSU5U RVJBQ1RJT04gMQorI2VuZGlmCisKKyNpZiAoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhP TkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwNDAwKQogI2RlZmluZSBIQVZFX1VJX0dF U1RVUkVfUkVDT0dOSVpFUl9NT0RJRklFUl9GTEFHUyAxCiAjZW5kaWYKIApJbmRleDogU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJ KHJldmlzaW9uIDI2MjkwMSkKKysrIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDYtMTEgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRh cmQ+CisKKyAgICAgICAgV2ViS2l0OiBNYWtlIFVJR2VzdHVyZVJlY29nbml6ZXIgYnVpbGQgZm9y IHdhdGNoT1MgYW5kIHR2T1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMzAzOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQyMTc2NTQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBiZWhhdmlvciB1bmNoYW5nZWQuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0 U1BJLmg6IEd1YXJkIFVJR2VzdHVyZVJlY29nbml6ZXIgbW9kaWZpZXJGbGFncyB3aXRoIEhBVkUo VUlfR0VTVFVSRV9SRUNPR05JWkVSX01PRElGSUVSX0ZMQUdTKS4KKwogMjAyMC0wNi0xMSAgQ2hh bmdTZW9rIE9oICA8Y2hhbmdzZW9rQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0dUS10gSW1wbGVt ZW50IGJ1dHRvbi1wcmVzcy1ldmVudCwgYnV0dG9uLXJlbGVhc2UtZXZlbnQsIGFuZCBhYnNvbHV0 ZS1heGlzLWV2ZW50IG9mIEdBTUVQQUQgQVBJLgpJbmRleDogU291cmNlL1dlYktpdC9QbGF0Zm9y bS9zcGkvaW9zL1VJS2l0U1BJLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9QbGF0Zm9y bS9zcGkvaW9zL1VJS2l0U1BJLmgJKHJldmlzaW9uIDI2MjkwMSkKKysrIFNvdXJjZS9XZWJLaXQv UGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MTksNyArNDE5 LDcgQEAgdHlwZWRlZiBlbnVtIHsKIEBlbmQKIAogQGludGVyZmFjZSBVSUdlc3R1cmVSZWNvZ25p emVyICgpCi0jaWYgUExBVEZPUk0oSU9TKSAmJiAhZGVmaW5lZChfX0lQSE9ORV8xM180KQorI2lm ICFIQVZFKFVJX0dFU1RVUkVfUkVDT0dOSVpFUl9NT0RJRklFUl9GTEFHUykKIEBwcm9wZXJ0eSAo bm9uYXRvbWljLCByZWFkb25seSwgZ2V0dGVyPV9tb2RpZmllckZsYWdzKSBVSUtleU1vZGlmaWVy RmxhZ3MgbW9kaWZpZXJGbGFnczsKICNlbmRpZgogQGVuZAo= 401668 2020-06-11 12:30:50 -0700 2020-06-11 13:21:04 -0700 Patch bug-213038-20200611123049.patch text/plain 1172 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjI5MTYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA2LTExICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXQ6IE1ha2UgVUlHZXN0dXJlUmVjb2du aXplciBidWlsZCBmb3Igd2F0Y2hPUyBhbmQgdHZPUworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMDM4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82 NDIxNzY1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHd0Zi9QbGF0Zm9ybUhhdmUuaDogRW5hYmxlIEhBVkUoVUlfR0VTVFVSRV9SRUNPR05JWkVS X01PRElGSUVSX0ZMQUdTKSBmb3Igd2F0Y2hPUyBhbmQgdHZPUy4KKwogMjAyMC0wNi0xMSAgRGF2 aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtJUENdIEFkb3B0IGVu dW0gY2xhc3MgZm9yIERyYWdTb3VyY2VBY3Rpb24KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRm b3JtSGF2ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCShy ZXZpc2lvbiAyNjI5MTUpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaAkod29ya2lu ZyBjb3B5KQpAQCAtNDQ1LDYgKzQ0NSw5IEBACiAKICNpZiAoUExBVEZPUk0oSU9TKSAmJiBfX0lQ SE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzA0MDApCiAjZGVmaW5lIEhBVkVfVUlf Q1VSU09SX0lOVEVSQUNUSU9OIDEKKyNlbmRpZgorCisjaWYgKFBMQVRGT1JNKElPUykgJiYgX19J UEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTMwNDAwIHx8IFBMQVRGT1JNKFdBVENI T1MpIHx8IFBMQVRGT1JNKEFQUExFVFYpKQogI2RlZmluZSBIQVZFX1VJX0dFU1RVUkVfUkVDT0dO SVpFUl9NT0RJRklFUl9GTEFHUyAxCiAjZW5kaWYKIAo= 401677 2020-06-11 13:21:06 -0700 2020-06-11 14:02:57 -0700 Patch for landing bug-213038-20200611132105.patch text/plain 1168 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjI5MjApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA2LTExICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXQ6IE1ha2UgVUlHZXN0dXJlUmVjb2du aXplciBidWlsZCBmb3Igd2F0Y2hPUyBhbmQgdHZPUworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzMDM4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82 NDIxNzY1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgICog d3RmL1BsYXRmb3JtSGF2ZS5oOiBFbmFibGUgSEFWRShVSV9HRVNUVVJFX1JFQ09HTklaRVJfTU9E SUZJRVJfRkxBR1MpIGZvciB3YXRjaE9TIGFuZCB0dk9TLgorCiAyMDIwLTA2LTExICBEYXZpZCBL aWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgW0lQQ10gQWRvcHQgZW51bSBj bGFzcyBmb3IgRHJhZ1NvdXJjZUFjdGlvbgpJbmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm1I YXZlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgJKHJldmlz aW9uIDI2MjkyMCkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCSh3b3JraW5nIGNv cHkpCkBAIC00NDUsNiArNDQ1LDkgQEAKIAogI2lmIChQTEFURk9STShJT1MpICYmIF9fSVBIT05F X09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEzMDQwMCkKICNkZWZpbmUgSEFWRV9VSV9DVVJT T1JfSU5URVJBQ1RJT04gMQorI2VuZGlmCisKKyNpZiAoUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9O RV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzA0MDApIHx8IFBMQVRGT1JNKFdBVENIT1Mp IHx8IFBMQVRGT1JNKEFQUExFVFYpCiAjZGVmaW5lIEhBVkVfVUlfR0VTVFVSRV9SRUNPR05JWkVS X01PRElGSUVSX0ZMQUdTIDEKICNlbmRpZgogCg==