213020 2020-06-10 04:24:34 -0700 [WebXR] unsigned long in IDL should be translated as unsigned in C++ code 2020-06-19 00:33:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208988 1 svillar svillar darin dino svillar webkit-bug-importer youennf zan oldest_to_newest 1661131 0 svillar 2020-06-10 04:24:34 -0700 [WebXR] unsigned long in IDL should be translated as unsigned in C++ code 1661133 1 401533 svillar 2020-06-10 04:28:24 -0700 Created attachment 401533 Patch 1661199 2 401533 darin 2020-06-10 10:02:34 -0700 Comment on attachment 401533 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401533&action=review > Source/WebCore/Modules/webxr/WebXRSession.cpp:203 > + unsigned newId = ++m_nextCallbackId; This makes it clear that m_nextCallbackId is misnamed. Because we can see here that in practice it contains the last already-used callback ID, not the next callback ID to be used. > Source/WebCore/Modules/webxr/WebXRSession.h:77 > + void cancelAnimationFrame(unsigned handle); A little inelegant that the header calls this "handle", but the .cpp file calls it "callbackId". 1661308 3 401533 svillar 2020-06-10 13:03:40 -0700 Comment on attachment 401533 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401533&action=review Thanks for the quick review! >> Source/WebCore/Modules/webxr/WebXRSession.cpp:203 >> + unsigned newId = ++m_nextCallbackId; > > This makes it clear that m_nextCallbackId is misnamed. Because we can see here that in practice it contains the last already-used callback ID, not the next callback ID to be used. Right. I'll do the following, initialize m_nextCallbackId to 1 and the replace the ++m_nextCallbackId by m_nextCallbackId++ >> Source/WebCore/Modules/webxr/WebXRSession.h:77 >> + void cancelAnimationFrame(unsigned handle); > > A little inelegant that the header calls this "handle", but the .cpp file calls it "callbackId". ACK, I'll use a more consistent naming. 1664196 4 svillar 2020-06-19 00:32:21 -0700 Committed r263256: <https://trac.webkit.org/changeset/263256> 1664215 5 webkit-bug-importer 2020-06-19 00:33:19 -0700 <rdar://problem/64522477> 401533 2020-06-10 04:28:24 -0700 2020-06-10 10:02:34 -0700 Patch bug-213020-20200610132823.patch text/plain 5361 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZhNDQ5NDA5MDUxZDhk MTE1MmI0NzcyOGYwMWI0ZjkxZjNlZGIyMy4uMGU1MWNkNjRhZmExOGM4OGU5YjM1OTI2YTQ2YjYz YzNhMWNjOWEzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA2LTEwICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXZWJYUl0g dW5zaWduZWQgbG9uZyBpbiBJREwgc2hvdWxkIGJlIHRyYW5zbGF0ZWQgYXMgdW5zaWduZWQgaW4g QysrIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMzAyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoZSAidW5zaWduZWQgbG9uZyIgdHlwZSBkZWZpbml0aW9uIGluIElETCBtdXN0IGJlIHRyYW5z bGF0ZWQgdG8gdW5zaWduZWQgaW4gQysrIGNvZGUuCisKKyAgICAgICAgSSdtIGFsc28gcmVwbGFj aW5nIHRoZSB2ZXJ5IGxvbmcgWFJGcmFtZVJlcXVlc3RDYWxsYmFjazo6SWRlbnRpZmllciBieSBz aW1wbHkgdW5zaWduZWQgYXMgaXQKKyAgICAgICAgaXNuJ3QgYWRkaW5nIGFueXRoaW5nLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0IHJlcXVpcmVkIGFzIHRoZXJlIGlzIG5vIGNoYW5nZSBpbiBmdW5j dGlvbmFsaXR5LCBqdXN0IHJlbW92aW5nIGFuIGFsaWFzLgorCisgICAgICAgICogTW9kdWxlcy93 ZWJ4ci9XZWJYUlNlc3Npb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViWFJTZXNzaW9uOjpy ZXF1ZXN0QW5pbWF0aW9uRnJhbWUpOgorICAgICAgICAoV2ViQ29yZTo6V2ViWFJTZXNzaW9uOjpj YW5jZWxBbmltYXRpb25GcmFtZSk6CisgICAgICAgICogTW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Np b24uaDoKKyAgICAgICAgKiBNb2R1bGVzL3dlYnhyL1hSRnJhbWVSZXF1ZXN0Q2FsbGJhY2suaDoK KyAgICAgICAgKFdlYkNvcmU6OlhSRnJhbWVSZXF1ZXN0Q2FsbGJhY2s6OmNhbGxiYWNrSWQpOgor ICAgICAgICAoV2ViQ29yZTo6WFJGcmFtZVJlcXVlc3RDYWxsYmFjazo6c2V0Q2FsbGJhY2tJZCk6 CisKIDIwMjAtMDYtMDkgIFBpbmtpIEd5YW5jaGFuZGFuaSAgPHBneWFuY2hhbmRhbmlAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbGVhc2UgQXNzZXJ0IEAgV2ViQ29yZTo6UmVuZGVyVHJlZUJ1aWxk ZXI6OlJlbmRlclRyZWVCdWlsZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYnhyL1dlYlhSU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dl YlhSU2Vzc2lvbi5jcHAKaW5kZXggMDc2MWU2NzFjNDA3YmUyYmMwYTRjZTYzODkwYjZhNGJiZmYz MDYyNC4uNTU2YjUxZjI4MjVhZTY4ZTY2YTQ1NTkxZDNiZWRkYzEwZTRhMGRlNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIvV2ViWFJTZXNzaW9uLmNwcApAQCAtMTk2LDExICsx OTYsMTEgQEAgdm9pZCBXZWJYUlNlc3Npb246OnNjaGVkdWxlQW5pbWF0aW9uKCkKIH0KIAogLy8g aHR0cHM6Ly9pbW1lcnNpdmUtd2ViLmdpdGh1Yi5pby93ZWJ4ci8jZG9tLXhyc2Vzc2lvbi1yZXF1 ZXN0YW5pbWF0aW9uZnJhbWUKLVhSRnJhbWVSZXF1ZXN0Q2FsbGJhY2s6OklkZW50aWZpZXIgV2Vi WFJTZXNzaW9uOjpyZXF1ZXN0QW5pbWF0aW9uRnJhbWUoUmVmPFhSRnJhbWVSZXF1ZXN0Q2FsbGJh Y2s+JiYgY2FsbGJhY2spCit1bnNpZ25lZCBXZWJYUlNlc3Npb246OnJlcXVlc3RBbmltYXRpb25G cmFtZShSZWY8WFJGcmFtZVJlcXVlc3RDYWxsYmFjaz4mJiBjYWxsYmFjaykKIHsKICAgICAvLyAx LiBMZXQgc2Vzc2lvbiBiZSB0aGUgdGFyZ2V0IFhSU2Vzc2lvbiBvYmplY3QuCiAgICAgLy8gMi4g SW5jcmVtZW50IHNlc3Npb24ncyBhbmltYXRpb24gZnJhbWUgY2FsbGJhY2sgaWRlbnRpZmllciBi eSBvbmUuCi0gICAgWFJGcmFtZVJlcXVlc3RDYWxsYmFjazo6SWRlbnRpZmllciBuZXdJZCA9ICsr bV9uZXh0Q2FsbGJhY2tJZDsKKyAgICB1bnNpZ25lZCBuZXdJZCA9ICsrbV9uZXh0Q2FsbGJhY2tJ ZDsKIAogICAgIC8vIDMuIEFwcGVuZCBjYWxsYmFjayB0byBzZXNzaW9uJ3MgbGlzdCBvZiBhbmlt YXRpb24gZnJhbWUgY2FsbGJhY2tzLCBhc3NvY2lhdGVkIHdpdGggc2Vzc2lvbidzCiAgICAgLy8g YW5pbWF0aW9uIGZyYW1lIGNhbGxiYWNrIGlkZW50aWZpZXIncyBjdXJyZW50IHZhbHVlLgpAQCAt MjE0LDcgKzIxNCw3IEBAIFhSRnJhbWVSZXF1ZXN0Q2FsbGJhY2s6OklkZW50aWZpZXIgV2ViWFJT ZXNzaW9uOjpyZXF1ZXN0QW5pbWF0aW9uRnJhbWUoUmVmPFhSRnJhCiB9CiAKIC8vIGh0dHBzOi8v aW1tZXJzaXZlLXdlYi5naXRodWIuaW8vd2VieHIvI2RvbS14cnNlc3Npb24tY2FuY2VsYW5pbWF0 aW9uZnJhbWUKLXZvaWQgV2ViWFJTZXNzaW9uOjpjYW5jZWxBbmltYXRpb25GcmFtZShYUkZyYW1l UmVxdWVzdENhbGxiYWNrOjpJZGVudGlmaWVyIGNhbGxiYWNrSWQpCit2b2lkIFdlYlhSU2Vzc2lv bjo6Y2FuY2VsQW5pbWF0aW9uRnJhbWUodW5zaWduZWQgY2FsbGJhY2tJZCkKIHsKICAgICAvLyAx LiBMZXQgc2Vzc2lvbiBiZSB0aGUgdGFyZ2V0IFhSU2Vzc2lvbiBvYmplY3QuCiAgICAgLy8gMi4g RmluZCB0aGUgZW50cnkgaW4gc2Vzc2lvbidzIGxpc3Qgb2YgYW5pbWF0aW9uIGZyYW1lIGNhbGxi YWNrcyBvciBzZXNzaW9uJ3MgbGlzdCBvZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIv V2ViWFJTZXNzaW9uLmgKaW5kZXggYmNkYjNjYTc4ZmI1ZWEwMThjNzU5Y2MyMjYyOGZlZmM2Njc3 ZmVmNy4uYWY2MDRkYzIyNmM4MzRlYzkxZmVlZmJmNTE5NDAyMDE1NTFjMWQ3YyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24uaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dlYlhSU2Vzc2lvbi5oCkBAIC0zNSw3ICszNSw2IEBA CiAjaW5jbHVkZSAiV2ViWFJSZW5kZXJTdGF0ZS5oIgogI2luY2x1ZGUgIldlYlhSU3BhY2UuaCIK ICNpbmNsdWRlICJYUkVudmlyb25tZW50QmxlbmRNb2RlLmgiCi0jaW5jbHVkZSAiWFJGcmFtZVJl cXVlc3RDYWxsYmFjay5oIgogI2luY2x1ZGUgIlhSSW50ZXJhY3Rpb25Nb2RlLmgiCiAjaW5jbHVk ZSAiWFJSZWZlcmVuY2VTcGFjZVR5cGUuaCIKICNpbmNsdWRlICJYUlNlc3Npb25Nb2RlLmgiCkBA IC00OCw2ICs0Nyw3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgWFJGcmFtZVJl cXVlc3RDYWxsYmFjazsKIGNsYXNzIFdlYlhSUmVmZXJlbmNlU3BhY2U7CiBjbGFzcyBXZWJYUlN5 c3RlbTsKIHN0cnVjdCBYUlJlbmRlclN0YXRlSW5pdDsKQEAgLTczLDggKzczLDggQEAgcHVibGlj OgogICAgIHZvaWQgdXBkYXRlUmVuZGVyU3RhdGUoY29uc3QgWFJSZW5kZXJTdGF0ZUluaXQmKTsK ICAgICB2b2lkIHJlcXVlc3RSZWZlcmVuY2VTcGFjZShYUlJlZmVyZW5jZVNwYWNlVHlwZSwgUmVx dWVzdFJlZmVyZW5jZVNwYWNlUHJvbWlzZSYmKTsKIAotICAgIFhSRnJhbWVSZXF1ZXN0Q2FsbGJh Y2s6OklkZW50aWZpZXIgcmVxdWVzdEFuaW1hdGlvbkZyYW1lKFJlZjxYUkZyYW1lUmVxdWVzdENh bGxiYWNrPiYmKTsKLSAgICB2b2lkIGNhbmNlbEFuaW1hdGlvbkZyYW1lKFhSRnJhbWVSZXF1ZXN0 Q2FsbGJhY2s6OklkZW50aWZpZXIgaGFuZGxlKTsKKyAgICB1bnNpZ25lZCByZXF1ZXN0QW5pbWF0 aW9uRnJhbWUoUmVmPFhSRnJhbWVSZXF1ZXN0Q2FsbGJhY2s+JiYpOworICAgIHZvaWQgY2FuY2Vs QW5pbWF0aW9uRnJhbWUodW5zaWduZWQgaGFuZGxlKTsKIAogICAgIHZvaWQgZW5kKEVuZFByb21p c2UmJik7CiAKQEAgLTExMiw3ICsxMTIsNyBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxXZWJYUlJl bmRlclN0YXRlPiBtX2FjdGl2ZVJlbmRlclN0YXRlOwogICAgIFJlZlB0cjxXZWJYUlJlbmRlclN0 YXRlPiBtX3BlbmRpbmdSZW5kZXJTdGF0ZTsKIAotICAgIFhSRnJhbWVSZXF1ZXN0Q2FsbGJhY2s6 OklkZW50aWZpZXIgbV9uZXh0Q2FsbGJhY2tJZCB7IDAgfTsKKyAgICB1bnNpZ25lZCBtX25leHRD YWxsYmFja0lkIHsgMCB9OwogICAgIFZlY3RvcjxSZWY8WFJGcmFtZVJlcXVlc3RDYWxsYmFjaz4+ IG1fY2FsbGJhY2tzOwogICAgIFZlY3RvcjxSZWY8WFJGcmFtZVJlcXVlc3RDYWxsYmFjaz4+IG1f cnVubmluZ0NhbGxiYWNrczsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJ4ci9YUkZyYW1lUmVxdWVzdENhbGxiYWNrLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YnhyL1hSRnJhbWVSZXF1ZXN0Q2FsbGJhY2suaAppbmRleCBjNzU2OGEyNDYyNTEwYTFhYjM0MDhh YzdjMjE4YTkzNmNhZDM4YWFkLi40OGRjZDkzNjRmYjM5YmEzNWE4MjRiMzFlN2UwYmUyZTE2YTFi NzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1hSRnJhbWVSZXF1 ZXN0Q2FsbGJhY2suaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1hSRnJhbWVS ZXF1ZXN0Q2FsbGJhY2suaApAQCAtNDEsMTQgKzQxLDEzIEBAIHB1YmxpYzoKIAogICAgIHZpcnR1 YWwgQ2FsbGJhY2tSZXN1bHQ8dm9pZD4gaGFuZGxlRXZlbnQoZG91YmxlIGhpZ2hSZXNUaW1lTXMs IFdlYlhSRnJhbWUmKSA9IDA7CiAKLSAgICB1c2luZyBJZGVudGlmaWVyID0gdW5zaWduZWQgbG9u ZzsKLSAgICBJZGVudGlmaWVyIGNhbGxiYWNrSWQoKSB7IEFTU0VSVChtX2lkKTsgcmV0dXJuIG1f aWQ7IH0KLSAgICB2b2lkIHNldENhbGxiYWNrSWQoSWRlbnRpZmllciBpZCkgeyBBU1NFUlQoIW1f aWQpOyBtX2lkID0gaWQ7IH0KKyAgICB1bnNpZ25lZCBjYWxsYmFja0lkKCkgeyBBU1NFUlQobV9p ZCk7IHJldHVybiBtX2lkOyB9CisgICAgdm9pZCBzZXRDYWxsYmFja0lkKHVuc2lnbmVkIGlkKSB7 IEFTU0VSVCghbV9pZCk7IG1faWQgPSBpZDsgfQogICAgIHZvaWQgY2FuY2VsKCkgeyBtX2NhbmNl bGxlZCA9IHRydWU7IH0KICAgICBib29sIGlzQ2FuY2VsbGVkKCkgY29uc3QgeyByZXR1cm4gbV9j YW5jZWxsZWQ7IH0KIAogcHJpdmF0ZToKLSAgICBJZGVudGlmaWVyIG1faWQgeyAwIH07CisgICAg dW5zaWduZWQgbV9pZCB7IDAgfTsKICAgICBib29sIG1fY2FuY2VsbGVkIHsgZmFsc2UgfTsKIH07 CiAK