<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>21296</bug_id>
          
          <creation_ts>2008-10-01 23:18:27 -0700</creation_ts>
          <short_desc>Remove profiling hooks when not profiling</short_desc>
          <delta_ts>2008-11-24 17:09:40 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>21735</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>20812</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Cameron Zwarich (cpst)">zwarich</reporter>
          <assigned_to name="Geoffrey Garen">ggaren</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>93673</commentid>
    <comment_count>0</comment_count>
    <who name="Cameron Zwarich (cpst)">zwarich</who>
    <bug_when>2008-10-01 23:18:27 -0700</bug_when>
    <thetext>We currently always emit profiling hooks, even when we are not profiling. This adds unnecessary branches to function calls and returns. The solution is to regenerate code when profiling is enabled.

Geoff has already done some preliminary work in this direction in bug 21281.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>93806</commentid>
    <comment_count>1</comment_count>
    <who name="Cameron Zwarich (cpst)">zwarich</who>
    <bug_when>2008-10-02 15:33:57 -0700</bug_when>
    <thetext>Removing all branches (both the profiling branch and the activation / &apos;arguments&apos; branch) from op_ret is at least a 4.3% speedup on Richards and a 1.0% speedup on DeltaBlue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100107</commentid>
    <comment_count>2</comment_count>
    <who name="Cameron Zwarich (cpst)">zwarich</who>
    <bug_when>2008-11-24 17:09:40 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of 21735 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>