212952 2020-06-08 20:47:27 -0700 Remove "no-preference" value for prefers-color-scheme media query 2021-05-03 10:37:19 -0700 1 1 1 Unclassified WebKit CSS Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed P2 Normal --- 1 simon.fraser ntim ddkilzer eoconnor eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jer.noble koivisto macpherson megan_gardner menard ntim philipj sergio simon.fraser timothy webkit-bug-importer oldest_to_newest 1660561 0 simon.fraser 2020-06-08 20:47:27 -0700 See https://github.com/w3c/csswg-drafts/issues/3857#issuecomment-634779976 and https://groups.google.com/a/chromium.org/d/msg/blink-dev/3RhZFvZE1LM/t7BpLBWkAwAJ 1756062 1 427530 ntim 2021-05-02 10:21:04 -0700 Created attachment 427530 Patch 1756099 2 427530 koivisto 2021-05-02 23:45:12 -0700 Comment on attachment 427530 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427530&action=review > Source/WebCore/css/MediaQueryEvaluator.cpp:-811 > switch (keyword) { > - case CSSValueNoPreference: > - return false; The default for this switch is false so this doesn't seem to change anything at all. 1756107 3 427530 koivisto 2021-05-03 00:21:43 -0700 Comment on attachment 427530 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427530&action=review > LayoutTests/css-dark-mode/older-systems/prefers-color-scheme.html:25 > -@media (prefers-color-scheme: no-preference) { > +@media not (prefers-color-scheme) { We may need to keep supporting 'no-preference' value even when parsing is fixed. 1756109 4 427530 koivisto 2021-05-03 00:34:44 -0700 Comment on attachment 427530 Patch I don't know if it is ok to remove 'no-preference' support but if it is, it can be done after the parsing fix. It should also be done properly by removing all the code, not by stealth test changes. 1756115 5 427530 ntim 2021-05-03 01:15:12 -0700 Comment on attachment 427530 Patch Regarding tests: the test already tests for `foo` which is the invalid keyword case (like `no-preference`). WPT also has coverage for `no-preference`: https://wpt.fyi/results/css/mediaqueries/prefers-color-scheme.html?label=master&label=experimental&aligned&q=prefers-color-scheme Regarding removing all the code: CSSValueNoPreference can't be removed since other MQ use it (prefers-contrast/prefers-reduced-motion). 1756206 6 koivisto 2021-05-03 09:21:21 -0700 Tim Hatcher says getting rid of this is ok. 1756229 7 ews-feeder 2021-05-03 10:36:09 -0700 Committed r276908 (237253@main): <https://commits.webkit.org/237253@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427530. 1756232 8 webkit-bug-importer 2021-05-03 10:37:19 -0700 <rdar://problem/77461590> 427530 2021-05-02 10:21:04 -0700 2021-05-03 10:36:10 -0700 Patch bug-212952-20210502192103.patch text/plain 3630 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmY2ZDliMWUwZWU1NzFm Y2EzOWJkMmEyYTA5N2E5MjczZmYxNDc4MS4uNDM2ZDkxOWVlNDlkYjFlODcyYTRhODcxYWI0Yzg5 M2JiYTEzM2FhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTAyICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlICJuby1wcmVmZXJlbmNl IiB2YWx1ZSBmb3IgcHJlZmVycy1jb2xvci1zY2hlbWUgbWVkaWEgcXVlcnkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjk1MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdQVCBwYXJzaW5nIHRlc3RzIHN0 aWxsIGZhaWwgZHVlIHRvOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI1MjgyCisgICAgICAgIFVwZGF0ZWQgZXZhbHVhdGlvbiB0ZXN0cyB0byB1c2UgYG5vdCAocHJl ZmVycy1jb2xvci1zY2hlbWUpYCBpbnN0ZWFkLgorCisgICAgICAgICogY3NzL01lZGlhUXVlcnlF dmFsdWF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cHJlZmVyc0NvbG9yU2NoZW1lRXZhbHVh dGUpOgorCiAyMDIxLTA1LTAxICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAog ICAgICAgICBTaGFyZSBzdHlsZSByZXNvbHZlcnMgYmV0d2VlbiBhdXRob3Igc2hhZG93IHRyZWVz IHdpdGggaWRlbnRpY2FsIHN0eWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVk aWFRdWVyeUV2YWx1YXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeUV2YWx1 YXRvci5jcHAKaW5kZXggMmVmMWVhNmJhMWRhMmMwM2U4OTE1OTIxYmM0MmRhMjJlMTRlNjQxYy4u ZDY0NzI1NmJmMWM0MDZjNzMxMjU5OGRlZmFmMjZkMDViZDQwN2QxYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFsdWF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmNwcApAQCAtODA3LDggKzgwNyw2IEBAIHN0YXRp YyBib29sIHByZWZlcnNDb2xvclNjaGVtZUV2YWx1YXRlKENTU1ZhbHVlKiB2YWx1ZSwgY29uc3Qg Q1NTVG9MZW5ndGhDb252ZXJzCiAgICAgYm9vbCB1c2VEYXJrQXBwZWFyYW5jZSA9IGZyYW1lLnBh Z2UoKS0+dXNlRGFya0FwcGVhcmFuY2UoKTsKIAogICAgIHN3aXRjaCAoa2V5d29yZCkgewotICAg IGNhc2UgQ1NTVmFsdWVOb1ByZWZlcmVuY2U6Ci0gICAgICAgIHJldHVybiBmYWxzZTsKICAgICBj YXNlIENTU1ZhbHVlRGFyazoKICAgICAgICAgcmV0dXJuIHVzZURhcmtBcHBlYXJhbmNlOwogICAg IGNhc2UgQ1NTVmFsdWVMaWdodDoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyY2ZmMmY2NDg2M2ViMWUwODQzN2QxODJmNTZj Y2RlYjg0MGM4MzI4Li4wOThkNDUzYWQ2YzM3OTJhMzNiMTU1M2JhZDAzNjMyZjZjYjQ2NDA0IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDUtMDIgIFRpbSBOZ3V5ZW4gIDxudGltQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmUgIm5vLXByZWZlcmVuY2UiIHZhbHVlIGZvciBwcmVmZXJz LWNvbG9yLXNjaGVtZSBtZWRpYSBxdWVyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEyOTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV1BUIHBhcnNpbmcgdGVzdHMgc3RpbGwgZmFpbCBkdWUgdG86IGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUyODIKKyAgICAgICAgVXBk YXRlZCBldmFsdWF0aW9uIHRlc3RzIHRvIHVzZSBgbm90IChwcmVmZXJzLWNvbG9yLXNjaGVtZSlg IGluc3RlYWQuCisKKyAgICAgICAgKiBjc3MtZGFyay1tb2RlL29sZGVyLXN5c3RlbXMvcHJlZmVy cy1jb2xvci1zY2hlbWUuaHRtbDoKKyAgICAgICAgKiBjc3MtZGFyay1tb2RlL3ByZWZlcnMtY29s b3Itc2NoZW1lLmh0bWw6CisKIDIwMjEtMDUtMDEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBw bGUuY29tPgogCiAgICAgICAgIFNoYXJlIHN0eWxlIHJlc29sdmVycyBiZXR3ZWVuIGF1dGhvciBz aGFkb3cgdHJlZXMgd2l0aCBpZGVudGljYWwgc3R5bGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Nzcy1kYXJrLW1vZGUvb2xkZXItc3lzdGVtcy9wcmVmZXJzLWNvbG9yLXNjaGVtZS5odG1sIGIv TGF5b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9vbGRlci1zeXN0ZW1zL3ByZWZlcnMtY29sb3Itc2No ZW1lLmh0bWwKaW5kZXggYTg0YTNhNmM0ZGM2NjllOTQ4YTFhMzVkNDU3MmFlNzBmZWZiNWVmMy4u ZGNlYmNiMzVkZjg5MGM5YjI1MmM2NzI5Yzg1NGFkMGViZGRlZmFhNSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9vbGRlci1zeXN0ZW1zL3ByZWZlcnMtY29sb3Itc2NoZW1l Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9vbGRlci1zeXN0ZW1zL3ByZWZl cnMtY29sb3Itc2NoZW1lLmh0bWwKQEAgLTIyLDcgKzIyLDcgQEAgZGl2IHsKICAgICB9CiB9CiAK LUBtZWRpYSAocHJlZmVycy1jb2xvci1zY2hlbWU6IG5vLXByZWZlcmVuY2UpIHsKK0BtZWRpYSBu b3QgKHByZWZlcnMtY29sb3Itc2NoZW1lKSB7CiAgICAgLyogVGhpcyBpcyB2YWxpZCwgYnV0IHNo b3VsZCBub3QgYXBwbHkgZm9yIHVzIHNpbmNlIHRoZXJlIGlzIG5vIG9wdGlvbiBmb3Igbm8gdXNl ciBwcmVmZXJlbmNlLiAqLwogICAgICN0ZXN0MSB7CiAgICAgICAgIGJhY2tncm91bmQtY29sb3I6 IGN5YW47CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL3ByZWZlcnMtY29s b3Itc2NoZW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL3ByZWZlcnMtY29sb3It c2NoZW1lLmh0bWwKaW5kZXggMGJiY2U4OGFmYTg3ZjA5ZGFkYmM2OGZmN2QxMGFjYzRjZDI5NGRm YS4uOTNlMWVkOGZiY2NkNzYyMzVhNGRiOGY0ODhlODE1ZDZhZDkxZTAxMSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9wcmVmZXJzLWNvbG9yLXNjaGVtZS5odG1sCisrKyBi L0xheW91dFRlc3RzL2Nzcy1kYXJrLW1vZGUvcHJlZmVycy1jb2xvci1zY2hlbWUuaHRtbApAQCAt MjEsNyArMjEsNyBAQCBkaXYgewogICAgIH0KIH0KIAotQG1lZGlhIChwcmVmZXJzLWNvbG9yLXNj aGVtZTogbm8tcHJlZmVyZW5jZSkgeworQG1lZGlhIG5vdCAocHJlZmVycy1jb2xvci1zY2hlbWUp IHsKICAgICAvKiBUaGlzIGlzIHZhbGlkLCBidXQgc2hvdWxkIG5vdCBhcHBseSBmb3IgdXMgc2lu Y2UgdGhlcmUgaXMgbm8gb3B0aW9uIGZvciBubyB1c2VyIHByZWZlcmVuY2UuICovCiAgICAgI3Rl c3QxIHsKICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogY3lhbjsK